From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE551E77188 for ; Fri, 10 Jan 2025 04:43:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DF2B6B007B; Thu, 9 Jan 2025 23:43:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18FC16B0082; Thu, 9 Jan 2025 23:43:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07E036B0083; Thu, 9 Jan 2025 23:43:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DE42B6B007B for ; Thu, 9 Jan 2025 23:43:23 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 53F9DC0687 for ; Fri, 10 Jan 2025 04:43:23 +0000 (UTC) X-FDA: 82990298286.01.00CDA2D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id AB74880004 for ; Fri, 10 Jan 2025 04:43:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=U13niips; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736484201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xBhoXGh3soWz/b2Z4/xZhQsZ4ANrkCh08Bw8MPU2Mo0=; b=qBCesyGnuY6ocurcp3sSqxc8b+Fzsa0s12e1DfGFWupNCH7WfISzr9iUD8d54rLXS4h21T 5EO1ifrMSig0/6OlnkyR028GSIFglOWxBct5KFsXEf6Uwz0stIuhF5Hke6QWynBd5gH6EH tNFhqtod2aD/jhOfrb/Aodlv/3Z8TR8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736484201; a=rsa-sha256; cv=none; b=bQ55RZw9myPqCuO0IJ108iRZYKT3a7wODZ1SWgs5QaC02HfL27PEe8b6Qmf74R7bmQ++SF aJmo4i8wbaAedH4rk55HbfGAWHKmzJgZERybiQP2xZYtp9i+SJPCN3Hi1yfIOgVbf4GQ16 OUo42YxmG7OPyH3JZaNpZMHS0pb2ZgU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=U13niips; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xBhoXGh3soWz/b2Z4/xZhQsZ4ANrkCh08Bw8MPU2Mo0=; b=U13niipsFte8+r2OmrvPHfCSY0 CkvIxq9BO29MI7dGC+0NRDae2j1u+8LO0RsYwJ9QWqydzkCZMNs1C50uVnrBfHLdFB3PBzwBfA8d6 2u3MEouVzGHudjhpkuKbndt5sCrQ8gqRzdxnJ92al8NNau1mxPem4JHnGax7rcZsuE6SGBFBYUNnG dLuhxLnUpxfCIDBWQmFbAMKRh55IP4658RgIttgz84sS9YIXigLPJUv9BrOP9bmqRfmeCECp+6Izb h0pOmQzdsI2QwpGR5UjmMKc3iBHeHGhzQP9udIDtXqUJ4F6I5yqrVSTG25h/q79P0EvBgA0p/YD2v Dm3scvRQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tW6rd-0000000BU8G-0OfY; Fri, 10 Jan 2025 04:43:17 +0000 Date: Fri, 10 Jan 2025 04:43:16 +0000 From: Matthew Wilcox To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, Vishal Moola , Alex Shi , Alex Shi Subject: Re: [PATCH v9 mm-unstable 11/18] mm/zsmalloc: convert reset_page to reset_zpdesc Message-ID: References: <20241216150450.1228021-1-42.hyeyoo@gmail.com> <20241216150450.1228021-12-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241216150450.1228021-12-42.hyeyoo@gmail.com> X-Rspamd-Queue-Id: AB74880004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 5pq94i6gcqtbw38ptb7oe14h7in3z5dp X-HE-Tag: 1736484201-550694 X-HE-Meta: U2FsdGVkX1+LRD6/lOJO0Bq5R+H59u7wJAkFwY6ecFupqB0p2Uxj7CwbwmGknK9ZhgI4GmDuojtaCc2VxzMnWCEn+Q2DVPmkpv6BVw38waFSDBs2+66O7oVMFudDkgBFE45tebkBG5tz1MrenCvZKFSV4jV1tULsvzxVxZ1joFc6y5M0wp3Z/qX7vCUhrwsK/xXKLMPqbOUKR/xrshZBxh04tBGIkMdT7Ew2V1YiNvbuo/xFyqRn2PKThPYB/BEEQHWJvpoCljn+LWvHz4TeipzdIH9zzUInKn/etSicCI2vtj4VwSl6hRxxxGtrBsQ2It03qfs2cFDo3DH67IS+8FOiNk1xXnQBA59IkFznkdTDdNhlzHGH/bmxjQffL3BADCvFr5ZBM8SCfS4KJjU0tBJUP9Kq9e4dyVrmqPRXt18qm7h8lx/VlXlCgMA9PN17vxwBwpHkWuNjg8CE7aKqukPBjuvH/uHiD4zf+NROJWLzJO+RK7mgurQWjLF+jO3WuuBMKUEyYmMp6uFIRS0nEgZkws68BajgLixm0mxzNpUTWbRjyaUB2gZeIhIqFc2pG9bLAAqB/IF6jXZ32ViYVGVodJZHlxEgq53O16bhC9Yk2gvLSSbG8WiMv8EIEV685r30cFuM9qjZMVwLEK1Y1BIpQ4taBXXVZE4uxrZlYsDNPTdCPvUNyU6sZgIlacYdaUJp1J9Xi4EjlTxRunLIrbuh7kFRvtG7ao1OYT9tAptrYvVuys7QZ3Zt5HVTUku+29qemAge2R1GoOjyxBQhl1OpCfeQceJGtZpzm0o1yxJZDH6AXCKYJlrGDaOEx/+EnJjy7yXuuNLFl8aVUq+Xr9UPYLB6rGh2YiVUnvIgD7TMLX5vroIotzcRBD0MGXSzxdReqeEtjg/6GLOmHc2aI+E1V32wgJ0QCZBc6JI6ILYcJuja0APYNGUZO7N7WZQsZJrcT4xISPo8/9ye3JR Csq7h6P5 26aHTUh3DhsVofsBO88Q3DsZR1+dQ4FL4qL9QzAuerHrYtNY+Cii97pgb6F2axyqqGhGaJ3qtaM4F+KCwG1qvNMhCdlDsfz6mUTFuhdytFQPdJ1LegiJ+Z0JeJOdahpHxYBECZt0NHXMfgQFpiJp4zIHzJX+J9APv6B+EgzWrlQ1Rq9Np2sX0aiEPFifYaXnTCt2vZ9LSAsczHBv/BRV0Je131lKkb3QyfZByOc5NWE7aufk1THsMAe0Wh6xJwWLMMfxfFBP9bWBI8jV4P06wqEuGxiBvLTEaX2H3Kg/0PZtX4d6TCEOF96lwofMkexGr3sjCBGvkwO3PQWiyNLAPm40NQcvDy6OXdf07Ie1D0bEq9GPM3D4Eh6c48+tntTXclM6yfZ2cdHEJTD0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 17, 2024 at 12:04:42AM +0900, Hyeonggon Yoo wrote: > From: Alex Shi > > zpdesc.zspage matches with page.private, zpdesc.next matches with > page.index. They will be reset in reset_page() which is called prior to > free base pages of a zspage. > > Since the fields that need to be initialized are independent of the > order in struct zpdesc, Keep it to use struct page to ensure robustness > against potential rearrangements of struct zpdesc fields in the future. > > [42.hyeyoo: keep reset_zpdesc() to use struct page fields] Ummm ... why did you make this change? Now page->index still has a user in zsmalloc ;-( > Signed-off-by: Alex Shi > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > mm/zsmalloc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 432e78e61d2e..dded6d1f3b7a 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -843,8 +843,10 @@ static inline bool obj_allocated(struct zpdesc *zpdesc, void *obj, > return true; > } > > -static void reset_page(struct page *page) > +static void reset_zpdesc(struct zpdesc *zpdesc) > { > + struct page *page = zpdesc_page(zpdesc); > + > __ClearPageMovable(page); > ClearPagePrivate(page); > set_page_private(page, 0); > @@ -887,7 +889,7 @@ static void __free_zspage(struct zs_pool *pool, struct size_class *class, > do { > VM_BUG_ON_PAGE(!PageLocked(page), page); > next = get_next_page(page); > - reset_page(page); > + reset_zpdesc(page_zpdesc(page)); > unlock_page(page); > dec_zone_page_state(page, NR_ZSPAGES); > put_page(page); > @@ -1865,7 +1867,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page, > zpdesc_inc_zone_page_state(newzpdesc); > } > > - reset_page(page); > + reset_zpdesc(zpdesc); > zpdesc_put(zpdesc); > > return MIGRATEPAGE_SUCCESS; > -- > 2.43.5 >