From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F386C02181 for ; Mon, 20 Jan 2025 22:42:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0E6F6B0085; Mon, 20 Jan 2025 17:42:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBE706B0088; Mon, 20 Jan 2025 17:42:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5F596B0089; Mon, 20 Jan 2025 17:42:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A451B6B0085 for ; Mon, 20 Jan 2025 17:42:29 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 27DA01601AA for ; Mon, 20 Jan 2025 22:42:29 +0000 (UTC) X-FDA: 83029305618.27.42D52DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id CB74E18000D for ; Mon, 20 Jan 2025 22:42:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwrvqZqB; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737412947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rr/mJCPPlIoUxh0qeb7nwuTIwN1v1Uw8JIILAMa5xao=; b=2ocov7rSycmC8hG8lAbskwZIF3iiSpzZjN5sIFYyjpc0u06OiCEZ09WDlNMiNcvvzFzD4Y 3Vmz0n/RSh4p6boZ9E5TCdNDfo2dTlwsjhIAV3F++PQvN6YXAqNNwq/6PcMeB0e2ttpVhU z5kL0zj7p9YD+mmrqia1f3j92HdymM4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737412947; a=rsa-sha256; cv=none; b=CORjdY9m01uQFyfpwz2qx9HlBSdSAh7EOIx/oyaW80k9BbwmyhXctJGFZd78QzWdDmLquO 3hOpGrjiYsq7lmPuyStxWK1GoCLlBAN70veZcKB8EZuw2Mf+J6znFM3/Jpd6/OGhCzmaVL iFrePntvkEOF9MMAN+5zs3YcOPPabYQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GwrvqZqB; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737412946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rr/mJCPPlIoUxh0qeb7nwuTIwN1v1Uw8JIILAMa5xao=; b=GwrvqZqBzdnejOk/1z0QBbFz2zjt4JHeqfdwGF3owVo07uwn3Ts37KrsPev9H2r83g5WVB DwixF09L0xcUVhzTIEkYnDl00GQUjsnvPdMaUzs/aKknxpJTwxuM/7+k5R6pEz6bc39Qph BGeyxk0u9ElNg7bgqFJZMjV1zitDMOY= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-nGzO_O-PNuCXihV9HB8vdQ-1; Mon, 20 Jan 2025 17:42:24 -0500 X-MC-Unique: nGzO_O-PNuCXihV9HB8vdQ-1 X-Mimecast-MFC-AGG-ID: nGzO_O-PNuCXihV9HB8vdQ Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7b6d0be4fb8so842561385a.2 for ; Mon, 20 Jan 2025 14:42:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737412944; x=1738017744; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rr/mJCPPlIoUxh0qeb7nwuTIwN1v1Uw8JIILAMa5xao=; b=VN9loSR1ObkRqBLL/EtHhl9xbz5HZjvE8CY3BtN6vkPgV6fPdLA9t7CaTb61PycJ6Z Rtj0poxnvJc3ljGIeKMa7rShBNPEJIR8CZviwDs949p+U+5IBvkuvccGRGTO15lZ/p/U PzZ/UEXSBgqWNzo0zNoskocKfMUm9IVfE4B5kesTUdHHGpeLVydu1Rb7kyJVhDWJXU10 YHyH/QHGlig4iOfuWVfAFr3kNE9tLls9GjDOXL/0dEOHSRPqbmX0dvqlMzdmkyZZt/1E zeWoXe7nBLeLP1jckC2px6HQeNa+bi85KivzpOjQxSKnbbZHNk4rAJ3zEJXtSx5PmhnL SJ+Q== X-Forwarded-Encrypted: i=1; AJvYcCXhTIJ6MFnUkXXj+hW7ROJgENeM1itZxJcxBs9YsqKv3M2W3FYCVc8pJgrSBZYTUq9v69psIxsq1Q==@kvack.org X-Gm-Message-State: AOJu0YzEmx+kxwV8w7Yh6D5zKa2ljWYrI0zzxLzCO+3VQfPc6jZ5uyla bL/HLsZzTic6Tginu1tKNFr04PKC+PyAW6JtV9GotXcbo5TubpYT9l6q+p74+ojpjHGZdF+3xgc qLk7yMGyH623reQmke7K2lVR7odLbK325HBkVQuC6gbgNOokv X-Gm-Gg: ASbGncuDGPFea/R34rDZj9xjf8Q2RoJThmPf5gvuhHQHHweEXUo7UBiNKmjyCPr0lDQ h01MRdWuE96q3xLJWaBWgofMp4J7dan0+DPOj85kUknlAs3fD0lik6OU3g4osG2jl6eVowbeFFW NyIisTK5CQ6K8vIQ9oQ7kM3pnqOM6lnpNrka2R2IjSVBJE1XTXPjGrO+7WX8jjjEnHCEJvK4a3h 36jQscgM3BXf39XKhLBBZMQC37PdxQS9YsODfP4TJUCvE9W9xn9b7Ns1UrUmG0n3q/H67uSJfBx bewGwjtT1hC1FLEj/2xaiPmgXYmOrhk= X-Received: by 2002:a05:620a:1a02:b0:7b6:6a76:3a44 with SMTP id af79cd13be357-7be631f2fe6mr2099332285a.17.1737412944398; Mon, 20 Jan 2025 14:42:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEThixwCznyw5iNLbhD2xvehIRrXyI7UvkShNUVV9hD0bz/X+BcgicvUE24wdf1vF932XY0Hw== X-Received: by 2002:a05:620a:1a02:b0:7b6:6a76:3a44 with SMTP id af79cd13be357-7be631f2fe6mr2099326185a.17.1737412944062; Mon, 20 Jan 2025 14:42:24 -0800 (PST) Received: from x1n (pool-99-254-114-190.cpe.net.cable.rogers.com. [99.254.114.190]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be614d9955sm493015685a.81.2025.01.20.14.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 14:42:22 -0800 (PST) Date: Mon, 20 Jan 2025 17:42:18 -0500 From: Peter Xu To: Ackerley Tng Cc: tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, david@redhat.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, seanjc@google.com, pbonzini@redhat.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, isaku.yamahata@intel.com, muchun.song@linux.dev, mike.kravetz@oracle.com, erdemaktas@google.com, vannapurve@google.com, qperret@google.com, jhubbard@nvidia.com, willy@infradead.org, shuah@kernel.org, brauner@kernel.org, bfoster@redhat.com, kent.overstreet@linux.dev, pvorel@suse.cz, rppt@kernel.org, richard.weiyang@gmail.com, anup@brainfault.org, haibo1.xu@intel.com, ajones@ventanamicro.com, vkuznets@redhat.com, maciej.wieczor-retman@intel.com, pgonda@google.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@kvack.org Subject: Re: [RFC PATCH 27/39] KVM: guest_memfd: Allow mmapping guest_memfd files Message-ID: References: <5a05eb947cf7aa21f00b94171ca818cc3d5bdfee.1726009989.git.ackerleytng@google.com> MIME-Version: 1.0 In-Reply-To: <5a05eb947cf7aa21f00b94171ca818cc3d5bdfee.1726009989.git.ackerleytng@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JEoP4lIoCoDyXsL-tLH9OFo65YOBeRDPhxLdvlcnBsk_1737412944 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: ph1u7f1zdxzumxmox6m7xd6grz1mdoan X-Rspam-User: X-Rspamd-Queue-Id: CB74E18000D X-Rspamd-Server: rspam03 X-HE-Tag: 1737412946-426039 X-HE-Meta: U2FsdGVkX19wdKt/8RwVXaNLmdJN6jMCPnXLpj+KkNdgv0vRd1sGmscXSDw4zmk9BYppStkfxaa9Ob6P4wy99OruhLgqNTrZukakVSrbQJXDlQmNgK1mqveoENNkF/QwSp6aqmmbgvFwJldUPlriXpliEaHftFlt5wVVr5QjVlrC/7zEfLRTHKDiV4AGjSzXngaM4XniCm7yzG/OR5xdP5hhElVRblbdjvvtc9E5nYcvo4mKQqCQvZqIe1d76N47MjOw050AUsWMNvVY+jYtBvLG8W9pLtubOYI1ib5Rs3z8JOinGTprug+MlstHKN+1gwFnaCYxlgH+wB7SM1B97Y+n2DRhCexFibb4biRapKR7ZXRee8LDhMrPwZgopJcTfbH7jVaT5EZ19P4C2oa8sEG8U13du/iuUtezt1f/30DkfqWnWqacJB2kpA9G28Oba21GXActy9Xo3giwtoBcIXbb2TmCnR5wt+nTKpHA3T3xPMHXYci342MWC4EsKWfdHAA4FrnG4cE/DwYAdYn++0sK65V74ZSeojgU5wYVLw9Ct2xhkSirmzpyk5H3YvZiZrjprInUs8bw5A5pNyJEawvPBkZaKpc4tja8hQ2hR/V5aqao112Ki8Xsigza5d72oYGFfsNNeXdE6DorD17eCYwbac5+UBeaqfE83SunWC0iZezneysdPLrMV6W6eQNLJsVFf5ZSRjh4gGiGCJZwiUylV8D2v/rtfyHuirSbukDIjRhtnSazYUV8bxox1n8BKgyaLZoWdX3/MpejqtgR0wll/PlHh17OeSfpwRYruJ+vDIsMj9v36IlLs2SsVartGUrCj67xYWyqJ7fQbl0Kgc6xHFuK+iMzbSIOJ4WhbMBa9Qq4l4iFxaGhlNuiEmTdM0k21eqwB8D1GvYmt+BURCMheFlce04Yv6vay504ePS2oqeQlzP7uUJZD4M0TI4NwBGiGqyE0YlsBkpJWy+ sE5H5Mni QY6aeTLNFM9aaLTaP4gtaUhgAdi+Fay0mG9JK0w/ZfRNl9vOR6+p9BUH9XyIAT6ZvWopDwQb/oJ0mLgbBr5+NEGSaXIJkRRpvdCjX6RwPQH+oOfXkCfAEheHSVr0zNxQ38YuOcxJjDAisyHxej2eyiirlfvYAY+cBXNOZkFESnxTWGHVVzKAYqBC+i/jgwiCeWLmw7QV82IsfKFpFxaalvgiXAStVkwhW099xWrO0fI3y4uHRaUgZ1t1PLj4qkR+Y0B3nbS1LTrs7LhlOBy+sVjJbvDt+/dbqIp6COQcvZ9C15BonP7t5hF+4vzrrW6K1YVUz5EVGP3R76LYLd6Iw1EU6GrZP7QlDdTrwhMe6yfxZPOUEQqGUAm/sQWC1pQEufPON00sBxxOPjqWdzCgfgHo/ngmJyQ7GZp0bNXHbC2p8W3n0ayXDzueZjS4BDJfZpZ+cdMgeZnmxTQlqwuTJy5+WOi15yy1opDLl0Sfcp65bSc8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000150, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 11:43:58PM +0000, Ackerley Tng wrote: > @@ -790,6 +791,9 @@ static long kvm_gmem_punch_hole(struct inode *inode, loff_t offset, loff_t len) > */ > filemap_invalidate_lock(inode->i_mapping); > > + /* TODO: Check if even_cows should be 0 or 1 */ > + unmap_mapping_range(inode->i_mapping, start, len, 0); > + > list_for_each_entry(gmem, gmem_list, entry) > kvm_gmem_invalidate_begin(gmem, start, end); > > @@ -946,6 +950,9 @@ static void kvm_gmem_hugetlb_teardown(struct inode *inode) > { > struct kvm_gmem_hugetlb *hgmem; > > + /* TODO: Check if even_cows should be 0 or 1 */ > + unmap_mapping_range(inode->i_mapping, 0, LLONG_MAX, 0); Setting to 0 is ok in both places: even_cows only applies to MAP_PRIVATE, which gmemfd doesn't support. So feel free to drop the two comment lines. Thanks, -- Peter Xu