From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C3EC02181 for ; Mon, 20 Jan 2025 15:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07D566B007B; Mon, 20 Jan 2025 10:36:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02D0A6B0083; Mon, 20 Jan 2025 10:36:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5E9D6B0085; Mon, 20 Jan 2025 10:36:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C9A156B007B for ; Mon, 20 Jan 2025 10:36:30 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5724F1A026F for ; Mon, 20 Jan 2025 15:36:30 +0000 (UTC) X-FDA: 83028232140.07.34C39A5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 388D0180007 for ; Mon, 20 Jan 2025 15:36:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q9mZvCE6; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737387388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=//go+pLaCR8IMBhqazIFlxoNFbU+MztBKStJ5RScj4U=; b=WCHpqosQrA01SaILMN4xIyOomS4xm3JFbBXqezc0bA4ffj13voB3qoNZNINaJAUWo5xoFk azlG0UK0ISOHcTslxIQ0YVztAr44y5DhAneRQHRf4UCiKR6qQDfxSh81cP7GP2e2Jh3pbP 1IrBhqyv0IeIpflIWPyqAwEUoJXpy2s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737387388; a=rsa-sha256; cv=none; b=l4RSdOu7JdQUuNCKxrowLkcLLS3jsKCPu1B2NySnlOhlr6eL2R9L5xkwdsx1f6O33HuqUD PoYcfKbhCfVSZWa4MEhYNr61C+f48z/BbH+3eHUqoMXbUQv6CDpsqoWL9zYRwANhh+1s/S d6HnN6gKixKavjMG0h1OYXN/oiASWPo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q9mZvCE6; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=//go+pLaCR8IMBhqazIFlxoNFbU+MztBKStJ5RScj4U=; b=Q9mZvCE64gKpU3BjPLuegQ4Gdd a7aoxil88qj19bU32p9Se5y/HYtVcDbpZfz3/OLPySCcoGIFvWt/cO73iZFVbHkJnBW13DQlOao8B sZZZUf9Tka9eHvnnPGKp7U7GSRwZjuCUz01+9QsMfowcFfsgJAZkviaiTETR20uZljRHi6Wks9Jev qeOMB6no6jZNxFvpwCnd/1V49zZ460G8ih0sSZ98HiAGXxkk+gTqIO6OQ5rb8RJgDoxScZDtIpRuJ v2CVzWniU84NZzqBjCtID++0EDyT9Te+ekVjd8Fn9EhytyNa+n27QYebPjcK4jeOGS2FYvCU3DHQS sCaeU95Q==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tZtou-0000000Bhdd-3fGT; Mon, 20 Jan 2025 15:36:09 +0000 Date: Mon, 20 Jan 2025 15:36:08 +0000 From: Matthew Wilcox To: Hyesoo Yu Cc: janghyuck.kim@samsung.com, Andrew Morton , Jonathan Corbet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: slub: Panic if the object corruption is checked. Message-ID: References: <20250120082908.4162780-1-hyesoo.yu@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250120082908.4162780-1-hyesoo.yu@samsung.com> X-Rspamd-Queue-Id: 388D0180007 X-Stat-Signature: pwwkhguxjzc1sazry9dxm1ur35rgiajx X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737387386-237937 X-HE-Meta: U2FsdGVkX18NBrLIIJJdPG9Z3aK8090bmL5O3Zct1exhek16EOq+O8/b6mPqx9G/Fbjp1wDUbX+74U6TlCtaMn+HczokccdASwiye75CGRnVxT8en0NOUDXf04c0fJvjvlSbqbK0BS9p9naa4suo7qhgl4rgRXd+bdPNPLyccJ03G6J1QTEIwYIW9CdZP7QXGt3wvBhCMHYcLhYN5ShqPcnA8f0cbtwi69GNOM/79SbNH3eOpaPrMyjTMQKjggkz8xSHryfDDF/7egThTGyNYLSl/wGo7R7s8N3Ln0hyEYZ9HwJMAdN5ckbmGDXRTK9aZD/L0oRDqSlme4cDOG4pCraxnlKDZ72kkbaZzr+nGJx1A/bFKx4wnNgLeJttX6iTvrHTkGFXdCAMmVEcrPsQkvCVS3dP4jHwt+/QQ0/CBVJh3DM8g6KSilLZPViAtxtWoXtUsblYb4topacMqiG54aZsuGmmHEKEMGASXKiPH3wHyyadIaWlYHdMvwuHiCR5uQnymu8tI/TAk9gB1YXsIzT3ExLvp/eQ6B2NDs4Yoe0w+G3w8YJmeOelNDt7VYSbChQx2nEsd5HmrfDZjJfIjPdQLSWQJQ0QWGXZl9WX49lP/wC2mG/g8Hv5PvOBUdtlkoZSawNPtgAE/Mknz3pJZ/ZU9Cjhu03I43A3qVeT07madMIva/IOCqG/g6VreCIHoMtS4Wyf7IH4F5K5g9qGWgzJ7XBkcqoizm0kqhos+J3YftE5GzIzC0hxLVLjHBS5sJ2BuADyAiAZiaNBjA4TYsTuQa3UEFXzE62xAyONyJfbnjlyvxGfhtCPVJKZF6QZ6GDSlY6xmbgJgLbEAfw2kgsG/1skZWCOgci8kGBVr62JAoBo9VZLP7llASELDiqWT228OntGX862gHl0BBVSgfE64HUTUs2GY6We7Ly4V76/zUcMuSGzQYAJJWGkSXDP6vAB6ZpgApZupOqvlcg f4Wtdy+f ak0L+fn9E+/zRfhx++qTCmo1UmWJFPWPBcBiXE7F9hnwsXDEgVdpDB44HCFKXv0coaEdEmsOi33+eEMpICtvGOTBW83WSnRk7jbWNIs8jB/nQNNcFFuqzO+82RckoCixicpKzlEmUKRkkBR9XcqShs9N300dWNl76tLzigjpXDLOHfkz8DqpLAgUlyxkeGXnzl76lH27+0ZHy3jIYCB1J+8cRAWVv7iRihJscqKxbCGwhlh/AiUc+XmYYLB+TlumoBA5KGIVp2TmEzKEY6YUb6bKH9Ak3H8r75d707kqZkILaoSfZ5GVrqb4c6/W0A0Dswmd+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 20, 2025 at 05:28:21PM +0900, Hyesoo Yu wrote: > If a slab object is corrupted or an error occurs in its internal > value, continuing after restoration may cause other side effects. > At this point, it is difficult to debug because the problem occurred > in the past. A flag has been added that can cause a panic when there > is a problem with the object. > > Signed-off-by: Hyesoo Yu > Change-Id: I4e7e5e0ec3421a7f6c84d591db052f79d3775493 Linux does not use Change IDs. Please omit these from future patches. Panicing is a very unfriendly approach. I think a better approach would be to freeze the slab where corruption is detected. That is, no future objects are allocated from that slab, and attempts to free objects from that slab become no-ops. I don't think that should be hard to implement.