From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6ECC02185 for ; Mon, 20 Jan 2025 09:40:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AED16B0085; Mon, 20 Jan 2025 04:40:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85F276B0088; Mon, 20 Jan 2025 04:40:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7003C6B0089; Mon, 20 Jan 2025 04:40:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 525606B0085 for ; Mon, 20 Jan 2025 04:40:57 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E4C32A2917 for ; Mon, 20 Jan 2025 09:40:56 +0000 (UTC) X-FDA: 83027336112.13.CBED0E4 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf09.hostedemail.com (Postfix) with ESMTP id BA76D140006 for ; Mon, 20 Jan 2025 09:40:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ewDX9AKY; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737366055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yPKYIW+/1BswY6JPHJ5KhjmDv3E4BoFMuuugSXDPRmg=; b=fKf8PAcuiabYqeiJvFc6mglAJX+UDpySXUA/cDGFv7GlWe+l8yAnwhCSJEzlqRaQxEGAhy f7uDHNpXbfX0hB4FxilG1JsRcnFLv//Xm1YDr+e+YxqPZK7PckSR3xcRlj3SLPJQ5SZNF3 +bgJfWTaKs4kJiWcNlI64dUEu3WMieY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ewDX9AKY; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737366055; a=rsa-sha256; cv=none; b=bsX+CkIP57XXEADpcMdoLhXUkVAPeqnEfbg3/bbIjiNydlpOilr1BOLGdMxEwaf546VkdK Bb1ut+IPJJDsddfvZRdQ4IPea8IHVm5Tg0aZ6GgESRwKkyQGmTRutTAfi4JvtZZFm2jFuo Sc0LBeg0+0lbhTfdD+f86RDhmfLq2wQ= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aaf60d85238so713360266b.0 for ; Mon, 20 Jan 2025 01:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737366053; x=1737970853; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yPKYIW+/1BswY6JPHJ5KhjmDv3E4BoFMuuugSXDPRmg=; b=ewDX9AKYT7yX9dcr2tXNiv6dx4SfTIJI3ZaauWUqS3vWdhJzhD5Fw8xytiNJCpJ19u 8HJOX+iwnf0+8TMeF417d6qV9XxyyBKZ9tb8phOtcj46Fmnvobm1ImYeM82V5kYKYv28 tVr1U5niQddacmb0j9JFJFCFqE37Z2AtD031cYVy7uMA3odafKzYCjdfzrfn7irheRwT ZoUjGRtC/9J92o/oCIXNVesziKqjigQMH3DZfcOJz9/c9n/NhsPUvy5rvliWrzZH7FxZ zL6FW5rgPi8aHFjdNvx9mutcdzqhtLO9jE2W9tCXTWTygzwdwhc+KaNoL535vsUiXdaW 8r+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737366053; x=1737970853; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yPKYIW+/1BswY6JPHJ5KhjmDv3E4BoFMuuugSXDPRmg=; b=ieSgLcgyhi7rMrGl5HYurr4QXdD2zUirsLTt7bx01PnaLud0cdN2OS3sWNrH93P7VZ aW4Tm3hWUVYZqOgVLEAI5vMpXq3/POa8XVKDsocfSqpcGRAsmydfHDmTlVv2tQLmucSe +KdwifSPfyD/+ZEJgPqSJSJdwzWtq9d2LwZXe+2AYvKg7ughCw0o9x/6Q8FIlImiFnm3 Oui8Z4nLU1YYtueX3S5gAKhky6WMAYxB/7IXz7hxecADhNuv45bqzz1sCQo261q+AU1F HXTIbc2X7iSYw1sokiawEXKWCVeqyb9tuWT+MZjXgMDEjnamC6hVWRc9heMOuXkRHnWQ 4KPQ== X-Forwarded-Encrypted: i=1; AJvYcCUxLK0PcgiPPa4nKTZbiGQDxeNx4XxIgpPV4A8qkuPU8d1CmqdAwSx1m4Vu1ce4FNoG90SDmCIjeA==@kvack.org X-Gm-Message-State: AOJu0Yz9fk/b91dTnSxth201/wjb84h+AiMxgfij4Ole1Ozid6KYOQVV ieIJciLYXFMWbp6N9cdJd1hzrNRerykoZKSMgPeqSjDeCeeBpUNZWqgjivbD3VI= X-Gm-Gg: ASbGncsH6wDf/2nfpttfua9uGUoeKrH7LfxhFl4IVTUhDilGct1dNAkzOFcGck9XmNN v6Li9tM+NYmg0j1fTTmN6mhOlnMM+w22wjoPnaNh95MB1U51F6TArUOBxON/ykfmE/QM1UF0BPs H4aY21R3cQSPJ04l60Ri7fhyFm3BbiPVMobKUsoS1kAJV/y3Yr4FWshL9IjlJN2vgz65ZMNFRM4 vM3zM8b7d/F6JGSAhF22hS8zFYYfE6klzJNpNYRWZKxRbkBlcmjsRn8CY2plzpYPWMxZtFQFbci 2EeG4kM= X-Google-Smtp-Source: AGHT+IFA2mrrQCmqsHXHh3qM1OB0JGHDkTSHTxhU+WYqBMFAdjqFLOjNjtr6V6ka7y9doZtbRAOrKg== X-Received: by 2002:a17:907:7da2:b0:ab3:84b5:19b7 with SMTP id a640c23a62f3a-ab38b52ed37mr1243807866b.56.1737366052904; Mon, 20 Jan 2025 01:40:52 -0800 (PST) Received: from localhost (109-81-84-225.rct.o2.cz. [109.81.84.225]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384f86244sm592211066b.152.2025.01.20.01.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 01:40:52 -0800 (PST) Date: Mon, 20 Jan 2025 10:40:51 +0100 From: Michal Hocko To: zhiguojiang Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH] mm: memcg supports freeing the specified zone's memory Message-ID: References: <20250116142242.615-1-justinjiang@vivo.com> <3156c69f-b52d-4777-ba38-4c32ebc16b24@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BA76D140006 X-Stat-Signature: gsiz4wmkwj9rmjo87a973kpcfr63thoe X-HE-Tag: 1737366054-584096 X-HE-Meta: U2FsdGVkX18wncGOT1uLY640Ncx3IJf9r0mlolR5r1qRTcMoMN9DEPLBtswr4OIv6RtG3tnjFcQthT8CjsUP7NN1ZYlSE1zDScvzfntz6kgtZ/rQ9wLQfvUSm3jcKjy/meLy1Ms8/2egoUjjOZpQ7SdLJ8ltUOmlJ9S8yGja322BxWR5cxhtYZ33C7iWXeQFlaleHlOUt2HD0WWW0XNWpISDbGpW6iQDL6dahMknJ9fmmL0uJ5uGTnEWrmxyp9sp5bow7hHZi1XUjuKFvifutzZUz/kjTM5Kb1YnIwpwybeZkIVNL12XT9xWmOOYfY1jKPadVPDOOHTsFiv7+IhShSJmhuq8BH6cQmTT5f/x1Hd1xCYpXGovJejBAlhPLz0BWWKwdQrdKNkVjSyK26sd+YYyaAzyxd+hf2dBwepqN6a4PaTcwS0ZIIW7RUN15D0I7OLlLns/dCqkey6pVkFZbvEBbeAw6P6Zmu668GV9jirLXXufQEaJ4gZTs4cZbH9pHzWj+oGsipEavky+yLn67DN1pyuMg0SiEkzVXdGMjW6ZKF0mzzBAOaeHmTtWXaWu+Fu+WNg44wDKEcle+/ZxaFUs4JmjpMWQfri3U7xZbnhSMPNlF8jjvBOKeD8Nr9jLQWik50feTaA+mCxedRbGCdI9o9RT/vz3YHgOJhs+u3S/xWysd64ikLfu1C2hM+3W+A18uuvm1qU7MV7GQmBASBo1oID5BTk5seCe4UBbrjg+x1944YKPiCD5Nj95pMzdqApbJ6l2CCKfunbul1HrR3MU3MdLEoU8DOPChsqQSAYMziSQdzVenj7xE2HukWWHo0KRoyblKzvYZvLCdOlI8O/4bZDehmxaZ9JuZAaqlyUAsPOr9hfa74IYwugroGIhqgRZmBU6HbWIjMDQjRg30C1amgqqGbQfZLb8XHM3n7aoU+S1ZhbShEMqYU+0cRNbDRl95yNr95C4CuZWlbw 8navPLb+ s6XbuHgph5KM4ZqLFfzO8bikwSGFiQ9y7ghwZF1e3kbR+vwLSGSCtSkgMZEA+Za4dH/KmqmkTLkwhqnlLOtOxCquZV1DMXhmU/xlUsMnp1R50QsOv4TNoc1ewdf5LFvgexEEalJx7jYUr8IOTSaPonbWjLuspdzaw0mg6lgVmSnyCzhlD5KiFG3bQpBoTc6viiCUBI5+1CBGwn7kV8Hj6NUisSdYYH/UncunUFtu66Jr/nSI/QNCB5s1wku5e634Bn9V3upeRM3e5lkyIYFk12jFCzKRQwotl5s52DUko8eJvsXvPW9ZLElUotmUYkpuMUPCEpLaACyxBKge5wqL3624DcVgGTVM50a0rCqlP0VDegFlRuQuZh7QqUKVuf+FAVn7M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 20-01-25 09:22:47, zhiguojiang wrote: > > > 在 2025/1/17 19:43, Michal Hocko 写道: > > On Fri 17-01-25 18:25:13, zhiguojiang wrote: > > [...] > > > > Could you describe problem that you are trying to solve? > > > In a dual zone system with both movable and normal zones, we encountered > > > the problem where the GFP_KERNEL flag failed to allocate memory from the > > > normal zone and crashed. Analyzing the logs, we found that there was > > > very little free memory in the normal zone, but more free memory in the > > > movable zone at this time. Therefore, we want to reclaim accurately > > > the normal zone's memory occupied by memcg through > > > try_to_free_mem_cgroup_pages(). > > Could you be more specific please? What was the allocation request. Has > > the allocation or charge failed? Do you have allocation failure memory > > info or oom killer report? > Hi Michal Hocko, > > RAM12GB, Normal zone 7GB, Movable zone 5GB. > Issue: kmalloc-order3 fails from Normal zone and triggers oom-killer. At > this time, > there is no order3 memory in Normal zone, but there is still a lot in > Movable zone. Thank you, I believe this makes the situation much more clear. It seems that the Zone normal is too fragmented to satisfy order-3 allocation request (the amount of free memory is above high watermark). That means that the focus should be more on memory compaction rather than reclaim. And more importantly at the global level rather than memcg. Also you are running quite an old kernel which might be missing many compaction related improvements. I would recommend re-running your workload with the current Linus tree to see whether your problem is still reproducible. If yes, please report along with compaction counters (reported viac /proc/vmstat). Good luck! -- Michal Hocko SUSE Labs