From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0F3E77188 for ; Tue, 7 Jan 2025 03:35:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBCF06B0083; Mon, 6 Jan 2025 22:35:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6D626B0089; Mon, 6 Jan 2025 22:35:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C346A6B008C; Mon, 6 Jan 2025 22:35:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A5B436B0083 for ; Mon, 6 Jan 2025 22:35:57 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 38736C066F for ; Tue, 7 Jan 2025 03:35:57 +0000 (UTC) X-FDA: 82979241954.12.0B28576 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 167DF160016 for ; Tue, 7 Jan 2025 03:35:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jSGCwOgo; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736220955; a=rsa-sha256; cv=none; b=LnMjfLKIGh5Lm/3Lt4nh8nNYrZM1ZFZIXGYFvt8SZhfIBkmdZt7c7myni8iq7fcoIzM2c1 BeFtMzqYEEW50OmJCQk526bzLGk0tccPo8CMVF5JG+EM9dyfVy8fskr8OO9/IdVszvor2O lpV4m1sx9Ulv95fn8wj4+BhYSlirbr4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jSGCwOgo; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736220955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PhzOYiwRQMoDyruOb7T1RFgmcpV0jqauxD2Zun7rLB0=; b=bS6paQEPE5Y1mdMd12plT7eYQdrnsHkWuPnMwMqE6ALX8LJOCKmf3DESM2ECHY9pPB0awS d9bj9BImaFnZU0JZgA6fg8loK5CoHPRyozeAjPNxQq2vq0tt8Ol+JF86xmlOb8cNMptrWV /fRoxUcfxio2rVaMDJwPQgur+BlY9PY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PhzOYiwRQMoDyruOb7T1RFgmcpV0jqauxD2Zun7rLB0=; b=jSGCwOgoQom4maBFc9OL/c6tTK /HnmDcDkuT4O648RrwPbbIojHCyrl8EQawvuK+k5ud5QFXlGmdG2R7nhhxx3njxSdHgPocGrAJZUY rax+FGU4Q3PVnW2qiNvJdJOK0mUPo3R2e/gO3d5XmIDnOjbGKJnZ4cqy8JrY+vIvCX4WSEhPoF3xL 2NbaUY4brg11DxFptnFaD72fg/zG4bb8QmAn9wNDRMvgZzid2K4U+1RUPiTyDSIRgBMbUG38VIaqA 8NmJ4BgGWvRHnyrK8Lw5tao8KcYtCOfRYCjjSIe0btesBAZY+2OhALPIwgNiA9NuN2zT25JK0jiba t6KBH3Ig==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tV0Nh-00000002YxU-2Dfd; Tue, 07 Jan 2025 03:35:49 +0000 Date: Tue, 7 Jan 2025 03:35:49 +0000 From: Matthew Wilcox To: Huacai Chen Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, Koichiro Den , Sebastian Andrzej Siewior , Lorenzo Stoakes , Mark Rutland , Charalampos Mitrodimas Subject: Re: [PATCH] Simple fix Message-ID: References: <7gd4skn6l4i3liu6cvzmgqlrwxc3rukrnau7lnpyhmfyjuvqwl@gdwgybedp5gs> <20250107011848.689556-1-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107011848.689556-1-chenhuacai@loongson.cn> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 167DF160016 X-Stat-Signature: ymqaz679ec877oph4qre7s6tmq6k88dp X-Rspam-User: X-HE-Tag: 1736220954-867996 X-HE-Meta: U2FsdGVkX18+ogUmFUa4ybj+IHCrfQTwP1CdTy3pC9IX2ssDwkCCJu8CP2/ZYrWRVOQ5xmcIfdRsNyzlgwZgF5lvIGob2s93iX6ZI/GHR2/ndwpWcWOpj9JeBm74bP/pvk2fxZ21m7RIm7MmPSLfk1VQhPAkdbfVGUzJUiS/+C6IcFd3jYHVCOZsJNquQCaCEmqo+tnYlY67VX+ZUwIMUBguVHAU1TMrU4BU8Z2+SaAw+p+LYllBK0wlMlF+fiA7f3DtivJzIgIDxgxFyrQbOtboVjCltCleIM3M3phUYbr6XJxl9UvUgEcI0xZU5bLf9oRJZGX2kQ+Ruh8ON5OZ+ayh+wSXFBL1eBeUsDXKzp8NfNzzTLeSWerWZMmvPqzC60ggw/Rpbb+/yJjhRKMPdbzbjTIdF5Sv1t6y4EPsM+6nUYnvZGoz74Y7aA5S7x+3GLjcEpfanj1RAGzdGHt6QecOBAhhmAJ5X9plF/Xhu9BfP9OIGNw8GPaoBX1zuZLPHQrs9gPLG5oy8cgg32gXhwfWZyl79VXheBWk+HHCnyTqhn7m0JsU7GQ1lRoKZm56EVtGtq+AiDE1Y+6l2EnqS8fS0JcQLA51yAiPZvMpgYazMyJ0hkWNe2W/t3dWOPz6zuqdaf13Q4z1G2ZMnnHTsNyCCzFMIVdK60Gd+dqNMz79WE6nSaImUC0/d7OdFeNpqzl9BkoXHCNpshFwEV+r/sTpYzQbyPI3AvN6oGGmJ8acPbzh0h8QsKUO86CpY8WDDfe8zXyqLEHWbtVQz4WWTIZpI8om8Ri7DDoHzamYur2tvLGCPYcKDqrw0B/PxAbYvhGnkUHSjCCQrbjryF52us4GRVokVBSFxeHz6oEo7v3ZgXWfyU30v2lzt7q0bUusEXYBA8wTujrJ0g7IqfVw1DjXSbpRETqZFLdhzJsOTGigSnknSvcIxvgwXa7Dfmsc8KPYc380F8SiH4cZOJD le0JBTER B9xMBu4uwszbPvl3V0rLuPzYwn1mHgv7g0PNaZPtFJ75ePE6DAVYZRJVG1igaoBRKtkF4ztgX1CsNbCLal0jUL7ULv1ut5MM41Bjzm1AySqLKLROF0Sb+o7EkgeAwCns+Dxck+3B14tPDP2LGoyVRUjMlm2+p1kcG2HPF+xqGpL7XAoXxHrmUwJRMaKnjdscstTdlfoGHfgCK+AUqwW27Ymd9wVToiw7iUCGh X-Bogosity: Ham, tests=bogofilter, spamicity=0.062366, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 07, 2025 at 09:18:48AM +0800, Huacai Chen wrote: > Hi, all, I like simple fixes, so is this acceptable (based on an early > version from Koichiro Den)? This is an unacceptable commit message. > mm/vmstat.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 0889b75cef14..1badc24a21ff 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -2122,10 +2122,15 @@ static void __init start_shepherd_timer(void) > { > int cpu; > > - for_each_possible_cpu(cpu) > + for_each_possible_cpu(cpu) { > INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), > vmstat_update); > > + /* Will be enabled on vmstat_cpu_online() */ > + if (!cpu_online(cpu)) > + disable_delayed_work_sync(&per_cpu(vmstat_work, cpu)); > + } > + > schedule_delayed_work(&shepherd, > round_jiffies_relative(sysctl_stat_interval)); > } > -- > 2.43.5 > >