From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9354AE77199 for ; Tue, 7 Jan 2025 02:06:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A9F76B0093; Mon, 6 Jan 2025 21:06:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 231916B0095; Mon, 6 Jan 2025 21:06:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D15E6B0096; Mon, 6 Jan 2025 21:06:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E296A6B0093 for ; Mon, 6 Jan 2025 21:06:50 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4F64DC0609 for ; Tue, 7 Jan 2025 02:06:50 +0000 (UTC) X-FDA: 82979017380.15.0578AB4 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf10.hostedemail.com (Postfix) with ESMTP id 53C93C001B for ; Tue, 7 Jan 2025 02:06:47 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=ppt5WskA; spf=pass (imf10.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736215608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IjuG/BOSvMcwQTrLlf/kxq04qceC6aED/k0KKY8cXVA=; b=qncgFwAyeux8Zl5AymXWNadPtYqFrEH0WFN1qFs2OxtrJ0u8W4IR2UBNj3BS/OG58TEu8x 97ND2sjmORuzefFEYg96c4yk78kHsKksLg9o7UHt3NaZSYBb2ubtbvWDP44un1Pgr7V0Fn o6cpRLkgIt2cjh8izO7lrCx06c3u/KU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=ppt5WskA; spf=pass (imf10.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736215608; a=rsa-sha256; cv=none; b=G6BZAdZc70quMdXh2Gndk03URnwBzM5dvDZI+PcALgN5fipXI9hCiNEVF6nVhrz0J9p/6h 16pyEzxYJgDajkE9+axCs17SgEdKPkfUWiy/7UuK1KIcoW/JcIYyQXHN9EcU6okj9oNi8P ocd1+SJSiauPSSmHrxeGpna0FdrF4RU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IjuG/BOSvMcwQTrLlf/kxq04qceC6aED/k0KKY8cXVA=; b=ppt5WskAFKw+Q6/U7GneokZHAp tUbJs8JSz7pCSJRmTS1xH8C1jExjh18udUWENVKrf3apVj4be4a1zFlfNH8iXG0KIFZ9n7rOSP/Uu NHLQplvghi0c1Tcy4Zx7qhzCSUOCyurKnTxE/HUEekFqBSO1umlzLOG3kdqpx4M1iOig+yuqsymO3 Rzov4HHt8E4QmIOFPc4ptMl9hhT/Hk4cc3dBjpie+hzIxN+T3x3yd1GWHdXA8c3w/yjZlLgHLxHcy YUbGhlIZk9Dtg80lQY11rG7k6dAHegzQdKTmWW1AM5DbomPVv+LXgelcYYzT7HN+EkqX7DBQSW72O c7GIu0Rw==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tUymZ-006WZf-0q; Tue, 07 Jan 2025 10:06:45 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 07 Jan 2025 10:06:44 +0800 Date: Tue, 7 Jan 2025 10:06:44 +0800 From: Herbert Xu To: Yosry Ahmed Cc: "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: <20241221063119.29140-1-kanchana.p.sridhar@intel.com> <20241221063119.29140-3-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 53C93C001B X-Rspam-User: X-Stat-Signature: pa96enf97to6joz6u8obe7r3yb3i4ywh X-HE-Tag: 1736215607-982239 X-HE-Meta: U2FsdGVkX1+syPcFc9aokMvVWWGq4zJTsk0LW3NxYsqBqhGMP8MaIMBQnMM+xA3q/tQ1ZlTK2BTcOy80K1DrPGpn9BH7SPn5Or1BNBI6cmc/YYUPPuoGS4xJtH0OoTTlSuKYS75Nz6y+Zb4gy0ZhoVmZTzD1KY/CcZdwXpZgSlKey2BfZwqf5YYCHtwhX8dDqLxyktpFlWiVWeB7lAeQDusAjE8CILuMS980pzZoyTeddizORFkEW7mwRZaL9tN/sPlCoSvMmGOSWzl2bIQVtUeFVds1EXqZoQr6/7dK8DceX+A4PGr9/DLsiagzBqtljbg7IrM5lBjqFG4LNgfeMhh+HVo2/PRdYQwEnJomYg8XTQAqPpgnDav1Cw7qaIOBFFBP4DR1nI67KWfCO/nbQ/zf5kIQLFeEQpNLj4/hvKkbKFJ39Vcjbt2S5omwHQ0urVoR4SyQjleBkLbl/z9pcOcvDAoC15yq+i3Y4gfN5uGcbckDSgrc/Xf5Pr00PABlsvqMMjG9TniX/80DqdAcEh4GPy3BqHSK04T3jiOIOSlmyvkvF3rWRaip2qkOyR2azpZFL5sU4Fio5etF72303x091Q1i2A7TWwIXeVwdrRvmu4PnRLYe1OyFK9rVnhvBjZBpocN/RotY7kM0HZnmTE3r6XwYwcqH++2LOpmBuPNvGDdfc2Z50DpCQ2IDaNi3IuSh11tFUUn1l05Df2BVrkuIwJKQdaUw/nNl4EcUFFJA4g7mrYQXuhEi+vm+gC9AwbwO+bSWnCFQs6ZAw+44cEuCNJ2zAfje+4dySfhnfKZmtR5C/mlidFLrqaZMEm6Bg87XyResAf+unNql8lA906WObdV4B1hLGDw22rqeWtWjWKdKKl5EAzzXf+GLzusY76jFciCtnsQf4DbwmKKYPfUvAHTY/EjTpDiABcRi5g3RajKesmbhW8PXWT+bgtv/3uZQzmv8q2qMmUURm5N RrknuT9K rASzpc6Ehmi1ZoWMVQ15ihdWcGZKLdsHq7t9EI1Y4Nsv0VUzBiBQ6hpzpckNp+tbSlvsJbMeh4wxhbwm0LLjnhBJFBx+GRSKWa12qDANk0Q1+snbLaEIiWkdwOjg0GoSACz9Pcln5yhfYgXY432QPnz3+ZdRrphlD++YRPXwMzkBmaqkE1pniyPNXfN+T27IaGLGRnj4k4uLK6nGWVZ3KJNi/1kjAmlKCdllKEXFsWEvAgBQ+MJF7oFFSFkV7McDPIzUtO4Pap6pa/6VPlfs2NHWobsNEXkl71x6iQigf9W8+8z3RXhQhHU3HJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 05:46:01PM -0800, Yosry Ahmed wrote: > > For software compressors, the batch size should be 1. In that > scenario, from a zswap perspective (without going into the acomp > implementation details please), is there a functional difference? If > not, we can just use the request chaining API regardless of batching > if that is what Herbert means. If you can supply a batch size of 8 for iaa, there is no reason why you can't do it for software algorithms. It's the same reason that we have GSO in the TCP stack, regardless of whether the hardware can handle TSO. The amortisation of the segmentation cost means that it will be a win over-all. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt