From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A41BCE77188 for ; Mon, 6 Jan 2025 14:51:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DF186B0098; Mon, 6 Jan 2025 09:51:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38F236B009A; Mon, 6 Jan 2025 09:51:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27DDB6B009B; Mon, 6 Jan 2025 09:51:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 07B1C6B0098 for ; Mon, 6 Jan 2025 09:51:57 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A9E6D161639 for ; Mon, 6 Jan 2025 14:51:56 +0000 (UTC) X-FDA: 82977316632.01.966E669 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id F02CC14000A for ; Mon, 6 Jan 2025 14:51:54 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736175115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkGxFueoVINi5fyFIRpdOxzuvoQHxYoJE4cR1nHWUKA=; b=oAWzqknk2+q/B0DGSO7z6M4Dh8Lfk926eZiM012QPB7QuPcN7j3+IKdzVYelxlG0gpXYhI NWAUHWTdqjCoH2SoskWP93gr5vbYdsHRqihgDYOCj61lJKRO69UXfgjWKb1uqWYL69UAxO P6iOzjDJLLDOvVfyv65TXgaX+UGoFMA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736175115; a=rsa-sha256; cv=none; b=MQJDBgH4w9OwlFWL1supTkNSyuVG0ha8aWzleihvPDfQNmSRlS+RLnYhHXGjteQ1/6hxOv /+NosOSa5nmb0eEOL0V/lAgZjAI8BRjw0FW/hdWCjkErF++etK5zrSDNvyJtIwfvHjSOtk m62H4PwMXqdgOoawBTZ9mn4PKSVsnps= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58B98143D; Mon, 6 Jan 2025 06:52:22 -0800 (PST) Received: from e133380.arm.com (e133380.arm.com [10.1.197.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 24D7D3F59E; Mon, 6 Jan 2025 06:51:52 -0800 (PST) Date: Mon, 6 Jan 2025 14:51:49 +0000 From: Dave Martin To: Akihiko Odaki Cc: Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , Baoquan He , Vivek Goyal , Dave Young , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, devel@daynix.com Subject: Re: [PATCH v2 5/5] crash: Remove KEXEC_CORE_NOTE_NAME Message-ID: References: <20250104-elf-v2-0-77dc2e06db4e@daynix.com> <20250104-elf-v2-5-77dc2e06db4e@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250104-elf-v2-5-77dc2e06db4e@daynix.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F02CC14000A X-Stat-Signature: wmu3zipc4zgo6jhorergccb11w3qgjez X-Rspam-User: X-HE-Tag: 1736175114-745662 X-HE-Meta: U2FsdGVkX1+dDiKvKaKdBUHhv0H6JcRndh9ZonCsyz1YcAIKoqrs1CxzYbJL2OQ2C3wsDkQy7576/jcMNXkbBXV0gOQgylZP+z37Jsu4E7tQ/DchIswXAT054yP0UCtvA/C808DiMxooE10jsZxAJbf1k85k5f+K2ZTaqAy8xfrgpu7P6P3JenrdIo8ooYYgSVmMLHeBUSJ8BY48clBwhc4PgbEh8G+4S2CZvpTP6MzJKNZ12dse4VCqsvzx/rC/4VXO8J6Cl06vRkKIU77WjoHWwbkQGMYBXf72if3I9LZuksJmDAv1DvF1ZSdW7/NjKHm3GocPnVZ+Q/a3eOIIcEd1sRRzLsjAgJJpLgTFBcxZuBNE9764ZY+0iKRqQ+m71Trw8IjgJbvidvjVlfCFSfBe9RoX9mVcLNKsq//9HvrNJnM5V3wcx8U7R883tMA57yEtrYqOIQ83CnWI9NPmJElxvHiEdqG92XTMNw6G2TxTAviQOGWk0v4zljEKURmCNU0c+bZT3my4i04XwlCX4RFPMBslhQC8+PmjbXrnXpb2qae3iIf8lpdD1OPDxl+NtFmL9jO2MC0PBS7OsN3LKo8S43isNe2mVZAxShDWZ8if0SHpiz0ZSJbUieB8mWFn/Vu+RtUtdyWEWA6CNDklTLc7nfzDIwwXHwliUoq/IvY3cXdchn8gsV1qN3kQwhZOYpc3c+ulBYtfWoHeINfrkRjDJ+FUjbaYUcNuhIyzeo+bS0B51W17kl0IWOj6V998SObeFl+Nvavt6nwKkYtXJFOqjFaSGnJw0X/bHQsxyYmPlSLU3RFqWuyQ8/lkRlnEBShlWmtNZRlDKBRZTH+ooPrGnI8AF0dYJR8YjUszVdBD0zyXQexrDSMaBwdRvvcFjlNXeb0G/O+UhCKvkWgSHe8JhFjMSZdiGiGiR4PQ7A61cS9ZprNIwazMqCFGUqBRA9A73NhC7lr2RoFhKOp DIFPQ76l HrdOyQXwo+vnnGBPvFgWjVTJkL1E/IZq0ran8zGzeJ7M++nuM6Uu8wuaUleicF/Hzn6eCNPxmI8kdiwYIHicxm8GZpHqBJNDDpzYH0Ni3DZs9SZSSFIdqkjVuBpVK8iNkGjsiwU5yacfrJq4FvVFIsgBh+cDRWqjc1I9bLlc76a9PnQ9Al2fz6dyAd68WCK72TpmILwff0f/Zzy7+o2JocbC7aOPbPJmJ8Edgh6cdj/HHc4JBRjccpQehpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Sat, Jan 04, 2025 at 11:38:38PM +0900, Akihiko Odaki wrote: > Now KEXEC_CORE_NOTE_NAME is only used at one place and it does not seem > to provide any value anymore. Replace the remaining usage with the > literal and remove the macro. > > Signed-off-by: Akihiko Odaki > --- > arch/s390/kernel/crash_dump.c | 2 +- > include/linux/kexec.h | 2 -- > include/linux/vmcore_info.h | 1 - > 3 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c > index cd0c93a8fb8b..4a9817489e35 100644 > --- a/arch/s390/kernel/crash_dump.c > +++ b/arch/s390/kernel/crash_dump.c > @@ -253,7 +253,7 @@ static const char *nt_name(Elf64_Word type) > const char *name = "LINUX"; > > if (type == NT_PRPSINFO || type == NT_PRSTATUS || type == NT_PRFPREG) > - name = KEXEC_CORE_NOTE_NAME; > + name = "CORE"; If I've understood the code here correctly, the note type is supplied at all the nt_init() and nt_size() call sites, so instead of this hack can we wrap those in macros that get the formal name from elf.h rather than guessing it here? e.g.: #define nt_size(..., note, ...) \ __nt_size(..., NT ## _ ## note, NN ## _ ## note, ...) etc. The compiler is quite likely to fold away most of the implied duplication of code (it would be interesting to look at the compiler output) -- but anyway, this is super-slow-path: nobody expects realtime response when the kernel has crashed. [...] Cheers ---Dave