From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90971E77199 for ; Mon, 6 Jan 2025 14:35:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA2476B008A; Mon, 6 Jan 2025 09:35:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2B656B0092; Mon, 6 Jan 2025 09:35:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C80396B0093; Mon, 6 Jan 2025 09:35:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A51E86B008A for ; Mon, 6 Jan 2025 09:35:38 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 57824A12E4 for ; Mon, 6 Jan 2025 14:35:38 +0000 (UTC) X-FDA: 82977275556.20.659244E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf22.hostedemail.com (Postfix) with ESMTP id 02B04C000C for ; Mon, 6 Jan 2025 14:35:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RgUCNi9X; spf=pass (imf22.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736174136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yoK5E8r9ZiVbP/iseDdGu93jcAAz/4Uy/8D3TkhMEPQ=; b=F1FD2cBwdqkpm5xscSK99Bwo0+n1aWshTrRlxTdItGQm5tuhl2lAYMmTWNgx3h3K8ANjFW jaPM/RLK+0BAQ44N7+ZpL6+vAEni5bWH8DeoZ0GCH67vLwEV8FXaSxUZ9fF+A85QSrzxig nlyoQeMqhRIIhD6w0pEgYHFg4xFjT9g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736174136; a=rsa-sha256; cv=none; b=3LvYxMQ+dn+74BUooBuKS4fmOmxBClsIl4/uN/b4PhbL3WDOmGlfJ3id+8/AviNgJ6bpLJ bsy78FLhekvx4IVnjU7C3f13mkc+I9gOXEkfLHc1hq7l/7GkGsGAVPIxHaCxgRqijHH4OC dT7xawGjISPXe5a93g9XSMlj9HrE8Ik= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RgUCNi9X; spf=pass (imf22.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 506DKdR6028353; Mon, 6 Jan 2025 14:35:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=yoK5E8r9ZiVbP/iseDdGu93jcAAz/4 Uy/8D3TkhMEPQ=; b=RgUCNi9X25JhEHAe1CAG1qqWDykE2cD2UYRU3jmdIYZ8Ch T5zNuZL1wNyGI3Vx6v5lGgT6nrQjUFmPBzbnAHtewI+GPO2JVytXZHj2wHKmhggO GdcJ4vAjUlaHrEKk26fgqLKossjwTqPk3DWuWYX2Dr+Z7onrnepYYdpVWHvCydHs bu32Wpeqd9ftCqq6EZBoM7oOtX/GhoZh7MR5d6abz5ggaLaPXwccpK1Z1mGCENN4 yKVEOjmgL8y/m6mo88lKz8bR0FDZGFR18HK66OfhU0FrVIV1cSA7wvm4ufpM7WPO 4ER6RJeXDR1BpR42AHtSLYfW3/ShkDYByj64zWig== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44047hb2wm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 14:35:17 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 506EZGRn003388; Mon, 6 Jan 2025 14:35:16 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44047hb2wj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 14:35:16 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 506CA9Jj026189; Mon, 6 Jan 2025 14:35:15 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yj11wr3q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 14:35:15 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 506EZDIG28705314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jan 2025 14:35:13 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 96B4320043; Mon, 6 Jan 2025 14:35:13 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 345D620040; Mon, 6 Jan 2025 14:35:11 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.26.127]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 6 Jan 2025 14:35:11 +0000 (GMT) Date: Mon, 6 Jan 2025 15:35:09 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Message-ID: References: <2d16f0fe-9c7f-4229-b7b5-ffa3ab1b1143@bytedance.com> <57ea8193-2fd9-41a9-85b4-7af924f900f4@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57ea8193-2fd9-41a9-85b4-7af924f900f4@bytedance.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: sJuxnsXxxJgGCCGTIUc0sEdh5BRYGtAz X-Proofpoint-ORIG-GUID: UPicS2fzhLCrpHuuN_a8oN-YM2X9yFa6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0 mlxlogscore=791 bulkscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501060128 X-Rspamd-Queue-Id: 02B04C000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 3hkk8itcd1xqxi39x9aozcmn17coiq4o X-HE-Tag: 1736174135-95718 X-HE-Meta: U2FsdGVkX19KqF8GnXx38MFpJU2ABRsQ8cvyUxCtNO2lYqwyldmFo+tZnEuAtOluMxQkIgd/9GMa5s3tztRgl/ud9Mxpo3hWSoarpd3Q6TbKpOxE/51hOR7EKLMh/LdsddPUA2/z9Q3NlInCj73Fcrg+f328BAMFyjsIYYyHAURapf8SKsWJJDcn6DXbHvovWF+5Rc5hubl7syi5jASzbJ93MnlKgfaUePghYTN/aqJFZn2rYzQy0baOOaOa/JLRmLzXV/AdUYEDpbYuFotu4uze6MM1JOdMY0wNAqHp/lg078BIAIgusGaDqGi5hBtrYkgvkyW57Sqpc9qYoTXt2EWPn0a77gPdhd9uANRKpKtOzPj5uwESGZAcaf0736njjF5RyGDO0H6y4nEu7vvv3MxccoVnIHcv+KD6yijuIkkpP6bXxNtzefqKJZZ5R5BSpg6yP5WeojCM10OcyUGiELYM/9sodVGC53AVifS28RkCZgBNyksT0M0Bgr0sRnkpcspObPIwGLs5fCNgf69/+/TLyFgmeUB98Q3GfvdWe0r6v8PF6ohGYLykNO6C4DDZwPPDftHu9J9ty0A6qHSmEB3juLYdTeBT67cA8imEUMZakdHQTAtx4GKpoyYtVDfERYizxyM3Wi3cRaOFy4la2+nQbSr3wwPejpyBJtXT/gyjqdIlreuzklj1SIz1rmcCxKe8uMcPLnVHAg0mtBD0N983+evqHKuLKuLRhGuaT0nrdATWc4xElcIuwz1GqLPhlwbUt5eVTiqLp3qJsGANEW59fcpAKEuS3+kNdIE5VuM0RQWLWJ+BE0/EkpkO9aqHPJDlC1zr28P1TijjgFr2Jd/OzRgmSEC0PyahTW9csAeqkU6jUJNwHQe02xSZs42JuK5cVDPQC96LrpovbLHRNI1StGSuDzOxrR28A8rEu/NdhRizw+nUylk5K4Xt+YWd5uYjMmNGIgYb9C2XE/W YniFGVQs He3tOj146jysJvUfUypudB0xZOn1VgawcMAoBilz4ol1TV9YMpzQHhmgLs/oPd4zkMY6E53IvyFoW8ONHg6x8PJl6cfE9GJilDnPT4dGQJC1QIZP1lfbGMPU1cbXABNMohEKPx6f9p7bd+esm2EKNrPVg/ElZ3UwWpeyoDwTKBCQiiao3Bttl1WwfqZBChlCyDv2zvMqnihJvNSeNC9Hha4GykdhH81FKH5+3sC9Yh4BcmPoe0qzGhBLWRs+ptPDlLgq2yPCEXbRAwbf5qWAMpilxXGhI03hHBG1kVdpMYVGlAWMvFX8Aj1fFRrcXgsnQ9497kfgRGFzjxfYBtcFQTzbAS3DXU8E3eFdvKeCk25yfo4O8ySrzgResWF6ppaggXiCdf88f1VVuHe2mCzkVcgIFFp/1suwCAZ1DA9wtQJHU4xvguXsWp/5JrHyH9n+uwh8J+vEYDCaZd5U5rUDoCc1AQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 09:34:55PM +0800, Qi Zheng wrote: > OK, will change the subject and description to: > > s390: pgtable: also move pagetable_dtor() of PxD to pagetable_dtor_free() > > To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of > PMD|PUD|P4D to pagetable_dtor_free(). > > But pagetable_dtor_free() is newly introduced in this patch, should it > be changed to 'move ... to pagetable_pte_dtor_free()'? But this seems > strange. :( s390: pgtable: consolidate PxD and PTE TLB free paths Call pagetable_dtor() for PMD|PUD|P4D tables just before ptdesc is freed - same as it is done for PTE tables. That allows consolidating TLB free paths for all table types. Makes sense? > Thanks! Thank you!