From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D8CE77188 for ; Mon, 6 Jan 2025 12:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E19E6B0089; Mon, 6 Jan 2025 07:37:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06A376B0092; Mon, 6 Jan 2025 07:37:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E263F6B0093; Mon, 6 Jan 2025 07:37:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C4FC26B0089 for ; Mon, 6 Jan 2025 07:37:25 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 73A3316152C for ; Mon, 6 Jan 2025 12:37:25 +0000 (UTC) X-FDA: 82976977650.02.0111F3E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf16.hostedemail.com (Postfix) with ESMTP id D64F7180007 for ; Mon, 6 Jan 2025 12:37:22 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=gylwNq3j; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736167043; a=rsa-sha256; cv=none; b=Njln7/Df2jsXBZPBMIFFI6Fi7NGA+lZgjcPOF8kxz9jKNs+BoheikucOKi/x2x5RuRmQI1 HYbCzf1QHd5+G16EXkfuksMW9Ufw1nnlM1z2HupsEGrCqqR50sKk9zYYriJc72sz9V5BMI BXDegcuykrnLFX06hplqfd3iJ3aCoJc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=gylwNq3j; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736167043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SHRVspXO3U3J22EWQcFrDH7XAHWgniRmJ5qosSJnn6g=; b=E1i/HtZmGXCHspPHbAhy780NBLbZ0sVpanB4AShYkHraidHq7OQ2/UANYBYgvyt14O61jh IHa2ciL3z6ngiQWKM8rew7OkNMfD03Kf4kRKF3jpNUu5oV+SNPtZ9VK8UYxl3WczzRPIZ9 Ib/GXZ4zQb2JurWSsE527X4y+xnsiCo= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5063qlTX013067; Mon, 6 Jan 2025 12:37:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=SHRVspXO3U3J22EWQcFrDH7XAHWgni RmJ5qosSJnn6g=; b=gylwNq3j8Ick4RHspj1WpowzwXtJldVyTnrF8QuvAYKM9D cb8krtFCzCsoyxvh89UJl26z7qHWUqnN/ImInk6EwuS0vqp4PP2dgss2yasVDKW2 Lff3/BNOwZhA8CZ78PF3yjvRLK1XQw15T7aqhCvEf/yXs04EvpitmkPslxE8hb51 wgf5maxpIuSGfKzDGpse0DX4tM9gBITxyTYA+7bWfogitjj8uwIINly3796qqLPh b77+nf7AsA9eS2XD7o5ZzopzbMCJakQIq7daMPDRVe0joP4ae60Avs8p9yEVq73l VN9BQgghYULTXZUzQE9YkTytypyDPG5p2Q7BERgw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4407nh1wst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 12:37:03 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 506Cb2iQ020201; Mon, 6 Jan 2025 12:37:02 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4407nh1wsr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 12:37:02 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5069MVZp003593; Mon, 6 Jan 2025 12:37:01 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yfaswvgm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 12:37:01 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 506Caxhn26870206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jan 2025 12:36:59 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 98FB32004B; Mon, 6 Jan 2025 12:36:59 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 402EF20040; Mon, 6 Jan 2025 12:36:57 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.15.34]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 6 Jan 2025 12:36:57 +0000 (GMT) Date: Mon, 6 Jan 2025 13:36:55 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v4 07/15] mm: pgtable: introduce pagetable_dtor() Message-ID: References: <8ada95453180c71b7fca92b9a9f11fa0f92d45a6.1735549103.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mN1kYnlUlqSgV99r0ZXPtutQd1lOYK0_ X-Proofpoint-GUID: 4h_GDpYFs18Yd8GMGP0i2nDMJVSwVuwn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 adultscore=0 suspectscore=0 malwarescore=0 mlxlogscore=643 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501060110 X-Stat-Signature: wqhrzbb9gcjwsfytsg8posoksoon3pme X-Rspam-User: X-Rspamd-Queue-Id: D64F7180007 X-Rspamd-Server: rspam08 X-HE-Tag: 1736167042-685645 X-HE-Meta: U2FsdGVkX19wHto9WmwRpUZ2Btz3HMwlJbrdzORCKixdkzpqnI161h8b7WHGvQNVfFae2HdTvHNjg3+lCSa2UZIMeiABAdjkmqKoU7GSLjlgT1cWI8RQddA8ZThoG7flTe6b7lvJpHGxLpBlKc1HB3n7HjdglytX0L8RMzkS1Hc3w5O59fo4WrAs68N+qWpLEr0Dms8RhjRNcQ7aO8HLYCHGWhsmNwn3MTH6ZwoDOBykvDgZtmAJ1fsCKj/KE+WaHm1084QLJkxdi4y3ktPqy19g/vP8mgarQEWQyLFZQYz6O7gq52uWV494TcWeb3ghYyANCuBzscAvVEwsahM8u61FQ7f03w9h/SBIsG6o44PhVMuBuOzyf4bt4FWMMdRDz96wpCZS1nFTlavaTZItX+3yFOXgDwXUGOSsfLx49yHspIvgx358P/r3xCqnhDCOzTf6mKw5qW7vyGDJrW4GNxOmQ5PE7bPWXwJ3GzW6axdMay77ZGRRcMzpj2cndxSJqleBgpnShA8HGF1aDGuDSTjs+NM8FBSe1mX3B31G87O9eUQ7WGB1QbcrKl6lQVTuJj9U4PUdu4QFY+0vWqjIPabWgnjpWOwZ8+9bNa9PrIxl1rdjB83H8veyPOAhQWOkgv6D8BlCLn+WwFQVmSz6QD3Wfg+CcekFTk3HTBpFexJfxpHyF6RCooRtAHt4oWTpJJTp99EHIJ03sdXmpvIPzBzMSuiya1YA0HhE1xg5xzTYQYy2pDAttFZVRnWx2//futUDJhW+a+WIJP7tw/vvJ08hHflae4d8rsLPZrVNT3orqs13IVUSRAAjDWFPQJQmpPL7YD2BVT/kIQaOCWwsyOhGjaV+zTppybsvIvPp6XJtXpcU1xEKdrb52Tnp676k15bCQyV4Q4cLFNoMTNLqYmbTQP+4J9hBmBRdsD/qnE3J59Pwx0Y8bHKNXlYmSRUfE5ADjeWgJAMvHusu704 yc4efNEo 6+uIiDqGUArRuLR+BfqHwIlrw1clhi6jHkAHFTwS7IJL01HWotVKRiaxRHv0CMgMxBTRHpJnF6JXoRmqlu7zw3E4R0P0ul3kqzizXTDgOOSNTUREKK+L4powLcglmv+w6uYYwgs/grOBzhdbA1qH5Y7fGaJGNjIqL4+RCqh/nQhX7T/mBT79Pxtum20FkrzT2JdMvouLMuOUtYdvuKhPbRhcPIRjxbyE0LbvLNc8DZ8S6jwor3ughMW0LkXXFBFMaHr4vlR2S9QpOz6FDo8Q+mh294MYiqCc20UpQELFVmf86lPi0rQ2+96XnEch7rCBxjLZCNV0FCF1LJZ6IoYbleJfLjRiE1PMfyfRRPk9mWrzdooV9ZCEnLbfIzO6sF+P6g9ZZXas9VwamoVIFKxixkkiMmE2XG+5T6stALiJhC1/4kXRvc1smGi37/glQjcx5shnT/rJAtJke1X9wqFK/Ng5qCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 06:55:58PM +0800, Qi Zheng wrote: > > > +static inline void pagetable_dtor(struct ptdesc *ptdesc) > > > +{ > > > + struct folio *folio = ptdesc_folio(ptdesc); > > > + > > > + ptlock_free(ptdesc); > > > + __folio_clear_pgtable(folio); > > > + lruvec_stat_sub_folio(folio, NR_PAGETABLE); > > > +} > > > + > > > > If I am not mistaken, it is just pagetable_pte_dtor() rename. > > What is the point in moving the code around? > > No, this is to unify pagetable_p*_dtor() into pagetable_dtor(), so > that we can move pagetable_dtor() to __tlb_remove_table(), and then > ptlock and PTE page can be freed together through RCU, which is > also the main purpose of this patch series. I am only talking about this patch. pagetable_dtor() code above is the same pagetable_pte_dtor() below - it is only the function name that changed. So why to move the function body? Anyway, that is just a nit. > Thanks! > > > -static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) > > > -{ > > > - struct folio *folio = ptdesc_folio(ptdesc); > > > - > > > - ptlock_free(ptdesc); > > > - __folio_clear_pgtable(folio); > > > - lruvec_stat_sub_folio(folio, NR_PAGETABLE); > > > -} Thank you!