From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA5CE77198 for ; Mon, 6 Jan 2025 10:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BD626B008C; Mon, 6 Jan 2025 05:36:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 593EF6B0092; Mon, 6 Jan 2025 05:36:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45AEF6B0093; Mon, 6 Jan 2025 05:36:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 285E76B008C for ; Mon, 6 Jan 2025 05:36:50 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CD0A84467C for ; Mon, 6 Jan 2025 10:36:49 +0000 (UTC) X-FDA: 82976673738.01.CDA1142 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf06.hostedemail.com (Postfix) with ESMTP id 8FB39180013 for ; Mon, 6 Jan 2025 10:36:47 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qBCXpVvd; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf06.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736159807; a=rsa-sha256; cv=none; b=8eiQ9IK3sJGnx4dV4QNJEOMuJ1n0mFR+IoEtNI17rokutxJ/oZdYOqHNsCgIjf/LebFCKf gQp20ppXgVOC1Fw5omUMGibD5tuMgkDueCfgPCaq4YaboqjlfcX5PbsKrAw1wo/1fWumNb XY0LDaEYA6U9db4+x7IOvfQZ2MAigyM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qBCXpVvd; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf06.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736159807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RryxP58J6OnCln8Pqlo5t61Qkdx5FcBQVf8+7yUkQC4=; b=2yBulo1BeOYX8Y3HrSui/Pzf476uTOPVVcLPdXIO49mpt4qVnIDpcFLHTZsYbkkREVofmm jnq/RYGToGyxs6dAZTjehP4DWX95xIOC2/2QP+oE344O/vkkN5W3PyD95V7tgNK+/VI2j5 HdyjYRTCXqsO2xCdidf6gISG+3Kexj4= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5068Lt7i026633; Mon, 6 Jan 2025 10:36:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=RryxP58J6OnCln8Pqlo5t61Qkdx5Fc BQVf8+7yUkQC4=; b=qBCXpVvdPbt+ywixcDwnQL6Z9ZlbqjoTKd2P0szWJ5PG7K HrQ1dU1lfCN1w8QdSGyr0DPgqO66Ie3q/rewjUdpPXV9XDc280aXNb7xaTJA7VBs Apmo4/OJijEJhq+G0tWODsOXDI0M6JF8OhuoQwzpyTtJ6p890/4l5MBsiXCoaPdA jWrav9CzXcn/gEDNtXvu3d6gHy7ENTCfUp3F/4dtHAicfe3a1lPqMC72/3iWTlQM 92BjmrYfEN7dxjeYXZgtqtc4DB5H338vNnKVg4GId9wHaKoWlSUxSjz7nK2elinr 7l9jgdC7oG1Qk16vMHzYBWtDa+b9EVRm1Gss1x4Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43yuj5360w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 10:36:31 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 506AVZkY030738; Mon, 6 Jan 2025 10:36:30 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43yuj5360r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 10:36:30 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5066jHrP027971; Mon, 6 Jan 2025 10:36:29 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yhhjw3xg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 10:36:29 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 506AaRat55837070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jan 2025 10:36:28 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB29A20049; Mon, 6 Jan 2025 10:36:27 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6187320040; Mon, 6 Jan 2025 10:36:25 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.15.34]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 6 Jan 2025 10:36:25 +0000 (GMT) Date: Mon, 6 Jan 2025 11:36:23 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: RDtAwTXGBq-o50c3MhVc3_C2qJNd4B3w X-Proofpoint-ORIG-GUID: BH90a8PnsJG6ZogqWB6Telp_r4uMcgo3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxlogscore=745 phishscore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501060093 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8FB39180013 X-Stat-Signature: ckmyaajzcid1ynh5jqrez1am74aoztut X-HE-Tag: 1736159807-178861 X-HE-Meta: U2FsdGVkX19K0Cik17jaMjP4QWKSJRl/nzao3P4WXkRZ3ICqHEQ7ByRNLnutrEKwtxhnbjQrOOksIMjtNsSNxzxWBYdOuUq+7qaNfrLftkPvOCxdqKcsWTf1eLkdLe1bjJ4afQfscePEK4WRYYurLnpyGiTkJ8CwXr7FMSsmi2xHOqW8lzi0/Q7m9BBijvZX7XACFXDOQayWYLdjrgIQSTgynA8tRcjufNEiPOZCYctgYfjyP5On0KA+6d/dxLj5CwQ7+HJyONlrdKCaZz9T/Bfo6vborvCb1GfFlYTUDM+HH5ULTvZyK58mPM5HnxbSKCTxj7g+pDTHQzkeHWz7DvpotVc1wldABBVYK1leGI+aaiXrqS9OWi1ApS+BzsF0ZF4otwuxovhbxd9QLcGXkBZWMWHVpv0QI4yhp7fqGl+Vpy93UokGBCgADa6KJuBQtf6JQ37rVamsEyglY8h993pmSF+rJMp3LfzVkd3e+doTJCS9yp91b0A5uV5bA3ZYrTMVEH+4jieKt8DVBaCkuq0jLtIgtHvHF57yaLN0LEXzuQamE2xycD/Un5GKollHMyd7RkY51JdgbPxxi7aXFI5O69KF2lbyr5m3u0R+FQFCLTEe17J1N7Qsa5+MUWZHkRxIxzbZbQb92TlYz08LNRtmX92A4jGzg9kiG4KXRtvplxnNbAJdDCFoNX9LDgNstMwWXBCSBM/7eWUZ3pxRqNj3UJQmCyZCCwntJ/BGweKoIQG85hfJDx5pF0rN/ZO4gxqzf8QPcD3/fl4Dc032sS46WUBBEZZvocS6ULNBLuiOIg6cNZoTxyqmkVOYuF05BVpaNuaHLVSo/6q/IL/VI7Efetu7u9ZA7G+DdIsxhf9MfE9rkcw4jFX/h97mrWTxk24/lYzTveN6rVkQT5MxhVRCoDtMMKUuHwvmuExM2CKqI5/X+1hCc4qPiWp+8adGUaSXP0rBJcAbANGOY0A MpdSMfTD RcBfRjpFf4s2sCKCcHtyBt/WznFnpIxy2jlxxgReq3kQNOkom9HPxf6Cz1SlcmYHZbPZ4s0aTo/1QDKCEHrWYQA3pc0mV9UcaShfxCBa7dSrcYGfGnz25gTe7pYcH//2loJ5zlFaxX4uwjWK4M1qi2S1yYU3D5bFJbaE+rP7StcTv/BM8pfxK+UMY8t/bUdvwlySESTZKCnz1HAZicgT+CjdRB0gDaNytnBkae4993zirjT2ScMe27fsHi2NCe13ZS/aEdjqJlOuo3mlmtjxNwHy/vx7nfhUT0nIXtOf9hdMBc+facco7Ng+SvWnXfVhQmeEzNEdjYsm7Phpt9TPXVd1fIW1z20Ji7/l7OM5jxr1oUZTcvq/k9cBgUj/bw3rFRP6ZZTinhGLXttP8DcPRcIRXeK1xrpjAlrqXqGxA7HmU2XDV/hk3dgW7G42aXyMSmPFl+fjcUzloLVDnl1y8y6AdOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 05:07:47PM +0800, Qi Zheng wrote: > To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of > PMD|PUD|P4D to __tlb_remove_table(). The above and Subject are still incorrect: pagetable_dtor() is called from pagetable_dtor_free(), not from __tlb_remove_table(). ... > diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c > index 569de24d33761..c73b89811a264 100644 > --- a/arch/s390/mm/pgalloc.c > +++ b/arch/s390/mm/pgalloc.c > @@ -180,7 +180,7 @@ unsigned long *page_table_alloc(struct mm_struct *mm) > return table; > } > > -static void pagetable_pte_dtor_free(struct ptdesc *ptdesc) > +static void pagetable_dtor_free(struct ptdesc *ptdesc) > { > pagetable_dtor(ptdesc); > pagetable_free(ptdesc); > @@ -190,20 +190,14 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) > { > struct ptdesc *ptdesc = virt_to_ptdesc(table); > > - pagetable_pte_dtor_free(ptdesc); > + pagetable_dtor_free(ptdesc); > } > > void __tlb_remove_table(void *table) > { > struct ptdesc *ptdesc = virt_to_ptdesc(table); > - struct page *page = ptdesc_page(ptdesc); > > - if (compound_order(page) == CRST_ALLOC_ORDER) { > - /* pmd, pud, or p4d */ > - pagetable_free(ptdesc); > - return; > - } > - pagetable_pte_dtor_free(ptdesc); > + pagetable_dtor_free(ptdesc); > }