From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C54E77188 for ; Mon, 6 Jan 2025 10:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73EC96B0082; Mon, 6 Jan 2025 05:33:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EEB56B0088; Mon, 6 Jan 2025 05:33:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58EEC6B0089; Mon, 6 Jan 2025 05:33:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3A5746B0082 for ; Mon, 6 Jan 2025 05:33:27 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DB82B44850 for ; Mon, 6 Jan 2025 10:33:26 +0000 (UTC) X-FDA: 82976665212.04.0083AFA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf23.hostedemail.com (Postfix) with ESMTP id AAFD5140010 for ; Mon, 6 Jan 2025 10:33:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UNSjWw3i; spf=pass (imf23.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736159604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T/dIATF0B0cb2CjV4kpJjZfFPga/hCk4zk30iJIHW7w=; b=Jant3ziNrkh/ZF5xxIIAXQ7AzVY4Ap0NjyCGhM+kZXGOpHKuGFz1rl9nKum/VBx3zQhBFO icFQv9C74GhImRzUmxNy7ZC57tyeUON7YZaNqXmqe44gqCkbFKvX/H4xM7hTjbRpcTVTm8 ksCZNqFte84e+P5myP+ppax/5SG20dM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UNSjWw3i; spf=pass (imf23.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736159604; a=rsa-sha256; cv=none; b=dh1QTPWSTjM25zLl7mh/0z2fBo9u5Rit6ZuwlIa0R+rM+hrOGJDOh05FEnAwcjJLg0DVSI hwaT/EfXRFkYFuj3uWbFQyRayRlYKPFG1JNAncs3Rh2YauO79QHfNERoyc9dwEVc0xASTP L4rUk5Gg6R7HFIqg6f0SuhgxiXJDu5A= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 505NaE33006668; Mon, 6 Jan 2025 10:33:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=T/dIATF0B0cb2CjV4kpJjZfFPga/hC k4zk30iJIHW7w=; b=UNSjWw3irJn0V+Dm8j5t3FNW5/wXx/WChR9S+1E2fwnee6 3YnxLlHQxOWH5zrs+0j3Lht+s4UrTI6g7Yg1KPB8FMCugDt75nNJJWZKMmbDbPht aD4e1ztejD6AY9RigrcvvmP08x+kE9ZPTuYPeo60tFTmnQ8k4Cpe4cZrulHW0baX bOFNUKH9z8P8+JW+mRFxmH7ld8nXAdzH+SB/wWVmxjkHXf+l7Q0PcRAwggyYoIXJ RPu2iCOjOnvWnlY1gzTc7zEiBMqw+MBx8ifutL9cQhg4trkc8IU7fa53qIVbDErN zLxsI17bxYOGqDtgLVqTsRSbTQbHdK5UUjCL9AUQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4403waj0t2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 10:33:02 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 506AX1FB005709; Mon, 6 Jan 2025 10:33:01 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4403waj0sx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 10:33:01 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 506A0LB9008869; Mon, 6 Jan 2025 10:33:00 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43yfpyndxu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2025 10:33:00 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 506AWwE135127994 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Jan 2025 10:32:58 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8AC1920049; Mon, 6 Jan 2025 10:32:58 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 535C720040; Mon, 6 Jan 2025 10:32:56 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.15.34]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 6 Jan 2025 10:32:56 +0000 (GMT) Date: Mon, 6 Jan 2025 11:32:54 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v4 06/15] s390: pgtable: add statistics for PUD and P4D level page table Message-ID: References: <35be22a2b1666df729a9fc108c2da5cce266e4be.1735549103.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35be22a2b1666df729a9fc108c2da5cce266e4be.1735549103.git.zhengqi.arch@bytedance.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3z7EZUf66yDmnmtJgcHtcRdfzcBMN59A X-Proofpoint-ORIG-GUID: jOq3BOzX-nfrjMJZAlUBmLDYevP81AVQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=650 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxscore=0 clxscore=1011 adultscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501060093 X-Rspamd-Server: rspam05 X-Stat-Signature: i8xrsnpjenbkw59d1u1afektsoahhext X-Rspamd-Queue-Id: AAFD5140010 X-Rspam-User: X-HE-Tag: 1736159604-639158 X-HE-Meta: U2FsdGVkX1+Fz+0HKJzZQLd+YtD8vjWgAmuZqO1toc+e3xSZ8aIX9BBKZNusDXk8tSdZ6dSkRHQVcJxNEthUlt03ITev4mrhSXt5EmNbtFCNjX6Rmwd9SaivXNOMSI8hY8gYkbdjhtKFq+xzpPbX0MBwMjJe2gNJJH0AwnFRNNaetlx+DM/gXr45DTmibX4bf/vF81hM2fopeOPf3/a50Ql+UC+NP+nhvU+Op6dxjoZjbea36KS+qlKRWOjYYGWS69IjAyAey6cU71HUBm86cEp+kAyTCCBIURGFBVJb3PyEcLuPx9ujlhdM5CSUBULSGiQ6zficH/Nv8WwrgDZhvELvibz+YpC3KIkwIQVaG/WQoeMFEWnnVXvAo10J/f7EMRnFKImKocGrAxDQtnCJqS/moueAp4yJlQxqFh7ykdugH1Oce0aXG7QFH975MPW2pRiG14eCpRtTmDpj1IAnhPdHVoeVtARC44ptAIIP9wZ2pp+VAwKi7if8960Gj84wo3zTAxzJhNvQVtYyDflV9pW/BSQTDrORysVfW1f/l7Zzj1fGb79R/5qfIw2kjT9me1MoO92jpEhhvjCF0hh9yugH67Ht1D/pBKDlyQpUzi/DVgrgKbqPcCB1kBFHidfXqYvcwjuq4Zra3clheBedJwV9aHTU3gNa4t29NnyjL9rLK1NYL2A/PSKDIuS/aRQYt6l/32EQHhybkW5I7sX3StdUxpnlmiatmHfePY4EgirRyh8qaKXD3/0xGFDfIoPKwurSIYRiMGzk7JIlcC4wDMNDd4Yt8SoOqFca8dCsLYUNw6dfBgp6JjpNzysjfyPrbsZDKXAiFxgtlU0hscR+j+FuLqLg9XlbY3dgKX1Flq996bRM0GmFxj7cjqv/+0Dco695X8BqDE4fpzGWi3/Bz01wWK/t1FAlkrk6uPNakOi1GWJYkgrDr1hiWdQYvvoX4zM01Q7L9nEo3woyZFF kqheMDG3 YfD6POo+1Uz5qx6+0NfrlvrIwATSSrdIaNgzBNia8KvGJW9mk9p+I4RG8+KRfrInnuVVVS1d4efEjnSciHRuJz2hFvKbJNXsGMRT7lC+T3I5xjTRIMiBpLRNAlKFZl6EsKrVk3wkFGaub7ady4iYrDAmEn9Y1ZIwuc708OiHHfN6mJDOisXiTA2Ts+GgfCRm9oTcmb3eV9xVhKuwtCKkPTxp3Mt+vlhcUGyZAtgsWI+pBOtf3uoWp2+ve6VKHADpiGzHx3DIeSVg9uAFa3KNbvSJIAV0o6o+PXZgKn2O124xlZ2Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 05:07:41PM +0800, Qi Zheng wrote: > Like PMD and PTE level page table, also add statistics for PUD and P4D > page table. ... > diff --git a/arch/s390/include/asm/tlb.h b/arch/s390/include/asm/tlb.h > index e95b2c8081eb8..b946964afce8e 100644 > --- a/arch/s390/include/asm/tlb.h > +++ b/arch/s390/include/asm/tlb.h > @@ -110,24 +110,6 @@ static inline void pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, > tlb_remove_ptdesc(tlb, pmd); > } > > -/* > - * p4d_free_tlb frees a pud table and clears the CRSTE for the > - * region second table entry from the tlb. > - * If the mm uses a four level page table the single p4d is freed > - * as the pgd. p4d_free_tlb checks the asce_limit against 8PB > - * to avoid the double free of the p4d in this case. > - */ > -static inline void p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > - unsigned long address) > -{ > - if (mm_p4d_folded(tlb->mm)) > - return; > - __tlb_adjust_range(tlb, address, PAGE_SIZE); > - tlb->mm->context.flush_mm = 1; > - tlb->freed_tables = 1; > - tlb_remove_ptdesc(tlb, p4d); > -} > - > /* > * pud_free_tlb frees a pud table and clears the CRSTE for the > * region third table entry from the tlb. > @@ -140,11 +122,30 @@ static inline void pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > { > if (mm_pud_folded(tlb->mm)) > return; > + pagetable_pud_dtor(virt_to_ptdesc(pud)); > tlb->mm->context.flush_mm = 1; > tlb->freed_tables = 1; > tlb->cleared_p4ds = 1; > tlb_remove_ptdesc(tlb, pud); > } > > +/* > + * p4d_free_tlb frees a p4d table and clears the CRSTE for the > + * region second table entry from the tlb. > + * If the mm uses a four level page table the single p4d is freed > + * as the pgd. p4d_free_tlb checks the asce_limit against 8PB > + * to avoid the double free of the p4d in this case. > + */ > +static inline void p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > + unsigned long address) > +{ > + if (mm_p4d_folded(tlb->mm)) > + return; > + pagetable_p4d_dtor(virt_to_ptdesc(p4d)); > + __tlb_adjust_range(tlb, address, PAGE_SIZE); > + tlb->mm->context.flush_mm = 1; > + tlb->freed_tables = 1; > + tlb_remove_ptdesc(tlb, p4d); > +} I understand that you want to sort p.._free_tlb() routines, but please do not move the code around or make a separate follow-up patch. Thanks!