From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26108E77188 for ; Mon, 6 Jan 2025 09:46:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44D566B0082; Mon, 6 Jan 2025 04:46:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D78E6B0088; Mon, 6 Jan 2025 04:46:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29DBB6B0089; Mon, 6 Jan 2025 04:46:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0B0A36B0082 for ; Mon, 6 Jan 2025 04:46:56 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7BC3F12141F for ; Mon, 6 Jan 2025 09:46:55 +0000 (UTC) X-FDA: 82976547990.30.D8EAA42 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id E71B3140005 for ; Mon, 6 Jan 2025 09:46:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf26.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736156814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TBfoqog/8StVFQ/R7lfOlnAuVbNV0+TtJThMoSLuaic=; b=dkwvSuDZGsjz9hUEHRNrA9kHaW3YgByLtYf8JRMUc3Lvl/QZYtp9ZtUKJ9GHAdBcksTOW3 tce+qBwEPu68RsT+vQfUFtGAsekfZc/+r3it4x75m6IPLoAW+5Avh26/YecnrrPr1z5t5H 29itBv/uGzyVWNaeR3SG0RokGiYmXDI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf26.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736156814; a=rsa-sha256; cv=none; b=z6F8ivnPGzqP1ciRP83qmMQvU4scS9zeTYMS1qj2RzZM6ijclz9eRK5RDJSI3DKBgBrcUl YkFBJVhoAhwgTeighxbES0sYHkMmsmXVlCLR3S8rFFsYrgqH+9FuJQFb0pz80y+P3MueTA RE3hfcC2ev3/uLL0/cpPM9/HfF3o358= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 37BF8A4135F; Mon, 6 Jan 2025 09:45:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C51CBC4CED2; Mon, 6 Jan 2025 09:46:51 +0000 (UTC) Date: Mon, 6 Jan 2025 09:46:49 +0000 From: Catalin Marinas To: Guo Weikang Cc: Mike Rapoport , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/memmap: Prevent double scanning of memmap by kmemleak Message-ID: References: <20250106021126.1678334-1-guoweikang.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250106021126.1678334-1-guoweikang.kernel@gmail.com> X-Rspamd-Queue-Id: E71B3140005 X-Stat-Signature: ozbfk9obxyjupoau6mu9e59nnzn8rtod X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736156813-575183 X-HE-Meta: U2FsdGVkX19AaQuiRDYEV9bcUS6qF/LKCjlqQEXJcl0/RN8AkDQYSZ7p/U8s6Shm7jSl1J3XP6gGSAiHBsS7U/V3OzHE3QUtKDXPvdq7KpFCvbaLhXvY1MGpVieS4Ns2ke4yPfkTayIDijpTpWSoTzWP5mHJmM1EOQgSS+/88WJXgkSSt6mAhDPxpBG27sB5s75zA1a1hquKUo8O4dLOBXsKtQ/XtS3rLHqM0dbebXnzo7y2ZLpY1yDgSQ9koUhYYzWo1Jxssa8HvPDSnKtSvSMRDOMGgARK5RihtweMRVJt7sCx707afJ+AP8KJE4A8pKFC11HRMk7Z2X9nNJ10mKTt0sVodbXpd/2ZhY4tuBzGOj4Vv9WewGGYdJVdZf80v3x4qX93hxOIEiUmlLYCCppmy6HBokyjVz85QrcZb84x0ufyoof+VPoG6UxP6DDeekQL8rXVkyRH9VNr8Xrt132hc7Mqe+rvXyKzaH+9veTV/H+JVowvocJOVIa0hpKh0LYAAN/sD3DF8jeUkkArxGIAMX6ZRD/iDnC6wANKAVivFFt14QMhsVO8fJQ9/ZDun7duMnw+tGbjS0iLhRRe5rMCk/8RBGcdjRBqhwEvYqkVWvy4oey5MkJZHGgG11gIiFMTj6x3nfBiAGk94eZPhXTWIpkJzDWaJ2eYVmKfJeruDnJ+qCpysoyIkCKE/NBR22Jk345Oyshsma3UteVQkCvmplabAeu8fkYmC3FrEOAsRIiFCHVtrjTJ8cW2ZlVdrL7I5v/QnMLfF7Y+eJodwfQLBJhM5et8SjLIzDNFMcQ91hkce+xTUY5u+KFDoW44beKv4mawHCb3YDpXEDU24oeBwHZzRuJPkovwKc4ZfACnFqXapoBV8yFSC+g9TZeu+NGMoTQzvmQqRbGVErgxzgVeqKQALyF/Glg6qfWd3qKfVXOrdGQEbwPnQ4bZ3D7oHFb4zbuWR9EEVEkkMLZ wfLpDHhZ 6u00pxsFei4TQG3/Wjo4xhwQ54GrEn+8YKhvDVH9CnEwVPabOh0YdXIrribS64DL8S33+ASKVl+HoruKj8bJ49dIAD6WqKAMd1r4luYHf1XQZQOjyrJYwemp2b8jVpZw/O03mZcSbUV65D7H6vIXQnPH42J8NP41sPa+eD9wPRyY1/Nv6yRjCujfmKsDOJnakXZgya3QS3ZcgL7fVwChZkVUqgVQnl4RqWIPdtS6s3J8Fic0OUTA0cYMCnKge7mxAZlu8wQN/sVbIqph0Y7stRyW/g3DvreJhEehALLUFDly298YsjvrDOq8jl0tlXikfWN19WzIwjrUgxRPfHi3Xsvc2gDIwGR/n9nJlxH26SSP5B4fPYMvhfNftGeMtIrAlil/aAKKWTl2B2/0jGq6ABJJXjZz2bzeNvXhzCJ3z8r6WnZ/Cc1W2XB2sc6bFrDOADjF1bXkBDC74zChYr7nReOxeNZVntqEj11uc9WYK75PzXMFkWDuODDvNiXF3oOV6WAc+2IhkvfPtbUk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 06, 2025 at 10:11:25AM +0800, Guo Weikang wrote: > kmemleak explicitly scans the mem_map through the valid struct page objects. > However, memmap_alloc() was also adding this memory to the gray object list, > causing it to be scanned twice. Removes memmap_alloc() from the > scan list and adds a comment to clarify the behavior. > > Link: https://lore.kernel.org/lkml/CAOm6qn=FVeTpH54wGDFMHuCOeYtvoTx30ktnv9-w3Nh8RMofEA@mail.gmail.com/ > > Signed-off-by: Guo Weikang Reviewed-by: Catalin Marinas