From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B078E77198 for ; Mon, 6 Jan 2025 09:29:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1E2B6B0082; Mon, 6 Jan 2025 04:29:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACDA96B0088; Mon, 6 Jan 2025 04:29:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 995426B0089; Mon, 6 Jan 2025 04:29:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7B2946B0082 for ; Mon, 6 Jan 2025 04:29:10 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 24720141380 for ; Mon, 6 Jan 2025 09:29:10 +0000 (UTC) X-FDA: 82976503260.23.DA1059F Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf11.hostedemail.com (Postfix) with ESMTP id F29984000D for ; Mon, 6 Jan 2025 09:29:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=M1uGya0C; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736155748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pRxlTsw4noJRO4PTJ4WE4xz8vvmd5m1JovKox4IgnXM=; b=FCO2g1jFSpWugwiSHPLhuFTf32VlPMrLPUoyDsFBoZ8twT7ZFi/XAshR+qVpCXgzC4tYhv UDWrAufxQ7AaoIfdngHa69XDL6jXOM1cUovt3tixEMF38U5bdJwEKxzS13nSAbVpi1bmyl cLPgErvqJPDimO/oGBIJa73vVuTDM2g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736155748; a=rsa-sha256; cv=none; b=bN+7Qy28AvEuzNH7hwNmB6vUeRO94rQ7a3S8LrZDUUtwWpm9WeZlKfqeQ7Gg5TFGdjAzfj wvg2KUdply9t1j2Sr/yX04ktw6Q8IIvtZ1F13NvSh0Kf6Heft2n+Gbp4Zv9YvFaC2iMBh5 gE9Nx0pz5szWqnT0zAsmlKsnI4xdL30= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=M1uGya0C; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a9e44654ae3so2364880366b.1 for ; Mon, 06 Jan 2025 01:29:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736155746; x=1736760546; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pRxlTsw4noJRO4PTJ4WE4xz8vvmd5m1JovKox4IgnXM=; b=M1uGya0CmE4b8dQo0D94K2ajQr81UX+62PS5AkCdy/8bsYxIZfH26QASkPev8Qk9YM RENTdqh1s/YkhIcvF9zu3NQfG2CG9ZbQEQ1dJbExlugSrvbp0VN7hWyxFbSi9/umstxp yQq4LcV9MK8whob6qSpDQ3rAWfYft79kIO8xTozOQ+gy6B7pJOegD33Sn+1jcIMZxvof auLkIkX3lBlkyIxctcz8JtdqRyfTDQOb3HEInTXCWrCA9NXkNqNms+berb0mISaebvbo SwpwFG3z6SBRhj49wY5ME2Lt9/hjuweesWLMEy2TOJ4Ft/8cs4ps9B5DUGOZkbeKbGYB N2hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736155746; x=1736760546; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pRxlTsw4noJRO4PTJ4WE4xz8vvmd5m1JovKox4IgnXM=; b=VlLPyeXai26ZNi+7W85L3I+lAm00Y2EryaYJwdmnDLC5RXZWGO2NK66EPXvdy+nOrc RjhvgmTY7EKkuNGwV8MotpxeQ/GULojN+wH8X6sutnEwIIn7ijephvrd+/11VvO37V7m ZC5Gz5ZUut/WM2iyY4K76wvbulwlTk1NtbbdUev6rkigN+c5kOrViMbFDBkl4MMSGiIe l7y75G9mo95MsPPQLhvt73nMoAZZtNayhl1Pff/XghJ9KFPi15zC7vFRij/Mypveyeii DdebO+OHXKL4ToxFjGxduSvZx/QsKJuTDnIIm61iPE6al27cwR171FJYbrBvQdXAWgnB wX6Q== X-Forwarded-Encrypted: i=1; AJvYcCXuE9AUw+QtTcXtN/qy8Lt+gBuKjSBd5RjJLPuiCWv+czA6uGhQZ7Y2z1x8DaElKwcgl/+a6eQdjQ==@kvack.org X-Gm-Message-State: AOJu0Yxp3iKgtvvxJiGpfpWqnpAJkMy6gGf/oHTeg2lYaWxTSp7uymlt TAu/3ZRXQgmKTKY4GakfQgwtqVP6CncGVbKRVkNTdgh8DuLlApdf97a8rNawUr8= X-Gm-Gg: ASbGncsRxU/SzDbuCen1DhW+wSTvQnRA65NV/kh6SMt8Xq5a7iVEGiZE3VqXKgb5WIc 7Oyw0JpqWjcmqSpgyB9zHYQj5+8EuQ5puJ7h2zYaRUEKYI01RT13oFW+gJkpYUncpfp3bnDkF57 t+7RuOC5IKcHtUBb904QD5hWxgkr/lg8Krls70wJlBuu1K8UEnOR0jY8tFv3EiryjE+rzE86D1u 6g9YuqI09fh9D/zdYRS0sj/8S/jA6sKNTuwX2FaCVBdOyf8WomlCzt+uhyAHa/OUKOIaQ== X-Google-Smtp-Source: AGHT+IE9spkvUXDeN+P/2tZdetnqrX50fooWVBrN0b+rpEyRq475EPIXn/4wfVRuavFOn/XGTHxFbg== X-Received: by 2002:a17:907:9715:b0:aac:619:e914 with SMTP id a640c23a62f3a-aac2ad88fcfmr5774830466b.16.1736155746300; Mon, 06 Jan 2025 01:29:06 -0800 (PST) Received: from localhost (109-81-95-200.rct.o2.cz. [109.81.95.200]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe4c49sm2248227166b.128.2025.01.06.01.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 01:29:05 -0800 (PST) Date: Mon, 6 Jan 2025 10:29:04 +0100 From: Michal Hocko To: Chen Ridong Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, handai.szj@taobao.com, rientjes@google.com, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v3] memcg: fix soft lockup in the OOM process Message-ID: References: <20241224025238.3768787-1-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241224025238.3768787-1-chenridong@huaweicloud.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F29984000D X-Stat-Signature: 3f7ee1438gs1ftadi6wkr7y8bdkxkh5o X-Rspam-User: X-HE-Tag: 1736155747-223318 X-HE-Meta: U2FsdGVkX1/rOtEwrr/s3Z4c04XTP+3gAA3Fdva0cL5JjIHk5qYH/0tJFVVpj5jURUETqC15vSrhlSMnSO0cECwm4LKpr9NjNrH95fT3Kz1PIX5ex6fUEJ9ZyyHK7JPCHvwuCMv+S8jyWh8/J7aqUkYtKz9BdWb3sHOmyNnWut8XPNbpWNxivcc1ZBwDCz796K8R/gHHFSz9dWgjq33lNR8jZALwiC+vO7jv53p/vuZILHxcKn312RE9zV1xHnauDZ99l0wrNNbtzJvmm0hDkJ0vrazQL12uq9bIbWli5W7YnLxI2MEcNl1zfbtX290CV9sb8tHDayu6DCHtKUPYUmUKKEHp8yTC1W7fOQ3WBWogWoT41tQZc3exxQDwmAptKE5OGH6E5vwS19ENw8tBfD8IvD0kDFAMg+5WF11xKfdpio1tHTQEZDv81U9yVLzmMCuPtJLKgD6hvtwC4LhrI3Qg0bguCHJwNKe7ekGkyxr3II89ilE3zdySjwHQt7GPsQ1vP/Iw/Z6wlEao2nFCHv8bOS+Tl/4TdfIWoe/hoEO76/DCH+c3e1aTTojRBx66+QuHvf8DXFH+16Uku3I54pv+hwYoE/cCFQgLWGrr4cdjjEvwuPVp+jFO8gdg2QTKqHtX1n35wep5kN6NZUYQlMd3qPJmP889WEhwnyBqEZOGzXrttBPs47Y50QCUyci/mAa3RKKHfSO6Sg2eOakkYTniGwHaK20yVuemfNkqw6Ldq7Im+EM0xfn65zmc/cA02WyTwHrCN/jDI00efO3IJ31UeI8HUo3omXyBP5AOJgKGLix9P4PY9P9a8+UiggzzjUjLwhAn0bEUBreXINAOn63LOzemcliJZd1WRavJTSWpoRLCZVQMN+GibBqUYme1kSTHwz0WtHABeAlGNtcYgNI71G9t9ElGJnfSZyhp1w0BywC1MoIw1lMuWUYNYlg5x5xs2/kdyEfdY8KYKIT hZqnGbIh 8SosfydcIMPDxxRb0850lh3mHotV3G/4Ho2sgn1JZdEMpPzC+yDg3QyBMkrpy4TDALFJmOu2cggLtUsuBXgTsGMXDIdXAV79suzTJ1xGwIBR1/MLva0vlBRSkRvYfldcjB3mwIr3x7f4eKxnBqECQ7BdvDTXKsZLDXFiE7RV/WheYX0KAGRvqrYSr9kbrEwy0Fh1xhWI1SFdUg1XJnDvatXuTTPsGSIXr/jw2eIN3ugY4QVtKbpPAQZFFuHvBhieWNB3kKKml3Lrj6hoNHE1jhpWnmvW9+Ywh+83X7PwCRf2PBcsBRsUOgqetb3MtwfyoFNC9/+rtpPgixLhDlHeWMt9JdnkhDoCR0Ow/DnINEuWafNivWaMIWQaHKe8k0YJrBu4nwyB8UVx8PF+7VFpItn4OgeE8UeNcDcmlGl/g6f8gkoL91fTHTwZv+d1M8oCgzq1R+BVgMfaYj/aoyyUglM/OMOtb7NKVx9XkPKMb3kT3nhg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 24-12-24 02:52:38, Chen Ridong wrote: > From: Chen Ridong > > A soft lockup issue was found in the product with about 56,000 tasks were > in the OOM cgroup, it was traversing them when the soft lockup was > triggered. > > watchdog: BUG: soft lockup - CPU#2 stuck for 23s! [VM Thread:1503066] > CPU: 2 PID: 1503066 Comm: VM Thread Kdump: loaded Tainted: G > Hardware name: Huawei Cloud OpenStack Nova, BIOS > RIP: 0010:console_unlock+0x343/0x540 > RSP: 0000:ffffb751447db9a0 EFLAGS: 00000247 ORIG_RAX: ffffffffffffff13 > RAX: 0000000000000001 RBX: 0000000000000000 RCX: 00000000ffffffff > RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000247 > RBP: ffffffffafc71f90 R08: 0000000000000000 R09: 0000000000000040 > R10: 0000000000000080 R11: 0000000000000000 R12: ffffffffafc74bd0 > R13: ffffffffaf60a220 R14: 0000000000000247 R15: 0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f2fe6ad91f0 CR3: 00000004b2076003 CR4: 0000000000360ee0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > vprintk_emit+0x193/0x280 > printk+0x52/0x6e > dump_task+0x114/0x130 > mem_cgroup_scan_tasks+0x76/0x100 > dump_header+0x1fe/0x210 > oom_kill_process+0xd1/0x100 > out_of_memory+0x125/0x570 > mem_cgroup_out_of_memory+0xb5/0xd0 > try_charge+0x720/0x770 > mem_cgroup_try_charge+0x86/0x180 > mem_cgroup_try_charge_delay+0x1c/0x40 > do_anonymous_page+0xb5/0x390 > handle_mm_fault+0xc4/0x1f0 > > This is because thousands of processes are in the OOM cgroup, it takes a > long time to traverse all of them. As a result, this lead to soft lockup > in the OOM process. > > To fix this issue, call 'cond_resched' in the 'mem_cgroup_scan_tasks' > function per 1000 iterations. For global OOM, call > 'touch_softlockup_watchdog' per 1000 iterations to avoid this issue. > > Fixes: 9cbb78bb3143 ("mm, memcg: introduce own oom handler to iterate only over its own threads") > Signed-off-by: Chen Ridong LGTM, I would really not overthink that much. PREEMPT_NONE and Soft lockups will hopefully soon become a non-issue. Acked-by: Michal Hocko -- Michal Hocko SUSE Labs