From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 742F9E77197 for ; Mon, 6 Jan 2025 02:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0AFD6B0093; Sun, 5 Jan 2025 21:22:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBA576B0095; Sun, 5 Jan 2025 21:22:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5AA06B0096; Sun, 5 Jan 2025 21:22:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A7ABF6B0093 for ; Sun, 5 Jan 2025 21:22:09 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5203B141258 for ; Mon, 6 Jan 2025 02:22:09 +0000 (UTC) X-FDA: 82975427178.10.519AE14 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id E9080A0005 for ; Mon, 6 Jan 2025 02:22:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QNB9Xhnq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736130127; a=rsa-sha256; cv=none; b=EWhHjYJAYia6V+b2sh6z/3OHAhWo4yixf1qvg/L9kGitTx1s5zdWDFdsdsV0pCeeaNEscR 6Gal5zrhyPVTSQSk8fWH50UbXG2lRB5sghO+Yg0sRvmu41QrUs9weW4Nd4uJLb97poIuOA jfFzSgu4tIUMTasuA/nKFjEyA8nz0L0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QNB9Xhnq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736130127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QDNMuGdRbtFXOEF4wgeAn1mDrtVJdeBZdGzWjrJ9xwA=; b=VNO7vSO4pg/HqAS8r2kMJFruirBik2SaHLdXV+bx1dj4otDuVTumPrU8qLxfHE8eDgQcB6 DOyNJAjRpKzlRYUIfG8JYcxXc5r7qxqpj1K0PAkzWd5L9JZbQEXoqssxu2MTbm+b/T1dHn DU0VbiTDjtQAlI7T5ElwHixQYx8reh8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736130125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QDNMuGdRbtFXOEF4wgeAn1mDrtVJdeBZdGzWjrJ9xwA=; b=QNB9XhnqUc/yjh6TtuQerhD5A6MqvdUNuvKpTV0yLghQ/l91KSYUT9FRJIOFIYx9zqFyPP KuIig+oQQ2X6cFTCD6uyCPLkq/p9JsULusoSvLy2sJl2rPQQ1mdIb5RxMRaax3kNwHXqf6 wdKn6+yllEXial7HwHhZaN7YW2GbXSY= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-440-WPXHLyM9NlasFo14ZUzn-g-1; Sun, 05 Jan 2025 21:22:04 -0500 X-MC-Unique: WPXHLyM9NlasFo14ZUzn-g-1 X-Mimecast-MFC-AGG-ID: WPXHLyM9NlasFo14ZUzn-g Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3DB7D19560A2; Mon, 6 Jan 2025 02:22:01 +0000 (UTC) Received: from localhost (unknown [10.72.112.99]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E7E113000197; Mon, 6 Jan 2025 02:21:57 +0000 (UTC) Date: Mon, 6 Jan 2025 10:21:53 +0800 From: Baoquan He To: Akihiko Odaki Cc: Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , Dave Martin , Vivek Goyal , Dave Young , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, devel@daynix.com Subject: Re: [PATCH v2 1/5] elf: Define note name macros Message-ID: References: <20250104-elf-v2-0-77dc2e06db4e@daynix.com> <20250104-elf-v2-1-77dc2e06db4e@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250104-elf-v2-1-77dc2e06db4e@daynix.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E9080A0005 X-Stat-Signature: 7zrqdd8c9xigkfjjoum74znd17ir4o57 X-HE-Tag: 1736130125-512726 X-HE-Meta: U2FsdGVkX1+SVvPrHqKWuyJZ6QLFj6qLm96CkYHqCkBFxChdfuC+jyy8oTILnXPzXcwxsqYZ3TWhGUjU0NDvDRZic8ms7V5X0pfA4abESdxFCRpZxi+NNGSIYZopPm6TvkgXZfd4LB0+aA6rvlGXLHrhFvldV4e9aRmr+1asBVD8PWn1pgoRll0aSMeYA8CDqcksehoooTe3XyzgVO3Rd1ONUlBpIlIY+PEHtquwARoBlKxI5MFbrZRfdlhbDoJfPRZKOzrdGj+3BIOiGjsIjWhcaU9s+fsvth+Qr3R2v8ZBKDPmOCxVIUk2kuNQe7JwxB8Mnm4IGDLwFVPgQqTL1mwAoQ7y3UGU09keqlnVbOIeXiMKXSipnCNfIPgXFdu9tCzN/U7pM1avZ94IKfbTbne7hGAnKi1m3Z5eUOvT2IBHSR1xZbfMbQ7ycEbVehqUm8LLZUfNp4ewVlBGRaGzkR8V0WTZk6zzEfE2Rm8+p5ukkLbLvbqBDOGdaJU+i2z9sI3vDVWsj0p56MLYXruIJhBL3XdS/DmwiI/6UTBaxdKRK0eyLpU2ITlGsb9sta925tHCsymr5U2aWApniMfwYZHKaVRv/eZJY9GNdcawnYSK4xe8QtmwAMpJn9G/qNSQZqIBtoy479RSNev9j1FU8Y130B/DkeQaotmMKGI0wD2P6JLy3cKi6watAnJoX2+WhNMaB6apkZ6BYlUlpjY3p2/lyEAJOs7Fo2jmk4Rob/lU4v9SIxR/7j6Ifzw635tqjPz5t5UyLFI1W1xKqcSMHIXcLkSP2jfwg6ZjY3KkJhq/D6uFuSxJUoK/SZ0ETUzAgCVfgXGyGqHU+dFfq4ANCFnsnisKVg6eVM9HAIZuKtdiX1P9ZfiqlQARTKWDFMMYsC0H0UEjUd4SmHSj9rUkozHWp131vEmYww0yFdGHMLlVvCCE20B+u9kO4OgEFCfgvNkPg4MxrfF5CjTYYN7 3jUo4qhh TyKFgFry4BolkaFONXmhac3y/2oNt3xF+sJcaCw0RFMrxS7xDC06xB3HQXiwwvnbWJKyiBxsgDaRR9YAe2U3X+Spj20zhQm01pobIg3PgV9eU4vPfCtZcrjZKLZ854UIMAkBB9jddj73ySA779Gv2S7wYPgMEwBnAHNDhESUPTtDIcdetF8TP9W0pi1V9eilomuMNlFcpCJrMpi1qVMaKrT2dRuQaCbLlAYM/fxPu7HmVO4XTDV9GCnxhtSMqKI/It64vPGQ4rVOVat3dlhC24AtNfkLvv9VOn07bleE1z8yEBE+/6BYzjILxqYBaywgwbnOmz1y+m7Vi1WUV8BAVW2+jzeRho9QYhLjiztgYeBSeXbDzsL1bp4Zz7GBXu1y5e6o5tEiw3NMP+5dMLpj3tSY2m/IPu4RNu8YN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01/04/25 at 11:38pm, Akihiko Odaki wrote: > elf.h had a comment saying: > > Notes used in ET_CORE. Architectures export some of the arch register > > sets using the corresponding note types via the PTRACE_GETREGSET and > > PTRACE_SETREGSET requests. > > The note name for these types is "LINUX", except NT_PRFPREG that is > > named "CORE". > > However, NT_PRSTATUS is also named "CORE". It is also unclear what > "these types" refers to. > > To fix these problems, define a name for each note type. The added > definitions are macros so the kernel and userspace can directly refer to > them. > > Signed-off-by: Akihiko Odaki > --- > include/uapi/linux/elf.h | 86 ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 83 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h > index b44069d29cec..014b705b97d7 100644 > --- a/include/uapi/linux/elf.h > +++ b/include/uapi/linux/elf.h > @@ -372,8 +372,6 @@ typedef struct elf64_shdr { > * Notes used in ET_CORE. Architectures export some of the arch register sets > * using the corresponding note types via the PTRACE_GETREGSET and > * PTRACE_SETREGSET requests. > - * The note name for these types is "LINUX", except NT_PRFPREG that is named > - * "CORE". > */ > #define NT_PRSTATUS 1 > #define NT_PRFPREG 2 > @@ -460,9 +458,91 @@ typedef struct elf64_shdr { > #define NT_LOONGARCH_HW_BREAK 0xa05 /* LoongArch hardware breakpoint registers */ > #define NT_LOONGARCH_HW_WATCH 0xa06 /* LoongArch hardware watchpoint registers */ > > -/* Note types with note name "GNU" */ > +/* Note used in ET_EXEC and ET_DYN. */ > #define NT_GNU_PROPERTY_TYPE_0 5 > > +/* Note names */ > +#define NN_PRSTATUS "CORE" > +#define NN_PRFPREG "CORE" > +#define NN_PRPSINFO "CORE" > +#define NN_TASKSTRUCT "CORE" > +#define NN_AUXV "CORE" > +#define NN_SIGINFO "CORE" > +#define NN_FILE "CORE" > +#define NN_PRXFPREG "LINUX" No objection to make them clearer. Thanks for the effort. Wondering where below arch specific macros are used. So you just added all NN_xxx for the corresponding NT_xxx? Not sure if this is needed if we don't use them at all in the current kernel. > +#define NN_PPC_VMX "LINUX" > +#define NN_PPC_SPE "LINUX" > +#define NN_PPC_VSX "LINUX" > +#define NN_PPC_TAR "LINUX" > +#define NN_PPC_PPR "LINUX" > +#define NN_PPC_DSCR "LINUX" > +#define NN_PPC_EBB "LINUX" > +#define NN_PPC_PMU "LINUX" > +#define NN_PPC_TM_CGPR "LINUX" > +#define NN_PPC_TM_CFPR "LINUX" > +#define NN_PPC_TM_CVMX "LINUX" > +#define NN_PPC_TM_CVSX "LINUX" > +#define NN_PPC_TM_SPR "LINUX" > +#define NN_PPC_TM_CTAR "LINUX" > +#define NN_PPC_TM_CPPR "LINUX" > +#define NN_PPC_TM_CDSCR "LINUX" > +#define NN_PPC_PKEY "LINUX" > +#define NN_PPC_DEXCR "LINUX" > +#define NN_PPC_HASHKEYR "LINUX" > +#define NN_386_TLS "LINUX" > +#define NN_386_IOPERM "LINUX" > +#define NN_X86_XSTATE "LINUX" > +#define NN_X86_SHSTK "LINUX" > +#define NN_X86_XSAVE_LAYOUT "LINUX" > +#define NN_S390_HIGH_GPRS "LINUX" > +#define NN_S390_TIMER "LINUX" > +#define NN_S390_TODCMP "LINUX" > +#define NN_S390_TODPREG "LINUX" > +#define NN_S390_CTRS "LINUX" > +#define NN_S390_PREFIX "LINUX" > +#define NN_S390_LAST_BREAK "LINUX" > +#define NN_S390_SYSTEM_CALL "LINUX" > +#define NN_S390_TDB "LINUX" > +#define NN_S390_VXRS_LOW "LINUX" > +#define NN_S390_VXRS_HIGH "LINUX" > +#define NN_S390_GS_CB "LINUX" > +#define NN_S390_GS_BC "LINUX" > +#define NN_S390_RI_CB "LINUX" > +#define NN_S390_PV_CPU_DATA "LINUX" > +#define NN_ARM_VFP "LINUX" > +#define NN_ARM_TLS "LINUX" > +#define NN_ARM_HW_BREAK "LINUX" > +#define NN_ARM_HW_WATCH "LINUX" > +#define NN_ARM_SYSTEM_CALL "LINUX" > +#define NN_ARM_SVE "LINUX" > +#define NN_ARM_PAC_MASK "LINUX" > +#define NN_ARM_PACA_KEYS "LINUX" > +#define NN_ARM_PACG_KEYS "LINUX" > +#define NN_ARM_TAGGED_ADDR_CTRL "LINUX" > +#define NN_ARM_PAC_ENABLED_KEYS "LINUX" > +#define NN_ARM_SSVE "LINUX" > +#define NN_ARM_ZA "LINUX" > +#define NN_ARM_ZT "LINUX" > +#define NN_ARM_FPMR "LINUX" > +#define NN_ARM_POE "LINUX" > +#define NN_ARM_GCS "LINUX" > +#define NN_ARC_V2 "LINUX" > +#define NN_VMCOREDD "LINUX" > +#define NN_MIPS_DSP "LINUX" > +#define NN_MIPS_FP_MODE "LINUX" > +#define NN_MIPS_MSA "LINUX" > +#define NN_RISCV_CSR "LINUX" > +#define NN_RISCV_VECTOR "LINUX" > +#define NN_RISCV_TAGGED_ADDR_CTRL "LINUX" > +#define NN_LOONGARCH_CPUCFG "LINUX" > +#define NN_LOONGARCH_CSR "LINUX" > +#define NN_LOONGARCH_LSX "LINUX" > +#define NN_LOONGARCH_LASX "LINUX" > +#define NN_LOONGARCH_LBT "LINUX" > +#define NN_LOONGARCH_HW_BREAK "LINUX" > +#define NN_LOONGARCH_HW_WATCH "LINUX" > +#define NN_GNU_PROPERTY_TYPE_0 "GNU" > + > /* Note header in a PT_NOTE section */ > typedef struct elf32_note { > Elf32_Word n_namesz; /* Name size */ > > -- > 2.47.1 >