From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E46E77197 for ; Sun, 5 Jan 2025 21:10:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 042B66B0083; Sun, 5 Jan 2025 16:10:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F34866B0088; Sun, 5 Jan 2025 16:10:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E245F6B0089; Sun, 5 Jan 2025 16:10:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C31746B0083 for ; Sun, 5 Jan 2025 16:10:14 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7A57D14115C for ; Sun, 5 Jan 2025 21:10:14 +0000 (UTC) X-FDA: 82974641148.08.96E0FED Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by imf28.hostedemail.com (Postfix) with ESMTP id 4A783C0015 for ; Sun, 5 Jan 2025 21:10:12 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of pablo@netfilter.org designates 217.70.188.207 as permitted sender) smtp.mailfrom=pablo@netfilter.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736111413; a=rsa-sha256; cv=none; b=xZozqTCa5jgxITdHAL5nrNAPy00z5qiBngOH7T+kJgNWnDK3pYLSm/UbCuc0vLHxPZLMh2 J4yE+/d3aSRCUB2YWpXDTnve1rlPFjrjlH9QLNd2jBNEr/JN4PzKGwmUrt/Hhv2fCg19s7 FzVhEczsNE9D5G0Mib11Yh5gjcJxi18= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of pablo@netfilter.org designates 217.70.188.207 as permitted sender) smtp.mailfrom=pablo@netfilter.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736111413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AwtYt8hinjHZ2rgg5Rj/tdZ44pkCD9FXrEr8Uf0eLN4=; b=fJ7b4cMC0Amm5sK7bPTEDyosnF8bMl6Fk58Ip241l4MPT5MkDgW6FiQa7AKuttuTojA1od Oy/XgZiIPNOXMQ+12V0t+lbL4VKjO3hITQ5a8WSnP0qPrLRkN2Tst7PuwjWiumR/ifnoAY oWyH2nyfw8i4LLiGT45QZJhE5tq1TJA= Date: Sun, 5 Jan 2025 22:10:07 +0100 From: Pablo Neira Ayuso To: Andrew Morton Cc: cheung wall , linux-mm@kvack.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: "WARNING in nf_ct_alloc_hashtable" in Linux kernel version 6.13.0-rc2 Message-ID: References: <20250103180150.4c4d1f30220720ba7f1a133b@linux-foundation.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="9kpNbaPKe2hx3gvx" Content-Disposition: inline In-Reply-To: <20250103180150.4c4d1f30220720ba7f1a133b@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4A783C0015 X-Stat-Signature: k3of5azyexh61bnidnu7fphejmgpkpn9 X-HE-Tag: 1736111412-914735 X-HE-Meta: U2FsdGVkX1+RvXyr8U1IuG/XtX+Ui0DqiFv7EqDpLvEOmHpS+wpvCuGsUIH5xZCjqqTMsiSGBWIYAR8OBWkZ5xYWMQa5HvmS1f97v+nUxvf7wZoHPrf2s1QAqWeFR/NhWs3Gdl3KoPwCeuQE1l2vogoAm5IaStYHlIruhg+mRBX6InoUPRJe7ArSvuc04tU3ozkZH7TWScA6sLBUcHnZU/wmZu1gvmIFtyCM4d056hAn2fA/rXC0mrswrK4Aelww24qlcJnZKiZrO1qFcHC5Q79geJFy6hr+ctrLKR4EtJWT+q+KZvv8WihdsiJl9+f3S5iZ+hCxftq5f25/CVkUCfaZTpBwApTMVqfH64EOZfeL7WbsHfZEP6LZQKdcXXSdJb6Bgc77fJCnz0m+Tlq90vcMWSkA8jXZDa9VgiP7iABj36olZFQIZ5qnYYkwuGQmYVsTN53XdScw2AJ+kjWj0W+8QJcBICy7ft/5EgODBFZodddJKKaMEjhRoH5YaeifjeXSa2h426lE8/2tMxqmLXpd3X+faCW6erWyJ3tJ7iMyytg75rpvRDxV6jn9OO6bNTBjEaKxl3z4GX635fkP5Z8/+TdbUs1DfUVOZQjNKTJTXMlOiwayoDfscsnwHMHOqSIJ/eco76DvL7vfVkWQWjMF921geWFsdM8yDLD3gqV4nYv3u6wHYkuRzKX5eGbYdyub66waNvNnFPAa7b5x/2AfwgbDRJL6ugTNkrL4c9x/mJX7aBPdR1KVOmnPnvhNcGxCosvdcYvZ2Mf+bgYiLigBas/00X5tyO4vRJ1CKkDXE5lF/bzLS+XVpW2eEhl1FleCFsbrRq6Hlsp6roTtbMAVyRDHTEqfYH2TpY7Q3RTms+4PEb6QwquV4dTZ0qQ6eTgElMKXN/KNEvGuMwo33hFWQKGwIyz0EBbRNssjx4E34jhJ5Pf5BpcJdrArDapVaClUC0dl8vCqFRbFhQg obRaBZXS yKcREZhvK914KR5jf7sKraXe5i0mu/Mn/B3nbpynhecQB1cM0e0PkDjTzGI1DY15ksZlJerdWtt3aM5cIvMqgwnpM8f2p0UDmjbVqawt/4NxlnfI8HOtAo4KeTa5kbUe1kmTr/gYpVrZJMHzRESlAFCBUyrqhZjstsMVbmekPFwpiNMCEBmvFXxSPAhYluXd8uRxG+D/+6ie7atH1GB0xlUB0SJ4UzC04UzFPNVhKvoR4+8T5PD/zmWzMVhkhn/XMb+WMoM2dI5getflz3MgrTDegPnZQiQwFn7+zgFeTtAGnOlTtsFNJ7O+rxXwEBQJMVyKxxp25dw2ZuwRDOJ7BVafnSCGFS9r0nk1u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --9kpNbaPKe2hx3gvx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi, On Fri, Jan 03, 2025 at 06:01:50PM -0800, Andrew Morton wrote: > On Fri, 3 Jan 2025 17:12:53 +0800 cheung wall wrote: > > > Hello, > > > > I am writing to report a potential vulnerability identified in the > > Linux Kernel version 6.13.0-rc2. This issue was discovered using our > > custom vulnerability discovery tool. > > > > HEAD commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 (tag: v6.13-rc2) > > > > Affected File: mm/util.c > > > > File: mm/util.c > > > > Function: __kvmalloc_node_noprof > > (cc netfilter-devel) > > This is > > /* Don't even allow crazy sizes */ > if (unlikely(size > INT_MAX)) { > WARN_ON_ONCE(!(flags & __GFP_NOWARN)); > return NULL; > } > > in __kvmalloc_node_noprof(). Ok, then I assume this is a WARN_ON_ONCE splat. I'm attaching a patch to address this. --9kpNbaPKe2hx3gvx Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="x.patch" diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index 8666d733b984..13a2097b56e2 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c @@ -2516,7 +2516,7 @@ void *nf_ct_alloc_hashtable(unsigned int *sizep, int nulls) BUILD_BUG_ON(sizeof(struct hlist_nulls_head) != sizeof(struct hlist_head)); nr_slots = *sizep = roundup(*sizep, PAGE_SIZE / sizeof(struct hlist_nulls_head)); - hash = kvcalloc(nr_slots, sizeof(struct hlist_nulls_head), GFP_KERNEL); + hash = kvcalloc(nr_slots, sizeof(struct hlist_nulls_head), GFP_KERNEL | __GFP_NOWARN); if (hash && nulls) for (i = 0; i < nr_slots; i++) --9kpNbaPKe2hx3gvx--