From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A6AE77188 for ; Sat, 4 Jan 2025 16:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A86896B0082; Sat, 4 Jan 2025 11:45:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A365A6B0088; Sat, 4 Jan 2025 11:45:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FDCB6B0089; Sat, 4 Jan 2025 11:45:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 729896B0082 for ; Sat, 4 Jan 2025 11:45:32 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F3C241C7D6A for ; Sat, 4 Jan 2025 16:45:31 +0000 (UTC) X-FDA: 82970345262.11.B9A79EA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 632A52000E for ; Sat, 4 Jan 2025 16:45:30 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pZkL+40N; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736009130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ucTR2G0pRGEjHjgOby2uDrzHenJ87MZeqqPtWHQOClI=; b=X2OCPFXtzfsYSYgQ/bbSMCMhv8u7BJGKVVI/ooKcZ43mskmuVP7fL0eg4kcJ6NTGyaeY8e Lto5IETsBeTBUmQDKk7jwfcpsuVKa74nQwCDCBxVrOn4pZ9MS3Hvgk2b1g+h52Uuc+RHks n/S/3j7KTY8xN/ZDhTwHtNFqKjJaEgU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pZkL+40N; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736009130; a=rsa-sha256; cv=none; b=kCLmthodal2ClQ5iEYJEd+NfSg3EpsDJpoGypZ4BCp2lbLu13IrUCNrjSGXo7rppGEVQEP CquR6+dMA1EYA9/zuvFCEJQYVlnJGttg03VOGFfjWcgkq7ONn3f0cC8JlNm3KPi3Ao0QQf vDBAmflxLhga5LlzEU3q1nl59XU3vUg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ucTR2G0pRGEjHjgOby2uDrzHenJ87MZeqqPtWHQOClI=; b=pZkL+40NoVmmfrLaWCpYOtXXdC GcD9sRpjRayUNCmEyBWxsmvED9MyZ+yck/7nD+HGZVorB5dvKxUioGUjzJ/bs/SHmSlZUbft7ukoo WYxxpXWv/bp5kmSNalKxOgcDEWhuYHPE87CaTDWoATiUylY8QYoBY3vmfbZko0QfphapqHj8fMfpK qLMRhfBo/0VXMCndHWe3+dF4J3gWzBeyS8mUB9ToMyFtN/tYx7jxf7iQeLF/DXVSq/G7ToxUvft3U S9kMR5h/SIlgbsNqt88sja3aWnEpJ3WzSh2yUaZ5ltcDTY084WqzZX4dWW8cxMf6JIGMQHDy8BBBh 4C1W2tOQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tU7H9-00000003ZeF-2jrS; Sat, 04 Jan 2025 16:45:23 +0000 Date: Sat, 4 Jan 2025 16:45:23 +0000 From: Matthew Wilcox To: Leesoo Ahn Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: ensure the uniformity of arguments passed to do_mmap(..) Message-ID: References: <20250104063925.1544944-1-lsahn@ooseel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250104063925.1544944-1-lsahn@ooseel.net> X-Rspamd-Queue-Id: 632A52000E X-Rspamd-Server: rspam12 X-Stat-Signature: c7sx5ti5qnpfco1ph16ew3uqfo111y3c X-Rspam-User: X-HE-Tag: 1736009130-670416 X-HE-Meta: U2FsdGVkX1+b4e0DOFiR36VzV7eDworNuFEISYe3u2Q4xzMpXFionFXhKE8XS6kawRUkzGoPdx7WXbHhbURibfzdT0UWOeOjz5CiTgdBa/nnNSUB4q0VjdoxkUJi2j2Xed7SHqCtlBHke0feGMKp++71VzKwQYV5Hmzd9URh39bwLe1j3wZ0PehlagTiaNsFO76GeHUeS4HTLWtSgDM+WSPsUgm5827XPqWDDZGCoIIG/iuTkOkFA5cW1C5p0G2I5Tl4rzciDoC2QAGhJiAxGufeRXLwyoVixp1GZeLuxBJWhHSXuGnb3Ts9MZcOHCJnTfIxwMpJC1zLsiF3IGe6v+tqeFS12hLZd75/PU+hFgtHzsFzajlOxZTiV/nc6lf3S1yjwp08+W0kxtpuDx+b9CSdgSo+cmhY5tSp/9YOAARy6zy1kd/2u4/hZMXG8GYOH/tuYdwgn58GwP/BQ3iYpuuXUKWp0fZH99M1Pqn/0TQ5J8QvSSfRhpapHwdVAjvKUevJGVkJ/nKdP+S+WlcuDE4O0KAtsJdBDeGYugUVOj1pAcMQM6wG/Dz9zLOw8ZRiz717InTakrfMBVYMdBAp1cUlVkU8SQJo8qT2c+nE4BHheaRzaRGSrdmJyY3FrM0rRUokkBbdDkPeWTbe1KBqE9mIuJUT9jgQJINgcOavceemQ0fK/FCe0TlPjGWw1tmqu17+ltt0dKxvfrBr9ZzrVl/5gEIBBhRa6trPQh8TTQKUUev7rlubOiz1/rze/6tGEZzKwdBGQHJ1mafbaAuO9SSw+gHsEEWBoovUmM3ki3ZnW5HA3wpHMbZrGv88JPAeoNGtPfqTlxw3vyPxsFUewXyIk3U64CDZx5y1k8EtJa8n3WLbNFolRzDzRPQGieL/OF/rrfhO84MPOh/9y7ylklTpx95jv1zFClMSunjXc3GmPHuLuECrg6vOySPcNBASbShnia75tWHJ2BWDOF7 x1Sc0l7U oWQJ6sKkBFujekHEOJMQWF2EQOwMU+ZqoSi/brhB5t2WhDxiEGBo9FKyYsU4APWzbAK0uy3WTxnfNfEdeRLB6gYo1fgsdZv4uuiMeY3W3NyxUXevQ2yeRc9EjNzFWxW3A45+Omi56s3mujBVwPu2Lwlp08tykFhIUGqDw54JsROzdtLsIxg3gC4kmiYBoRhyxFPhPNy/yCjmf5H3ZopiidyZ5G64RWkvkC6wWgK0F3DmnEtV53nfGEj1dXnz2XoZjTDy9LZZDOoK7Web6Hq4NE5s0yA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.037077, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 04, 2025 at 03:39:25PM +0900, Leesoo Ahn wrote: > Standardize the way of passing a value to @populate parameter of do_mmap(..) > as follow: > > 1. Caller must initialize the variable to 0, except it's clarified as > the name of the variable, 'unused'. > 2. do_mmap(..) doesn't take care of its initialization. Why? This seems fragile.