From: Matthew Wilcox <willy@infradead.org>
To: Leesoo Ahn <lsahn@ooseel.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: ensure the uniformity of arguments passed to do_mmap(..)
Date: Sat, 4 Jan 2025 16:45:23 +0000 [thread overview]
Message-ID: <Z3lloz-Deza8XXtO@casper.infradead.org> (raw)
In-Reply-To: <20250104063925.1544944-1-lsahn@ooseel.net>
On Sat, Jan 04, 2025 at 03:39:25PM +0900, Leesoo Ahn wrote:
> Standardize the way of passing a value to @populate parameter of do_mmap(..)
> as follow:
>
> 1. Caller must initialize the variable to 0, except it's clarified as
> the name of the variable, 'unused'.
> 2. do_mmap(..) doesn't take care of its initialization.
Why? This seems fragile.
prev parent reply other threads:[~2025-01-04 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 6:39 Leesoo Ahn
2025-01-04 16:45 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3lloz-Deza8XXtO@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lsahn@ooseel.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox