From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EE4E7718F for ; Fri, 3 Jan 2025 22:21:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15A056B0083; Fri, 3 Jan 2025 17:21:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10B5E6B0088; Fri, 3 Jan 2025 17:21:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEC806B0089; Fri, 3 Jan 2025 17:21:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D110A6B0083 for ; Fri, 3 Jan 2025 17:21:20 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7B398AF0AE for ; Fri, 3 Jan 2025 22:21:20 +0000 (UTC) X-FDA: 82967562720.24.8A34287 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 8FF4814000B for ; Fri, 3 Jan 2025 22:21:18 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=vKXYIT6a; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.172 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735942878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dZcMirbSfxhX99MDoRCRw7E5AlqvqyTuG+lABcQf9zI=; b=KS/yE/0Tu3jOEs866uDBpgi52WtBa4YQCipo2imtnE6bDSgnoQhMtZhGXmUnWx1YTLGMau /JV0JTNvopbc3m+haF6vZlf5E5ekA4TBjuKRfuTrK3dNt66aRKKe/HyMtatnKnvGU05TTk bsKsP5Gip2obBWsS9h0K64J8EbzXh74= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=vKXYIT6a; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.172 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735942878; a=rsa-sha256; cv=none; b=GkhQrtGKkyoVpSn7PFpbaV/0yyqO+i+A6o4uLEJCqAyQspFYJkOoNT219q04uXSqx73U7+ /t3OuZ2U+SNholc6YkEFiXxQdHots0NzPiAlVHR0RvnUURuwcJLt6NGgb6JA3C8syvutyi B6OinoKxFVB9wcrbzST99n66i9JwJTA= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-467a1d43821so120115791cf.1 for ; Fri, 03 Jan 2025 14:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735942877; x=1736547677; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dZcMirbSfxhX99MDoRCRw7E5AlqvqyTuG+lABcQf9zI=; b=vKXYIT6aHlkt8qYXFQeTUzYkGswqObUCC7SXTS3gfPlD1bTV81vKnWre17/lIX9Gja BMVkn9prTklCjb1EvMxe4IlE+iCLKusM3iklrFG4oTdNsZRHWJu+Lgk7TNAoWjUna98E IPOrWQtLwyFRGRMLrCHHMbJZu0kmPtAdjBVDBrQxPBq7lbK/95/jazVOJOkoV6ISNxjP ZfGHI/A2O9zDUQNXoR+973VSd1XRLMTN2YxdIbfID7g9eAAa1Po2DlD2C4PfveapPBs9 jfHSXgE8oZi4DJwUz9aAkkrpY/DHo3dJWoAJ2gpZxMI9kxA72IZhRIVknOnCpv5KGNc5 vniQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735942877; x=1736547677; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dZcMirbSfxhX99MDoRCRw7E5AlqvqyTuG+lABcQf9zI=; b=JevWApJVilvC2OgZ71ugqWDXdH42gxS+rW/DUTMbKMbTg4FO3HitIsctpLpC+WV2Op FKRX95T751uaczAw8mgZjCdUGD51pSDXEvrYlxQJLyEShVIIpMcdUS59vg212UX8GjSv IHMLPQpeEF/qBxxcvuh5Ri5fAJi9EnlUTw32ya2rdZbvxNsXurOC0CjRJXZDpnXyErgC ECARfmwNL2/AZ6ZSChrvYb0DPykdUKjji+NNrH4fqtuOmxnmfh4YmNMDNM2PSf4ui2D/ Jv5s+6xOkTs4sQuVnxBykIywkfpxn/iM3zKa3t6PzO3YBwV8MhtmwndTfr0ple9shNG3 pKGg== X-Gm-Message-State: AOJu0Yx2ynvPZdJXnj0XpXiw45Gy/FEOKE3nZ5G1wOH+7pdmg6zPcAIv uoobDFyRnP4RgQoQihip2FlqyLgEfW9X5FUUjCiD5mMrUxxInIoMYTn+6+UFI+kyTPK8JILAOk+ S X-Gm-Gg: ASbGncv7JvRwb73FBI1jGQHQk95EVQRs0k5a0qZ+rbkrA25Dz8HGxeuypRhAybPywRH /Ar/ovRF0iSmq2IPgM5//TdjhiVb7dqABZ4T4EPBMTPI6t3u7cBNKkDtCi2sm3bOXly9qOdg7j4 0Sy9qw4x+rwbEoYTEvNgO3NgTRISmTKXQdQyNW2yKSeubMQwv9VbnDN0HzqZ5v+RANI5GEZF/Ve /Mo5d1P6OJmKZY6So8sEdE+J8kWQRYV7dAluWcthGp3+WdO0f3s0jwl4IgBYSLVts4UZTaSjYna pP7mMGnf0Q+W3Si4+NThWuI5MCchkSb6a/P3h/Y= X-Google-Smtp-Source: AGHT+IFo18OivZlpr4+m5f7oY4gzxJ6E5rG8wtyHUuD/UFxzYxNZo4Ouk8ASWazLOiSOvfdhyEgOfQ== X-Received: by 2002:a05:622a:550:b0:462:a9c7:e5f5 with SMTP id d75a77b69052e-46a3b0c29bamr974557421cf.25.1735942877603; Fri, 03 Jan 2025 14:21:17 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3e67e245sm149329811cf.23.2025.01.03.14.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 14:21:17 -0800 (PST) Date: Fri, 3 Jan 2025 17:21:14 -0500 From: Gregory Price To: Zi Yan Cc: linux-mm@kvack.org, David Rientjes , Shivank Garg , Aneesh Kumar , David Hildenbrand , John Hubbard , Kirill Shutemov , Matthew Wilcox , Mel Gorman , "Rao, Bharata Bhasker" , Rik van Riel , RaghavendraKT , Wei Xu , Suyeon Lee , Lei Chen , "Shukla, Santosh" , "Grimm, Jon" , sj@kernel.org, shy828301@gmail.com, Liam Howlett , Gregory Price , "Huang, Ying" Subject: Re: [RFC PATCH 5/5] test: add sysctl for folio copy tests and adjust NR_MAX_BATCHED_MIGRATION Message-ID: References: <20250103172419.4148674-1-ziy@nvidia.com> <20250103172419.4148674-6-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250103172419.4148674-6-ziy@nvidia.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8FF4814000B X-Rspam-User: X-Stat-Signature: u5y7dtikxjg7bjx33i8nfgodeomrut59 X-HE-Tag: 1735942878-904 X-HE-Meta: U2FsdGVkX18OGJ+m7BoQaGeyTJ6tKpj4tnroxNf2wStJGnbmWX3nA0x+TD95sHkqBh1kiq4TIK9TVNBHdSluOrAaLfrUkcCoW04gbANQogsOUT+c9yHGR48HUxPM31It0gEhkxrqMyuvWedMizC6K/Dbdh8fqW1uMwQ1jNRwsCq/D6U/TmRh8NCBVwz2bx2LtAfknNJsqelUZ7wosNO3yS+wcqVMSxBpmGm4FzKE5b44sAE5BMnbL10EgrPNPSCdOJmEveT8+ueAiVnMufKgA1J9FPDn6iW+tXQDB8U9Idy7INqTcZPRWWSNNyZSDwwYaHyc27VX8+YA43n2kuJhg18WLeQk68InR1kexv/iPjNG1/WZdG2Gk7WyMMBmkglzB95zITRjQkJM+kdhpuK2hNnO0iCssuLzEP+mCyRAAHBYoYUOtRG/Ssge6Ef4MBqnEFog07BGg9tmnPZq1Jj8UB1p7QvRctI79MJWwWXAUBwfz6gYEyqmrluzmNLtjtSj7OJHfGPuK+fJs1nM2u3t6U2LQzLw1OckmPp/UX1KH5Aw7PghX53XOTcRY7hbbePtNThJs+tWQ+bkPnO8+EiEi7mcHFBZKwwZcVI1Bhn9kxSI89tmY/vEuIF/BYB4Qur2KXGtinm0s1olW+r7LQN8rI/Ptge7S6s3Ye6JtAeaZ8fmlvyMznzESUs55ehXJpduDPedO5M30Xq1LUpk3tX3ZR5eIkE6Rp+X9Y5l/oXjrplDvK4gKxRKTFmxjtIyl0Hee2RI1TGmHhy8CAKRn9wIWzp+NHFjl7wruQb9fRF6JSC19zdJcLwG+7Uhietd3k7UTAXlx/6HSY9XLJxARK9D2R4ngtW28dSJUrlcQ+c5Aap5l7iHNDvLKt0zDh7HrLnvRoMSp5NTb9wCUQ1aTyCdk6rBFOHHTe+9FITPZYCcXJDLXMzF0xVkvy0ZGsKGrdM+eN4X+cioCwRHv9NgGI5 JbFjrxG8 mC9uVgehiHjxW6Mk3WYhWoid1oO7QjheDjozV9xpNKyLpgogCSmx3/r2wa8+5FS8q/r3M9I4yEr1TIFWU2ETbw7tser50fYT2TwMdDRrYKwuu+Mk7tUs7agKmqU+1x9H2bG9ugPe/wSgQQQAPiq21NVHz21wTuT2+dUOKxXg0PLe0pIbrsaLqzGb+lHfxgN9E+yrKzpk8Dh/YsF4HDrW0cblHKbb9vdpUGCIbS5OVlIjsyUyaC1gHTr05H1OjCTyTeyOH0Nr19b+fE5JbrnwFMLKfHLqJpuqfqaRtfCbJoElBaeyb7FteF4f6S7CYBVE2+I61jq2mipUeNfojMBvlRFKQNZVo+ZXGonZyk4OnYA4CbTKQkJGgK0+ZliYR/9NR5Ewzq+vxqcvT69ewkEfDGQ6QpkowWDBUFdDSKGSrI/7H7QqAybGPRUQkyVcDyO+Fvkpf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 03, 2025 at 12:24:19PM -0500, Zi Yan wrote: ... snip ... > + { > + .procname = "use_mt_copy", > + .data = &use_mt_copy, > + .maxlen = sizeof(use_mt_copy), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > + { > + .procname = "limit_mt_num", > + .data = &limit_mt_num, > + .maxlen = sizeof(limit_mt_num), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ONE, > + .extra2 = SYSCTL_32, > + }, > + { > + .procname = "push_0_pull_1", > + .data = &push_0_pull_1, > + .maxlen = sizeof(push_0_pull_1), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > { > .procname = "drop_caches", > .data = &sysctl_drop_caches, Build errors here ~Gregory --- diff --git a/kernel/sysctl.c b/kernel/sysctl.c index f9ba48cd6e09..bca82e6132b3 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2093,8 +2093,8 @@ static struct ctl_table vm_table[] = { #endif { .procname = "use_mt_copy", - .data = &use_mt_copy, - .maxlen = sizeof(use_mt_copy), + .data = &sysctl_use_mt_copy, + .maxlen = sizeof(sysctl_use_mt_copy), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, @@ -2102,8 +2102,8 @@ static struct ctl_table vm_table[] = { }, { .procname = "limit_mt_num", - .data = &limit_mt_num, - .maxlen = sizeof(limit_mt_num), + .data = &sysctl_limit_mt_num, + .maxlen = sizeof(sysctl_limit_mt_num), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ONE, @@ -2111,8 +2111,8 @@ static struct ctl_table vm_table[] = { }, { .procname = "push_0_pull_1", - .data = &push_0_pull_1, - .maxlen = sizeof(push_0_pull_1), + .data = &sysctl_push_0_pull_1, + .maxlen = sizeof(sysctl_push_0_pull_1), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO,