From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D12DE77188 for ; Fri, 3 Jan 2025 19:19:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11BE36B0093; Fri, 3 Jan 2025 14:19:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CCA26B0095; Fri, 3 Jan 2025 14:19:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAED16B0096; Fri, 3 Jan 2025 14:19:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CC7BA6B0093 for ; Fri, 3 Jan 2025 14:19:21 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6A59380A0B for ; Fri, 3 Jan 2025 19:19:21 +0000 (UTC) X-FDA: 82967104122.02.75179C0 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 95C021C0009 for ; Fri, 3 Jan 2025 19:19:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=utmQreOK; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.47 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735931959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LqIcsQa3xQ89k15UvHNpKUF7d2hPkHrES1PrudycnJI=; b=4Z9gLrIhAn/Cc7NSLOpO46p1N4zYF69O+43B9ejQllOKUsTBCWzKDV2JzDl0d1lgmvl2qQ ruW152xjFHpNL+PtAgVgaLyDUGsHC+HhdXQVCktNV2BpWJwXcFBYsNDGCcwa/17jDF0Nv1 Frkm8k15RkCxG3eFlqzCwbKVPksqzm4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735931959; a=rsa-sha256; cv=none; b=DeBunzwbcmCRvugpWxndLD2Viz3JcHBxksyPQvNJro5UVYai1Pc0Fk4TNWnJ+n6N2v6b/d uq2/92T3P2bkmi5brfOrWTfxfZswjzkuEmgj3d2fyM4O0RnvWuYuqs6ob51gPvzLi9TC5L 7qfo/FfDD5yU/HewbkYUGJi1i9agyQI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=utmQreOK; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.47 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6d92cd1e811so115644056d6.1 for ; Fri, 03 Jan 2025 11:19:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735931959; x=1736536759; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LqIcsQa3xQ89k15UvHNpKUF7d2hPkHrES1PrudycnJI=; b=utmQreOKVHJ8yQRnVX1KGEMjp134ytmrQcAn32O4R4TPtO664cyaVPl+wvNZK5o2vV BbEPFiS1BtXhv5R5stID8Yr+LJwy1nGZ3xSTBacSaXuvB1yyMDKB9+0scimsfldlTCth MibTAfBvTrmTJnTlPCsmXyK4rTA4SOI6FpAzRYpF6K9wbJc/E+cDyuMvBH6xYltp0R86 SqXBi+7xORBWTl23LC9T5C89NNPRiA36Zs9hGdZdXdNb2HywMgakgVYtcz5qDZdWep7f pK7uEG4elJSg+rOI3ohqaUq9peCNvppuzm00nS7jAD6CKwKyL00hhbVdYvGifgg1DnSE ZeoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735931959; x=1736536759; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LqIcsQa3xQ89k15UvHNpKUF7d2hPkHrES1PrudycnJI=; b=pCf+XSErnKO6pH1ufPpiPUu7YAHc0MNitcsz74xJbFdQdodNY1tJTX1sR8eYEEsrHD 65lJxy7Hqypy9NAPXJt1znZ1aKo1hRqUzJM0F6Saz+Y+MuQfs7DT1co20bsWLuUoEZw5 cSMYvK3TfPk3EXo72+fFY1+2279FWXOpkleRk7RiTJGBivMJzf0xg0H8LTiQbjjVh4mW hB+3bXsmmj5EvZn5rthFJsNiEzSi2Yjmz/VKyTGxSd+PmtAGGOvMnXciO6eFCLeqQd3F /dQZ5NE/TqawD90lisHGi3qFP8uNpNaJXFWvbOaUI9gYgvSdZOchRvPS5z3UymOoqTe1 mV9A== X-Gm-Message-State: AOJu0Yy9ha0WBsq17XYh8YFopHEg2jtOGDZMOLBTNgcVlvk0tPuUzDHa vWiOWRosk5eMO5HcYkKv5E+Dyehh5nEobfQkq1M93yLmW2HeMUB3NhDmh2OfCnU= X-Gm-Gg: ASbGncsJe1Ob+N/xDXZ7AN5B/gcd3c9ZF11XKI26RS6Vy2N/7vdA5Bgv69R+o16H+sa TFak8Y0/xFHjdmMjCF6MLI4C0aJUHXDfHWSsH2pJwdcIp0QNHm844Lmzp8eJnk4TcE3dCa5jTew n5tos3LUejDrQA5yMs69fYkPNtYqK5cnNqV1k+mAEQbB0YrRqTeuMvhmQuBukRjL5etVVFNJqmg hR21wQjf2C9zjzbMg/gtpP/RnzkjeqBXWXEFFDbDPTVlTvPKKoRTP+4SzPViUX8sxjYJEsi0/XS YtEN46CC6Ax8zkridpBPqhh58QSVTVz7pqP2kwM= X-Google-Smtp-Source: AGHT+IFXU9YnpCsbuLkPNkBDdSawluQ0vddI2FbCErzICwlopoFOniCDgIP+AcoxPMRkHPraDR2BNw== X-Received: by 2002:a05:6214:124d:b0:6d8:ad28:adce with SMTP id 6a1803df08f44-6dd2360e147mr870358366d6.15.1735931958766; Fri, 03 Jan 2025 11:19:18 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd18137218sm142415636d6.57.2025.01.03.11.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 11:19:17 -0800 (PST) Date: Fri, 3 Jan 2025 14:19:15 -0500 From: Gregory Price To: Donet Tom Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 95C021C0009 X-Stat-Signature: rut7gjixmiqj8yi1yzya5g6616oniqjj X-Rspam-User: X-HE-Tag: 1735931959-509794 X-HE-Meta: U2FsdGVkX18byLUy6307tUKL96KZpA5cvN8adPdSPK7fdChg892u7QOk7RfU+Ha2Ix7/0YGXL01PLKzYKbqZrnWjIlct4faiklQ3zs6dI35STz6ORtdB3vHwcrlDWrTVIrthj1t2NAvYJKc3lnDxhM5pBWqXs9Im6wzJdRU9XLiQkZMxLp+KPiheO6/wAFyedEPE/eoyDHz1pDFYvluew+P5znRBsgYsNQDfXUkvruszC0F2o0SLjLwjep5kVACW1OFAEw/FYY1JcA3luTCEZFtqSXJJLjGq4WisHKziEoeyIvQgM0ld6y+NE5N7a/A2mbK3K644KKM7u5MUzq0eX0TXtPy5NxJKolgubAibmL1AAUFZfhye0rFHKGGu2rYmqmcxnQlEKuIFfh7x9leZ+JQQLhYxp2R641n7KqBTyjvqCG8lFSVXnm++BXCSd1P1uKnfn9rH4EquQOV1PqVfFHqudcloD8disUBPtDynhn2LHn8Cc1g9HTX6kGW9kF4ehznZLcSYXm92RF/FxS+LNFc3cKaFA2dXSuTp+GxzyXkDE6b4irzcqhdlhS+3b0UyEe2ksL+9TncfUxbtkCh2wBa2bNgCCU5jkF01QFMsHbaES8RfEhGULQmG8IJ4x6mKWE7MpwGxxvl5c6n9ebR8zn2eJcPfC0Qp2PcyS5xpx1LOuDbGKIOz3020Tm1aM9SB0i6REYvNkqQlFMoOEZ613WhnJ66crayYXMcJEHdDNpBWauQYNRojuD/Ozxhv82wEX9Lcqg5ncbnCLSZPbFUt62PxoJTohGBaT5hOCI1Sot63ItOMEsyD+ciVtKqWsps6hSV7PNCNFKQZVNdu5Aj9Ko1QJQmqApCUFNRbyODth6/GfcK8g0TikBZj84DVeoHUGLp/ZZuVA/9bWG82FtcpoyLXjHhpC+vT84I5jwy42fY5Fwe/n9yuM0nnjGoK2wBOV6YaMVLuYj+/cW6bqZ1 A1/MydF8 rshufOk/1VSA8E6w9CTi/4gy8+UX4ay8NSvMFm8BeMXWeOPn4Rbr7113KMT+8Ozkdy+/IVaVdyHmOTArksrrnRHZF9StJFbWg1fB/tCkTDws6rK+XcTx5V6go8uZM4Yu3UAsXCAsSPnS62UhY4NCcRqUmG4ot6UlC6A+nYL87Gyv+/rmuB2rFatNP9xBup0MNcFNAN/V+M/uT1ng599nDCWbl0kR4f9FspxDPEje+AzHkvtARcq6zxhuG0ly+LPIvENCOQJD94ahByVroTun2GdEE6NrC5nTQSXhVnxQVylsyru49ve39U5+0i7sr7HOuQtOy6tG8j6iLZTdgblvGfkGtodIjAElxDHUSOmz6aXdEAE4xJzTq7Vi3f8rB1PPTArbF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 03, 2025 at 03:48:24PM +0530, Donet Tom wrote: > > On 12/11/24 03:07, Gregory Price wrote: > > Count non-page-fault events as page-cache numa hints instead of > > fault hints in vmstat. Add a define to select the hint type to > > keep the code clean. > > > > Signed-off-by: Gregory Price > > --- > > include/linux/vm_event_item.h | 8 ++++++++ > > mm/memory.c | 6 +++--- > > mm/vmstat.c | 2 ++ > > 3 files changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > > index f70d0958095c..c5abb0f7cca7 100644 > > --- a/include/linux/vm_event_item.h > > +++ b/include/linux/vm_event_item.h > > @@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > > NUMA_HUGE_PTE_UPDATES, > > NUMA_HINT_FAULTS, > > NUMA_HINT_FAULTS_LOCAL, > > + NUMA_HINT_PAGE_CACHE, > Hi Gregory, > > While running tests on the patch, I encountered the following warning > message on the console. > Thank you for catching this, will add to v3. v3 is coming soon with more microbenchmark info, then hopefully moving on to some workload testing. ~Gregory