From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F059E77188 for ; Fri, 3 Jan 2025 19:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3BAF6B0092; Fri, 3 Jan 2025 14:17:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DE9B76B0093; Fri, 3 Jan 2025 14:17:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8AE06B0095; Fri, 3 Jan 2025 14:17:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A81056B0092 for ; Fri, 3 Jan 2025 14:17:34 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 77926444A3 for ; Fri, 3 Jan 2025 19:17:33 +0000 (UTC) X-FDA: 82967099586.27.D9FC77C Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf20.hostedemail.com (Postfix) with ESMTP id 7C07D1C000A for ; Fri, 3 Jan 2025 19:17:31 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="TRlBlR/Z"; dmarc=none; spf=pass (imf20.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.179 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735931851; a=rsa-sha256; cv=none; b=Fp7KYVEZuw8jhViM49oF24zDNnmFgSrdu0MZDwzbHy8EvyxUiOUncr+sNN33lwhKnUiP8S fYLK/Xx7LC9ubeOHVgmXxJhYehzdqGWc7xHa1QghzLtgM4TbOSwbszo1Xda+ewKwPL/JN2 R0zer0SYcZBi7X5Q2y1UhF0RbIOmyaQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="TRlBlR/Z"; dmarc=none; spf=pass (imf20.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.179 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735931851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9xCWEzpOc0+t50bMdRZ9ztI351/EKUKzWqLOYInH75A=; b=dzFCK3D2IOlk433UE6nU0yI+MtT+8uOBpfdeBlXAMvK8OHmB7CZClicGExdWETcRsLqxsU eaPpKPEidAJoq3XJGCp7ODK/+pEtdFgGsqSNjSZNcMUKR1yhe82N9xUGoHKqXbzlOx2cFh DRNpci3TEIc36HzwvndCDTeQVEqJC8c= Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7b6f1be1daeso1185864285a.0 for ; Fri, 03 Jan 2025 11:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735931850; x=1736536650; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9xCWEzpOc0+t50bMdRZ9ztI351/EKUKzWqLOYInH75A=; b=TRlBlR/Zy56yZCVbMtucBlJmtBslsTdNCaJXW/9zI15gd2ODbbf7yjHUkeFPkPA43a j8NybS9yIQbZrTVFwRQ0DX/TRl1JetD/leWKU1FmTP5ZnxoUXGm3lEndotoiTEuMOuL8 msELF0EhE7TWXs6IT/ixIPivDcj8F0BWxbSqVTL+twE78sKEfaP1UIFrCS+9gPOQldK+ pjE9zMtI8J17fowtm6+QmaZgKHfINT+6+EvOP5SfVWH6imUBil1iHe14ynR6/Eu6BzQJ XxZ/mRZ8DjMC8cDqlxJgBzQJLyZNPIVFdKUOssSKFzWbx11kUnJFg68XS7tcIDRNIOnw 5RIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735931850; x=1736536650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9xCWEzpOc0+t50bMdRZ9ztI351/EKUKzWqLOYInH75A=; b=W0HEzq+DdBKud9A6+mdKS/d4+ph7k196RMCnEmx0YFEoxPreqzGaXfc1Gj65xV43ky 2V+78S8BPeONWlI1sk5REWI1cQIjEXoUDfJzFlrvNbHVumjga+UJdLzQSfc7HNVr5e6E Gia5E+oU0G4Lu61a7xuk39lr3+92DXSkLXXg5Lcrvi0+8mrRYgfZmkusoyF+Dqmc0E4U sL5m/OmxyxNIoWUDl7y6qFR7DXIvUfqf+r/5mutSWYmrDIfzgVY9H6RSICahm0ZQ6yiL 9KQSEA4Rq61490T0sen/FjYHX50hCKcflQrehMnEr0CX5GgQ2XM4/L4Qp0JszC06esut TiTg== X-Gm-Message-State: AOJu0YwZXznFmmviUO0gZpjlYrRwkC82iqWkDVNzqRq7f8d660bXm20l laMqhqcdoG2/ixmYSUtDfpBGZnWyE8qeUKS1/hBCHeQq3hATRtqo0Omn7BrvZOk= X-Gm-Gg: ASbGncs25m+HM3okC46ZT8DkrPfe6rVVZo4zg6yjrm8Gal6IOG5ulkr7KH5LRpYICld Ob3evipO2LuFP8MP51AjizL3gpfhu7ele/6vthu7d4NaXmcLSbZXSeBCMMzeVVdSEzqR+3DS49S Wx9LBPwAWAVYzmq3czzSmL9W+2jXXmw+FEFikyvWxR3wfR+iIs6KMLPii8C6/OZqU6f8V4bs6I9 fzThRdsKjntoi55vpBtUDj/3rlKZjjeV4frLqFNA2aLC3YMwwBhkrtvT90cBYmHZX3Fc5vh3zTv f7oGhfky5KSiezhRuZuMH3ElbqBKY5eNVk3CcXk= X-Google-Smtp-Source: AGHT+IH5aLDwFVXcgn8JNVrwAfr94iW/Nrr+sh3E9MNJo1KeMcTRLHwTPTXTGn1APlUcaTnbvHLksQ== X-Received: by 2002:a05:620a:2708:b0:7b6:dac1:cb80 with SMTP id af79cd13be357-7b9ba838d46mr8148371985a.58.1735931850471; Fri, 03 Jan 2025 11:17:30 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac4cc65fsm1293291985a.107.2025.01.03.11.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 11:17:29 -0800 (PST) Date: Fri, 3 Jan 2025 14:17:28 -0500 From: Gregory Price To: Zi Yan Cc: linux-mm@kvack.org, David Rientjes , Shivank Garg , Aneesh Kumar , David Hildenbrand , John Hubbard , Kirill Shutemov , Matthew Wilcox , Mel Gorman , "Rao, Bharata Bhasker" , Rik van Riel , RaghavendraKT , Wei Xu , Suyeon Lee , Lei Chen , "Shukla, Santosh" , "Grimm, Jon" , sj@kernel.org, shy828301@gmail.com, Liam Howlett , Gregory Price , "Huang, Ying" Subject: Re: [RFC PATCH 0/5] Accelerate page migration with batching and multi threads Message-ID: References: <20250103172419.4148674-1-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250103172419.4148674-1-ziy@nvidia.com> X-Stat-Signature: 851g4q57c681hcfdg9k185b1ahf468p4 X-Rspam-User: X-Rspamd-Queue-Id: 7C07D1C000A X-Rspamd-Server: rspam08 X-HE-Tag: 1735931851-146874 X-HE-Meta: U2FsdGVkX19WdaE3nJnPVznqmwFEoVwde1Qe/nKL/iGSP7ssrIOTq8rpMX++/eHd/XW0TqC/BdnUG2JSMa0/Yc8AeCfICXf8W8Wu+OHGDhTWQrUGS8ovcdShB2TtsC2frVm6T5ObIfyd7YJIyJjsZIaYZbw7fl6P9IOkfSwEVbmln2/MwyEwYpRPeJ9r8+cePagoHXeIT+ViUoHC+jq9OVhL4BLqDIRTtvfpguh+6klaxyBAidADE2m5F6mjVCh349qMAN1YxxL15DVgJxtc6ZCG7DNDLI84F+HDowJ8ND1kEzNLmVGHghgX6C0GQAZmUSfhc0S13SXeKhB4vKUAND5r4RVMOqCBNp/3RrrPvTw/cQnWgW36BZfoLK4iI8elTRdgxdjEOGdgRKQJqWnCEbtivA5p2+U6qcCrZ4R9Y3I209akRsn/GswtYSJ0DxXcODVpinVJYX08p7yXpIYaw3KE5KXuaBzAad9BgRdFxER6kvJCnL7keXH7xqCZa9c+v/ecDCBD9A3P3c9CtNdfOCSTiXTpCEa9qrRvNwdHWm1xNGSmWIRs2OxN2J0BQaKw8YaumsSfCEQr5Tw+KeSf/KAGLCj4oVteA34H9Y5flEgDwrtsu3qqgck5KIRVwWgg53IxDqs7mpv+ym8Aa2GJmC3m7eaJ3Yua4/rnbTGnS6o7O2GMXxEsIzdOaa3oi6t1jrqIWwcVMPyT1g8Da6yryG9kvqFkikphPD2FlTlLunqK+bjb9nv4m0/cwVMq+mA9eL20fGnXice8mtps2mFvuQJhWbjpNpdwc5V0S2MIxWUiypkhNMI4HAWxbGUMRLHs1micCJCCvw6moXv9hJ31ccAQGKdiDeoIqh9MJyefZhIZgIKs2iQ4QCk1rrbWRraqb0cXMBJaukTo6xpZPHLgFla9mY5kv8rgHilX3Yb7IKhTUMe+zGKMRms7Gnnw1K1NhKWLRHTLYQPbqUr/GO1 q2OFa4qA Ip1d55qCuTVXXF92qZ98iXlATJSrq1sSexULNFxK7zWGPbzS3yWfXjs+WlYB4U8jXmnk5saTTscgh1LPMJY4uGPk3tsgkJDwyrGRJ8Z3YlOI2codp3b+D3Dl8gCbpJTOmkqeg1QcHlHLGyrfTqObZrcqPDIuIxaPW/3vE8v8cB+9MbxiX4NqPUsu7RAEhzHLxD0YHJyymMKQVHeRAHgto2sD3Uz0E6PXnxeLNvceO/5XKh5yE3SoDVibwM7JEDgb2LlNKmhUfRrqhM11e/DqGgwxwUl7McNboYZHQ8+q7BfVPTrQDmaVfIeIOlda+gxVB09bvtfB+8jRBGAIfQxAd/iaH4rXUCF1U2CjBphB5wFQwk7HUr5LZqte4IiIBQhjGPfMYgIpPqB0ZKLwfJKi7WDyp8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 03, 2025 at 12:24:14PM -0500, Zi Yan wrote: > Hi all, > > This patchset accelerates page migration by batching folio copy operations and > using multiple CPU threads and is based on Shivank's Enhancements to Page > Migration with Batch Offloading via DMA patchset[1] and my original accelerate > page migration patchset[2]. It is on top of mm-everything-2025-01-03-05-59. > The last patch is for testing purpose and should not be considered. > This is well timed as I've been testing a batch-migration variant of migrate_misplaced_folio for my pagecache promotion work (attached). I will add this to my pagecache branch and give it a test at some point. Quick question: is the multi-threaded movement supported in the context of task_work? i.e. in which context is the multi-threaded path safe/unsafe? (inline in a syscall, async only, etc). ~Gregory --- diff --git a/include/linux/migrate.h b/include/linux/migrate.h index 9438cc7c2aeb..17baf63964c0 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -146,6 +146,9 @@ int migrate_misplaced_folio_prepare(struct folio *folio, struct vm_area_struct *vma, int node); int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, int node); +int migrate_misplaced_folio_batch(struct list_head *foliolist, + struct vm_area_struct *vma, + int node); #else static inline int migrate_misplaced_folio_prepare(struct folio *folio, struct vm_area_struct *vma, int node) @@ -157,6 +160,12 @@ static inline int migrate_misplaced_folio(struct folio *folio, { return -EAGAIN; /* can't migrate now */ } +int migrate_misplaced_folio_batch(struct list_head *foliolist, + struct vm_area_struct *vma, + int node) +{ + return -EAGAIN; /* can't migrate now */ +} #endif /* CONFIG_NUMA_BALANCING */ #ifdef CONFIG_MIGRATION diff --git a/mm/migrate.c b/mm/migrate.c index 459f396f7bc1..454fd93c4cc7 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -2608,5 +2608,27 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, BUG_ON(!list_empty(&migratepages)); return nr_remaining ? -EAGAIN : 0; } + +int migrate_misplaced_folio_batch(struct list_head *folio_list, + struct vm_area_struct *vma, + int node) +{ + pg_data_t *pgdat = NODE_DATA(node); + unsigned int nr_succeeded; + int nr_remaining; + + nr_remaining = migrate_pages(folio_list, alloc_misplaced_dst_folio, + NULL, node, MIGRATE_ASYNC, + MR_NUMA_MISPLACED, &nr_succeeded); + if (nr_remaining) + putback_movable_pages(folio_list); + + if (nr_succeeded) { + count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); + mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, nr_succeeded); + } + BUG_ON(!list_empty(folio_list)); + return nr_remaining ? -EAGAIN : 0; +} #endif /* CONFIG_NUMA_BALANCING */ #endif /* CONFIG_NUMA */