From: Matthew Wilcox <willy@infradead.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com,
wangkefeng.wang@huawei.com, kasong@tencent.com,
ying.huang@linux.alibaba.com, 21cnbao@gmail.com,
ryan.roberts@arm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: shmem: skip swapcache for swapin of synchronous swap device
Date: Thu, 2 Jan 2025 13:10:02 +0000 [thread overview]
Message-ID: <Z3aQKm5_s-5XkAK7@casper.infradead.org> (raw)
In-Reply-To: <04997e54c276eff40a6119a90d36a4e71aade89c.1735806921.git.baolin.wang@linux.alibaba.com>
On Thu, Jan 02, 2025 at 04:40:17PM +0800, Baolin Wang wrote:
> With fast swap devices (such as zram), swapin latency is crucial to applications.
> For shmem swapin, similar to anonymous memory swapin, we can skip the swapcache
> operation to improve swapin latency.
OK, but now we have more complexity. Why can't we always skip the
swapcache on swapin? (Actually, I think we can always skip the
swapcache on swapout too, but that's a different matter).
> +static struct folio *shmem_swap_alloc_folio(struct inode *inode, struct vm_area_struct *vma,
> + pgoff_t index, swp_entry_t entry, int order, gfp_t gfp)
Please wrap at 80 columns and use two tabs for indenting subsequent
lines. ie:
static struct folio *shmem_swap_alloc_folio(struct inode *inode,
struct vm_area_struct *vma, pgoff_t index, swp_entry_t entry,
int order, gfp_t gfp)
next prev parent reply other threads:[~2025-01-02 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 8:40 Baolin Wang
2025-01-02 13:10 ` Matthew Wilcox [this message]
2025-01-06 3:46 ` Baolin Wang
2025-01-06 4:07 ` Matthew Wilcox
2025-01-06 4:59 ` Baolin Wang
2025-01-06 6:29 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3aQKm5_s-5XkAK7@casper.infradead.org \
--to=willy@infradead.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox