From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 238BEE77197 for ; Thu, 9 Jan 2025 15:45:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50C896B0085; Thu, 9 Jan 2025 10:45:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BB576B0088; Thu, 9 Jan 2025 10:45:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B7B6B0089; Thu, 9 Jan 2025 10:45:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 16A716B0085 for ; Thu, 9 Jan 2025 10:45:40 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 607A2801BA for ; Thu, 9 Jan 2025 15:45:39 +0000 (UTC) X-FDA: 82988338398.20.A1BB70C Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 277BB1C0009 for ; Thu, 9 Jan 2025 15:45:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=minyard-net.20230601.gappssmtp.com header.s=20230601 header.b=FTtDZhxK; spf=none (imf18.hostedemail.com: domain of corey@minyard.net has no SPF policy when checking 209.85.210.48) smtp.mailfrom=corey@minyard.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736437537; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cgTp2x21PamB5G5tjbV3jPSQRWSgTUkiJmrzV93coW4=; b=vCJLS3RTA6+4O0IjFoGfAgzuZmcgKaBaIN3LYk7QSPUF9KHNkwruvsp0nol1ir6tJK57Ma YdhZRcb5iHQeIqooFSzbztFE01uy6KuOcDonbHbMRJ2ybVjGqUyX+st6c6E3gMArStOHuR daPa6E7RtH5WdNSED0sUA8rH79tzCaY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736437537; a=rsa-sha256; cv=none; b=EypLuPg3VxVouz0dcDt+o0v/Yn1E8tyP8YNM4h0UvzndLM66/Rt3ftmVxaoUWdKYFTWcTv P3dWEMnLmJxB2M12sN8sh8RT94/bzZDc384MZGeWvEe6e8Lqo78XdytVI5dZrk9fSZ8iLe 6Kkegs+lzx0cxkBri/jSfnZ7dxR0BhU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=minyard-net.20230601.gappssmtp.com header.s=20230601 header.b=FTtDZhxK; spf=none (imf18.hostedemail.com: domain of corey@minyard.net has no SPF policy when checking 209.85.210.48) smtp.mailfrom=corey@minyard.net; dmarc=none Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-71e35be77b5so294448a34.1 for ; Thu, 09 Jan 2025 07:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard-net.20230601.gappssmtp.com; s=20230601; t=1736437536; x=1737042336; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=cgTp2x21PamB5G5tjbV3jPSQRWSgTUkiJmrzV93coW4=; b=FTtDZhxKq5mKIKYe5XiC9DFYqOe75qbaDH4vWaHaiZBPBeJrtSEyWzm9jci/+Lo+Ft INmobGUFOZ/8XsDtN5vfnCMd7YXdMWm8gPvIrQzbJU3mnJ7QZqcaZ10GZ3icwCbVL1A0 2A0+z5+eKQSia0yR15seG6rLFFGo/C04tTueAlMKZbNl0I8K1WDISEdVKuna5up+vWcm gd8Q7lxqVrbklT73y1rH4PFhwG4ZI6UQVQF/7iW+4JS1dEhSFoHYI9KNwjH+186R1Tpm ABdg0VvutXCnewq16piIy5plOraMQf4ibl+y704zOzIM8spmCA0Hylq9ezuVJ9kyVnP+ j98Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736437536; x=1737042336; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cgTp2x21PamB5G5tjbV3jPSQRWSgTUkiJmrzV93coW4=; b=DFXdQPpZsw9LvY9vE7si/AltGX1eaErUaTOAXG7Oniml6xxEzjWyBvOCSaO17mBcLE hl28t45SkLlfwZLcxKv385kFAqJuglUNITZQciAynDafdgZ4drvB3whPTIwJmT1jB2nm 6Glw9Qkk0uihLnGKrmnFUXnEwgb2RgUnvKjUso1DXh7immEnkuclJrQhc8BjOOol4c0L Wh0NW2zIcbUjmdeIvDgvSlzBNBJS9Lp1C4K28CsmH4uItrJPPwDB1X6TTePYO8LKY9H7 vjrlvJ0pe2XegE7eXy//NErMoPn1phiuj5zVj+HiHybwe6Z3T6jIl2cHNL5sPDYOJmiM /Tmw== X-Forwarded-Encrypted: i=1; AJvYcCVqr6gW7MVo7o4bDPl4GASsvaS1Ib6yXgCQnQnHQjrFQs4fj1ZAU0u6fCqq7toyV0FqK9kFHoGmiw==@kvack.org X-Gm-Message-State: AOJu0YzAh9or7x36E/yISpteJQAqTLISw1QkEnsAJ4YmrVA3aynWPqWX BSuMr7DyGoLdcBXc2efLZeLKn2y/mGvztDCpxPd5kZ0kYQ7/gdEfsVCjvJ+Xf6k= X-Gm-Gg: ASbGnctCd0GjluBSLjXh04N5ktZVQ7apAoS8p+jq5Zw8psp9QFCJPzl4MXClcy0RNCb JzxlfrA0/LZVKmz7vn75OlflZL8qJ06Rk7gdz3nV2pRmr9wSLM0XyL1Jqb4tv9tLwQYb5sl2zln HnghT1K5gCORf0qq3xiLctmGTyCm25eZPlkBFB9GY8Wq4Td89ewCfeYdplpLN45ftyj5JUGDmIr kZfdWNZc3lp6a55HBffyw9hsete6bLD7Z6HHD/G4SS4aDJ5OK8IPy/mQw/u X-Google-Smtp-Source: AGHT+IHELUnxP9ZvL+e2Ztemz39I9ORoPYZLTVwEa+XG73J5uz7w7yM0cuXu9KZqTaUsGk+1/+jmGA== X-Received: by 2002:a05:6830:6610:b0:716:a95d:9ef with SMTP id 46e09a7af769-721e2e000d6mr4949630a34.2.1736437534534; Thu, 09 Jan 2025 07:45:34 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:9076:47eb:1e0a:16fb]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5f882625f0esm386258eaf.9.2025.01.09.07.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 07:45:34 -0800 (PST) Date: Thu, 9 Jan 2025 09:45:27 -0600 From: Corey Minyard To: Joel Granados Cc: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Kees Cook , Luis Chamberlain , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, codalist@coda.cs.cmu.edu, linux-mm@kvack.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, fsverity@lists.linux.dev, linux-xfs@vger.kernel.org, io-uring@vger.kernel.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable Message-ID: Reply-To: corey@minyard.net References: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 277BB1C0009 X-Stat-Signature: 65yq4eoyu97od95fzaww8i5u4zh9ktdd X-Rspam-User: X-HE-Tag: 1736437536-79339 X-HE-Meta: U2FsdGVkX1+ipw+1uahcqcPdWzbJWYQembSEJRsN+8txUtOjG7m4EJX6LIjLtI35sY4Ij4PLMm+oiYa/zDnrryqNxQmIGPmVP8Zsrqf95XYiu2JgFpQK6d/PAiw1UHC9+ibknqvrgiR07Qnu3CW3xasSZWOyUaJWVDpAcS3kyVxcIxAPQ9DoNofd5OLEiI0555hmZSeWJgsZKCGZr96aJeQZxh/7K8EbLqQaw1/J2HnBTeholp9e/rS2dWqa5OWqKgE7kVuaa0YWuaxIiKSx2yPg4VanuCElr6VMVqXJvMdEOXTG4siyQvVY6jpdCtYcaHkIXa22iSrYGC6rKEDzPVb9RL1X1qmWyVrzb4k2IUVClYwozvzVUafq9mmw9lNp5LvK+CFgRsxsbWdrXO50Q/n9W00Byyk+vEeKHIO5Wep0sD1P0evqaoz5amqVCa5+1aV3kL9C9nj1J4xUr2SCiVzoTttpfNfYMDLoJ5upIs8QnVRj/x06SRqwdah00zUt4JMwObv3lO0sYax28hU2uoi9js0ElEYqiscCZR13T4EkF6cUrEaCIP6O6yH6op051IGyX6H8Gu1iU3Th4EeQ+86nJN4YcQ30ezlBlG2FMAhlZffunFDu/AzazkR59Y02n/8AkaT5c6tEm8jf8bu3ZiZVOBFA8y7snXTlm1fLo2o6HE+WaTSXBEivD6vBQAYXQHZF7DFIYxIGMet57/eUN+u8KPZ7+C3WFRt2s8SVfBExwcUtTONeaem01vdVRCdyIJSbwLx4wKIRCn0lMVba4O2sH3mCunn47PZX4JhhwHwdOX1R6r0WELH6ilnLNFU19EKxlwkiZwGGcLPcH+2xommjkne+PPMXhmr0eSErmxrnVXLUfdsj5YTcQXy+T++kQfPht6uU7w2lg93/vK2knVXghLR+fg9RGUY32hGchoVvLF9t23+2vdEtal6Xs/dfctYQqI2fH5VRgiUT33P LcEJ1+/4 9hUJgnjppPdk+q0IAhjggCmBEb2Z5aZE5BVIywF9cHhr73nWaahhfvg31p5LJl1t1nR5fZVqIcIs60/xeBFfHI/A6cvxckbfbn9NgZWlimvMqu13QkyZRdqQrNaH9IDjJlZ/OvFtiI6yOKwk51Ho3Q/5yESpHjscJHSwzsgCPmN/hZ1GhWWHTTbjuYcGXK8sagb+BFhr1WxSoGAIElletlJBv9bJsuVZPTYnVjmdAW1Ga//SRypQvh31D622zdQTkgpVG5DPkQfmFtt9xD6LZqzKSBKR2qIGlkU6zqFmDGEPILNuGbdsbwyyoXPltzB1H4zAmjBrytOOfDqrOYIpzmUNrXbxVs4fqlfu7RIWMy/+/zxlSCnEprexRx8vYq8RA5iZE/nf7W895LvJCfU1Vuu2LRWKrQ6T2gETjsiJzX3HiLStPh9xg+NNjENa13B59CQjs8OCX7OTMuTA5X92EYAdL/vruDFo0zMxeh5i6wJLqkxS+K15QoYDLR2+rT0QXivYGI8hQGJ4TnD/P8/h+Ff+ROaUHJlk70xR8uEZ6D7GWO/ZIGSIopz/5tLKJ77jZ14CorcKg/II34akwo13JCNgvjp36t7WovDefuz1189lGaFula8fU4lihYea133uhsdPbhhMRhR+wHb8k+1IVDxIMf+gTs2ck0E+H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000209, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. > ... > diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c > index 941d2dcc8c9d..de84f59468a9 100644 > --- a/drivers/char/ipmi/ipmi_poweroff.c > +++ b/drivers/char/ipmi/ipmi_poweroff.c > @@ -650,7 +650,7 @@ static struct ipmi_smi_watcher smi_watcher = { > #ifdef CONFIG_PROC_FS > #include > > -static struct ctl_table ipmi_table[] = { > +static const struct ctl_table ipmi_table[] = { > { .procname = "poweroff_powercycle", > .data = &poweroff_powercycle, > .maxlen = sizeof(poweroff_powercycle), For the IPMI portion: Acked-by: Corey Minyard