From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894CAE77197 for ; Thu, 9 Jan 2025 13:40:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC3F16B0088; Thu, 9 Jan 2025 08:40:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4CEF6B0089; Thu, 9 Jan 2025 08:40:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B14A86B008A; Thu, 9 Jan 2025 08:40:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 935936B0088 for ; Thu, 9 Jan 2025 08:40:55 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 05F0E1A19F9 for ; Thu, 9 Jan 2025 13:40:55 +0000 (UTC) X-FDA: 82988024070.16.882106A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 16F20160016 for ; Thu, 9 Jan 2025 13:40:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XoFnguaQ; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736430053; a=rsa-sha256; cv=none; b=03uN2kml3TEHkvf2jbFatU2fd0xUFP3fUV5hbYg4cw3jkP1+93J5uU/NmzyBPXfljny9su MQFguolkcQNOnp1AsxagiF67q81vWINZoi6r7tw/VKWWSTXN+fJH1O22KGOoZVSJZPkmUK /lL20bmj4bvRIofFoRjJf/maDK6DYo8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XoFnguaQ; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736430053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ONkHYJbSiJ+lgRj5oCXMcej9oxZjVhTQh5GSrqSFnw=; b=KA1BWtEC2x1K7YUmXsSti2T/sDMHi4WH3rKu5ornqSeDJCQf7Fhro48X2ZlTvY3K5tRfig hRAyWd8QJ8CrGL7AMCVHTMRtn8te2EwPpfOiorQrdm5RR0ajtjXwvpHNf87noTXpkFL83f JfVxfZqMzEp8CikwB6sNOpEtgSA5WtY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5ONkHYJbSiJ+lgRj5oCXMcej9oxZjVhTQh5GSrqSFnw=; b=XoFnguaQScdeB+y2eXOvayZbDn PmjUfRVQwoTcFKu9G9azrG5d6QlGTjUUcs6i6seWo8n4R1POuiTkgwqdw+GPX2i+Yca6BRmQuJiB8 c2gUHAWJ09qxpq7Z4zh7LuNiB4W8PzfeNkLzuvA93xWUE+Ksr09XdxzQThn7Mm+rI0RpUaH6qvfkh sKhuy8x8Y/g4BR25cyWGi2BErEdZpKz+Cx4O6tJz4WIsEp1QHdt+GR+VVqCDAnTmYrUGAIawJ8yVx F06s3P52+yncPhtD39ihAzQxjtgo4f9e12DHPBcK6CvFYMOMhKZlUTEMNMGecsMGgK/E6XAyRJooU 8dJqM0qw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tVsmA-00000006DJJ-2aan; Thu, 09 Jan 2025 13:40:42 +0000 Date: Thu, 9 Jan 2025 13:40:42 +0000 From: Matthew Wilcox To: Liu Shixin Cc: Andrew Morton , Chengming Zhou , Kefeng Wang , Nanyong Sun , Muchun Song , Qi Zheng , Johannes Weiner , Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: khugepaged: fix call hpage_collapse_scan_file() for anonymous vma Message-ID: References: <20250109070059.369257-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250109070059.369257-1-liushixin2@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 16F20160016 X-Stat-Signature: hu7z3jkjwrt9b37qiafn33j3x7ggf6z8 X-HE-Tag: 1736430052-76136 X-HE-Meta: U2FsdGVkX1+H5Od1KhwTsBJ0TgQhZs636Z+Pjmq1HIfGH3bKINWb0+sghgIaVWxNryNqxAzPEVO7JIxG2gBiFSB5rvCj4U49Fn5nK+USaIrsDVG2Tpq7dzoRdlo5XczTpiLErJKQTKdjHMrZkHJY6mJbmyajds+zk3HEw1eU3x8cyE5wtciMELCTvEoNP3//axypmDj3q8tqPWIQb1czKJK7XvDwIvN0wzWnl+MN5Cu8zpKFzKRLq2cpDSz0lTuWmTjmRBoJ9pzykDnI8HwcgFN4cydmj/A7U9Xac8ckmZAw548i5ApXIDakQPvi2LA14aEC/LqY1tRysT8JgioK6fK8c35D9uZm9vhF+4hnxZ4EJcxHx7ZYwpwQ/Na6pV3GnldVg5ovDHjBPpKn9r2eVUO5VhxPcIE4nVqOupxw30klVVqch7Nwf8zUk3aUfAkzYosiZpZdA4DBCA+oOwdoKkIa5SWFBZPYiT10xUGTgOXzjk3kxbx1Ex8+xu45TSWYGvW566Ea9H6JkZLNaHkXVugZ+TJ9xOM2zDSQCgdI30Z9PFBQvniAbVn4PcwVd5Qh1s/pvX+CAhCDlUnJIAaqNQNgWgLqeRg9QaYQpjgzQEVJmfOlGNaYU/t8N8LF/l+e6Ti3C2fVbBfpZInk2pYejqcRPkz8wJc8ALTo+MwFyzhO52OkUsxRPMoBuqeLWcAQvJ7CyLTEjcfwTb0j2SgMyR6cR29OxXFAe8cbrZmwQwleASPF2N2yufMbNydyLRrlk7XPe4zqSQ/3IzWCcAqxHm7KIxuWSl9TYMeI33GulutdblesSQnRg8OOFceRTSThNW1r7EdYjPcZtOwO/JqUa24F2v62hZ0A47Xg2ExtWK+Tu3uT6fE2FQ5qjxdldAf/73FKsJg8rEE+C5P8zGOS5U0SktfKH6IoV9yJ0Yrm87Yl2gigpjM+m6qFp0CRBFCBujdZMcFHPbCTaL5WGkX QvKVGA2z A1uVf6/+sTb8Yp3oMO+6bdnS5cGiw7q0emdsnIYa+CgBsumKyZz83BYrN0zKBKYgR7RQtmaBcG31xbh5i58WwGaCnpV1cUIZb8Z192Rb7GTatME8/udVdueWok6y9uEV41U665DNS9ISH6iVLBxroV+gQTlc29RCtZwZ6A9Vb5y6Ihimr0P6jPeGUs7GqFoqwsCVPrSgG1GL8WlECddriiEEeDV9Xw9n7ZrzP9pkDFcYdFUKoC2Ia+KAjEgi3pcOBVyVGOVzNz4WzzZycNGfkjZaJRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 09, 2025 at 03:00:59PM +0800, Liu Shixin wrote: > Add vma_is_anonymous() check to make such vma be processed by > hpage_collapse_scan_pmd(). Wouldn't it be better to replace the vm_file check with vma_is_anonymous()? ie: > - if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file) { > + if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file && > + !vma_is_anonymous(vma)) { + if (IS_ENABLED(CONFIG_SHMEM) && + !vma_is_anonymous(vma)) {