From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A35EE77188 for ; Tue, 31 Dec 2024 12:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66A626B007B; Tue, 31 Dec 2024 07:04:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61A9C6B0082; Tue, 31 Dec 2024 07:04:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E1236B0083; Tue, 31 Dec 2024 07:04:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 32D516B007B for ; Tue, 31 Dec 2024 07:04:02 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E6B35AFE2E for ; Tue, 31 Dec 2024 12:04:01 +0000 (UTC) X-FDA: 82955118288.03.67DC0B7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 8C396180017 for ; Tue, 31 Dec 2024 12:03:26 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735646608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dRrPaPk5lPHuhjc33AhYt7NP7EQjSMlwbhALT9nPHSw=; b=zMKzUhuqmlqirl2fyCs9i7BgfPEafgX6iiI1e94lqwjR1YjkPHBGiQp41fDRMNsfvhe0y+ c4Qub0AJ+8sOu/a38/uozgaO2VIRpmHK7J6wL/yUAxDvt33jkjytZk9N+6JS/FOYpQGZYq O+DjQMn/Sv+8lvAhAdve1PJo7Gx/BsY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735646608; a=rsa-sha256; cv=none; b=7ITXwI3pxDxxONqx/qgpvTeZMJOvY9Hg2vcfrq12LKsFl2Yi+dbO2i/KTawA7yHMIqyE0M iPWDyFg1EJPZ2VVoFs+XbpBhjhlfP/ajIjsBxt0GZkYOBH4fG452VJJaCv5c2sGsBZS32i kRrPTdvipH606lUtluy0BKSLXIJGbA4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C48DB5C5B64; Tue, 31 Dec 2024 12:03:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC320C4CED2; Tue, 31 Dec 2024 12:03:57 +0000 (UTC) Date: Tue, 31 Dec 2024 12:03:55 +0000 From: Catalin Marinas To: Uros Bizjak Cc: Guo Weikang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/kmemleak: Fix percpu memory leak detection failure Message-ID: References: <20241227092311.3572500-1-guoweikang.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8C396180017 X-Stat-Signature: tfdtkhkcmcme8w6irjpmxyps7yy7qe3d X-Rspam-User: X-HE-Tag: 1735646606-358578 X-HE-Meta: U2FsdGVkX1++wwUr4xPENlc5nCoLTUZZmNxvhhI+j9hOwhn3UHAKxqwYn249gXa+hDDvUWgnrvNz8XjmhOWPjGwoFpdFnQZlE46BVtmjITpYvhf7sk40V+8Ez9Az58W7YmZqshT//y4qFJHfTa9eWOeXir7mPfgMt7d7r7PYMjkirGPHMBsWo9SQEX/XNH0nhcxoMdMTwmkldmfH8rm017BikJmg0dhYL4EofN5taIjS/TIBpVks0tvJLR20qOPtGT95cT3FLmaOmqAlPe+hcWvh7xHaSyyTg0+ENLq4paq2O7IK2NWEtN/OkcQGTHmswN8rV7RMO1iC4olk3yoG6SdOJS17uE5SEc5s1kkQp7vVB5ZcSNuP8fQ7+XDQJuwbs7FA4B5sKeWrKn8PfHWm1tE+B4/xQdxJ281MO3VEj6U+nXY55sxL5Qq2oW41IppbLZQnZsCUb0jdbpdVwwjMdFUtSS0cguvHOLsqE37ByecZvm1jYteMj5ZBQiGjP+X5BRGPUrC36zSI+AsZMQ8hBCbvH1B5RBVePXsbqyPtx7NBi/PaB2x2oJF/6t1N8fkBmRcxAl9H8o/lufKKlaSiuUem9yDIROz5YpzlhQXQIGcMWDpLFqzxQgTfLj5bGGzmRIhyEaWIbQezmeo2Z8XmwLPe6FGpvbvOgGrSmhzDX1pTJn3Ryi+ek6xfcVLYPuRt6enEtErlBlNT/v5uktl+V0MPh7J24aBoHzz2vHStHPzOdsJyLisfWEMjzaYKhg8x9UB57f/puUCv/7/bjOEKQdOo/NVe0iMMDoHBxpq04FMHXGxYYeEsiRYkvlZqzASZfk1+JDXy5/8q7TtgIrV/ug+TEbRMRn+bW7Nhfrz+TTfzUMDiruVeervcemeyfcFJKAjGglFwMrxlBCo6hsf6hfc0U9SE8o2wcmGiYFW40Q58jDT7MinnhE/rmyDqWl7kwB3bpuuhz11jDis0M43 UVhIR/xA LX2p5FUTCNashUVoyXnY0Oq1SyNgiTSz75zrLhA2CQ2mgcXLAackN8+MivY+f9fxDtC4HH3R3uCeH2QHPFLBJamHxlLqepzPi/OxEAViTXCxlPvcEEAwmTcIsjNJ9N/SzAAV5SS7LYO8dlwZq8lzpC63YaiInUGtOjaC28gd44UshTzFeFVAF9KjdgaXTU/BHJkVgo5NYwbBRuiilWA3ChagIrRBbLnUxfjv8RXyfIx2D/vZggG9QbAEsK/BboNWZW268q3tsA2RG4aUS4DZqGsyixXPC4jDUpmAn7FQtrJMT9YKo7WVKyABno2gA4CHwHq1YHE9SFDzyh6HgaieboVomeye6dq4V1ZQi2geQojLts00roLKVHg8ZsNRhKHh/9CxMvPCrsEywlPZTnSRbqcarFVQfcY/cAQ4Bl4osDvu64DyV5E+Ft6EUpX+VWiI4xnsnxsbJzYoe6ofwE2W8KB78qK7Mf636rSwm/XsgYZGDqYo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 11:42:49AM +0100, Uros Bizjak wrote: > On Fri, Dec 27, 2024 at 11:37 AM Uros Bizjak wrote: > > On Fri, Dec 27, 2024 at 10:23 AM Guo Weikang > > wrote: > > > kmemleak_alloc_percpu gives an incorrect min_count parameter, causing > > > percpu memory to be considered a gray object. > > > > > > Fixes: 8c8685928910 ("mm/kmemleak: use IS_ERR_PCPU() for pointer in the percpu address space") > > > > > > Signed-off-by: Guo Weikang > > > > I don't know how 1 turned to 0, the change was definitely unintended. > > Looking at the original patch at [1], it looks like a mismerge to me. > > [1] https://lore.kernel.org/all/20240818210235.33481-2-ubizjak@gmail.com/T/#u About the same time we had commit 6c99d4eb7c5e ("kmemleak: enable tracking for percpu pointers") increasing min_count to 1 but in the merge this got lost. -- Catalin