From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73B2E7718F for ; Mon, 30 Dec 2024 18:04:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 710D66B0096; Mon, 30 Dec 2024 13:04:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C05F6B00A7; Mon, 30 Dec 2024 13:04:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53A5B6B00A9; Mon, 30 Dec 2024 13:04:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2C64C6B0096 for ; Mon, 30 Dec 2024 13:04:57 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C3C001C8E55 for ; Mon, 30 Dec 2024 18:04:56 +0000 (UTC) X-FDA: 82952400468.11.B798376 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf24.hostedemail.com (Postfix) with ESMTP id 2C4D4180007 for ; Mon, 30 Dec 2024 18:04:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CD6Bac+q; spf=pass (imf24.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735581873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qZZjmsalVy1RPu6DllD+AWXD+L5TOKhLMe2mP/FDXyQ=; b=rWdcjDg8F26D+AncvtW5ZuLM+KBEHIVhawoXAc17K84p7VspwuN4WxTV7ct8c/f8h8k7KT Yq4UemSkd7abxIfOfLEqYIiDP0bvB8vsStoz48Bx2yg+QtLi/ZSjRLvvgjug54aEFr0XR8 9vYHLkTQLzcIaVLi3M5FTlPaxzWgqBo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CD6Bac+q; spf=pass (imf24.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735581873; a=rsa-sha256; cv=none; b=GcuWAcADpKbBe7uBnMetdvmijHw99RzsL2vMesoEwE5IiuYeApWa8XBh3gphPvqwnYf5NR GVPFsuNN0W5EjtyQ6N1ei2qhCoQ7oTUpnVl5NBiRTDI8T/SKYGQoQTrIseBJUoQbLlgClq NWj9WV/23CXgEQlxn8p/KDN+eO8DdU4= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4678cce3d60so94306031cf.2 for ; Mon, 30 Dec 2024 10:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735581893; x=1736186693; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=qZZjmsalVy1RPu6DllD+AWXD+L5TOKhLMe2mP/FDXyQ=; b=CD6Bac+qlmTRYPwUM35xqYN4j2FsxFluiuoMjyOi+ZgnP0JvqYYrCPMj3uHCigJEpZ T//jqeXdYCI+Uk7evE2ZTU7sVyTdahtUSXMDdH5yGfwfWOz5okIdwTC66upPtgb20Hmf 0+rLWuY1+rWy7yNjSeRCReobWmYLmHOXaKjyvYtEjpi7cATPhk2csHhCB9qAEZrxHEb9 ZWgsHTvCTmpIvnGmAd2l9C+ztFhypMzLwwaV/Eb0TDt4y3upQYiWGXEDUAxsoemzmJmh h+YyZNBZMea5t0/1Nk8xM9HJyU7/wLye4j/vIWYTxVzNbBKVnka+Y9f98rBbSGF3E/9S 5yNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735581893; x=1736186693; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qZZjmsalVy1RPu6DllD+AWXD+L5TOKhLMe2mP/FDXyQ=; b=rUrZMyqFqI3xICaJLaojCn/jzYzwVhYumbd2v0EVGWWg+VV0xdUlTseRH2EZVqt+bA Bn8K0XzaeB7U55qfwQiHmIafGylZAEhy7YI3WlBYj2g/BVgurmUvTdY+XVfELtDlS64V O3XOnltkZzI3f3ln61xOobc5lA7R7yxcX2q0eEo3stfRXaQfvZjLPnMh11Zu6+0loLYD nStjGH0thz83KNW7SSdexbMBa/+U+iAHz0TwkSmTazwm3IP2CDnbI2knv8NH7FDplsuN e/vNUd6wcQ84T72qbsvp3uyDRSnH26tkDGdj3/lXxhzotlW5E4gLCVykeCtcq6VmTjVl q3wA== X-Forwarded-Encrypted: i=1; AJvYcCV1xFd1In9o4PY6mkHC6fYwu/T/ZAQDe3ZwtbIOF85A0CRV+ieLQDDr3bte8/WEvPE/IaNhFeUV/Q==@kvack.org X-Gm-Message-State: AOJu0YytvfIPU16IMwnK5vOSv4hGdow/OBXSHBtw6qsMtsfupcmyLtPv uNcCi4cH6iqhlmmx+a+BrBlLNCT7oOheZ7WdhfWp9zn18fii3XQz X-Gm-Gg: ASbGnctlw0QikO1DRKBj4MwdpUdBLkrNfwG64rm/6LZFaM6bJQ6pE5UmL+1dM9rwghF VLGbE7eSS6NRRzvAceMyG22kgwx6qav2dr04wC0Vl20QOBFdHc7OkETVfSQcn6m8vJf2BtkHtyC QiDFjFv3xX/RRnD0A+MMVyC5Cm6XX+BDTiCCSiWCArj2vmbsiWVlfc/iCNF3dvU8MD8AQ6H7yG3 OnlLdOR3699lrd4Q832hOJEnJYyjdt3b2VyKoKoK9TEi41lRtT2vNrpQiV7nosaUzffrtqXxJrw LBVCuCzspH1hSDvDunz04QfCFuZcZb6R9CXXIyK9V+iEjKw= X-Google-Smtp-Source: AGHT+IGCjIy5qUIaKORT2M+UmBqDr9D8WZDmYhRSUDwGsA9UITEoBHRupHOwbInP1NRFChibVP9RRw== X-Received: by 2002:ac8:7d52:0:b0:467:5eaf:7d1f with SMTP id d75a77b69052e-46a4a9c8aaemr520203711cf.50.1735581893093; Mon, 30 Dec 2024 10:04:53 -0800 (PST) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3e676f26sm107495471cf.19.2024.12.30.10.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 10:04:52 -0800 (PST) Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfauth.phl.internal (Postfix) with ESMTP id 33D171200080; Mon, 30 Dec 2024 13:04:52 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Mon, 30 Dec 2024 13:04:52 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddviedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenogfuuhhsphgvtghtffhomhgrihhnucdlgeelmdenucfjughr peffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepuehoqhhunhcuhf gvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtthgv rhhnpeeileffheeiheejueelveegleeghffgtefhueelvdduuefhiefggfeuiedugfetud enucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdhshiiikhgrlhhlvghrrdgrphhpshhp ohhtrdgtohhmpdhgohhoghhlvggrphhishdrtghomhdpghhoohdrghhlnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhm thhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvd dqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgvpdhn sggprhgtphhtthhopeelpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsuhhrvg hnsgesghhoohhglhgvrdgtohhmpdhrtghpthhtohephhgurghnthhonhesshhinhgrrdgt ohhmpdhrtghpthhtohepshihiigsohhtodduudejtddukeefkeguugegvdegvdekrggsje gsfeesshihiihkrghllhgvrhdrrghpphhsphhothhmrghilhdrtghomhdprhgtphhtthho pehpvghnghhuihhnqdhkvghrnhgvlhesihdqlhhovhgvrdhsrghkuhhrrgdrnhgvrdhjph dprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohep lhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoh eplhhinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthhtohepshihiihkrghllhgv rhdqsghughhssehgohhoghhlvghgrhhouhhpshdrtghomhdprhgtphhtthhopegsohhquh hnsehfihigmhgvrdhnrghmvg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 Dec 2024 13:04:51 -0500 (EST) Date: Mon, 30 Dec 2024 10:04:20 -0800 From: Boqun Feng To: Suren Baghdasaryan Cc: Hillf Danton , syzbot , Tetsuo Handa , edumazet@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] possible deadlock in vm_insert_page Message-ID: References: <676ea4aa.050a0220.2f3838.0483.GAE@google.com> <20241228001926.517-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 2C4D4180007 X-Stat-Signature: j4w1mq9mchuny6ehczobugopwdpbocdx X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1735581888-775246 X-HE-Meta: U2FsdGVkX19txuJJHrZdmULly5V0fpVBVubnJX66gSGyb86XwMOrvyTeL7pJJnvCnE2J9Ym2cDJ2dEkHOrytfk5ftACf245Lk6w09EECkr01ZzcpZ30sIh6BzJfmusJd3ZGh+Jhs3GoJX/SB99i5Uga58+mwSly0jmGHn5EQPpXuUJJJwQk7bTkdf2WCu9e+taq5PTbX1AegymvzTYuKUgh3TQ+EvRp7RUqfdX7XrlSLXYywoMptSVUEaS4syrEJ8ZsajIfrepnV4WJtglP8PkS+X0RFX06exAb9vyv0xJCpiH5xtlAkOx/NBHSpOMrTzMtFPxyCvHamHH/AmyFkxnddsQGbhKq8peunEXUVMn+sJUfO+/26w1F8TiweiHa88yqF2L3NdeYgcPDzC9X1MniVXsGksCWoSYQYwMXfPaEYPVG9awW5Rfm9EQtFizNXWCwOaFz+mLBxsmmO3VulSjyKrfaybne6xEX8XVioC9i/2dvOplfG480F1+uX79A24wF1Q0BtNl2eskzFcha1hpfWIsANanu4pHh8VZ57UcS3QcaH9r/beJnx324M9ABfph3doOBcCqW7RuQRi8hovycZXyqm7jpqzOxgr7Xwv+Tr791beLw3MPa8Oq47CsXWBKdJnadcORhCyhEuHls9CxAyrDT/nRwZV+mtPMTdc8DudwyT3JJHvuU0Qrfm9nwGAyBAoytudE2h11wNxrZ8p+wKCjsFa/ZJLAzTE3Ji0N5AJVOhCnmtVfqsQ+WQ14LiBxHLFjaPmGx1uvXwXAC3bVTRturWg7JQrpW9XmIPXB7AiGeacXcsucikdmNngx9M1lVbfcASmJRM/W521N91K4EOJSUHA8MzFJilBd7Y5NJ7k/Wub4FTsejvoyyP1csPH4vdnXgCdpYqJjuh+yweyAEBcKOFbS5pXs4gvuJIRuZCu+dzS68/UqTMIFK4kvtsQyhkvcBO+c4MwS4Kn5r D9fUe4+J mUJ9ae/GmebCtqWHNi1m5NaL0uu87IpRGDz0wSSpE2IgjzlEtT/jfGLvQDNwwfROgr1xSOs8tV4Hta7N+R7VOlhldaAtnU5oCqcdsgPBYZzesXOQi9WbjCiSF1xCkTnhtyXw5N0raE0hk0BjBQ80vnMfhnp+6tuxGjyEeVI4J1clFd2AKrptKuO1b3Bc8Jug1RDM9euZ4jh0b/UUWao4Le2YYtVIiFb/3508VymUc5wiCJKAx0AafNWhd8oaByayU5NLWh5PFNKc0LiDJScU74ynKeHL4VrNTeqqpBOKDuDXhva4Gg9mrcYyclx6uvZ9tyGehYPLdjTAGRz6cb7bFv/8iMie9tHlNSlj5G01612qFeRIDBgf8FM9cX8YcJWwDHUKuLagj8NBQDXcRi5BJHOHG+V5HH+cVRgq0cazfvYN3CD7/I/nwT9xs18LQIC3LxPoC5SRVp1nYCLl/9nXIScLs505kHM+2+wJW2NTzOyPLNYPvp/Cv4IDXTj8tPd7QwvfhXLcXuOQpRh/e1Fd4YdeBAEx0uHMcfdpWKdJZkLfGwzz9ZetSlECerkGgt3RlhnW7sD3oVeZPbJlgT4rJbq0jzFk+WZkYryCHx1Umhc6qR86yNDSi1bqJ1L1tzGWXAYh7daBAu0Gg39kYYCz2iFtq+FgXoG7oqL4SK6HQEicNwdpH06cpqyVje4VZcsSh6Ko+PXkQ7ArJ7uIyKsbd2O9AwJJpgKRVJJuS61kXZPCmVPXegB2obFkMF7SE2JVqJMrYhR+jYfuoGUagnzTwaRogwqPWFs61m7KxBVa04eDpRi6FJHR60gQBZ1GaKpaGPZz8cUKr3WjTJGQ0h+mWawSXkk8ll3OGTjIQHrF6rC2zW/8jF8x1x6HNegK0wn5S2tl5uRZglqMRByZ0AARyEelIZ1RE0be+UhNli4U1A586HkfkEYoUdUMn4NnT8KR0rYIT4LZGa2beFCfhX+ArgCqZmL0e H79mMVlo YVgDXveEQA4ggRBtLzBgH3VitPXSf4Di9pYjhKUnTPN2gWpHylVdLPkqHs9EaJxBoMKk+vaVyqqZnId9Ch6237/QjDEykvjKD3lYKJ1afptprCZhQ/oh0AttZ3ICOS43ejPkS5fEyxGGn8xpptLKQnYRa6jeKxVkVmkwHy+ueulviKz/KHVVcjpXcGbciMhcAtricK0ZKmdrDBfWw7j9Ip2zO/Zv+BusqB43Qf81vgOugfICRpwrJto+n6u4DoXtl61+0HUnl5M66rYc7qDffexb362bFZezpVr4slu73lI/sNqte62lRIQx8Cx0FExPF9fkiIm+Yf4UaHMmsw3M5RVAVSeJ2tJDdIjQCNogJ4rnRWg9FwqNkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 09:21:32AM -0800, Suren Baghdasaryan wrote: > On Sat, Dec 28, 2024 at 1:52 AM Boqun Feng wrote: > > > > On Fri, Dec 27, 2024 at 06:03:45PM -0800, Suren Baghdasaryan wrote: > > > On Fri, Dec 27, 2024 at 4:19 PM Hillf Danton wrote: > > > > > > > > On Fri, 27 Dec 2024 04:59:22 -0800 > > > > > Hello, > > > > > > > > > > syzbot found the following issue on: > > > > > > > > > > HEAD commit: 573067a5a685 Merge branch 'for-next/core' into for-kernelci > > > > > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=149fdfe8580000 > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=cd7202b56d469648 > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=11701838dd42428ab7b3 > > > > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > > > > > userspace arch: arm64 > > > > > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > > > > > Downloadable assets: > > > > > disk image: https://storage.googleapis.com/syzbot-assets/9d3b5c855aa0/disk-573067a5.raw.xz > > > > > vmlinux: https://storage.googleapis.com/syzbot-assets/0c06fc1ead83/vmlinux-573067a5.xz > > > > > kernel image: https://storage.googleapis.com/syzbot-assets/3390e59b9e4b/Image-573067a5.gz.xz > > > > > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > > > Reported-by: syzbot+11701838dd42428ab7b3@syzkaller.appspotmail.com > > > > > > > > > > ====================================================== > > > > > WARNING: possible circular locking dependency detected > > > > > 6.13.0-rc3-syzkaller-g573067a5a685 #0 Not tainted > > > > > ------------------------------------------------------ > > > > > syz.8.396/8273 is trying to acquire lock: > > > > > ffff0000d0caa9b8 (&vma->vm_lock->lock){++++}-{4:4}, at: vma_start_write include/linux/mm.h:769 [inline] > > > > > ffff0000d0caa9b8 (&vma->vm_lock->lock){++++}-{4:4}, at: vm_flags_set include/linux/mm.h:899 [inline] > > > > > ffff0000d0caa9b8 (&vma->vm_lock->lock){++++}-{4:4}, at: vm_insert_page+0x2a0/0xab0 mm/memory.c:2241 > > > > > > > > > > but task is already holding lock: > > > > > ffff0000d4aa2868 (&po->pg_vec_lock){+.+.}-{4:4}, at: packet_mmap+0x9c/0x4c8 net/packet/af_packet.c:4650 > > > > > > > > > > which lock already depends on the new lock. > > > > > > > > > > > > > > > the existing dependency chain (in reverse order) is: > > > > > > > > > > -> #10 (&po->pg_vec_lock){+.+.}-{4:4}: > > > > > __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585 > > > > > __mutex_lock kernel/locking/mutex.c:735 [inline] > > > > > mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787 > > > > > packet_mmap+0x9c/0x4c8 net/packet/af_packet.c:4650 > > > > > sock_mmap+0x90/0xa8 net/socket.c:1403 > > > > > call_mmap include/linux/fs.h:2183 [inline] > > > > > mmap_file mm/internal.h:124 [inline] > > > > > __mmap_new_file_vma mm/vma.c:2291 [inline] > > > > > __mmap_new_vma mm/vma.c:2355 [inline] > > > > > __mmap_region+0x1854/0x2180 mm/vma.c:2456 > > > > > mmap_region+0x1f4/0x370 mm/mmap.c:1348 > > > > > do_mmap+0x8b0/0xfd0 mm/mmap.c:496 > > > > > vm_mmap_pgoff+0x1a0/0x38c mm/util.c:580 > > > > > ksys_mmap_pgoff+0x3a4/0x5c8 mm/mmap.c:542 > > > > > __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline] > > > > > __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline] > > > > > __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21 > > > > > __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] > > > > > invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 > > > > > el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 > > > > > do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 > > > > > el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 > > > > > el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > -> #9 (&mm->mmap_lock){++++}-{4:4}: > > > > > __might_fault+0xc4/0x124 mm/memory.c:6751 > > > > > drm_mode_object_get_properties+0x208/0x540 drivers/gpu/drm/drm_mode_object.c:407 > > > > > drm_mode_obj_get_properties_ioctl+0x2bc/0x4fc drivers/gpu/drm/drm_mode_object.c:459 > > > > > drm_ioctl_kernel+0x26c/0x368 drivers/gpu/drm/drm_ioctl.c:796 > > > > > drm_ioctl+0x624/0xb14 drivers/gpu/drm/drm_ioctl.c:893 > > > > > vfs_ioctl fs/ioctl.c:51 [inline] > > > > > __do_sys_ioctl fs/ioctl.c:906 [inline] > > > > > __se_sys_ioctl fs/ioctl.c:892 [inline] > > > > > __arm64_sys_ioctl+0x14c/0x1cc fs/ioctl.c:892 > > > > > __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] > > > > > invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 > > > > > el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 > > > > > do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 > > > > > el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 > > > > > el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > -> #8 (crtc_ww_class_mutex){+.+.}-{4:4}: > > > > > ww_acquire_init include/linux/ww_mutex.h:162 [inline] > > > > > drm_modeset_acquire_init+0x1e4/0x384 drivers/gpu/drm/drm_modeset_lock.c:250 > > > > > drmm_mode_config_init+0xb98/0x130c drivers/gpu/drm/drm_mode_config.c:453 > > > > > vkms_modeset_init drivers/gpu/drm/vkms/vkms_drv.c:158 [inline] > > > > > vkms_create drivers/gpu/drm/vkms/vkms_drv.c:219 [inline] > > > > > vkms_init+0x2fc/0x600 drivers/gpu/drm/vkms/vkms_drv.c:256 > > > > > do_one_initcall+0x254/0x9f8 init/main.c:1266 > > > > > do_initcall_level+0x154/0x214 init/main.c:1328 > > > > > do_initcalls+0x58/0xac init/main.c:1344 > > > > > do_basic_setup+0x8c/0xa0 init/main.c:1363 > > > > > kernel_init_freeable+0x324/0x478 init/main.c:1577 > > > > > kernel_init+0x24/0x2a0 init/main.c:1466 > > > > > ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862 > > > > > > > > > > -> #7 (crtc_ww_class_acquire){+.+.}-{0:0}: > > > > > ww_acquire_init include/linux/ww_mutex.h:161 [inline] > > > > > drm_modeset_acquire_init+0x1c4/0x384 drivers/gpu/drm/drm_modeset_lock.c:250 > > > > > drm_client_modeset_commit_atomic+0xd8/0x724 drivers/gpu/drm/drm_client_modeset.c:1009 > > > > > drm_client_modeset_commit_locked+0xd0/0x4a8 drivers/gpu/drm/drm_client_modeset.c:1173 > > > > > drm_client_modeset_commit+0x50/0x7c drivers/gpu/drm/drm_client_modeset.c:1199 > > > > > __drm_fb_helper_restore_fbdev_mode_unlocked+0xd4/0x178 drivers/gpu/drm/drm_fb_helper.c:237 > > > > > drm_fb_helper_set_par+0xc4/0x110 drivers/gpu/drm/drm_fb_helper.c:1351 > > > > > fbcon_init+0xf34/0x1eb8 drivers/video/fbdev/core/fbcon.c:1113 > > > > > visual_init+0x27c/0x548 drivers/tty/vt/vt.c:1011 > > > > > do_bind_con_driver+0x7dc/0xe04 drivers/tty/vt/vt.c:3833 > > > > > do_take_over_console+0x4ac/0x5f0 drivers/tty/vt/vt.c:4399 > > > > > do_fbcon_takeover+0x158/0x260 drivers/video/fbdev/core/fbcon.c:549 > > > > > do_fb_registered drivers/video/fbdev/core/fbcon.c:2988 [inline] > > > > > fbcon_fb_registered+0x370/0x4ec drivers/video/fbdev/core/fbcon.c:3008 > > > > > do_register_framebuffer drivers/video/fbdev/core/fbmem.c:449 [inline] > > > > > register_framebuffer+0x470/0x610 drivers/video/fbdev/core/fbmem.c:515 > > > > > __drm_fb_helper_initial_config_and_unlock+0x137c/0x1910 drivers/gpu/drm/drm_fb_helper.c:1841 > > > > > drm_fb_helper_initial_config+0x48/0x64 drivers/gpu/drm/drm_fb_helper.c:1906 > > > > > drm_fbdev_client_hotplug+0x158/0x22c drivers/gpu/drm/drm_fbdev_client.c:51 > > > > > drm_client_register+0x144/0x1e0 drivers/gpu/drm/drm_client.c:140 > > > > > drm_fbdev_client_setup+0x1a4/0x39c drivers/gpu/drm/drm_fbdev_client.c:158 > > > > > drm_client_setup+0x28/0x9c drivers/gpu/drm/drm_client_setup.c:29 > > > > > vkms_create drivers/gpu/drm/vkms/vkms_drv.c:230 [inline] > > > > > vkms_init+0x4f0/0x600 drivers/gpu/drm/vkms/vkms_drv.c:256 > > > > > do_one_initcall+0x254/0x9f8 init/main.c:1266 > > > > > do_initcall_level+0x154/0x214 init/main.c:1328 > > > > > do_initcalls+0x58/0xac init/main.c:1344 > > > > > do_basic_setup+0x8c/0xa0 init/main.c:1363 > > > > > kernel_init_freeable+0x324/0x478 init/main.c:1577 > > > > > kernel_init+0x24/0x2a0 init/main.c:1466 > > > > > ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862 > > > > > > > > > > -> #6 (&client->modeset_mutex){+.+.}-{4:4}: > > > > > __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585 > > > > > __mutex_lock kernel/locking/mutex.c:735 [inline] > > > > > mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787 > > > > > drm_client_modeset_probe+0x304/0x3f64 drivers/gpu/drm/drm_client_modeset.c:834 > > > > > __drm_fb_helper_initial_config_and_unlock+0x104/0x1910 drivers/gpu/drm/drm_fb_helper.c:1818 > > > > > drm_fb_helper_initial_config+0x48/0x64 drivers/gpu/drm/drm_fb_helper.c:1906 > > > > > drm_fbdev_client_hotplug+0x158/0x22c drivers/gpu/drm/drm_fbdev_client.c:51 > > > > > drm_client_register+0x144/0x1e0 drivers/gpu/drm/drm_client.c:140 > > > > > drm_fbdev_client_setup+0x1a4/0x39c drivers/gpu/drm/drm_fbdev_client.c:158 > > > > > drm_client_setup+0x28/0x9c drivers/gpu/drm/drm_client_setup.c:29 > > > > > vkms_create drivers/gpu/drm/vkms/vkms_drv.c:230 [inline] > > > > > vkms_init+0x4f0/0x600 drivers/gpu/drm/vkms/vkms_drv.c:256 > > > > > do_one_initcall+0x254/0x9f8 init/main.c:1266 > > > > > do_initcall_level+0x154/0x214 init/main.c:1328 > > > > > do_initcalls+0x58/0xac init/main.c:1344 > > > > > do_basic_setup+0x8c/0xa0 init/main.c:1363 > > > > > kernel_init_freeable+0x324/0x478 init/main.c:1577 > > > > > kernel_init+0x24/0x2a0 init/main.c:1466 > > > > > ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862 > > > > > > > > > > -> #5 (&helper->lock){+.+.}-{4:4}: > > > > > __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585 > > > > > __mutex_lock kernel/locking/mutex.c:735 [inline] > > > > > mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787 > > > > > __drm_fb_helper_restore_fbdev_mode_unlocked+0xb4/0x178 drivers/gpu/drm/drm_fb_helper.c:228 > > > > > drm_fb_helper_set_par+0xc4/0x110 drivers/gpu/drm/drm_fb_helper.c:1351 > > > > > fbcon_init+0xf34/0x1eb8 drivers/video/fbdev/core/fbcon.c:1113 > > > > > visual_init+0x27c/0x548 drivers/tty/vt/vt.c:1011 > > > > > do_bind_con_driver+0x7dc/0xe04 drivers/tty/vt/vt.c:3833 > > > > > do_take_over_console+0x4ac/0x5f0 drivers/tty/vt/vt.c:4399 > > > > > do_fbcon_takeover+0x158/0x260 drivers/video/fbdev/core/fbcon.c:549 > > > > > do_fb_registered drivers/video/fbdev/core/fbcon.c:2988 [inline] > > > > > fbcon_fb_registered+0x370/0x4ec drivers/video/fbdev/core/fbcon.c:3008 > > > > > do_register_framebuffer drivers/video/fbdev/core/fbmem.c:449 [inline] > > > > > register_framebuffer+0x470/0x610 drivers/video/fbdev/core/fbmem.c:515 > > > > > __drm_fb_helper_initial_config_and_unlock+0x137c/0x1910 drivers/gpu/drm/drm_fb_helper.c:1841 > > > > > drm_fb_helper_initial_config+0x48/0x64 drivers/gpu/drm/drm_fb_helper.c:1906 > > > > > drm_fbdev_client_hotplug+0x158/0x22c drivers/gpu/drm/drm_fbdev_client.c:51 > > > > > drm_client_register+0x144/0x1e0 drivers/gpu/drm/drm_client.c:140 > > > > > drm_fbdev_client_setup+0x1a4/0x39c drivers/gpu/drm/drm_fbdev_client.c:158 > > > > > drm_client_setup+0x28/0x9c drivers/gpu/drm/drm_client_setup.c:29 > > > > > vkms_create drivers/gpu/drm/vkms/vkms_drv.c:230 [inline] > > > > > vkms_init+0x4f0/0x600 drivers/gpu/drm/vkms/vkms_drv.c:256 > > > > > do_one_initcall+0x254/0x9f8 init/main.c:1266 > > > > > do_initcall_level+0x154/0x214 init/main.c:1328 > > > > > do_initcalls+0x58/0xac init/main.c:1344 > > > > > do_basic_setup+0x8c/0xa0 init/main.c:1363 > > > > > kernel_init_freeable+0x324/0x478 init/main.c:1577 > > > > > kernel_init+0x24/0x2a0 init/main.c:1466 > > > > > ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:862 > > > > > > > > > > -> #4 (console_lock){+.+.}-{0:0}: > > > > > console_lock+0x19c/0x1f4 kernel/printk/printk.c:2833 > > > > > __bch2_print_string_as_lines fs/bcachefs/util.c:267 [inline] > > > > > bch2_print_string_as_lines+0x2c/0xd4 fs/bcachefs/util.c:286 > > > > > __bch2_fsck_err+0x1864/0x2544 fs/bcachefs/error.c:411 > > > > > bch2_check_fix_ptr fs/bcachefs/buckets.c:112 [inline] > > > > > bch2_check_fix_ptrs+0x15b8/0x515c fs/bcachefs/buckets.c:266 > > > > > bch2_trigger_extent+0x71c/0x814 fs/bcachefs/buckets.c:856 > > > > > bch2_key_trigger fs/bcachefs/bkey_methods.h:87 [inline] > > > > > bch2_gc_mark_key+0x4b4/0xb70 fs/bcachefs/btree_gc.c:634 > > > > > bch2_gc_btree fs/bcachefs/btree_gc.c:670 [inline] > > > > > bch2_gc_btrees fs/bcachefs/btree_gc.c:729 [inline] > > > > > bch2_check_allocations+0x1018/0x48f4 fs/bcachefs/btree_gc.c:1133 > > > > > bch2_run_recovery_pass+0xe4/0x1d4 fs/bcachefs/recovery_passes.c:191 > > > > > bch2_run_recovery_passes+0x30c/0x73c fs/bcachefs/recovery_passes.c:244 > > > > > bch2_fs_recovery+0x32d8/0x55dc fs/bcachefs/recovery.c:861 > > > > > bch2_fs_start+0x30c/0x53c fs/bcachefs/super.c:1037 > > > > > bch2_fs_get_tree+0x938/0x1030 fs/bcachefs/fs.c:2170 > > > > > vfs_get_tree+0x90/0x28c fs/super.c:1814 > > > > > do_new_mount+0x278/0x900 fs/namespace.c:3507 > > > > > path_mount+0x590/0xe04 fs/namespace.c:3834 > > > > > do_mount fs/namespace.c:3847 [inline] > > > > > __do_sys_mount fs/namespace.c:4057 [inline] > > > > > __se_sys_mount fs/namespace.c:4034 [inline] > > > > > __arm64_sys_mount+0x4d4/0x5ac fs/namespace.c:4034 > > > > > __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] > > > > > invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 > > > > > el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 > > > > > do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 > > > > > el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 > > > > > el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > -> #3 (&c->fsck_error_msgs_lock){+.+.}-{4:4}: > > > > > __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585 > > > > > __mutex_lock kernel/locking/mutex.c:735 [inline] > > > > > mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787 > > > > > __bch2_fsck_err+0x344/0x2544 fs/bcachefs/error.c:282 > > > > > bch2_check_fix_ptr fs/bcachefs/buckets.c:112 [inline] > > > > > bch2_check_fix_ptrs+0x15b8/0x515c fs/bcachefs/buckets.c:266 > > > > > bch2_trigger_extent+0x71c/0x814 fs/bcachefs/buckets.c:856 > > > > > bch2_key_trigger fs/bcachefs/bkey_methods.h:87 [inline] > > > > > bch2_gc_mark_key+0x4b4/0xb70 fs/bcachefs/btree_gc.c:634 > > > > > bch2_gc_btree fs/bcachefs/btree_gc.c:670 [inline] > > > > > bch2_gc_btrees fs/bcachefs/btree_gc.c:729 [inline] > > > > > bch2_check_allocations+0x1018/0x48f4 fs/bcachefs/btree_gc.c:1133 > > > > > bch2_run_recovery_pass+0xe4/0x1d4 fs/bcachefs/recovery_passes.c:191 > > > > > bch2_run_recovery_passes+0x30c/0x73c fs/bcachefs/recovery_passes.c:244 > > > > > bch2_fs_recovery+0x32d8/0x55dc fs/bcachefs/recovery.c:861 > > > > > bch2_fs_start+0x30c/0x53c fs/bcachefs/super.c:1037 > > > > > bch2_fs_get_tree+0x938/0x1030 fs/bcachefs/fs.c:2170 > > > > > vfs_get_tree+0x90/0x28c fs/super.c:1814 > > > > > do_new_mount+0x278/0x900 fs/namespace.c:3507 > > > > > path_mount+0x590/0xe04 fs/namespace.c:3834 > > > > > do_mount fs/namespace.c:3847 [inline] > > > > > __do_sys_mount fs/namespace.c:4057 [inline] > > > > > __se_sys_mount fs/namespace.c:4034 [inline] > > > > > __arm64_sys_mount+0x4d4/0x5ac fs/namespace.c:4034 > > > > > __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] > > > > > invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 > > > > > el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 > > > > > do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 > > > > > el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 > > > > > el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > -> #2 (&c->mark_lock){++++}-{0:0}: > > > > > percpu_down_read+0x5c/0x2e8 include/linux/percpu-rwsem.h:51 > > > > > __bch2_disk_reservation_add+0xc4/0x9f4 fs/bcachefs/buckets.c:1170 > > > > > bch2_disk_reservation_add+0x29c/0x4f4 fs/bcachefs/buckets.h:367 > > > > > __bch2_folio_reservation_get+0x2dc/0x798 fs/bcachefs/fs-io-pagecache.c:428 > > > > > bch2_folio_reservation_get fs/bcachefs/fs-io-pagecache.c:477 [inline] > > > > > bch2_page_mkwrite+0xa70/0xe44 fs/bcachefs/fs-io-pagecache.c:637 > > > > > do_page_mkwrite+0x140/0x2dc mm/memory.c:3176 > > > > > wp_page_shared mm/memory.c:3577 [inline] > > > > > do_wp_page+0x1f50/0x38a0 mm/memory.c:3727 > > > > > handle_pte_fault+0xe44/0x5890 mm/memory.c:5817 > > > > > __handle_mm_fault mm/memory.c:5944 [inline] > > > > > handle_mm_fault+0xf0c/0x17b0 mm/memory.c:6112 > > > > > do_page_fault+0x404/0x10a8 arch/arm64/mm/fault.c:647 > > > > > do_mem_abort+0x74/0x200 arch/arm64/mm/fault.c:919 > > > > > el0_da+0x60/0x178 arch/arm64/kernel/entry-common.c:604 > > > > > el0t_64_sync_handler+0xcc/0x108 arch/arm64/kernel/entry-common.c:765 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > -> #1 (sb_pagefaults#4){.+.+}-{0:0}: > > > > > percpu_down_read include/linux/percpu-rwsem.h:51 [inline] > > > > > __sb_start_write include/linux/fs.h:1725 [inline] > > > > > sb_start_pagefault include/linux/fs.h:1890 [inline] > > > > > bch2_page_mkwrite+0x280/0xe44 fs/bcachefs/fs-io-pagecache.c:614 > > > > > do_page_mkwrite+0x140/0x2dc mm/memory.c:3176 > > > > > wp_page_shared mm/memory.c:3577 [inline] > > > > > do_wp_page+0x1f50/0x38a0 mm/memory.c:3727 > > > > > handle_pte_fault+0xe44/0x5890 mm/memory.c:5817 > > > > > __handle_mm_fault mm/memory.c:5944 [inline] > > > > > handle_mm_fault+0xf0c/0x17b0 mm/memory.c:6112 > > > > > do_page_fault+0x404/0x10a8 arch/arm64/mm/fault.c:647 > > > > > do_mem_abort+0x74/0x200 arch/arm64/mm/fault.c:919 > > > > > el0_da+0x60/0x178 arch/arm64/kernel/entry-common.c:604 > > > > > el0t_64_sync_handler+0xcc/0x108 arch/arm64/kernel/entry-common.c:765 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > -> #0 (&vma->vm_lock->lock){++++}-{4:4}: > > > > > check_prev_add kernel/locking/lockdep.c:3161 [inline] > > > > > check_prevs_add kernel/locking/lockdep.c:3280 [inline] > > > > > validate_chain kernel/locking/lockdep.c:3904 [inline] > > > > > __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 > > > > > lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 > > > > > down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 > > > > > vma_start_write include/linux/mm.h:769 [inline] > > > > > vm_flags_set include/linux/mm.h:899 [inline] > > > > > vm_insert_page+0x2a0/0xab0 mm/memory.c:2241 > > > > > packet_mmap+0x2f8/0x4c8 net/packet/af_packet.c:4680 > > > > > sock_mmap+0x90/0xa8 net/socket.c:1403 > > > > > call_mmap include/linux/fs.h:2183 [inline] > > > > > mmap_file mm/internal.h:124 [inline] > > > > > __mmap_new_file_vma mm/vma.c:2291 [inline] > > > > > __mmap_new_vma mm/vma.c:2355 [inline] > > > > > __mmap_region+0x1854/0x2180 mm/vma.c:2456 > > > > > mmap_region+0x1f4/0x370 mm/mmap.c:1348 > > > > > do_mmap+0x8b0/0xfd0 mm/mmap.c:496 > > > > > vm_mmap_pgoff+0x1a0/0x38c mm/util.c:580 > > > > > ksys_mmap_pgoff+0x3a4/0x5c8 mm/mmap.c:542 > > > > > __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline] > > > > > __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline] > > > > > __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21 > > > > > __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] > > > > > invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 > > > > > el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 > > > > > do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 > > > > > el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 > > > > > el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > other info that might help us debug this: > > > > > > > > > > Chain exists of: > > > > > &vma->vm_lock->lock --> &mm->mmap_lock --> &po->pg_vec_lock > > > > > > > > > > Possible unsafe locking scenario: > > > > > > > > > > CPU0 CPU1 > > > > > ---- ---- > > > > > lock(&po->pg_vec_lock); > > > > > lock(&mm->mmap_lock); > > > > > lock(&po->pg_vec_lock); > > > > > lock(&vma->vm_lock->lock); > > > > > > > > > > *** DEADLOCK *** > > > > > > > > > > 2 locks held by syz.8.396/8273: > > > > > #0: ffff0000d6a2cc10 (&mm->mmap_lock){++++}-{4:4}, at: mmap_write_lock_killable include/linux/mmap_lock.h:122 [inline] > > > > > #0: ffff0000d6a2cc10 (&mm->mmap_lock){++++}-{4:4}, at: vm_mmap_pgoff+0x154/0x38c mm/util.c:578 > > > > > #1: ffff0000d4aa2868 (&po->pg_vec_lock){+.+.}-{4:4}, at: packet_mmap+0x9c/0x4c8 net/packet/af_packet.c:4650 > > > > > > > > > Given &mm->mmap_lock and &po->pg_vec_lock in same locking order on both sides, > > > > this deadlock report is bogus. Due to lockdep glitch? > > > > What do you mean by "both sides"? Note that, here is the report saying > > the locks that are already held by the current task, and that current > > task is going to acquire &vma->vm_lock->lock, so lockdep finds new > > dependency: > > > > &po->pg_vec_lock --> &vma->vm_lock->lock > > > > and there will be a circular dependency because (see above) lockdep > > recorded a dependency chain that: > > > > &vma->vm_lock->lock --> ... --> &po->pg_vec_lock > > > > > > > > Yeah, this looks fishy. Note that to write-lock vma->vm_lock (which is > > > what's done here) a task needs to also hold the mmap_write_lock, so > > > the above race between CPU0 and CPU1 should not be possible because > > > > Note the the dependency chain has 11 locks in it, so the real deadlock > > scenario may have 11 CPUs involved, and due to the limitation of how we > > can do pretty-print in kernel log, it's always show two CPUs cases. The > > real case may be: > > > > CPU0 CPU1 CPU2 CPU3 CPU4 CPU5 CPU6 CPU7 CPU8 CPU9 CPU10 > > ---- ---- ---- ---- ---- ---- ---- ---- ---- ---- ---- > > lock(&po->pg_vec_lock); > > lock(&vma->vm_lock->lock); > > lock(sb_pagefaults#4); > > lock(&c->mark_lock); > > lock(&c->fsck_error_msgs_lock); > > lock(console_lock); > > lock(&helper->lock); > > lock(&client->modeset_mutex); > > lock(crtc_ww_class_acquire); > > lock(crtc_ww_class_mutex); > > lock(&mm->mmap_lock); > > lock(&po->pg_vec_lock); > > lock(&mm->mmap_lock); > > lock(crtc_ww_class_mutex); > > lock(crtc_ww_class_acquire); > > lock(&client->modeset_mutex); > > lock(&helper->lock); > > lock(console_lock); > > lock(&c->fsck_error_msgs_lock); > > lock(&c->mark_lock); > > lock(sb_pagefaults#4); > > lock(&vma->vm_lock->lock); > > > > (of course, it could happen with less CPUs and it could also be a false > > positive, but the depenedency chain is real) > > > > Also a quick look seems to suggest that the lock dependency on CPU 1: > > > > lock(&vma->vm_lock->lock); > > lock(sb_pagefaults#4); > > > > can happen in a page fault with a reader of &vma->vm_lock->lock. > > The report clearly indicates a call to vma_start_write(), which means > vm_lock is being write-locked, not read-locked. That's why I commented > that the report does not consider that mmap_write_lock is already > taken when vma_start_write() is called. > > > > > do_page_fault(): > > lock_vma_under_rcu(): > > vma_start_read(): > > down_read_trylock(); // read lock &vma->vm_lock_lock here. > > ... > > handle_mm_fault(): > > sb_start_pagefault(); // lock(sb_pagefaults#4); > > > > if so, an existing reader can block the other writer, so I don't think > > the mmap_lock write protection can help here. > > In your example vma->vm_lock would be read-locked before > po->pg_vec_lock but in the report po->pg_vec_lock is locked before > vma->vm_lock->lock. I don't think what is reported here is the > do_page_fault() path. > You're missing the point, in the report, the current stack is indeed in a write path (i.e. &mm->mmap_lock first and then &vma->vm_lock->lock), however that's only part of the picture. The deadlock possibility is due to that there could be a concurrent do_page_fault() which will hold &vma->vm_lock->lock first and wait for another lock that eventually has a dependency on a &mm->mmap_lock. Regards, Boqun > > > > > > It's bit late for me to take a deep look, will continue tomorrow. So far > > the story seems to be: > > > > * Page fault can connect &vma->vm_lock->lock with &c->mark_lock. > > > > * Some bcachefs internal can connect &c->mark_lock with console_lock. > > > > * Some drm internal can connect console_lock with drm internal > > locks (e.g. crtc_ww_class_mutex) because of fbcon. > > > > * (not sure) drm may trigger a page fault (because of put_user()) > > with some internal locks held. This will connect > > crtc_ww_class_mutex with &mm->mmap_lock. > > > > * And eventually normal mm operations will connect &mm->mmap_lock > > with &vma->vm_lock->lock. > > > > Regards, > > Boqun > > > > > > > they will synchronize on the mmap_lock before locking vm_lock or > > > pg_vec_lock. > > > > > > > > > > > > stack backtrace: > > > > > CPU: 0 UID: 0 PID: 8273 Comm: syz.8.396 Not tainted 6.13.0-rc3-syzkaller-g573067a5a685 #0 > > > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 > > > > > Call trace: > > > > > show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C) > > > > > __dump_stack lib/dump_stack.c:94 [inline] > > > > > dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 > > > > > dump_stack+0x1c/0x28 lib/dump_stack.c:129 > > > > > print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074 > > > > > check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206 > > > > > check_prev_add kernel/locking/lockdep.c:3161 [inline] > > > > > check_prevs_add kernel/locking/lockdep.c:3280 [inline] > > > > > validate_chain kernel/locking/lockdep.c:3904 [inline] > > > > > __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 > > > > > lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 > > > > > down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 > > > > > vma_start_write include/linux/mm.h:769 [inline] > > > > > vm_flags_set include/linux/mm.h:899 [inline] > > > > > vm_insert_page+0x2a0/0xab0 mm/memory.c:2241 > > > > > packet_mmap+0x2f8/0x4c8 net/packet/af_packet.c:4680 > > > > > sock_mmap+0x90/0xa8 net/socket.c:1403 > > > > > call_mmap include/linux/fs.h:2183 [inline] > > > > > mmap_file mm/internal.h:124 [inline] > > > > > __mmap_new_file_vma mm/vma.c:2291 [inline] > > > > > __mmap_new_vma mm/vma.c:2355 [inline] > > > > > __mmap_region+0x1854/0x2180 mm/vma.c:2456 > > > > > mmap_region+0x1f4/0x370 mm/mmap.c:1348 > > > > > do_mmap+0x8b0/0xfd0 mm/mmap.c:496 > > > > > vm_mmap_pgoff+0x1a0/0x38c mm/util.c:580 > > > > > ksys_mmap_pgoff+0x3a4/0x5c8 mm/mmap.c:542 > > > > > __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline] > > > > > __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline] > > > > > __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21 > > > > > __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] > > > > > invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 > > > > > el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 > > > > > do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 > > > > > el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 > > > > > el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 > > > > > el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 > > > > > > > > > > > > > > > --- > > > > > This report is generated by a bot. It may contain errors. > > > > > See https://goo.gl/tpsmEJ for more information about syzbot. > > > > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > > > > > > > syzbot will keep track of this issue. See: > > > > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > > > > > > > > > If the report is already addressed, let syzbot know by replying with: > > > > > #syz fix: exact-commit-title > > > > > > > > > > If you want to overwrite report's subsystems, reply with: > > > > > #syz set subsystems: new-subsystem > > > > > (See the list of subsystem names on the web dashboard) > > > > > > > > > > If the report is a duplicate of another one, reply with: > > > > > #syz dup: exact-subject-of-another-report > > > > > > > > > > If you want to undo deduplication, reply with: > > > > > #syz undup > > > > > > > > >