From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBACFE77188 for ; Wed, 8 Jan 2025 19:07:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A0A36B0085; Wed, 8 Jan 2025 14:07:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44FEA6B0088; Wed, 8 Jan 2025 14:07:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CA166B0089; Wed, 8 Jan 2025 14:07:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BE356B0085 for ; Wed, 8 Jan 2025 14:07:35 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ADCE1A13A6 for ; Wed, 8 Jan 2025 19:07:34 +0000 (UTC) X-FDA: 82985218428.05.5FF7BF1 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 69C0C180011 for ; Wed, 8 Jan 2025 19:07:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xzekksq1; spf=pass (imf16.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736363252; a=rsa-sha256; cv=none; b=d9jJeTsSIEUTZDRrZwQ/dasiT8sFXKMzASHqupfMAd2NAOnI11Q5a/stRqWYb2oMyfo9gy BBp61/a8yAmCNJCGA3b9xDdGxqJje/RQZw4i2jddh2eawBMCyjgjOD1UAaHggzHkebGKcn ybZLf2sn0Mi30L5NjHqADAQfHym/psc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xzekksq1; spf=pass (imf16.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736363252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=et5B8hlP2uBddj4+hHdJGwr054UnEhnkyQk5Cy5HvXM=; b=5ROWcO3GVDS3540Bg2UlmYes8fS1ggtjfsFqYstP3oA8lKBnVly/5ZCJS4LjKaF8bvraag EP/rsIglOpB67yQ+ndqIkj9vHYMjDxCMvyjaBL5P66zEERocenxvmVdF19gv+UOspAvMik e9klE0YVufBy30hhgsof8isha9pff3A= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-467a3c85e11so243961cf.2 for ; Wed, 08 Jan 2025 11:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736363251; x=1736968051; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=et5B8hlP2uBddj4+hHdJGwr054UnEhnkyQk5Cy5HvXM=; b=Xzekksq1g3dZAtrkvMeJnftQf2YrPPB7e4ALqJLr9T6c2vxBsjwmZVH3kjKdOy4DN9 YXNqCf6ROWB8Tx5NVDA7SBmuokDqP3Je7eHSG5Idxx+4U8SbHF9BU3LIndjnMWafTejS EGK3OtsBHI9pyY++S6rOkiWDd9wPcsoW/Z1NuuvBrlH3B9y1FkdGi0/isVktGLtTdW7H ASyacLyATw+ut5O3tgBaqTmUaBjFy+QOGxn1CN/jKpTEeetvGhrpt5Gi9/EjM5kImSd2 /6TuCkYhiUUE38PI/j5yLY86DPp8EYHRZ/6YGVOfVu3b2G4ToixNRiqdD9jdqDyn8pca FRXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736363251; x=1736968051; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=et5B8hlP2uBddj4+hHdJGwr054UnEhnkyQk5Cy5HvXM=; b=F6hSORJ4b1RWO5KqueIjqV1lYbYnnA8msyCNU88wiwGRySnXXcs0asKKlYEA+RjK6F JLKs6ZzfOR0y8iCYtnaxozBIxKVS40vLLtV/59l/9igLMGXVNPV2qxCQuuV37Z6eHPzU d5uTe9mz8Av+K+tFYvqqKk0+FQFGafR1SZ/gOt1k3qxnN+u8Ro1vXv38bxnvwyvupWTC HO20pmmz0YNxlkWRB2nUNMvMW9CTHhzEVGuzhI4k4pMyUML8eQOql01dGW6vR82YLL7T eWYu+eAF6MQGlG10XaVyjZXUvOgT4T+j0RdC6y3W6k4lVgSEa8Er6o1qz+lYMOyML8+i I1ZQ== X-Forwarded-Encrypted: i=1; AJvYcCVplkDtUEjIMy29mjb7PX5yhrlms4M2CLTGr2D++CgjBzzEE04y1tCglSO0x17x2bCErdG5IV1h3Q==@kvack.org X-Gm-Message-State: AOJu0YxlRiKuNs1VuuMESL6BZH0j9g7ZArtmo8opfpoI6EDCAONqE5in Qv4DqB/zGD1rIGIC1pX4Ryiv80d9smIgKHa8Cd0t93G/wsdazqDE X-Gm-Gg: ASbGnct3iBFrg936B3L8EYUrr5dOmAHmTM6/jtAYyjqb5JQmYVrYNmWW/ehkTUiVOI5 xTWVjF5/4yNNcbJCSbh02SqCvtl8tPndW2tnmA+dL9KCsRu5wM/9gpfvheyMx1Qo5Dz77spyFjq 9ALyHc3zYTmr1sYK2FcaAiVRoE4+hLenXbSDXOkStTGxaBa8bPRcTXv0ZYjFMZFSFTEFm1VTixA cCCLFn7kvfYr4AEUQd3oVu3iEqXhZoZdAG3x1aJhNSs8u621NkC5mTPtPhXPvBKKR/EbmmuCsjD 4+tGEURzA8F6ibNMLFhRveFBOjx5ZNU30wOV+rxk7dkSFts= X-Google-Smtp-Source: AGHT+IEsXZGPY0Q5639xJE3pdKuvlKpF2vmpHCQELr8bTSDH+pPkF8i0QcQUl8rRNaApc6tev+D/Uw== X-Received: by 2002:a05:622a:144c:b0:458:5716:fbd8 with SMTP id d75a77b69052e-46c710abbe8mr57631381cf.32.1736363251338; Wed, 08 Jan 2025 11:07:31 -0800 (PST) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3e6ad93bsm199260431cf.53.2025.01.08.11.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 11:07:30 -0800 (PST) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfauth.phl.internal (Postfix) with ESMTP id 4A51E1200043; Wed, 8 Jan 2025 14:07:30 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Wed, 08 Jan 2025 14:07:30 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeggedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpeeuohhquhhnucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilh drtghomheqnecuggftrfgrthhtvghrnhepjeehgfefudffgeeguedvgeefgeejheehgfeg hfejjedukeekuedtffdthffgtedtnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpkh gvrhhnvghlrdhorhhgpdhrvggruggvrhdrrhgvrggunecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhph gvrhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdr fhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgvpdhnsggprhgtphhtth hopedugedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepfhgvlhhiphgvrghgghhg vghrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepohhjvggurgeskhgvrhhnvghlrdhorh hgpdhrtghpthhtoheprghlvgigrdhgrgihnhhorhesghhmrghilhdrtghomhdprhgtphht thhopehgrghrhiesghgrrhihghhuohdrnhgvthdprhgtphhtthhopegsjhhorhhnfegpgh hhsehprhhothhonhhmrghilhdrtghomhdprhgtphhtthhopegsvghnnhhordhlohhsshhi nhesphhrohhtohhnrdhmvgdprhgtphhtthhopegrrdhhihhnuggsohhrgheskhgvrhhnvg hlrdhorhhgpdhrtghpthhtoheprghlihgtvghrhihhlhesghhoohhglhgvrdgtohhmpdhr tghpthhtohepthhmghhrohhsshesuhhmihgthhdrvgguuh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jan 2025 14:07:29 -0500 (EST) Date: Wed, 8 Jan 2025 11:06:31 -0800 From: Boqun Feng To: Filipe Xavier Cc: Miguel Ojeda , Alex Gaynor , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Andrew Morton , rust-for-linux@vger.kernel.org, linux-mm@kvack.org, Filipe Xavier Subject: Re: [PATCH v2] rust: generalize userSliceReader to support any Vec Message-ID: References: <20250107-gen-userslice-readall-alloc-v2-1-d7fe4d19241a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107-gen-userslice-readall-alloc-v2-1-d7fe4d19241a@gmail.com> X-Rspamd-Queue-Id: 69C0C180011 X-Stat-Signature: 3xxqezeoupqeemy77ci7gwyahp6fshgf X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736363252-921526 X-HE-Meta: U2FsdGVkX19wQxcmDrQbVgC+1mPOl23uGa8fc6lNkG4S8w6TW77sDqhRtnYarbQPUDsQriXyLV1NY7qo6cjTWBmSnJH4kaEEfY5Z7V2EdtCz7puTBPt1fbYXhzLJl/zY/3/3WYtOkigshE8O81xsPl7JDiqjeVQ+DXtf0TJYyjrc3sMB8pp2szKgZqwvB1OcSRrZITV7aw+bfQ5v/hXLFxiQ8XTNhis1FWAYRjUj+IELYjiHqbfwWtb7fEclDK2TAkGxFvI7wNRKwMAScw4g1MWBeBWWQeC5X6s5STkYSM9CeiRzr2aj/c5TYL+F9u9eEgQYdf5pQS0t+kQ5grw+VUCmgrpUHGZSAzDTMvde8wUC22flmOsDt4wg0IrHnasXwSSe1mQr7W6oEr7ErLS7FjPgeFYQOeE5zJkvp9x+5u1pToF/TES4JOJO2TWFzJq1H+Ca0TPXBp6AQTgOFzx97uw7/ZBmEi1diiyX9AqRCYLw/BQgxD7dPvQQ4maV4inTbdjvZE47WDzdmvw81scQvn+GZNRFMdXjehVacjARfpqx/1dwtwa56mFdes2hssQ+oSRWyGfpSD50KMLGDy4V7F7DkjN3zUpMebFTT/NEIEU3FYV6fe2XKGjbd9DLI0JNlPqR+4BsObuEQlU015Qt5/riNLEw6JXvy83fT0jWSfpE64WS/FurglN8XTYHeqW97FyCWb3yaf9irWcTdA04HJPX1sCnrFIyktMY54JaGH3qYVAnnhL8y8198afU001R361mWzdcp6nu5ZROtNRhAczrvxHsDwMRTJ6qQJup786guJdkdEp1eRh1BjiAfpD0NwRCCLza2lbA4xkDO5Ouspz19hU6s/0MCYHtHmbdelxv01744nCneYXyyXky2Q1iXmSQKzpcYyLljbiBho4xKNSrplTvxr6mUQXooUhZUnJt5IbwupD1hFxgQMzOy4klVM8lnN82lGkXF18kIRR LrMhhoi/ UMGL7Oj2uje8LjZM7Jm8KM7fcuHQfSTDlD0qxeyC9jkkzACKjCJZyzygAtDKtU2t87vKRZY3pSjpgt24ZqT1rpPgjxrpxgvNG86EICg5WnqVthiR/k8YQlRbCRjF8Nh7cyaCWLFBRLv4oCH+1T/rZX+w2FtmqotGLsP6JKQXKkVXegHmYjRpLM1lW5XOKBGHYBtO1nEsh4AEHPBhXPiYONdvCUqnOfajiaKUNJbI6IJfYuBD1M9InR2LLKV811nx5SmmZX/21oqXmhdnWttYK2RVJ+Nh/SvCZnouGCR1TUopxU4b/IEBv8op8nqQOz+rDxM5PFZgRXGVOPeunG/CdIUuNYm9ogcrunPGTiKEOKCb0RX1lvO4kFry0WGtkJJUtBo5tToUzXPYDmB8JHemJdhsyhu8oFWtjRUyNs2qipKQhXqX83HU0kS7OAg52R+eOl8SZfpe/nlTlkDZeaikWc2QoQk3tHdsCMQvOt4+ei7vWINN37JtTpcMtey6pYnQi1GR6VjgsZ1MnIRk= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.496121, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 07, 2025 at 04:25:39PM -0300, Filipe Xavier wrote: > The UserSliceReader::read_all function is currently restricted to use > only Vec with the kmalloc allocator. > However, there is no reason for this limitation. > This patch generalizes the function to accept any Vec regardless of the > allocator used. > There's a use-case for a KVVec in Binder to avoid maximum > sizes for a certain array. > > Link: https://github.com/Rust-for-Linux/linux/issues/1136 > Signed-off-by: Filipe Xavier Reviewed-by: Boqun Feng Regards, Boqun > --- > Changes in v2: > - Commit description: added use case on description and send to memorymanagment on copy. > - Link to v1: https://lore.kernel.org/r/20241222-gen-userslice-readall-alloc-v1-1-c57b7d4972f0@gmail.com > --- > rust/kernel/uaccess.rs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/rust/kernel/uaccess.rs b/rust/kernel/uaccess.rs > index cc044924867b89f6116c7f9ec216d8cea2b3f8d7..719b0a48ff5550acc19f2e607c0a09f818145def 100644 > --- a/rust/kernel/uaccess.rs > +++ b/rust/kernel/uaccess.rs > @@ -5,7 +5,7 @@ > //! C header: [`include/linux/uaccess.h`](srctree/include/linux/uaccess.h) > > use crate::{ > - alloc::Flags, > + alloc::{Allocator, Flags}, > bindings, > error::Result, > ffi::c_void, > @@ -127,7 +127,7 @@ pub fn new(ptr: UserPtr, length: usize) -> Self { > /// Reads the entirety of the user slice, appending it to the end of the provided buffer. > /// > /// Fails with [`EFAULT`] if the read happens on a bad address. > - pub fn read_all(self, buf: &mut KVec, flags: Flags) -> Result { > + pub fn read_all(self, buf: &mut Vec, flags: Flags) -> Result { > self.reader().read_all(buf, flags) > } > > @@ -281,7 +281,7 @@ pub fn read(&mut self) -> Result { > /// Reads the entirety of the user slice, appending it to the end of the provided buffer. > /// > /// Fails with [`EFAULT`] if the read happens on a bad address. > - pub fn read_all(mut self, buf: &mut KVec, flags: Flags) -> Result { > + pub fn read_all(mut self, buf: &mut Vec, flags: Flags) -> Result { > let len = self.length; > buf.reserve(len, flags)?; > > > --- > base-commit: 0c5928deada15a8d075516e6e0d9ee19011bb000 > change-id: 20241222-gen-userslice-readall-alloc-8049c668e65e > > Best regards, > -- > Filipe Xavier >