From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7285E77188 for ; Wed, 8 Jan 2025 16:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BBED6B0093; Wed, 8 Jan 2025 11:13:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 446616B0095; Wed, 8 Jan 2025 11:13:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2987C6B0096; Wed, 8 Jan 2025 11:13:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 089126B0093 for ; Wed, 8 Jan 2025 11:13:28 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AE1E61611C8 for ; Wed, 8 Jan 2025 16:13:27 +0000 (UTC) X-FDA: 82984779654.19.40830B0 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf05.hostedemail.com (Postfix) with ESMTP id 348AB100007 for ; Wed, 8 Jan 2025 16:13:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Qc2i4Tp0; spf=pass (imf05.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736352805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/0pEosJAtrrq7+AZfl2ID181pVMDXxvqRB1iDHPru/M=; b=UJhGsLFCDsej38aOp1cm9XRRyiAZBvaoeKf7QXvnribCUT+Qcm0xvbnGaM5eFRbt04AnPJ n27cYOni8duj+pDhqkpkcl2mOvG32nBW98x27DXfsD38hDGLU5DgeZkZwE8AANNSd8eUBr 58I5vFuv5h3XkArel4wX2x+VxJu61l0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736352805; a=rsa-sha256; cv=none; b=TcIuI6BzOVLHIiMmWDWSeGO8OoDTfo3SA1p7EgP7qiyw2BBdmVPKO2/8MGsrzvedRfd5qz k2j3aj/542aYkf7Oepz0VsI37xv/JM7D6SrX80Lddol77m/DKJIuV2UddCGqtolGYq6cgY xAA+HmBeg7Y03UoRnR9qIGuPy7HCF4A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Qc2i4Tp0; spf=pass (imf05.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 508Ew0Hd008979; Wed, 8 Jan 2025 16:13:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=/0pEosJAtrrq7+AZfl2ID181pVMDXx vqRB1iDHPru/M=; b=Qc2i4Tp0uvBRyl+jGtaMLwYGZKKaztQUee3zrazLkmkths BKjfeh5hc4DNF+FovJkBB/fHbU/DPDjRCbIEh/eMZyHyvXxayMqu9FBQFJOug4QH iQGB7QT793mBW00g/2e5RWsTUnIRvzEqsPYZoZ1xrycOjY77mjmhxD3Tr58vKYfh i5WI1PseA+GU3nr66lZ1WH05bULNRioNAgJgAm9VNeTRLQ4pRSeX+RYdvIB2cetS GTBBs7NBz+M3Z6MiU02DQX/J9dzcrcbfHP6qZ8C6ajXXZ6zofEYRDTTx4bda1nof mnWd9f4JhtWC7wiQ3TFYDev/txCoPQl/rsnDG/uQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 441hupu905-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 16:13:02 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 508GD1K1025958; Wed, 8 Jan 2025 16:13:01 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 441hupu901-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 16:13:01 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 508CW5fH003630; Wed, 8 Jan 2025 16:13:00 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yfat8qq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 16:13:00 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 508GCwru8061280 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jan 2025 16:12:58 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B38D720040; Wed, 8 Jan 2025 16:12:58 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1575720043; Wed, 8 Jan 2025 16:12:58 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 8 Jan 2025 16:12:58 +0000 (GMT) Date: Wed, 8 Jan 2025 17:12:56 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, alex@ghiti.fr, andreas@gaisler.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v5 06/17] s390: pgtable: add statistics for PUD and P4D level page table Message-ID: References: <4707dffce228ccec5c6662810566dd12b5741c4b.1736317725.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4707dffce228ccec5c6662810566dd12b5741c4b.1736317725.git.zhengqi.arch@bytedance.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: KUhXNS6aArO_tUV9i1PAsm9yGShhoIw3 X-Proofpoint-GUID: AEhKKtU-rxWzLnMSxQ4AI9AzMP3tXlSR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1011 mlxscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 mlxlogscore=890 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501080133 X-Rspamd-Queue-Id: 348AB100007 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: zcrqyp5zsujtc4wr7xm8hn7g7y9g9rib X-HE-Tag: 1736352804-501795 X-HE-Meta: U2FsdGVkX19mCi/F6HWVJhIZPZXIlMutrQU3z9bu/nb0GzQjaPCtosJ8Te2XEK2DdCMuBPCf4fYWDLAUYnKRJHGqfkk/rEiRFdKi12tPs1HgL/zM+JSyh67LqhMrwKcfFlnXCFqBdyJpNQBC9I1teS+XdYb5RcJctBDl7AJaWyt177HvPDIa9sLJSId/womz3uiDK11X6T119Fw5Bdf4fvjuSEmEH8ozR5JF3d1k7EmrQWg2gWKZ9xhnT4LDfhnSonrX5JLeX7uHTBIlGTWdyMr/pxenzVC4QjNqfTCDCayj7MWZJ5TnD30pXYMJccBy4wtVAYfQorV+DlSYE8dc4VlGbR7GNrdm8RSF1V81FcY+Lfm/hEaOvJPmiWy7JMAt9d1NBLQMjZiObkk+5QSYzrZ5tsdbQUfsPdfCnjEqw6UuvXvLTBNs8HYolfItCJcATPyhgrN5NqBK8zd1V9Jl5Q+lVp/rg1sKGbI11kwuw4r781KkLq9gi+7Kpd+JlLfFX7bSZfrLFQsMyyEi458ybQzMtWim4HF+AhHHXwU7HD65K9xdXzP+phesc88py7hns3xPrcXfBc9X7pHWfwmTBRonTOrpLkPfWEnKEyPmrnZ00ex2JYiVVEpdcI6IQqEjaHj0N76X4lygDCrLnmTquel4Zj9QEHcwkK+KY29DjT/jl/JYGcNkfGF6zn1vB0jc0MFN2jCyTqtceRk5b/p6INXyAorOq+M2QpbH2G6oiK2aFXPAiLQ9ExqXpCx73KnVjvye0eDw+fts6jFk4Zp00FPUfCvMi6KiqXBVMrqMije9Mau5YS6CizQVvPBIAT1cfhjfYAcGcKsDgSHSzVhKmaG6v4y14GZgVkpM46+G7ouspQgecGEdVpQGMUVkoOxralpSXVvHvQU4J8b6mKijd52B2lxJbu+lYMbszChBtq8Gv+kw/SriZSTFR7dadgq877Yv1vSE6ioDk8DZSh9 hylyFwHw 4Rk3irnoIgwt2aBAWO7M2zNb+uKoXP9AqxWby3aGxW9gnADY0BvvQkZs3pAPDiyiWwUrfGS+kwypfBOyI3SrUccw90jG/lIr4g6MPUgqldf+45sBJBGkPDoSDefzlFU1YA2zk0uV8leIRxwnjQpAlST4VRndNoofWCXETJvPEq6h7LqnhcRofviwBXkLzHdZ7LmWKqzzGBCavvJiwiYx+FahxxWhsaoNimtSXUHzkYUXdZNBjfjg/YI4zJ4qTw70vQO4t0VfT+AzevUqpVOC/W/X1AZwAqHBmHQk46Cae00U825sGzP0E9Gp1AXykPxDwIogUqBvEJiNywjLqE4DrJ0X+CBtovz8Aj07I6Z3yCzK95xTx1+BNXPu2xYqbUjmDgsAqw8MdHpSZjIVHLmN1AGJF36HIaCDFQhSQyk6o7EgRQK41UxW9RGxR9DtYGAaLJ+KyF7gvFnX0CyseQ3YYyL68xNGToi1nh5TALTtQtnbCHWa7k5MlRKasTdm/2B+V5aUBInfBoaIsVSm0MYpOH5AMBwbgPm3ymz2lIAzrHCFpEOFCE6A2ZoeTYGyiXrWBzBPwbtfvYV7o2bE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 08, 2025 at 02:57:22PM +0800, Qi Zheng wrote: > Like PMD and PTE level page table, also add statistics for PUD and P4D > page table. > > Signed-off-by: Qi Zheng > Suggested-by: Peter Zijlstra (Intel) > Reviewed-by: Kevin Brodsky > Cc: linux-s390@vger.kernel.org > --- > arch/s390/include/asm/pgalloc.h | 29 +++++++++++++++++++++-------- > arch/s390/include/asm/tlb.h | 2 ++ > 2 files changed, 23 insertions(+), 8 deletions(-) > > diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h > index 7b84ef6dc4b6d..a0c1ca5d8423c 100644 > --- a/arch/s390/include/asm/pgalloc.h > +++ b/arch/s390/include/asm/pgalloc.h > @@ -53,29 +53,42 @@ static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned long address) > { > unsigned long *table = crst_table_alloc(mm); > > - if (table) > - crst_table_init(table, _REGION2_ENTRY_EMPTY); > + if (!table) > + return NULL; > + crst_table_init(table, _REGION2_ENTRY_EMPTY); > + pagetable_p4d_ctor(virt_to_ptdesc(table)); > + > return (p4d_t *) table; > } > > static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) > { > - if (!mm_p4d_folded(mm)) > - crst_table_free(mm, (unsigned long *) p4d); > + if (mm_p4d_folded(mm)) > + return; > + > + pagetable_p4d_dtor(virt_to_ptdesc(p4d)); > + crst_table_free(mm, (unsigned long *) p4d); > } > > static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address) > { > unsigned long *table = crst_table_alloc(mm); > - if (table) > - crst_table_init(table, _REGION3_ENTRY_EMPTY); > + > + if (!table) > + return NULL; > + crst_table_init(table, _REGION3_ENTRY_EMPTY); > + pagetable_pud_ctor(virt_to_ptdesc(table)); > + > return (pud_t *) table; > } > > static inline void pud_free(struct mm_struct *mm, pud_t *pud) > { > - if (!mm_pud_folded(mm)) > - crst_table_free(mm, (unsigned long *) pud); > + if (mm_pud_folded(mm)) > + return; > + > + pagetable_pud_dtor(virt_to_ptdesc(pud)); > + crst_table_free(mm, (unsigned long *) pud); > } > > static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long vmaddr) > diff --git a/arch/s390/include/asm/tlb.h b/arch/s390/include/asm/tlb.h > index e95b2c8081eb8..907d57a68145c 100644 > --- a/arch/s390/include/asm/tlb.h > +++ b/arch/s390/include/asm/tlb.h > @@ -122,6 +122,7 @@ static inline void p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > { > if (mm_p4d_folded(tlb->mm)) > return; > + pagetable_p4d_dtor(virt_to_ptdesc(p4d)); > __tlb_adjust_range(tlb, address, PAGE_SIZE); > tlb->mm->context.flush_mm = 1; > tlb->freed_tables = 1; > @@ -140,6 +141,7 @@ static inline void pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > { > if (mm_pud_folded(tlb->mm)) > return; > + pagetable_pud_dtor(virt_to_ptdesc(pud)); > tlb->mm->context.flush_mm = 1; > tlb->freed_tables = 1; > tlb->cleared_p4ds = 1; Acked-by: Alexander Gordeev Thanks!