From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EEF5E77199 for ; Wed, 8 Jan 2025 15:58:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 074CB6B007B; Wed, 8 Jan 2025 10:58:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0248C6B0082; Wed, 8 Jan 2025 10:58:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07916B0085; Wed, 8 Jan 2025 10:58:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C03926B007B for ; Wed, 8 Jan 2025 10:58:27 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 77939C1217 for ; Wed, 8 Jan 2025 15:58:27 +0000 (UTC) X-FDA: 82984741854.11.A6F88F3 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf27.hostedemail.com (Postfix) with ESMTP id 305E440016 for ; Wed, 8 Jan 2025 15:58:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="dshx/WuZ"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf27.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736351905; a=rsa-sha256; cv=none; b=dmj8DkP0EhN/5AzrPFRDxHKLawqueCGtF6XtqwaYG1FMeS8HFSbirmkeD3bBp3Wr9uwMev ZVSSCUNju6yPuoWUSRm8RXlaP495bYXDq5VTYhfY1Weqy2f5xrOxw+tZeZ80dHk2bvZbec NmyQA/CNCAMibymqqyM1G3Uujf9Awko= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="dshx/WuZ"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf27.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736351905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MY+iiPye8+N17txRsEvkwvzUmMz0DV07GQ1GbnTJG4c=; b=gtFkXyxlz2MC3rMI4PXjDp5I4MsnCH6A4qb5/bAKJDVADg+OwON3sv8diXjCfGKGsctreb RS9kr9WP6uszIUP5HW0PmxOKaBoKa9KbDz7f8trhcHUkhNAyRj7vDCQZFW6EZtBTDfaBQd eYhZErLaIsoRu8DqugpVJu7pqwjGfak= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 508E6Jqq032725; Wed, 8 Jan 2025 15:57:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=MY+iiPye8+N17txRsEvkwvzUmMz0DV 07GQ1GbnTJG4c=; b=dshx/WuZ0Qv/bc4mqlSJYaiOkN7jL0FodFWBDrBRH8iVF8 WAI9eK0nOPSGi4Ue0KDd+kgkKDTntcs4bUutgiouUjDX4BlPvF1UbzvRZEeb3Yw6 EYTqt4W5bBOGMNO5lCOURgKWnE2+9zAe6O/Oi7PzYz1zsunM//DdAAdZ5CSYAoym I1KKvecZW9WoTLLd5M4scUQzNpw16OKZOLo8aIO+e1US2KI25lwksMICBEo9VsrG Mx/KdyakeC0LBfanBnRQnFUaCc0X15p84Er7Ocmg2Dwx7xXczkSnHguQxll55fap bPfOIn5luAQOagl71oTApOOe3UjCBq+fJjBvpx5A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 441tu5ggka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 15:57:57 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 508Fnvql003022; Wed, 8 Jan 2025 15:57:57 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 441tu5ggk6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 15:57:57 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 508DgGTv013576; Wed, 8 Jan 2025 15:57:56 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43ygap0dkx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 15:57:56 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 508FvsnU36372768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jan 2025 15:57:54 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14B4C20043; Wed, 8 Jan 2025 15:57:54 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4553720040; Wed, 8 Jan 2025 15:57:53 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 8 Jan 2025 15:57:53 +0000 (GMT) Date: Wed, 8 Jan 2025 16:57:51 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, alex@ghiti.fr, andreas@gaisler.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v5 07/17] mm: pgtable: introduce pagetable_dtor() Message-ID: References: <47f44fff9dc68d9d9e9a0d6c036df275f820598a.1736317725.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47f44fff9dc68d9d9e9a0d6c036df275f820598a.1736317725.git.zhengqi.arch@bytedance.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: idHm2yZqvsjSn96DmI6ivvBkTbSLnUtC X-Proofpoint-ORIG-GUID: RLWMWP920gTrXASiDmVZwB5jZaufsLsY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 mlxlogscore=337 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1011 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501080129 X-Stat-Signature: 4mt8prny4qijcdieka1m4atd7cuma1ne X-Rspam-User: X-Rspamd-Queue-Id: 305E440016 X-Rspamd-Server: rspam08 X-HE-Tag: 1736351904-307995 X-HE-Meta: U2FsdGVkX1/6c/0/OVfYWDbtPSvQrrj34RpirKMPfRPyLmcQImwoGMV9ItkwDsbF8I52Opl9BbpCdfGCzS8hsiSWApsE8rc1PcArzCXrdezIT+krnZ5yeZFp12VuMsl/ic3QyualaIIjvli3uCGThqsfEoMD+In/PfsgWP0sHRRqC09Dk2lVh1UIhXbAgpPtoFJ1k3s/VxppqEKWHOdJETBcXNcVtRbakwrAxkXugLWGkzGxSJYqfvuNtZjZFSEL71QlklWNB5oDYpSOTQL/Tzq4YMUNQEfmveFL/3RQBnVI1tle8gbfDaqzYQ6G+A2W+SopyTObSdqcZ/CU6jW+AYCFjKOZxJEoHC1cx0dR2tXeG28eq8yogDbgOWMJeO/ERD8M9tkFILiQQ6OwktJVhZcq4bNQOyGFTsY3agG5gBt/iTLJJw9QyomKw0f8Vc7Ef9ST309qQE4Jfbqq34ndgoyABmzHNmGhqfmNRmqbGpx6Lc0yoM3OLSWR9aDhiob43ir3MedDxXyhaxLwwsdvTV4Eeh/kcxOtU6ogWBaTNLbBQkG9ROQLk6z0wh+kQiRShn8Wx6pg6Nrd/2kIQWXyHSF+ZdAk09joWr8NIPoWh+K11OioycDlKvuLNeRbAIrgzbHL1glbTFDpfnZhql6e9An4lBOZGbz32lvrDHNbVM/O3wggqzpICmdveDjv8xEqIMmOtIMx8LxGpgtTm58TLXbQB2t6D6AAv/d4kd5UYWv8clmxG+24N6mTVOF72bad4X4VqbiaNek+NJT1ZTzzwHKLJAnHyiutDCdTCDkeeGSHH03crASTsWcWT/FbUIWxPfnfOtqtFJAAzHYjFFu9S7zvtygStZvUl0DE5iuozFTJBRtbhKcxREpr7FrZyQEMj2tmnUeYhlLvw/B3OMx4IhmYIKK6O0xJGP45qg1BSsAUsobfUx251ioI0jndFz8qqIAAOU4W5sLxL4C6PiR d0y7qvPs 88/GQ3vYFg5ekrsuQz0qyghSkyVR0TfH8ZgmV59ovAscP1SLJKunRjcCMzk9J4Cjh0/WweoAfQRVbeyt+GoG5sr+Xc+wwtIg4AjAV9Yp4wRq2jmqswwPeo7n01GjrTNZVhHWd6B2R9HwMUwFbqdSoeJ6AC5FZVC5FZeH2Z+XEdZXWypiAvFxqko2ji6oMIoH+JTJ8k1Gs+FQ/IyOtYMzjBtvN8Cy+mVAU1w53VS8VRnhTEAEmCxYUJf/Z9gmVdB584IzGg1pseWdzYP7062Mj5oM5jEazsect1AWzHtkQQKe0umy3WeGPJ7kLj74+lbdtcPbkmJPHyRD9LMVyDcxGNBNG3f42tffc1KgR/Q/eIK2dv7aR/GV/GuuuifZ96G6BxagpZApVbimkApbHI1tyHkoxLloMUiFkdNpX0HP4O4S2t7DRBlV+Vf+6a/r0v+jUxuz8p9fE/MMLXF6XsyBo3i2FSOD8EsfbsBT9lbF7/IDPT7u1BzvmvKLtPQOY5K67Imgr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 08, 2025 at 02:57:23PM +0800, Qi Zheng wrote: > The pagetable_p*_dtor() are exactly the same except for the handling of > ptlock. If we make ptlock_free() handle the case where ptdesc->ptl is > NULL and remove VM_BUG_ON_PAGE() from pmd_ptlock_free(), we can unify > pagetable_p*_dtor() into one function. Let's introduce pagetable_dtor() > to do this. > > Later, pagetable_dtor() will be moved to tlb_remove_ptdesc(), so that > ptlock and page table pages can be freed together (regardless of whether > RCU is used). This prevents the use-after-free problem where the ptlock > is freed immediately but the page table pages is freed later via RCU. > > Signed-off-by: Qi Zheng > Originally-by: Peter Zijlstra (Intel) > Reviewed-by: Kevin Brodsky > --- ... > arch/s390/include/asm/pgalloc.h | 6 +-- > arch/s390/include/asm/tlb.h | 6 +-- > arch/s390/mm/pgalloc.c | 2 +- ... > include/asm-generic/pgalloc.h | 8 ++-- > include/linux/mm.h | 52 ++++------------------ > mm/memory.c | 3 +- > 28 files changed, 62 insertions(+), 95 deletions(-) ... For s390: Acked-by: Alexander Gordeev Thanks!