From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BAAE77199 for ; Wed, 8 Jan 2025 15:44:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 684506B007B; Wed, 8 Jan 2025 10:44:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6347A6B0082; Wed, 8 Jan 2025 10:44:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FB9A6B0088; Wed, 8 Jan 2025 10:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 32D5A6B007B for ; Wed, 8 Jan 2025 10:44:03 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C5C7C160846 for ; Wed, 8 Jan 2025 15:44:02 +0000 (UTC) X-FDA: 82984705524.22.216D4AE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 07461A0005 for ; Wed, 8 Jan 2025 15:44:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cPJm0Ekh; spf=pass (imf15.hostedemail.com: domain of danielt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=danielt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736351041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iAQ4x0/oizKfpSM1ZOfEKhrwcrgnRVCuoCpheJdwODk=; b=j5POBTuhwBZwhBdAXskRKqIALXvWC71zcJXweakYzrwyOU6abbXiHqwBU/FuReN7SFExvj 80lioG7AQy8xYpnuMBFFqmR5P8rpXLCcJUw/l4ultwpo2vKzYmQ1SSA2R9SK0Z9qPa2Oef zKxXiGx4SVuVKiKzzfJdAmR0WcdeRSE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cPJm0Ekh; spf=pass (imf15.hostedemail.com: domain of danielt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=danielt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736351041; a=rsa-sha256; cv=none; b=Gi+FFcpfo5ykwZOe2xM9Hq85PwAHegBBHnCdQiemjeh3SRJ8aTvTCzVfLnQK2Y9WlQDAWk Xet+WJVPGaLQztkLij8P96gqYg0E0WVPCVy0TpinmPa43Z0iu37GnWImi8OINRP8INbflf pkw/Y9DEsjYwyulBupDxq3pdCBQR9Q4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7CC105C53E1; Wed, 8 Jan 2025 15:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0593C4CED3; Wed, 8 Jan 2025 15:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736351039; bh=iAQ4x0/oizKfpSM1ZOfEKhrwcrgnRVCuoCpheJdwODk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cPJm0EkhpbVJZIRwKv38+KZr4RI6JAKZRMgSJAUilwa/dgEkob3GpPO+TLNtRiZCT DEWJDBRDzGsOiVUJ+Ljb7+Zn631cx7upT+JgUKWUOxWPdyfc0Rv/VXd92XMheafcRO HwTLae87NP1aV9jSsgjH8i80uyHv2fYQqRxRTS+9d/osRLJHpv7Z+BDIRhOLlXadBp ZyTfw0YbeI9/Tk1NMDXKp+ISKT72FLunUeqjvZM2LA81L2wBEkbl0Wz1SR/Zrf3sG0 DbpdPhUNKkmhlmzyHl1UUxz72wsi01z2Ht4x5xPDXSJRrWhFFXhn0nULlTfoL308Ir jxj7j8IS15+bA== Date: Wed, 8 Jan 2025 15:43:48 +0000 From: Daniel Thompson To: Mike Rapoport Cc: Andrew Morton , Andy Lutomirski , Anton Ivanov , Borislav Petkov , Brendan Higgins , Daniel Gomez , Dave Hansen , David Gow , Douglas Anderson , Ingo Molnar , Jason Wessel , Jiri Kosina , Joe Lawrence , Johannes Berg , Josh Poimboeuf , "Kirill A. Shutemov" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Miroslav Benes , "H. Peter Anvin" , Peter Zijlstra , Petr Mladek , Petr Pavlu , Rae Moar , Richard Weinberger , Sami Tolvanen , Shuah Khan , Song Liu , Steven Rostedt , Thomas Gleixner , kgdb-bugreport@lists.sourceforge.net, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, live-patching@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 5/8] module: introduce MODULE_STATE_GONE Message-ID: References: <20241227072825.1288491-1-rppt@kernel.org> <20241227072825.1288491-6-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241227072825.1288491-6-rppt@kernel.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 07461A0005 X-Rspam-User: X-Stat-Signature: e568foi6cobx8mkiindpnot77wmgbt3x X-HE-Tag: 1736351040-913992 X-HE-Meta: U2FsdGVkX1+bIH9IhCmlpwkrgqaFyUSzp0wMBQDfx8bs/OtmKgQMxe4rE484h4ylrPcr6L6kQEUiYyIYo6srrVmqynvEss8QMR8yfnKCeApGgEiz4vjeOfCBMIS4V/Kh73XOcl8FiaoEs6Z7M6+e1CRegPBDVYpN4l7hjRYzAJ4izxweLgwVHmpPYYqBQ2Wm37CqYQEraYN+yA7r4bkomuWfWbzeEM32unla+piYOOk0D4l4GD8XrWpqBKhtLQXOvJDEL0pny2pv17w/2x2fDUBcb5z9fcqVLPpTUk5eNt+kPW9KlL56LOoGeQqu0EfkpMB9jwLbaO43I9bCRn2cDfpHfa9minV9RLmHROFemNTrCDlp8Ojba7CubCVDV9+P1RSnzdmSjzLUmhhYsdvBv3cgUcUvRYf5yJwQYynACxLbjGKP5oGG4GkMajz7HnRyV9JVbpFuGoGBNx1Hi3mGc+GYFi5vp3kVHwPLpcucCOk4+xCj2gT6HpPVpyLpuOoKfHnvx3wQ8NyJgrMh34FHmo+4dMYsJW2JSXbQM4GgYTCWBB56Bz418++G3OiGDwnI/T/+TT6wZvhH7TTTuTI2K+w7/8XzkSHvSa5AhD1X8qRIo3Yl331ThFRr2qll2sQUqpmGCtRE8SgU3o1vOeFlOpS197T1826Rw0oa+OBbTT8HgR/n8Ni/D7e9txk6+FdsJ3Kso2Fs/mm08asL9Vi0rhdjtbsoWkGhNnvIKFhOp+MyYAleGdyOVusMO3EfETRViG2VVBG9ZoxjaT58KwdYrMhDYescDKN6oTwTexwRxVHzYROWbxp1AUY5j1THFD+bylVQk6B4cQ//lZp5Ji+AlUhXYVbNsdMd3JHHxONB6y3WnrU5sHNoOvgxEl56x4NpC2YrYyKxkHuuGWArtRqy5xJ6bWkxD3+y1s4jYAJpAwMZ1cp51XTek3669NJqPI9wuEkOr6m6X/kqkIpitEf orn91VlW 4YTFq40NBZPxnGv4hMcvqnntiCBwxettvNXu6ataKwCeq0RuBZl4/TLOdY+xVjy7vIpxKYiR900WJrAe5+AFEatxbg8mX0+wPPzD/2+8izcJvZhqGgXFUM3YCgzKu4eysNZwjr1dlfICC44w4rKs9ReuLs9hMkl9GwHpTz+5Hy6xI/pVFmH2+z0iCmDKpM1QwdLQlB+iLlkOqUYWeSui/8P9Gy+PnMeJv9/c/teZRDjNkGYlAxCZeLbKa/SdeLaTN1HtWRQuJapGAv48WvCbPDh6JNAIBAZDLERKO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 09:28:22AM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > In order to use execmem's API for temporal remapping of the memory > allocated from ROX cache as writable, there is a need to distinguish > between the state when the module is being formed and the state when it is > deconstructed and freed so that when module_memory_free() is called from > error paths during module loading it could restore ROX mappings. > > Replace open coded checks for MODULE_STATE_UNFORMED with a helper > function module_is_formed() and add a new MODULE_STATE_GONE that will be > set when the module is deconstructed and freed. > > Signed-off-by: Mike Rapoport (Microsoft) I've seen the rest of the discussion about this patch... but in case I forget, and from an extremely myopic kgdb/kdb point of view: Acked-by: Daniel Thompson (RISCstar) Daniel.