From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4BDEE77199 for ; Wed, 8 Jan 2025 13:50:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 738206B0082; Wed, 8 Jan 2025 08:50:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C1606B0088; Wed, 8 Jan 2025 08:50:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 561386B008A; Wed, 8 Jan 2025 08:50:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3707A6B0082 for ; Wed, 8 Jan 2025 08:50:23 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DA74614117B for ; Wed, 8 Jan 2025 13:50:22 +0000 (UTC) X-FDA: 82984419084.08.13AB47E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 3EC51160005 for ; Wed, 8 Jan 2025 13:50:21 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736344221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kUnPsKgtfCLP8/mvdYAfN7xgpNnrdA4BcrGL+u8Fii4=; b=OljKBvxeQtuxNsCElyQaL2/6jt9QOKCucJrWyw0VEShTSlYayXcGUFSC/gBF0ogTdZtE2q ViAIGQU/zNao+WSsvN1aSKMWidU3w5N5RK+GCnNKWRoXTw9EPE3IE2UGy9MKinM42O41ax hx1ViMLmAvDo6QdLTi+oo6fEJK6GdqA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736344221; a=rsa-sha256; cv=none; b=ZSdoU8bVPmT0H4/CGSd9TbjMtCcJHFbZu2vNyu4VZ2O8K5AkxAZi1tESpuU+rs8YHXLjHx i7zDm9noYoT48rxJjd2zjf/rx6aJt04I66R3P4gxCuUDXHeGxY+8AiUdO/FIq/kEuUQdW2 2JOjVocHqd1c+0s3RmZW0RDJvuUO9Fw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82CFA13D5; Wed, 8 Jan 2025 05:50:48 -0800 (PST) Received: from e133380.arm.com (e133380.arm.com [10.1.197.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 179663F673; Wed, 8 Jan 2025 05:50:16 -0800 (PST) Date: Wed, 8 Jan 2025 13:50:14 +0000 From: Dave Martin To: Akihiko Odaki Cc: Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , Baoquan He , Vivek Goyal , Dave Young , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, binutils@sourceware.org, devel@daynix.com Subject: Re: [PATCH v3 5/6] s390/crash: Use note name macros Message-ID: References: <20250107-elf-v3-0-99cb505b1ab2@daynix.com> <20250107-elf-v3-5-99cb505b1ab2@daynix.com> <965b73e7-d0a3-4fae-b0ec-70b5497cb6c4@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <965b73e7-d0a3-4fae-b0ec-70b5497cb6c4@daynix.com> X-Rspamd-Server: rspam05 X-Stat-Signature: fyzfig65g8yoaxjw7eydg4th9mnq5kun X-Rspamd-Queue-Id: 3EC51160005 X-Rspam-User: X-HE-Tag: 1736344221-169152 X-HE-Meta: U2FsdGVkX19O6gsbqDaEIMkY0DwYUEH0fmG6jJ1BLj23/V378E0Aw9LWP8dDZaX4aN+6BHmBCmL9qsVhu/EpqWLdMWWldSQ82VsAg9UvyP5fMEO6CNtfqwfV0JbIQmYfYDF2egQz0BpdL0msZb5nghIm3ag2slzHO6NK8PxEzNhIfJDsArPlDzeqmEMsUOJBN+JmqCYEG+/jFPK154ZLLgw0G5MLOcs7pz47uric7+XO5Z74TtW5uDGxbHJktehD540HTqr+xOWlehJrARWpscazNpj/YGQBP3yhkLIBnkBBGt3GVO86QGvlQmcmEXmOPM8c/XZ6Lph9Uh6e6k1TrWebir5Ztn9R4my/00uEwNEqEP96Kq+EIr8ApvvWgfZuOziQrMGW12lHsj6MqH6P7Qf+75VSq0KJbvSt4RzimPbKxCd2pMz+ZSPlWZwv2Qfss9zYDe00T1UqXhfdgsVbsXA/anRgNhOfxVAwMNlNzNqXNDyowlghuF3rjCkFs4ZQ3HxJ+Ly1hKd38wf+Pzr08jVHgf+5hBvBOaGvXv+x4bmiDH9wq/ZoP/beeXk0Y2E/mVHLyN9PbH303ObfJ38/+JZIaJJDFcm3b9/UfOgl8Nu6n185NW5P5QEubr2MVDVOJhAa6b7t7iOt2RkjOu1NZNtgjb+mMjC+2xhFAVuItPddUKkIzzMr72h15nfce4CWTTsG6lilWPpKCfWzYsYovRTVyLW7lIOnsr3uLZLIuQrDh5f8pIYT4NK0eJFOXapnCvpZ0IX5b4GYvEeqoCt+HeR0C4KFNUVAUinYP+hzdf9W71GWGqD+rMkteHDp5O+GW9Uyj7EEbERcgQpUvFJQ5Vyb/n3qIDYtrWt8ZK78wVN3bFX2vvb5+VAt3bO22GaEjr/1/P092JTzowqcwj88w2QGtlGRdqHlsH0e9YAeTkn7qMHs9oGOoaBTlKHXSsSRf305rQJUdMUj1Cc0T0N gpbs9rKW a+9d7GQTM1u2ch5jEIRELtAhwraC7Q6L4oS1FnWBR3dPeo4QmUwMuAagtWCuyT6Q6pCVbLzEHuB3TUfY4M88ZJU+vFama2tmzp6ONm5B91tzkc7H/bJu1Gr8gvAR7EnSw14kGv1MUQnbJq+IFUwlweeOGwdZTe8rcIBAzvgSafDrMEYf85IEToxO7iXBJWzLJu+AgFS8EU+YnIe4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: > On 2025/01/08 1:17, Dave Martin wrote: > > Hi, > > > > On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: > > > Use note name macros to match with the userspace's expectation. > > > > > > Signed-off-by: Akihiko Odaki > > > --- > > > arch/s390/kernel/crash_dump.c | 62 ++++++++++++++++--------------------------- > > > 1 file changed, 23 insertions(+), 39 deletions(-) > > > > > > diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c > > > > [...] > > > +#define NT_INIT(buf, type, desc) \ > > > + (nt_init_name((buf), NT_ ## type, &(desc), sizeof(desc), NN_ ## type)) [...] > > (Note also, the outer parentheses and the parentheses around (buf) > > appear redundant -- although harmless?) > > They only make a difference in trivial corner cases and may look needlessly > verbose. (In case there was a misunderstanding here, I meant that some parentheses can be removed without affecting correctness: #define NT_INIT(buf, type, desc) \ nt_init_name(buf, NT_ ## type, &(desc), sizeof(desc), NN_ ## type)) It still doesn't matter though -- and some people do prefer to be defensive anyway and err on the side of having too many parentheses rather than too few.) [...] Cheers ---Dave