From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0063FE77199 for ; Wed, 8 Jan 2025 17:33:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 848386B007B; Wed, 8 Jan 2025 12:33:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D1366B0083; Wed, 8 Jan 2025 12:33:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 671AB6B0085; Wed, 8 Jan 2025 12:33:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 469C36B007B for ; Wed, 8 Jan 2025 12:33:00 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D0A93B0C67 for ; Wed, 8 Jan 2025 17:32:59 +0000 (UTC) X-FDA: 82984980078.20.E0C8147 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 43791100018 for ; Wed, 8 Jan 2025 17:32:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pANWxhKc; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736357578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=efjfjhNy/ciPUjqdeZUPjdUi9qYemP+O/s6sz7yjRHE=; b=ukHy58vsPvaoldLVeH04nnRwCSdG5fFOjtmX/IkQHAc0m3Hd/2wVRRbPimDmhjlvYjTfT+ leNcwiPtj3JZTkWNMl9iC7NjbGASnf2x4DCoJhR8pCeVqYQHBP9lpoKTcJVjchp31vXFvG WdZBdgkYsL5MNSlPgf5/HU52Cy4G01E= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pANWxhKc; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736357578; a=rsa-sha256; cv=none; b=ojk4Ktnp+8JC7Tp3zuk6H6/OXsC+hdMz6HCMiOKYXvugoFKyHJojBHaw9OTz8JnENERyj3 mwNPbeZ1/Bz+5l4aqV35rexzWhfiOP5QcVPZuBFpWF4Vv33XoG0h6obRr0YclK8cX3YalC e4bbtUEXpjgX1Vy++ZvJdun8OUfH1vs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=efjfjhNy/ciPUjqdeZUPjdUi9qYemP+O/s6sz7yjRHE=; b=pANWxhKcc5wYNurkiGzQddiIqL w7FpUk/gg2lJv6MnbCeORlEgD9UrFNs//jhfIECLEtqRFCAv9y23s8T9g+biYYGyzU23Cjj5RQRzw +5FZck6XehMK7OSNvk8LNAReH3dmWzwsLeb1pqmxVDhp0x73Kct0k8oeL+bsrhDyCtganEVeG+Ghf 6R3I1t5hzKiYTOlpPwn/Yymgh5pjRJe/J8vxZ2cMggjbgWHpdfpB1TsMy8m8u1QFkUizqc/Mjplm1 klqEBhaNR0HRTpWaFEpms2iwL0Qt9vIBuQvU+zpmLBHN75pk2843p+7s4Ix2acbOOL0rFFJdubgZH nlqQdF5w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tVZvK-00000002GR2-2UD8; Wed, 08 Jan 2025 17:32:54 +0000 Date: Wed, 8 Jan 2025 17:32:54 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Andrew Morton , Jaya Kumar , Simona Vetter , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand Subject: Re: [RFC PATCH 3/3] fb_defio: do not use deprecated page->mapping, index fields Message-ID: References: <1e452b5b65f15a9a5d0c2ed3f5f812fdd1367603.1736352361.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1e452b5b65f15a9a5d0c2ed3f5f812fdd1367603.1736352361.git.lorenzo.stoakes@oracle.com> X-Rspamd-Queue-Id: 43791100018 X-Rspamd-Server: rspam12 X-Stat-Signature: jdmww1qc4guutuwhztbukbhzihcpeaji X-Rspam-User: X-HE-Tag: 1736357578-480296 X-HE-Meta: U2FsdGVkX183foNIDC1oHQBnLdb3Mu7Dx9DIw48IepA/fqdxWSDJCpsTsTnyPqOqzxVnfxgUIGi9vVXsaHq7Ia3GnRTHMw+k1uT1xtFIs9aZOKcRjjQ/PcWHH81AfhxIO7QV6zYBHpE0a5nDpJcv2aG+c1oF2b1FIijdrWXvsif3px/vxqylclsTfYUzAamSvaXFjjXuOPABlladU3484U2QoO9qHgPTyUeoBFCdaWe5ITwrq/Ldz1JRhmdjqtO2eTW/sQu6dkC8az2ksUrw2SRIu/o6UuwJwyYVrNa9Lmkjsuad3gRUECjdRDFtmJD9IAPDqIO1X5VzeqAmmZlX69tuBFg40o/jNtkEtkNgJHOhQc2YSwwLzN7EN5CHnxnleMg9YlPN+YVMs436ekNVuZJRmVuUiTtG8jUacgeRWN820itHAXt8+xiRhPHqi270yNdpvZRGeSIED3uKvzVDmVfIAr3LlvG+oK521/JTteozjHgK9/7q6+5lMVdgGa8ckO8NcCdirkpBw7tgCxSDIM1ybvikosOMr0AcUEuvg+PCsPvWF5qK+Q/BaJILsBVDFhWvg8gU5FO+fnolcjGGB4V3eupj5vOaRcvrenolKn6MjacxsYlrUc+QrFwy05tl9iqAPsezuafJ7pTTUgsIkEgbLsxoU0Gtg0QK3Z+ZlsBQ0slDxG9yZNDU4xO1X7Ku9H9vapH+rcTWIdFb9jMf6d3YuOCkPSYQQSuN6bFy2SVi6K9in546V30cvJLh30TweJGQhhieU+6YBV5FAxAgEu8EedP04z2ZfdqGCx2fwJHeptCdqmanz8h+V1HGEIKUJpEGL2LNo1PAc8j9EGaKOL5tGuOT0mk7O+Y+m7EIaCVFC5g/WC3aSupUVmJg/8vGY20jGXWVFYezrlEQo1x4pLC3hAZLBIxEDMq+eJtLo0jnKWcPsR0btR1D7c8f/Zn7Xu9EjjZhEgugiwJti1L IIitU1Mv TVsD2eGtJN+z1NSLKw/onAXnkdr5zJ/uKFQpa7/oRnNWEs7VagCamFsscEtxeacB2HgizkCfIL60iOeuJm8fB2kEQ1f5oRkitCU6igB3C5o3tsP9Hek8Osy6x3jsVsp9y7Y4roCI7ZvuQHg11761cAHCIL1vnL3tjuaDO9JAqd1yNcMNEi+Rmb+kC/xuuIOGxoP5X5d8d5oQagQnQsaFUwNNl7PPjOBQCRaCjQKwtMo53AUSHOmQiHMX7Iq+C6gRnRI+vWbe8IbIs05JuS+lnTKPdow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.021322, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 08, 2025 at 04:18:42PM +0000, Lorenzo Stoakes wrote: > @@ -280,7 +269,10 @@ static void fb_deferred_io_work(struct work_struct *work) > struct folio *folio = page_folio(pageref->page); > > folio_lock(folio); > - folio_mkclean(folio); > + rmap_wrprotect_file_page(fbdefio->mapping, > + pageref->offset >> PAGE_SHIFT, > + compound_nr(pageref->page), > + page_to_pfn(pageref->page)); > folio_unlock(folio); Why do we need to lock the folio? (since this isn't necessarily a folio) Also, do we need compound_nr() here? I _think_ for defio, the number of pages allocated per object are fixed, so this should be an fbdefio->nr_pages field? (something that's always troubled me about compound_nr() is that it returns 1 for tail pages and the number you actually expect for head pages)