From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA90E77197 for ; Tue, 7 Jan 2025 18:52:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C21116B009D; Tue, 7 Jan 2025 13:52:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD1586B009E; Tue, 7 Jan 2025 13:52:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98CE6B00A2; Tue, 7 Jan 2025 13:52:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8AD456B009D for ; Tue, 7 Jan 2025 13:52:42 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 114391C71FD for ; Tue, 7 Jan 2025 18:52:42 +0000 (UTC) X-FDA: 82981552164.18.9368741 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf07.hostedemail.com (Postfix) with ESMTP id 3227E4000F for ; Tue, 7 Jan 2025 18:52:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T0ueZ8by; spf=pass (imf07.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736275960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WKYDPoJDf5G97ixoaLVA9VDa5ofJjl1G+c8UFWYhtHY=; b=UKOVOiveIRVPs1zglit+s/60/iw2TYlqQIy6wScZyU+OTAS9+TFrtFKeSCqu2bscCU4Ex5 4JsIHCvF00PeHYMgVrEYautFc75oXknvtb2biUmwUUmVGbNqrtZgO7AjjnBIpBWHbI1Lph 44XvmkVMgwBC1BsRtncU60Fq0iAhR/w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736275960; a=rsa-sha256; cv=none; b=mjRu2N7lNcWRsj6bQk5qPl2A1SoHLXFM8kCGbf5/wDw42U+/L6DtuHtEOW9g2ymWmWbDPL 8veax59uX+/sGGVFkZxS2mCIrEeJ29V4aThH5ARZKB7PeXVYh7IRPYRso6tx84mZuTkNHa 965Tvg2aH9C2GAk6Azpz0TMiCpu78s8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T0ueZ8by; spf=pass (imf07.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-21625b4f978so11985ad.0 for ; Tue, 07 Jan 2025 10:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736275959; x=1736880759; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WKYDPoJDf5G97ixoaLVA9VDa5ofJjl1G+c8UFWYhtHY=; b=T0ueZ8by6KnwDGgOblkmDYQBDPtrFYBHLjNE11vTHHE+fAgH9js/Lt7E5928P0MCaf f8bJi4cW3yd50WDkTXT5SmVdUtXyJEzRiVMVXkoETaXf7QTUE3zD5PFAkg1fV1r3iFtr 2rf4qrSKbuX+huzcRM/tVUfVfgHMXm6Jng66ZVs0M2bxn7DTSKwW8Ihtp2tH1KTn0sqM bFkaCKspVQH1QXyG+Rpg2oAUufTddX8z5bSUEaVFzKT5vxDznxSX6eaPAr0BRLg7sd0M D4FsPKuJoJH8VGw6QxAW2TWkJDdAX5v5kxOEVqgSYDlua23qr7GrTSPX258XkO3+VNWH zXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736275959; x=1736880759; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WKYDPoJDf5G97ixoaLVA9VDa5ofJjl1G+c8UFWYhtHY=; b=ItqEFrQFWFnG11f472PjCHtCYUWgTS2yEcJxmGa/YsJDujpGCR1BmfzN+RNDFFhVcB pGjyROvDJfyjTkyibTHIBb82vhTDtkRsiLOylFP/ekZ3//N4vqphUn22XqoLzBRfmzIM 1e15AfZz3dfjmmwzACvoqlpoiPno0NHjallm7bWADJf1kG6FKmGGL6V7ltiYBcegCMkj dZ7eji9Aiew56535KRiSsEX3r3suMzvUMWQPkgOt0SLyZsd308AtCNgefND/DAeK0KJ3 6vF7rz295aCoLAnpw4pcJbAvtM3jkd9ZDPjVAMR49uKbNnNSKliXhecf5+KIliUmpfkO Nz4Q== X-Forwarded-Encrypted: i=1; AJvYcCW5JFfkNHQSaomMyH1TKDzLMeC3v3ssJz5xOL0VBp6ydHBFCheUCjSjghh5YSUpW8kqHsj+xbXDgw==@kvack.org X-Gm-Message-State: AOJu0YxKXz2jtj+2ICgRU+VaWdJCD886jkrwDnkH6RvZvjqaNH/YnY6b wLLWi86P+aZHttgfC/l+yYGiTeEB9DtqaxM9q8D7ShRiHMFo3akDoJM0BvllHw== X-Gm-Gg: ASbGnctDc6ggwTqA/CDq2ekyjrphXKgJmIPDw7/T6DTJhIJVfVKHvJ6m8va0copFeub /WFAIvPOUzYBC08v2vYOPLSP13H/fEjfudVNHsfiopzBHSMQrcIJB0yNGMoz2/XYh7ynnt2HDl1 bcZ21/KYJYAlTS7Ozx+b9m/yjdrn1mEqPpA8N/DQuQgubaSQ83wPmYC4HwtfvTtTKRmflf/RDbG wUmqwKS+N56o+U518QSrQGTGBrSABpaB7HtpDm++QWdRmsJrnwiOKea X-Google-Smtp-Source: AGHT+IHYa3h3hF3pQ/cbQJnbO0VppeiwjRz7wH+8tSVibTYQBeWBH2bqNQmCQx5+KIvI+cU46YzkVg== X-Received: by 2002:a17:902:c406:b0:215:44af:313b with SMTP id d9443c01a7336-21a83fe0bcfmr127435ad.0.1736275958764; Tue, 07 Jan 2025 10:52:38 -0800 (PST) Received: from google.com ([2620:15c:2d:3:be5c:2ec2:68e6:cb66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc962d53sm314249785ad.33.2025.01.07.10.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 10:52:38 -0800 (PST) Date: Tue, 7 Jan 2025 10:52:34 -0800 From: Isaac Manjarres To: Lorenzo Stoakes Cc: Andrew Morton , kaleshsingh@google.com, jstultz@google.com, aliceryhl@google.com, surenb@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/2] Cleanup for memfd_create() Message-ID: References: <20250102230658.1112261-1-isaacmanjarres@google.com> <9ee67338-b0af-4fdf-b8d6-bab4e6c4ccc3@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ee67338-b0af-4fdf-b8d6-bab4e6c4ccc3@lucifer.local> X-Rspamd-Queue-Id: 3227E4000F X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 6zxwe5zb33sp53kn1oc3uu35q86kujcg X-HE-Tag: 1736275960-647536 X-HE-Meta: U2FsdGVkX1/X9EW5gsGh9Qo/4i46p8v8P/PNS+n0wnXg2BgwxPMvczt6EVz7bCJiF8icGxT8/z+7xDRBpJ30eMWowMMfNYZZjzLLxjwKtgTuawQX28Wplww+RlXC7/pxfccjbLU2MoVtp1cb7eZ1zfcZAVK511pO1qmpKjGuArQLMOtBP9owhCqPAmK1ivu33yhymi8BrkY4F+dQBOCIKCS6nr+raYb/yTHy3GW7vU4M6aCj7Q6xib9O94qLf5x52sxJcrH10X7/c/sUHMs/jOyN+Pb8Xtvrd/irV6hi4Q8KlW53BYkHiO4fPcrINtN5YUuXFySELSCLGilM0Occ+Eus+AdiQj50NH50sBUGVyhp6bxHYfbVJE3S87q7b5pQlaktQn+bdj0XaoBtC71CuwQQLUyKn6Uoc9JUAUdyl2oKXkad1VnpNM8oSHNq5HUilkkTPWvYYQgKahaAjO6qpGghwUCQW7rvELXX+A/8QN0sDD3XBSdG9fzQQVHxGvJOlrvt9blK8LcBXxlHImIDs9XYa6SfpFOCH5am/NeH2EOS1pE1uOaVbaYZuOTB2IfvIGlnaG94iYY7W6g8gwC4FKHfvmpf5WfiJCb/vl/mk/Or+9gI/TDXKmMn2wlYlj2IInqLJN44VommT/K6C8spEbLyVEv3PwYw8A1BpsqswplwKhlHKemNHAEGhomdARD2vYh6JFMJp1PhPbl9lWH0d4IEojCX5ifD0ER+9uQgYcUAyTzi99yYLTnIB3D/YQF9MUF1biST6dSuz0vScIrkQYacrLGttkGDbN0NCtdHm1jTHKWPmUqfu7HYSC3eZ57Z9DGZfHUH0R44slvUvr6cOfvH39/UQFdeODbeW0Hm2RWcQ3AuGvW9X/wMqZSwowFhyl5VXrDy4KXXPB6gmZwZZ+BUkdbOEpjh7vuRib7ihizCgBeN20nQ2vB+ldUFmOHRd23SvlOh76Am4L6oCMa EeNqo/dE ubqgGYjBUAlxaMxXYOU5XaAvCenftNvC6lHQlJWX4DZnMCDvSDm+xdEB7so7PJXNVppLBmTHUPKKIwvezM2BDbkY44JgCASASQwHdVZqE8ziZHJc5SJGQDJeaCn9WSsDCFI3I3qKzzCA45VR50Mp9154qKLyU6ceiYRVbG6LYabehZ7Dlxx+ZHDYX/Mj4NRVymRf6mXxh2nbap0+O07rR3JjWS/8boMUdSuM/3ghmSbCQHNFN8aAjHxIjaVOdD7bGtZuqYWnhXVEkEM1dKAUtIXSW3kevktVcrYcrS6EsPa+6ytJ6335KBA0qdFU8Ak0PuSrRTrSVnWks4Eoq2kv24OsrHJwSN/cFaaKSV9+CyILcOjGlJtCwS6mnGtX1Bv/uNnAsMf9q+mD0nkw4YXAY/+tlQLyfBEaPXELnlWnODSDufmAXpcNX1cPsbgkXuOMyiPJiNrWeB1vIA1E= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.498823, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 07, 2025 at 03:09:49PM +0000, Lorenzo Stoakes wrote: > On Thu, Jan 02, 2025 at 03:06:53PM -0800, Isaac J. Manjarres wrote: > > memfd_create() handles all of its logic in a single function. Some of > > the logic in the function is also somewhat contrived (i.e. copying the > > memfd name from userpace). > > > > This series aims to cleanup memfd_create() by splitting out the logic > > into helper functions, and simplifying the memfd name copying to make > > the code easier to follow. > > > > This has no intended functional changes. > > > > What is this against? I tried b4 shazam'ing it against mm-unstable and it > didn't apply. Could you rebase on mm-unstable? > > Thanks! > Hi Lorenzo, I had uploaded this against Linus' master branch. However, I've uploaded a second version that is just a rebase on mm-unstable, as requested: https://lore.kernel.org/all/20250107184804.4074147-1-isaacmanjarres@google.com/ Thanks, Isaac