From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F63E77199 for ; Tue, 7 Jan 2025 14:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D22F26B00BE; Tue, 7 Jan 2025 09:22:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD3276B00BF; Tue, 7 Jan 2025 09:22:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B731D6B00C3; Tue, 7 Jan 2025 09:22:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 978956B00BE for ; Tue, 7 Jan 2025 09:22:43 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28CB31609C8 for ; Tue, 7 Jan 2025 14:22:43 +0000 (UTC) X-FDA: 82980871806.06.6E08832 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf26.hostedemail.com (Postfix) with ESMTP id AFBFC140005 for ; Tue, 7 Jan 2025 14:22:40 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=m0f+8NRk; spf=pass (imf26.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736259760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2B7QsXhwZNID9hkdJMhXhhx17J8OxXWuj8JjzDXzWQA=; b=gScyWHQEhhqY2J3bxihbXfys8MxGbA/Is0WFEZbQn80OB2ATVktHGyFOt+FNZgJ9atAJnZ z224WVgWYYpfd4CdJ9o/xQO6K8PrFkfUSCJ0z0dQslq/HhiGKHrxTDuubrpitZprOVL6ol 0rewA+tBQZm68S0+aFtBOzSwfYroHAg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736259760; a=rsa-sha256; cv=none; b=U5dBXYPhlSuqbgVOrr9f3LlVuPU1rO9Jvt/4iAYfU19iP9O1GdRuBFWAOPjb4dIhaiI0Q/ 9pOWhzri6A8IWOK2VXWCOl0Dt81P+K7XiKVwd8nS1u/d8eG0GzUXhnJqcPWAUVbciw2Sk/ MNmk8xK20cSPRiGCdhG1+JN4ywgU7BE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=m0f+8NRk; spf=pass (imf26.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50785ZGY017710; Tue, 7 Jan 2025 14:22:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=2B7QsXhwZNID9hkdJMhXhhx17J8OxX Wuj8JjzDXzWQA=; b=m0f+8NRkRQ5k6iEjZnjbuEmNBycrqf76ItjYHFoPDUTOdH tsDcx5zUcXHTnSo13TQHIktaMW3Ad5Lgiteov3XI7UyYvcHfs7tupMQKv7w+lpWi 4YLFjjrj3XJCNnlUHzBTj+CqV5Wfk1Tu9P3NK58XARBZIsYIoNvUqA/O4coLLn3B ZSyQoHvvvyoIu5c9lj7lHuDq6Jy7QSdEt4aDTyu6zAC3xDyVGqw+EC8rnEQUvB4M qTx/kRHnKTqWC1L1KpzOVhfnwVqqgCP8PkyNrpobTfKho0LfDQVBy1vGN7qwBYGb bQQ9LoXaqcbGbf/ddlkC1nG1T6m79jZRlMxk0gng== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4410f39jwh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 14:22:20 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 507E7cHb024539; Tue, 7 Jan 2025 14:22:20 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4410f39jwe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 14:22:20 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 507AEgaT027976; Tue, 7 Jan 2025 14:22:19 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yhhk2m6g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 14:22:19 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 507EMHnJ39453010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jan 2025 14:22:17 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3E19420043; Tue, 7 Jan 2025 14:22:17 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 584C920040; Tue, 7 Jan 2025 14:22:16 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 7 Jan 2025 14:22:16 +0000 (GMT) Date: Tue, 7 Jan 2025 15:22:15 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH v4 15/15] mm: pgtable: introduce generic pagetable_dtor_free() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: yROkuy-wyK9H6Q7dEn2Q7Ir9AUmTd7MT X-Proofpoint-ORIG-GUID: J54oxTq0KOpExrJ-UIH_1SyWDONwdbzM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=578 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501070118 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AFBFC140005 X-Stat-Signature: zpd1gt5xpnsooweyp5t76uerr5ksbxt4 X-Rspam-User: X-HE-Tag: 1736259760-914910 X-HE-Meta: U2FsdGVkX19uRIApdLt6LxkZx3fJfo+4s0QW27UZm3J9RwKmoqIttwmzhjmvZIsHIMbYcjETJeT6E2X7v5mE2CDYw+CUTfzK+ZVZj0iCaA1UO0GVnP0mhJA5sP9ve6W0nHCwOM/XZ/o9jRxZ0WI605nK/Y7pCwly3Rd3UtxmLFT8VEcLkDgBrUM4BlQ64LOBBhFePb4CeYCYoZ5ZLj3m2qPqrhO1uzp70YObF+VzoSBPS0dRAEYBNkpKqwPHC5dCCi/YvmbSiRbqBCNmZH6o9EZbGz88/E91kSexUaq0ZvElUtSyX7Etc9KMh8TDDpwWtmrGlEtz7ppdT0rqWDccOCu3dV4ocQSUd0h88tLLtrdZayixCFxOGxqQtNsFDao0P8SVGSdN7jT56abvJXWNNtX2C013QRYxObNyjrqVOFrFiE6L5bw3JHgIUQ1WR935GvunzZEpJGJmXzInnoOzLILxIUUy6WeADm+nCdwlkgYVGB1p8crJlj/U9SQzAm82wA+Y5cgYY94jNX91OZnf8lJzy3AGgG6y84H0BpOivImM0X2rauQYQJbZtCARB0WGOVHQDcUMHw3C0kEd0+DOHHtihLnQlLjMmGJCYHmOq8xnpej78jB4WSPIUgjSGVynr8RYEvoAO8Ph8LmDC+KcVVeg3F6DxXA4fKgwk/NiZLDitoPUtJek7A+anKTeLEjVmCyzqObplwajZG5qZNS1liMbGKGnM2UBlRYTjwViM1cGff+GfkFFHHPkD0Zctnt4mUpx6KgQ8m2yKX6r8U3A7CdwW0F7JPo5B/0dDP9sB8gWzkdC4uZQwgryhRlQMOnu6JRaCLny1rr142kkxQISmbT4T4TrcDgxjyfjYheOHEH3aK1GlYAMOyD/9l5/u2TNjtQm7RbRy3ofsahEdZUXviNByxoewmuZMGp4RTCLJzPMEybk6qTwUkyXpPevJLIR7UwXwgyUPhT8DsXGLrN jkCpTGMP /Pt/vsfo7APh9X9YucmGBoyc3r/jbLOmApIm5R3QOPnihAOVxGFhwaCwLfiBVN8NwfU15qSYzqifbb+1GNr8KFpZ75orimKO+tryAvJpfUPLUx9QvkLX1w+D11n3TvKOJaZp9FwLD5YQcvRI/7xw+Sq90SDaRsL7o9vHrpxkd0DpidngddDYEzp2LrTd71YC3zhEmylt+XcqaumqAFK1KwAlVu06l4TePqczbOblK/DjIY3Z4CwQTRhC3M6dDxhIaAwbRs+W30W1TZ2j3eRUeGnyOLBuDxci6d5ii3EbB28PILtpvvjfryFi+no7svZ5IjW7csh8cZppn5kOZiWvaEjEja695cAeZBkdV8wZGs0FC18AI7mjmbOJ62Pk+AZlpdqinnXVv3omCrHmBiTH+gydh3PI0Jr9uT3PkBLvgMPANxpOuYmEiuTEiJWjHzY72aWgZfplzksn1geJVRydQvx+QxKYBTKrxfhbEzOxNuMWbQxRQXg5soBmroHS/pt2SO6FeLfLtaI3QhyOxD2VCq/WSYjSDaZI+TaZm/fNS1lM58lRJc42htCkxsszFYsK0QqyR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 30, 2024 at 05:07:50PM +0800, Qi Zheng wrote: > The pte_free(), pmd_free(), __pud_free() and __p4d_free() in > asm-generic/pgalloc.h and the generic __tlb_remove_table() are basically > the same, so let's introduce pagetable_dtor_free() to deduplicate them. > > In addition, the pagetable_dtor_free() in s390 does the same thing, so > let's s390 also calls generic pagetable_dtor_free(). > > Signed-off-by: Qi Zheng > Suggested-by: Peter Zijlstra (Intel) > --- > arch/s390/mm/pgalloc.c | 6 ------ > include/asm-generic/pgalloc.h | 12 ++++-------- > include/asm-generic/tlb.h | 3 +-- > include/linux/mm.h | 6 ++++++ > 4 files changed, 11 insertions(+), 16 deletions(-) > > diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c > index 3e002dea6278f..a4e7619020931 100644 > --- a/arch/s390/mm/pgalloc.c > +++ b/arch/s390/mm/pgalloc.c > @@ -180,12 +180,6 @@ unsigned long *page_table_alloc(struct mm_struct *mm) > return table; > } > > -static void pagetable_dtor_free(struct ptdesc *ptdesc) > -{ > - pagetable_dtor(ptdesc); > - pagetable_free(ptdesc); > -} > - > void page_table_free(struct mm_struct *mm, unsigned long *table) > { > struct ptdesc *ptdesc = virt_to_ptdesc(table); > diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h > index 4afb346eae255..e3977ddca15e4 100644 > --- a/include/asm-generic/pgalloc.h > +++ b/include/asm-generic/pgalloc.h > @@ -109,8 +109,7 @@ static inline void pte_free(struct mm_struct *mm, struct page *pte_page) > { > struct ptdesc *ptdesc = page_ptdesc(pte_page); > > - pagetable_dtor(ptdesc); > - pagetable_free(ptdesc); > + pagetable_dtor_free(ptdesc); > } > > > @@ -153,8 +152,7 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) > struct ptdesc *ptdesc = virt_to_ptdesc(pmd); > > BUG_ON((unsigned long)pmd & (PAGE_SIZE-1)); > - pagetable_dtor(ptdesc); > - pagetable_free(ptdesc); > + pagetable_dtor_free(ptdesc); > } > #endif > > @@ -202,8 +200,7 @@ static inline void __pud_free(struct mm_struct *mm, pud_t *pud) > struct ptdesc *ptdesc = virt_to_ptdesc(pud); > > BUG_ON((unsigned long)pud & (PAGE_SIZE-1)); > - pagetable_dtor(ptdesc); > - pagetable_free(ptdesc); > + pagetable_dtor_free(ptdesc); > } > > #ifndef __HAVE_ARCH_PUD_FREE > @@ -248,8 +245,7 @@ static inline void __p4d_free(struct mm_struct *mm, p4d_t *p4d) > struct ptdesc *ptdesc = virt_to_ptdesc(p4d); > > BUG_ON((unsigned long)p4d & (PAGE_SIZE-1)); > - pagetable_dtor(ptdesc); > - pagetable_free(ptdesc); > + pagetable_dtor_free(ptdesc); > } > > #ifndef __HAVE_ARCH_P4D_FREE > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > index 69de47c7ef3c5..a96d4b440f3da 100644 > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -213,8 +213,7 @@ static inline void __tlb_remove_table(void *table) > { > struct ptdesc *ptdesc = (struct ptdesc *)table; > > - pagetable_dtor(ptdesc); > - pagetable_free(ptdesc); > + pagetable_dtor_free(ptdesc); > } > #endif > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index cad11fa10c192..94078c488e904 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3001,6 +3001,12 @@ static inline void pagetable_dtor(struct ptdesc *ptdesc) > lruvec_stat_sub_folio(folio, NR_PAGETABLE); > } > > +static inline void pagetable_dtor_free(struct ptdesc *ptdesc) > +{ > + pagetable_dtor(ptdesc); > + pagetable_free(ptdesc); > +} > + > static inline bool pagetable_pte_ctor(struct ptdesc *ptdesc) > { > struct folio *folio = ptdesc_folio(ptdesc); For s390: Acked-by: Alexander Gordeev Thanks!