From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D748E77197 for ; Thu, 9 Jan 2025 12:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD2266B007B; Thu, 9 Jan 2025 07:08:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5CDE6B0082; Thu, 9 Jan 2025 07:08:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FBDE6B0083; Thu, 9 Jan 2025 07:08:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6BB836B007B for ; Thu, 9 Jan 2025 07:08:29 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 39C39161886 for ; Thu, 9 Jan 2025 12:08:12 +0000 (UTC) X-FDA: 82987790466.19.C040130 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 51FC420003 for ; Thu, 9 Jan 2025 12:08:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736424490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4YVgIS/5ZlAwoAZTi+PHEKdEfNzJGY2kEocFY8AfogE=; b=uMHJ06lOjwAO5lscrzKb1sz5UzMI8+ORg0YHBtKIS14GhKKSQeY8lKLTFxgg1vtxSxSOMc CgWnpptTl6TSGcVj148aLk2S55tgCuN4U87UCHMFwICOnjxVXSaT165Eis6hh69HxcNAQs lhzM+NMS8Q0p99ktnc2MaS74VkzAtck= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736424490; a=rsa-sha256; cv=none; b=UCsK5qj8/8njDVacBxeBMyuM9b5zYQvR+cnHXca6ZiPwuyJHeDZNYnhe1zSKoP4nKKaov4 K2g9d4Kx4dv/UZKGQpCwHm6IKIAux+XAeNqu26gV8nkSJabnJdfaLZ62nX3vrAKTKPDSFM f7iCRzXWWZB3F0I9Pi+GerSmMIMnnIE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7ABC712FC; Thu, 9 Jan 2025 04:08:37 -0800 (PST) Received: from e133380.arm.com (e133380.arm.com [10.1.197.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DBD483F673; Thu, 9 Jan 2025 04:08:06 -0800 (PST) Date: Thu, 9 Jan 2025 12:08:04 +0000 From: Dave Martin To: Akihiko Odaki Cc: Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , Baoquan He , Vivek Goyal , Dave Young , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, binutils@sourceware.org, devel@daynix.com Subject: Re: [PATCH v3 5/6] s390/crash: Use note name macros Message-ID: References: <20250107-elf-v3-0-99cb505b1ab2@daynix.com> <20250107-elf-v3-5-99cb505b1ab2@daynix.com> <965b73e7-d0a3-4fae-b0ec-70b5497cb6c4@daynix.com> <2ad7234d-bfc5-49e3-abe6-7a85d992329d@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ad7234d-bfc5-49e3-abe6-7a85d992329d@daynix.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 51FC420003 X-Stat-Signature: wixpdroesfipy59okax7shuazxroi6to X-Rspam-User: X-HE-Tag: 1736424490-912273 X-HE-Meta: U2FsdGVkX1/C1WKuvnQ9vHLepEKhYgoCJqJ+0vC0FjZQ3zKXw2H9MYBdGS+c083tU0fUBJm79BAlTstx+/U8j6kPbOD1qr2gR7MkDxVXWm247HychyTp9/kQt42OMiRnbGNPLAgi8cOxwokIrPTGJqCXqEvP684Xoojbd8PmVngWjAnvhFVyAxhOkcRGEtbrtrRliAmbuEXZdERvhJVGbASQbNAD34hd5U7vcgSlHMExa7pBin5anw7WqyYrXBEz3QUFoWElRUf5I6Vwt8lmshI6QDzzjueSjkQn0D04FZrFq3zks2rEUhEsci9i+OSs/X27LuUPGt9HonXTTR4T6wqdPjW/ZaoQcglShChXpG/vxmrO5fXZ/b/9g0B8NpzfCKL0t6cHRoiOkoeKI7rAsRy4rDcuvh5C5rS56ItzOU1H3CPf1oRZgPrUAJek9v0VxMYg6miGe86utCSHMFYitUmu90RG+LqLHv65WWTszECDXKw4+hTlgQZLhkLZHbPCYRO/wkS6SPEONwwQ4irO/iDszyAuV443ItpQ2cPB2Ri41/osQQ5OrMpP46m7JML4t6D8tj9JpsNeoFROHW+nQ3ek39DRTmLlTPyPKDuztOf8+eFSPu1YFm0MTW0J5DcDTs/Vli01OPSbznBGDqx9Z6P3bHA4aX4M9xN17Ss5QIGwwP5xHknI6jvK/JweLkZ4jTL9I+1PACO0DdQ063VUbLAKl8hHEUDAktq3IqlvTcrHsrmuLO9/uqy4g2IsH2cqAxONuAtyHUp2xPXYT5EHqKBGaT/bP9KtUIuTyv/i8GeC9FAz2nPOv+eryjwqroFxaVPEtuw5Kf0QUlnr6MD7+V0FXQQb/NxNypq0JfeJRm1ZQ49ZOTUdwwn7D5+0EJTr0FJntPMFZcLq4kEvCklnPUYbBXwL/nPAExjcINhsd6WuCROyhVV5uHGP4K9PAZUV7bSV0kni9vjAl5wOHsW hO33dYjD M6J2PASf+sSo5MqigKtV1ep9YKDN5EEYkCtKggQ/cGTzBCgKWVPZ9dgwyPSlvVMKsRxT2aFzAju/3XwAYK6XgLwNab1JpNTUungvla9UvX1lyqQ00SuS4TuRMzZRedB2t8ZJ8Ga452kMuvwxFtnV7ipurlmGO8hLw5ride2mnaDmK09AlvXG//XZQXF8v/QjqLrIlwy1c6i+pDno= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, Jan 09, 2025 at 02:29:19PM +0900, Akihiko Odaki wrote: > On 2025/01/08 22:50, Dave Martin wrote: > > On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: > > > On 2025/01/08 1:17, Dave Martin wrote: > > > > Hi, > > > > > > > > On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: > > > > > Use note name macros to match with the userspace's expectation. > > > > > > > > > > Signed-off-by: Akihiko Odaki > > > > > --- > > > > > arch/s390/kernel/crash_dump.c | 62 ++++++++++++++++--------------------------- > > > > > 1 file changed, 23 insertions(+), 39 deletions(-) > > > > > > > > > > diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c > > > > > > > > [...] > > > > > > > +#define NT_INIT(buf, type, desc) \ > > > > > + (nt_init_name((buf), NT_ ## type, &(desc), sizeof(desc), NN_ ## type)) > > > > [...] > > > > > > (Note also, the outer parentheses and the parentheses around (buf) > > > > appear redundant -- although harmless?) > > > > > > They only make a difference in trivial corner cases and may look needlessly > > > verbose. > > > > (In case there was a misunderstanding here, I meant that some > > parentheses can be removed without affecting correctness: > > > > #define NT_INIT(buf, type, desc) \ > > nt_init_name(buf, NT_ ## type, &(desc), sizeof(desc), NN_ ## type)) > > > > It still doesn't matter though -- and some people do prefer to be > > defensive anyway and err on the side of having too many parentheses > > rather than too few.) > > Well, being very pedantic, there are some cases where these parentheses have > some effect. > > If you omit the outer parentheses, the following code will have different > consequences: > a->NT_INIT(buf, PRSTATUS, desc) > > The parentheses around buf will make difference for the following code: > #define COMMA , > NT_INIT(NULL COMMA buf, PRSTATUS, desc) > > But nobody will write such code. Ah, it looks like you're right on both! Apologies for the noise. (I must try find a neat use for these...) Cheers ---Dave