From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DB3E77188 for ; Tue, 24 Dec 2024 19:04:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A070E6B0082; Tue, 24 Dec 2024 14:04:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9900A6B0083; Tue, 24 Dec 2024 14:04:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8311C6B0085; Tue, 24 Dec 2024 14:04:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 63F036B0082 for ; Tue, 24 Dec 2024 14:04:55 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DE474121B47 for ; Tue, 24 Dec 2024 19:04:54 +0000 (UTC) X-FDA: 82930778112.27.3DA7B53 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 3D1A7180004 for ; Tue, 24 Dec 2024 19:04:25 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XNHIVWYz; spf=pass (imf06.hostedemail.com: domain of yuzhao@google.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735067047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+gQgO0It7CURSu9wG5Nm/XdljrqD36vrZMH4FWJBR8=; b=LO7SdeW+Jr57h3EnPLgRmQ7dggivES7N3F4DnA9sp1nJMi1xgMcmYSdxFszw5pYsO1H68k o9/QMQMHwXbK3D3GulIsk6xzcN9n2qHZ/gRBtDSd2+k/7q0Pq2efpduWqDFpHfxWZyEsfk tRKztR3vl8wVvHs97AjEG6Ir5lUmD64= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735067047; a=rsa-sha256; cv=none; b=EtT8H1qB0xVUFae0QML6EiNBBlZAYXlP4Ppu13cRQxyH+jJLG2t2hs/2+goLYfu68U87OH dQKcgs3WVJFpKBYb5eqxBjSzCqyHa6FVtfm/X1+bxM1l5zMSJb/DxzFsRdsvFEQUivxDK8 m8gN6cVbX+IWxGR7kXLGOI4YkQzxLUA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XNHIVWYz; spf=pass (imf06.hostedemail.com: domain of yuzhao@google.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2162c0f6a39so64428835ad.0 for ; Tue, 24 Dec 2024 11:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735067092; x=1735671892; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h+gQgO0It7CURSu9wG5Nm/XdljrqD36vrZMH4FWJBR8=; b=XNHIVWYzg24K/tU6NJvJ+oFUEKjdpbxYMI3og2tNfyxhc0kXSXq1lqAlCjOgQgkvxW gQIFCeYIN6oafa6i74Kbjt6IhbJqwaTUIJ0ergZwar50VSa9giaI+NNSw73NzRryGRYi JP2htlDxTf9nN2sb2cXbI1asnk+tL+Z7b3qsxZkuaiyF65uollMoQaS1pZcJcaYpqxl7 tv6q15Ibv4ahvEuBU7JP8Z6Ptvuvrsqh6JhWmrvgvAfqZ7nWb2CF5x/9ViDhNKfmWySA yXWY1xvlHaMJEGf6tWF8GW2A6/NWb+VtdaUxJ/QhzEtdE9heK2Lv+JlkKYFqF//Lgvz7 K+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735067092; x=1735671892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h+gQgO0It7CURSu9wG5Nm/XdljrqD36vrZMH4FWJBR8=; b=xPDZZ+dvNPzbwaZRxyCawNlDLNeRgFFlPZwk+GRnBQE5FZYYEk8DJBxPj2QgKJaw16 hBBqe/hkX6dF2Bxi682hAm4z329X80TTHl2fq9d6vW31B8f0dV2iW4LwXP/L2djFquCO vqXjczGc97Wi+EhZLYr7V9wR/2um6bqnmIrm2CP/P2sfjejTOQkgHO88k4pZaJTs/pph bzMldPiyCxhZXnIKlVvpLUiIqivcSH+6QJ519nrL0pCcznKqHJiAqvOvttJZdCZO2iLd OcTUalUoJLVrWGbXnRJTbVoAZf2/PVh5UKcm+HWdItv0r3zE9kuyh+71gL3Pu8H+/xy/ w1wQ== X-Forwarded-Encrypted: i=1; AJvYcCUx/8A/19sLQ3i56IVAGK8EWPzg9sX0MlkbL/7UE+x5/t/nnUvPkrPbXlvhHGSbpBhkPLPVRFDB1w==@kvack.org X-Gm-Message-State: AOJu0YyTe7qpvi7DT8hEtO1f77YcpO4VeudhCgTYSb1zb1yJXI4s1UHv /xIp6SnJIHEoiTKMdkedsAOzmwWOw47RCUEIc3yGMcURosyAXUifamiZ1KjHEboW/y2rx+peYn1 r1Q== X-Gm-Gg: ASbGncuRRcq2gyqDxkEtDm1nq+N3vxgL63sTjhow6RQF20STAtQY/EFr0kQIPdq55C/ vaCTZbW6nrre0KdjRtPdLPQAwhq0dSWog5Hn9ZRKRU+GnrWaVXMM/7lxb58zQ18m3MF2z2hwOMn sdH3xAu+IO0SY0Vl6Tei4AAwtDa7+LjTRTRqEwfHSxWknH+Q9d8sDzBZNSABGVxSpRUJPHc5yVQ OtQGMBiD0eHLRc3FyWG8YoYdoOAx9qWzSr4LDWLDTmXNSZSjnUrS8NcTXSzSCDlHO5gSxJgP3Uw c+QEhZPoIOg= X-Google-Smtp-Source: AGHT+IGgGVLlkjA9w/VtqNXWyqg+jv5tiTXwN8tN2Oz9Yo90E1ls4Xqit+S0t1EQxNnAyTSX36f2ig== X-Received: by 2002:a05:6a00:858b:b0:725:f359:4641 with SMTP id d2e1a72fcca58-72abdab904fmr27560136b3a.1.1735067091430; Tue, 24 Dec 2024 11:04:51 -0800 (PST) Received: from google.com ([2a00:79e0:2e28:6:3042:405c:6cff:1a37]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72afb89fedesm630246b3a.84.2024.12.24.11.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2024 11:04:50 -0800 (PST) Date: Tue, 24 Dec 2024 12:04:44 -0700 From: Yu Zhao To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Kairui Song , Kalesh Singh , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v3 6/6] mm/mglru: rework workingset protection Message-ID: References: <20241207221522.2250311-7-yuzhao@google.com> <202412231601.f1eb8f84-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202412231601.f1eb8f84-lkp@intel.com> X-Rspamd-Queue-Id: 3D1A7180004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: yo7spz3j9jejafcfebkswwi9upez4hod X-HE-Tag: 1735067065-694380 X-HE-Meta: U2FsdGVkX1+WkgCpV59H6V1ARs6vwO+qXpFJlh5ZMRc8B/mFWbFkrlF7HcTU+n+o0ziigbXT0BUrDON/migRcH+FyLGSWIYazBLZ/uq30pw/JvNi15Zhlygbv1W402v5MrpdJzVoYUaNJHydTl43OtzyPCIhDlkskaMzRUPehKS5qOrH0ICZT9/ybKMvHlmMY4fYqHSkfg89S92ORW6iPfpRGN/z6P42oefclnzCXTpZAGMOYV4A1khm3Ux3BRBIQbJeMF+OINDE5yCdlddVeEZPEjtIi4E5c9gegFLoMgjdWYyIIItPAhHcp+JWfCGUAcrgeip/LN+OhPqINZ8u4Cnc/EWDaLXkmxcyjtilJjnFcY3MbuZQU4hmQdjqD873JM8PMkTCUFoAcwMrt+IlM3ZCqnsvvVZb+e748+InNCPJ1DzEs0PgiE8vKUIDL9IH4oaGIUm6SPJmLULHHrA59PvRux22pzeO/r3HUi1t0IVAYIOt9oXBudeCVTSUkJegIvGkGJY4e9iByaaYTNOh9kXRpePwJW6v5zs3RIswt9KU4sRtwm7UXohVTxnEDJyS3fO7cy8RVwFLY5wyXRFtsejWxvppD5P/K3SIMUe/j9MYllrL3Q7KmxE0NfkFB5kSllFsfBXwx70poqF/RO1jrV565hTTQC//oy65wh7D05E04PXo28sFnZrg27m+SiYGZ+eyZkVxUWuj7jIvFlE6hpfdS9Enr1QfMUK9MM8yyYrO5+Ie+wSm3eESo83kb98Nqa70RAeTBSYJ504SySc+ZsCCApYBIVYdXAKVpxVQHoCL994AeGVBjETn2fk/Nfrafahyv/XVOrsfWIpu9/tp72ghHO/TzdP2Fs4bp5UJdyOQU2kVS0uoNzSl3tq9mxGykKUHfrjIdEXcCLk5qFAwL1TSOo+S6vkPeY+oMoqWxHxUy2U9pNRfJZz9zOaEzcHCQBmGXiNIpZvU0r56bEO C5+SerFF Rq+eQfWPb0UYFgEWGb5FaQf/lxcU+6iiuLZ6dioIGqx/OXP6DCoS1Eioh0okICiwFQUhzTsX2+LoFbg4pgGMRpAUk85fVK56nPQsi9G9v1kogiUU3Vri0tnPsw8jjHf8xs3wlNaEHHEGvtzu5I7IfwqHdR+8iMtZMZHE1KDp9BWyiTuhhuKTqJP8TkFGCkDQ+Bp37s7W3MVaRWkVojIm4o/kAhPWexCg153FVEjb5Qf6qUaXCugET8HsZyqA16HjmbBq7OLbwfvuSQRPSTYXDLJTrgwJLvrjXj26WDYOz5UvoWm2kBV2Y5deCx466vHJOC4enOhsEDOXbx1i7gcqCq4TdGEvK9Y0nK03+i9TWlL9g4i/oFHTLPA3yLmxqvhmvQV3cZEGaCDxting= X-Bogosity: Ham, tests=bogofilter, spamicity=0.318305, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 23, 2024 at 04:44:44PM +0800, kernel test robot wrote: > > > Hello, > > kernel test robot noticed a 5.7% regression of will-it-scale.per_process_ops on: Thanks, Oliver! > commit: 3b7734aa8458b62ecbfd785ca7918e831565006e ("[PATCH mm-unstable v3 6/6] mm/mglru: rework workingset protection") > url: https://github.com/intel-lab-lkp/linux/commits/Yu-Zhao/mm-mglru-clean-up-workingset/20241208-061714 > base: v6.13-rc1 > patch link: https://lore.kernel.org/all/20241207221522.2250311-7-yuzhao@google.com/ > patch subject: [PATCH mm-unstable v3 6/6] mm/mglru: rework workingset protection > > testcase: will-it-scale > config: x86_64-rhel-9.4 > compiler: gcc-12 > test machine: 104 threads 2 sockets (Skylake) with 192G memory > parameters: > > nr_task: 100% > mode: process > test: pread2 > cpufreq_governor: performance I think this is very likely caused by my change to folio_mark_accessed() that unncessarily dirties cache lines shared between different cores. Could you try the following fix please? diff --git a/mm/swap.c b/mm/swap.c index 062c8565b899..54bce14fef30 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -395,7 +395,8 @@ static void lru_gen_inc_refs(struct folio *folio) do { if ((old_flags & LRU_REFS_MASK) == LRU_REFS_MASK) { - folio_set_workingset(folio); + if (!folio_test_workingset(folio)) + folio_set_workingset(folio); return; }