From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7AFDE7718B for ; Mon, 23 Dec 2024 07:12:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7AE86B007B; Mon, 23 Dec 2024 02:12:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B03276B0082; Mon, 23 Dec 2024 02:12:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E256B0083; Mon, 23 Dec 2024 02:12:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 79E246B007B for ; Mon, 23 Dec 2024 02:12:52 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F2C1A816BB for ; Mon, 23 Dec 2024 07:12:51 +0000 (UTC) X-FDA: 82925356206.29.68F8985 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 1C0BB8000B for ; Mon, 23 Dec 2024 07:11:37 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PadoaIur; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734937952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tpXH6fpTjEphVQKpFxQ2V5QkwIF19GVaeym7wiAED5s=; b=QrjAJE65EHI1GRtFg7wDDS8of89aGE8Pbkom9KBi1kuosaeSbcnYTJFw4RoYgKqFdVHBal 1fDdUP8StgZogBkWpxCfbPyb6Z8CHjBCfE2aRemuzL9EhFyVdmvnif3Dl+I/B6ypFd5Jhr YM6DgoSjMIAkApPNhOxoDwZByZfiVEc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734937952; a=rsa-sha256; cv=none; b=snUqECc/c+1ckcV8VRGkouyAEeEg39GrDKy6nfMwBSjZdGjrcLom/u+0aVJ8L30VTZ3tvy l1JqeusV9aq3ovJJ/BQ9IA+g5kQ+NX/7YjZ3Of24y5tVE5d8fkK2tyaPK6MkavP8THeKnv M//A8TN/JxL6OM8q645incjpwl3jGCI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PadoaIur; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C64ED5C4A8D; Mon, 23 Dec 2024 07:12:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2221C4CED4; Mon, 23 Dec 2024 07:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734937968; bh=KiW6z79yHKtUcMEX/b8/Sp0F2L3XtvvNObnoy9wnwCI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PadoaIur+Bq/ska4dZ3htQaJQz4uazLSVowJVHucSNC53reVkWxd5YVJWY/8jYQei G/2ikWxztSp4IduffOwXB0a3mVJH23t9Ex7EGVUz/CnbNl3iJwZRxMrSqxsyp7jx0f g/t903ItkhiEVo2DrupFM7faoTX7/DPcXhBh/bkr20Ay+uNKYZumDkMyBSpawM5raK Ut+5vnDGc2C1sPQD75jm/n63pJiamwi58eI2wR3M3lVdk6xTR5vMn3Ur4QTOlkun8B BK41Buv9qow1NTThvM4tSiBT0cMpdhUu2SLkRibN1ROgpuegs2ZYg313l0II/8FbH3 cxXTeCHYfJOYg== Date: Mon, 23 Dec 2024 09:12:14 +0200 From: Mike Rapoport To: Guo Weikang Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, Xi Ruoyao Subject: Re: [PATCH v7] mm/memblock: Add memblock_alloc_or_panic interface Message-ID: References: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1C0BB8000B X-Stat-Signature: 1xpkffhw1mpq5yhysy4xw35j484zxx19 X-Rspam-User: X-HE-Tag: 1734937897-800117 X-HE-Meta: U2FsdGVkX1+9KeT7aZ8PklM6hGWoq4W8yYUKkI4cpW/dtKDlaRzpAXXMAqObnYgaoiNGVE99sgcWHhC9osPfwvREazmMShBNhB1I//Kg73gbDzrXcRWd+rMqTf5rsxbQ4nQ9o+fBWxovWzhaNu0gPkna/F6iZAy6c4NcQHmnyK4Zd2qoxgnn4BUvPQKN+1sP+sMTcFybYeJs394bP6gAcGgBWJdkwdrThwFRDhGA1zE8Z8rApV5wLG7pHDY4i44vf+K9zpEJ+Y37oO4RFD34NdAs85LZBP1OSJSyonX79KCsZS8uKhWAJ0SlwZ8o2ilZJywQXJQq8FPTFmqxh0Qc0jFA0Yfbqnbh0RxoSh+1yYsHV0Uc4RCLR0u1xyTkREEauQ6dptedpXrDIs5CvwxzxaTvaHMnNEIEQGY/EMPsQ1YE+WtRPZsHzzI55RLO5DLkv5edbohl8uYx4TbrZzA7IMvONkfCfD44Hfj2jySTQsuOXKuB2tX9a4DnkuVzdyEa9A7Ru5mWyhip3JTc4wsG0CyG6ZIfU0ENv9suCiu7AWbRsnW/aUS51fYv68ZttWjpByUtr1OHKUDRddpXdkqlWUvgvZkbKuZtooRWG6Kmk92kDCEH8xtn655alWsn8brSlwb6nPAkFlnIkO70Svl3LDs2JPcpSNQPSGrU7hwrGybl851e1ruAr941l1Gq3DwYf5c7rTxkbnqq7G21/gJi9uxnp/f1IYYRFPaGe9GOpv+jTPbKC/KUF8vPsXDwCkZJNpZ7t21Ntib03QXTxZ0cjQwiq4zekmACmWO65EgIpYP4OsiZauunCbvwR5IIvrmouxptaLCjnNEXoqzy3gWAnG2Zyfoeop6SXXbc7ijXMIVzksjgZ/wwDIvZb6+tcRuzlPkSK7sYSLxFuztKBgmMqVl1jrNW+n3C87X1SVRylR6uMBR5PjCWRsvQRkVhxIIMlszxMcCjV+8lWg1UIjG 1zz2qtYo rTj+oHpTCQ8jpY3b4BX5FZRKEJ4mWrDGzNBNiTKm0ve2lM/ydRC75D4E1OVdlLktNRym0l5i5YPNDRnFEC8eiAo92j7YvbisG4mBhUIB6YtIYnwh8c2K9/s9xQyR6WEqAu4gjxps28Ys/WshvoCo4euvcCWhYQXeeUm1eS+XAE5+im/QKtrccOUky3gP0ZQprcyF0UuUHx6W74q1txHk+5CaJyky9/y5d5cB1F671D7RLS1tLztaYGJtTFX7uv8sABQuD9dNr9+zoeZm5QWp16S/VsQVRt61D2PqBh0aihshMiP1xVX+OpB/Z1mCq8jlWsJgsuaQVuubc/ToLOC4+NixSenqQoqTjXv/udPsOfi+a2I0KdMcXr2gN6hOagmdBZF0ol2RAyv17qrxIbcE04uTzpw2DBtaS+HL7a/yUc9RfG/xOxIJaPvsALdSqXViByCC+Sk9xNg4q49eDzcUfXAfX4zb5cUZPlOos9iG8WBTvq1iZpEROrb1slc4sVGj/Q12eyu0NwTmQmEjdCKAv9LBoHx2o32qzZrlksp3GzrT/mSct3lUxsG6F28Ffx4eCUCcN6G6ogsjCD8o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > Before SLUB initialization, various subsystems used memblock_alloc to > allocate memory. In most cases, when memory allocation fails, an immediate > panic is required. To simplify this behavior and reduce repetitive checks, > introduce `memblock_alloc_or_panic`. This function ensures that memory > allocation failures result in a panic automatically, improving code > readability and consistency across subsystems that require this behavior. > > Changelog: > ---------- > v1: initial version > v2: add __memblock_alloc_or_panic support panic output caller > v3: panic output phys_addr_t use printk's %pap > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > v6: Fix CI compile error > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJUO-lkp@intel.com/ > v6: Fix CI compile warinigs > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUCq-lkp@intel.com/ > v7: add chagelog and adjust function declaration alignment format > ---------- > > Signed-off-by: Guo Weikang > Reviewed-by: Andrew Morton > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Mike Rapoport (Microsoft) > Acked-by: Xi Ruoyao If people commented on your patch it does not mean you should add Reviewed-by or Acked-by tags for them. Wait for explicit tags from the reviewers. And don't respin that often, "Reviewers are busy people and may not get to your patch right away" [1]. [1] https://docs.kernel.org/process/submitting-patches.html -- Sincerely yours, Mike.