From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22646E7718D for ; Sun, 22 Dec 2024 17:03:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97BE76B0083; Sun, 22 Dec 2024 12:03:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92BC56B0088; Sun, 22 Dec 2024 12:03:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F2E66B0089; Sun, 22 Dec 2024 12:03:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 620A26B0083 for ; Sun, 22 Dec 2024 12:03:30 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0AD74141257 for ; Sun, 22 Dec 2024 17:03:30 +0000 (UTC) X-FDA: 82923214752.13.C953FC7 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 61680180019 for ; Sun, 22 Dec 2024 17:02:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=OCohuWHV; spf=pass (imf16.hostedemail.com: domain of gourry@gourry.net designates 209.85.210.169 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734886991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tcOdHdWrcugtyWcHoCfyk0R8M1W+7zds2dEJm6C+mDI=; b=BVyyzHYhLSrdF9/NOlN55t3KGGwEhb+EJk8/sw+oyxysJCCmYe32h0nweCWLWENb1Vh6mU onVrrEXReT6M0VPpL54DFh53K1HouZUuGIFkQ6m1tjZCLJlRI7jXPiw7KsFHzNsnQEKeVN CPE9GNCi5DTs/XxUGHb92W23ycb2KHs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=OCohuWHV; spf=pass (imf16.hostedemail.com: domain of gourry@gourry.net designates 209.85.210.169 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734886991; a=rsa-sha256; cv=none; b=5ksFx0APMejYR6ELR6bA/Y4yGvBZdSDZ6H1MjDlAH8Owh/MoyWLG0c4hYw/eBPNZ+L+HdU e55NgGZLTvfxdaQo8s7RQcOwgJAIfaxuAl2Cll+OBkyEknGo8Vl6NwlnYAfSu3Upz6bfuc qpkhT75ojl/bfOHQya1QU9B+wjrd9sE= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-725f3594965so2878992b3a.3 for ; Sun, 22 Dec 2024 09:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1734887007; x=1735491807; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=tcOdHdWrcugtyWcHoCfyk0R8M1W+7zds2dEJm6C+mDI=; b=OCohuWHVH7fyfOEh1KrSI3zDFI+4zoEySpHydgyLu0tQ46e8k+8EUmhGPnrMtUJi5a FGAds5/h04ZqLBfY2Ay0HxNjZoVoX28Hkes/3KGi0rc6jVi4K/Pe520uiXWKT7RazCty DsA8VH6E7ZnpsFhwldrPGSbOAHK6K41xOj3ZkMIIPPdo1x5iwhiM55DJ+dzCHZwsevzN W1M0XOISSunkqsy4YZgl33P7G//mG4CWmvXqEgbPP8yeLT9I55uvBFl83P++LfM6aBiS ukHvrZLIqfzie7vqlMTEFpmVLbmngRlc2dRZuEiLlwivIFeEslp+2djfkB41lJAycsSo 3MDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734887007; x=1735491807; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tcOdHdWrcugtyWcHoCfyk0R8M1W+7zds2dEJm6C+mDI=; b=THRhnBGhOcDaxksq8rht2EzNuWt1YYbzI8YRRWNTIhtMkOkowMiRfyPa4Hah12kcNa VOTAHtwH6WKZmKnfafyJj1VyPGvITyoYsXvi+kxvykRUma5C1o7pyKRScI2S77/czOcl /uj7Eyi5xjZN1t64hcT72bGg4nb1IohvcvMsXT4h92OD2fzsmI2s9J6jY3aEnbJlRn+h qb4glpVBEXPYUZlklXGBttGkCligFDRWl0EMkwarPdgdt0H4nANLQ17RXMwWed4qHzrB NM4n1+QYrBgvmU8qeGvAcgxGqN+ytvII6i8GPzOFBm/vz08kOsaQWDeFm+dUsRpEH4xz IrHQ== X-Forwarded-Encrypted: i=1; AJvYcCWcoKQ/oht4aYdj3iLK/V/1zdGRgU8S3MzD/6/mrclhGANSxTcHxYDzeYPMjuRnjbgwp2DsmVbdgw==@kvack.org X-Gm-Message-State: AOJu0YyFudXiAOFjUXRHrqbnkrBlQtTH5H5uH5lzsA+rh7fczwTusYcy NFpiQV9IV7SS1l8TONWNAa45DwyaLianAZf9YklWysSq6jcxpMZGVU0lBUKcd90= X-Gm-Gg: ASbGncsjf+y9BH5hLaoUf/uebE4bfNcx3aOtw/Pk5XGZ/OfbTicK2mWxUJb1dw5vCaE 8L6LucXNQooVHLJtmVRBzLny8cB7PjeVTHoGffFqj2JxQmNd1LIJqs8aAOo3wGk2pQx7oUJpwaR S7HFPwSCigZvfMJELdF3IwPXFA65+xWX+UCQSyxA46lCeauWek3QWIi8KVPNGvVGIuBFiRBXhOA l6m/B7qcfPbwAAFznOdV6vH8km1SJXmtzaG3TTtvYaiRa+aKy3jc0yuDh5msN21E680s2VjgCI8 iRw/wOk= X-Google-Smtp-Source: AGHT+IHyDRNtmt1EM6O/D9w+dg7/VuoeBXOzeAbhhFbYiVHsrJa0pCNJI4n5WSuy+0/pLWrop6UFLQ== X-Received: by 2002:a05:6a00:2449:b0:728:e906:e45a with SMTP id d2e1a72fcca58-72abdecdbfdmr16342619b3a.24.1734887006789; Sun, 22 Dec 2024 09:03:26 -0800 (PST) Received: from gourry-fedora-PF4VCD3F ([75.167.163.61]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad831160sm6343053b3a.59.2024.12.22.09.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 09:03:26 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Sun, 22 Dec 2024 12:03:22 -0500 To: "Huang, Ying" Cc: Hyeonggon Yoo , Joshua Hahn , "gourry@gourry.net" , kernel_team@skhynix.com, 42.hyeyoo@gmail.com, "rafael@kernel.org" , "lenb@kernel.org" , "gregkh@linuxfoundation.org" , "akpm@linux-foundation.org" , Honggyu Kim , Rakie Kim , "dan.j.williams@intel.com" , "Jonathan.Cameron@huawei.com" , "dave.jiang@intel.com" , "horen.chuang@linux.dev" , "hannes@cmpxchg.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "kernel-team@meta.com" Subject: Re: [External Mail] [RFC PATCH v2] Weighted interleave auto-tuning Message-ID: References: <20241219191845.3506370-1-joshua.hahnjy@gmail.com> <3682b9cf-213c-497d-ab81-f70e1a785716@sk.com> <87r060i3nn.fsf@DESKTOP-5N7EMDA> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r060i3nn.fsf@DESKTOP-5N7EMDA> X-Rspamd-Queue-Id: 61680180019 X-Stat-Signature: r4sysrdpc1qb1eb6xthhxkiee63uad3c X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734886970-773000 X-HE-Meta: U2FsdGVkX196ma1p9nN462boh21L/cc+dHDILwT2QWtV76YC8HfOuKwTvaM+ptqr8Oh1sZkIO7FdV3PHnvCwvE0F/FK+Oxv/ek3eow67QzIrupJTUuh70dk+P4SZAHK35ePwxNhDrz2w0jbRjaIyBYygOCtUh5ke+j4P8DT2LGvL7Ji+IkaIccb1J/L+JHw2mO/qkPHQqDI52fMqU///799yrvmwUwPt7RRNWnliZ0rwjbl/f11SNusRUgrhe5dzN2utuUpIyBwfALJqZT23RQqkWamQjmpOAo1UHXr50Li0xMklSnwi+x3N2xt9M9p3MXyhS3Y+9e7LdLvPqd3Q8kGd7/SRbo3PcRYRd1DqV6ra5qQeHNLQDoZ4CMYw5FPj53FzTfP6FVZPWXKD90XPMSzMYHvifHkiaRw8iUQNqYr2Bz25PV7dMwcCXY2ySxsUmoxpAxRspOQLT0WfWncq2SISCmNt3Z+rVaybKhM4kK4PY9GubEza4/zNqJeOQ8gpHvNG3YCug3q6/0YClhiAjoQNb7PaWgWIw5IYtUG13eQ+hrBTxytmKlFNRjpfuM3dGm+QsxY9A7bQfsL76+jQnL9JaDyF63qCglP/kBPONqQ00ldBsycg4W2lvvEF/tURYL0GYc7eFbd9oG2GHK8IrLDQHBGsTCr4FpjGWQERDaR/RPSlaLE8du1ZsSQDGAZjwQm09681ZiaTz4m+OrmoJfyVIDa51vCv0Ba8nPJ9sfP1YYZjCGw8/u3ZLLMO/ICFKxu5BfJcNX4so02+mZKtRUvAyN83cGoPlypSkWlENntRMHus2w7W8YDTWpUxvi8YqhBAkzc5DvYEsS2MJb80+JuU6N/nTzK4om5v0chZYa2qEh+em8DrEYFBo+xds/YAWNlfLvaIHMpSCsz/vueI3zwBSJtAO/NQF8HkJiNhHXQmnmyxo1QQL7jYCHl+mPMIKDWe2DQgibQS+EDO7Xp ya0p/M20 xgAcl8tyj/fEief4pP3a7K9WftErQtlVuxKekxbB66qpeDZtlmitGtWOae9mNxCWV8y7beJec+b+TJgmWZYYxFhdYNzQ7jc5rX9eH7YemsXJMjgVIxryN34MSmC0YmcLmLsr1LaWaIb+hMsJa7deo8OYhEqpTSAnM7dPcWhlVOjAeBowlpt+yfWwYYPO6tcIk4+2T+Uq2gHS4BMxbQJaulaY4+/bKy7J21EiQGhQnc7AnZ5aLCKB4ae37XSq9QRP2MjWqocASJsTPyK7YMHq4xTTuojXdcOuiABqocZwYnhoT7eRkXA43ZrZID27Ab625i7fcyiuIBJJvzVex3imMi6Ala6fq4s853pk+CD4qrhEwW9HY1uJNg3fPmbfp0p5gRyWJoNXS355Ep/kuPemikyyjXPHtAscUHdHfhUY/fpD9Y6GL9CyVjbcP6oJDFEaWuNFJA33isQt0VmN8RFxg54x1SU9Z3ZGc2d1VXo+aB5pezPGNpKTy256xbW9/exCLeOs/Ilb6go2jXDWuXLKISdHUHKNjQN7nIL/Rsr7rxjKnvR6OigWVIULngvnO8AARB1vC7AblgBCHWpk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.205951, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 22, 2024 at 03:21:32PM +0800, Huang, Ying wrote: > Hyeonggon Yoo writes: > > > On this server, ideally weighted interleaving should be configured > > within a socket (e.g. local NUMA node + local CXL node) because > > weighted interleaving does not consider the bandwidth when accessed > > from a remote socket. > > If multiple sockets are considered, what is the best behavior? > > The process may be cross-socket too. So, we will need to use > set_mempolicy() to bind tasks to sockets firstly. Then, it may be > better to use per-task weights. > If we want to revisit this, we might be able to make task-local weights work without a new syscall, but the use case was not clear enough which is why it was soft-nak'd originally. vma-local weights are arguably more usable, but require the task to be numa-aware and probably require a new mempolicy syscall because mbind has no remaining arguments. recall my original testing results from stream: https://lore.kernel.org/linux-mm/20240202170238.90004-1-gregory.price@memverge.com/ Stream Benchmark (vs DRAM, 1 Socket + 1 CXL Device) Default interleave : -78% (slower than DRAM) Global weighting : -6% to +4% (workload dependant) Targeted weights : +2.5% to +4% (consistently better than DRAM) Just some context ~Gregory