From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9034DE77188 for ; Sun, 22 Dec 2024 16:22:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD6CA6B007B; Sun, 22 Dec 2024 11:22:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A85DE6B0082; Sun, 22 Dec 2024 11:22:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D436B0083; Sun, 22 Dec 2024 11:22:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 73B356B007B for ; Sun, 22 Dec 2024 11:22:37 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 21BAE1C7154 for ; Sun, 22 Dec 2024 16:22:37 +0000 (UTC) X-FDA: 82923111432.19.7426D51 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf08.hostedemail.com (Postfix) with ESMTP id 7EC7816000F for ; Sun, 22 Dec 2024 16:22:10 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="is/Q96TY"; spf=pass (imf08.hostedemail.com: domain of gourry@gourry.net designates 209.85.216.53 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734884527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lhMphLzKVS5f63UvtxZSlRXvAEndXTILEAOG+YUXA3A=; b=dQILtUfziLOP1lX1ZMht8aJ4r/oIPTh4Ke+m1oaFTrireTXgwYCOmBVhWXWLA+j8AIvHtH 3nfR4r7PgnfgB8rcARShUvIPYMc/xWqf7nzxGGo9bOamP0tZZNyR9H2/Q7JLYg1GI1A7O0 TXvYiWUv4K6bX8PERTgn2zs7XW/mZmM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="is/Q96TY"; spf=pass (imf08.hostedemail.com: domain of gourry@gourry.net designates 209.85.216.53 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734884527; a=rsa-sha256; cv=none; b=JHgtkQwG5o8vDVZiaKqrF0EEHKHUsejeI90rgSKiddVPN4EMFDYKFJ/n5SqUw1W0NtTqyS AfLrkr2yIy/Edge2fDa3dHbShSAqUhRK1n9BJheudbZNj1VP3HH7Mbz/5dCPpA4OgEIiTo 076vS3aPJbSFy0f6wFrpF5l4LThNDcI= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2ee46851b5eso2558085a91.1 for ; Sun, 22 Dec 2024 08:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1734884554; x=1735489354; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=lhMphLzKVS5f63UvtxZSlRXvAEndXTILEAOG+YUXA3A=; b=is/Q96TYEk4Huq+VbJGKfthHQ3p8g5fk5givdo+9OE3+pw82IfcoZrt89H0jnIPWfa YxHwKgsBV7dFHkew3NRUWLj2e3akAB1tf8BL3Q65bc1ppAgjv682MUf74lvovdrngxkC ICYIJDObA1A6cmy42UQhhlJndNRbdW9822/p1dibri192UyYhta80C9c9ZCTTw73pKl7 NjH4pFmwZcQWGJiP9TULDMVnDqPgqFcEyrHvaMvAh5tEyRhnPeVyhqHYEiEnZvMFzKC7 72ogJrhWJ+HqI+FckUyDM3SM0g6seYSTHsszjWlY9ns9HnkeAiQmHdlpEPRSi77VNcHK SMsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734884554; x=1735489354; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lhMphLzKVS5f63UvtxZSlRXvAEndXTILEAOG+YUXA3A=; b=DSTpR1HaxFNC5ndD2OnDaieoD8tFw/LkPic/Rhuu9cfgsZVqENNO3VQSr4BBTGAi72 UDpqrzfLTpPpx9Ks/eSjBxwcyHTBmbiHf65pzvbBDpUt1jPajQc2IPDgMeTyLCNROIJm 7zea0vJlzp4HQEPr9TwjiNx/bqSypzuxhxADpzt8zUNt/P9Of2GPb065anpNRNkuo8UW hfOhQuGxOAVp2bDJZxO40jMf7oBDUERFxyfEaGFeVjC48V7c97Y+jLaHi7/Y/vNYfoHF XVdaAwwiS7DHx+xL9RJtXWpPnDvY2bFZ+pmTnTCJWveKf9NpGNBHMw+FyrsU93WUtb3s JRkw== X-Forwarded-Encrypted: i=1; AJvYcCV/bzVhkNDNM61MaHTHgvFlOkqAq/oKbUPn5YRFFGhpnDte861Rc1ZBjCpQxznx+0zcR+XSOEoqig==@kvack.org X-Gm-Message-State: AOJu0YzulLJq+RbJA6Rm7t2LGJ75Suuz+dkfw78jO+zzx2Usdl/c/1yA qUGqOJoe8ngWSsBQ6QqQ22W2AgNp5QbpFsWKcjNfXjA7ebQIRgu+SWUrD31BRjw= X-Gm-Gg: ASbGncuGXDKer4CDrkqQNHbzfVHl1E33JiNPU0JHbxPPnEWSL5YvNaNS4Ybl6i4CpCj ZEkhVOxeDx8Y70ACJl9IWnPA8IrMhUd1j9FEHnKHw/DrhO8ihCGwhy9kWmGyIQutRpB635kNUFp 5nm0Tpy5KVulQlKDe1GorOBFt8ary5eaXRpcYmhL3cVI0DLobpPj0JeblFwILCI0PGGCW8KSQH5 IK/aWf7NpyPQ6bOwT19jegRvWgRaNPIJnPu/+us1jiyCCssE34oW5mHAkoHnSRG6I+9ZOXL1R31 YXiTAEY= X-Google-Smtp-Source: AGHT+IEKiByCxQcHgBwBzTh9JKARMoGVRZbxO4OzN23uay6InYuUda6DwNVKOm80QUIBp1BHB0RQ5g== X-Received: by 2002:a17:90b:2e0b:b0:2ee:d371:3227 with SMTP id 98e67ed59e1d1-2f452e4b9f2mr15476324a91.17.1734884553672; Sun, 22 Dec 2024 08:22:33 -0800 (PST) Received: from gourry-fedora-PF4VCD3F ([75.167.163.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96e85csm58722735ad.61.2024.12.22.08.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 08:22:33 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Sun, 22 Dec 2024 11:22:30 -0500 To: "Huang, Ying" Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com Subject: Re: [RFC v2 PATCH 0/5] Promotion of Unmapped Page Cache Folios. Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <87o715r4vn.fsf@DESKTOP-5N7EMDA> <87wmfsi47b.fsf@DESKTOP-5N7EMDA> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmfsi47b.fsf@DESKTOP-5N7EMDA> X-Rspamd-Queue-Id: 7EC7816000F X-Rspamd-Server: rspam12 X-Stat-Signature: cnen61bqck1np3euneyb7tqhif4ejgxd X-Rspam-User: X-HE-Tag: 1734884530-477880 X-HE-Meta: U2FsdGVkX1/K1SndOYGRv27xdYS+BRXTF3tj2zXKClNSeHX6cdSLB7cnWF/rwAMkfYDJ7nZU6PwR+4KgeyB3AilX4plWtq1FZsw1BDR8Fni7cUAa6yBrDIVOkockbN+oe7Cg82t2BMtUjaMExtQZBo2yDKS768NB+iSfVFw/1n29kFhmAOxGCzqpv+VjryuA5KlgWWYC54LEKehDQPg2kyiP2zzhOVWeaRn61+xZgaA8y7oZsB1LgK5CmNfyi5VYfWQpEwz7nr2XQ8J6YHP8rAa0kLcezMq06kJjCHi/9D5UU/LQxhAjucrkyZeWfp+bZ5WpOZrYWPEIUSznXVEXqkZaWdx5JpM6vPqZFZLWartikXSP7ybl8lqZx0PjglTBG/6K2O/7ho1Yavrt8dyQ/N+uZyOHSrl5tzQo4KAYA6IMp3SeXMt0Zq96CWf57gRvl4Cvuv5fPIIf+Z64/ptSvEsbg8KMzsMelL4BhW1WbMwCHUApPW7wTcIwQ+g3PTdRnblgkoum6+yX6OrCH+hQepdueNVN1ZJXCVopteOmnjRBnX+tC8nj8hzB7AdC6mkHhAz100P232lXMXipGF8Jo8a6WeqAfAb8WFrZcUIxPvbcawVWeFleSWNK8HT9YW8nqR+i3V7FqL9HCl6hnQErhDPfaw55uW3V78SQGL1dDW1d5n77rrxWv147g6I7vCVo8FGnWOsUu4ZJzkqVzsRPkOWsGgy/V9v0RR4Q4cNuhlj5EkacUys67eZM3p9sRn6H6NFpLgXrLsu4Z4idYoyHlgoec3ZLeuV6B9HzB3yzdmAdTkX5jczXHz+rx2rJyYnlnA1HYMnIxnW0HNU7wYSyvVc0xzaHKhgGwPqiMrQ4IMylpL6W1eE/WdIst/CSzXZJYY7V3bb/BvBiIG5FPrcAnwQd1oTRegbz9YshvgIhRgAboLCJYsl6OkHh95SiNNY6taR8ZM6JPTwFFk19mh7 kwmzsD91 fC1iRgiLANG3ClItIMK5n6Ig/2nrDDZ5qdx0yILwHsr0TlGOdUpdRJ5Ybf9YV5ejj/bUMzlVq4WaEClr5DLMJT13e8jpTjYUO0SYNeW05qY7c2QMTybm+YlP+eh/CswclUk4AZUAxqjmt2aClDXLSXspgio9lbNe/ru+8lffqrtWcbddqs83MugH/4IhmCQ9o30OMmrwl0ri13cwIz0/CT6TDBtH714cdlf+Fs9PcA8IIg3H6/cW2J+KaPxugiJwE2UUjwq8fsgnYW4ca3PqAeU9Xfw9qaD9M2fxHHTF7gZ9zV/2Ma45hq1k4nkeVvHSzBzphv3NF//53/NZndI8ncsUxL8u5KM3USC193eQZVSt5ExEK9WLCa+T57IUv/x6SNkZ5 X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499758, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 22, 2024 at 03:09:44PM +0800, Huang, Ying wrote: > Gregory Price writes: > > That's 3-6% performance in this contrived case. > > This is small too. > Small is relative. 3-6% performance increase across millions of servers across a year is a non trivial speedup for such a common operation. > > Can easily piggyback on that, just wasn't sure if overloading it was > > an acceptable idea. > > It's the recommended setup in the original PMEM promotion > implementation. Please check commit c959924b0dc5 ("memory tiering: > adjust hot threshold automatically"). > > > Although since that promotion rate limit is also > > per-task (as far as I know, will need to read into it a bit more) this > > is probably fine. > > It's not per-task. Please read the code, especially > should_numa_migrate_memory(). Oh, then this is already throttled. We call mpol_misplaced which calls should_numa_migrate_memory. There's some duplication of candidate selection logic between promotion_candidate and should_numa_migrate_memory, but it may be beneficial to keep it that way. I'll have to look. ~Gregory