From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5889AE77188 for ; Sun, 22 Dec 2024 10:07:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DE9D6B007B; Sun, 22 Dec 2024 05:07:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68E8B6B0082; Sun, 22 Dec 2024 05:07:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555526B0083; Sun, 22 Dec 2024 05:07:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37F6A6B007B for ; Sun, 22 Dec 2024 05:07:02 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 793A41A1456 for ; Sun, 22 Dec 2024 10:07:01 +0000 (UTC) X-FDA: 82922165928.04.672909E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 197A118000D for ; Sun, 22 Dec 2024 10:06:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s3+eZLw2; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734861981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+hFbeVZytTc7as3NSImfMf3crm19rt/Slw/x+P9Woiw=; b=QUZpJXCIZ8OfchvyTGWLaY1ZgkR95AViutX1oEBT55jMTeAAmAnAESAMKr9XPLuLX+PdEo cReMMpYJq2L4gYejjsN/nyZGAXfDN77vtncIuuYrMXvaMYs0C4PqBAiWuQKbiB4Y3aUjGg h2KFaJoT5LuLKLmwTaKrntOpP9q5nD0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s3+eZLw2; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734861981; a=rsa-sha256; cv=none; b=qv+BFLub+/CYW7jIFYD6dO3fY/VL66FA2kWEm4caJ6JtMslVD9v6EheTGkc67odd+979ku g41LNZXBSrEXBsMRd8wX762TUZ5H4sup3PsJsfTnuWvtVpH1kHk6Lg8MqFpeBQfnxMZP83 RlepJha14nbY+Z+dzd+/yzLc9NxSZlI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 018E35C4689; Sun, 22 Dec 2024 10:06:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7832C4CECD; Sun, 22 Dec 2024 10:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734862017; bh=sHCtg4von/olng1R4HlYChWVtzpfTivVlSvduFQtli4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s3+eZLw2H4fsTfYy7R26AMbxlUMiT45Y42thwzbQ7PzYcjCMV+xxnbiGc5SjcS8ee N/pq6zKrdaTkA0THA/ohfrCjL8qwibt1MJ2o6NoUYUPkl8EkNQJF5tSH+SY+J1fE/8 Cvqm19I8xARPjWukujUbLNF0kg/VQ2JYfhr7BGGUm+m05r04yTqUEGCkxSjPDtezqD tVCjBp4QZY5na1pptfRr8OCkrj7c6+qsi21cr2LJfacf2iXQzPcBvoG6AX6jq7P+Mk T1nS6fK7nO7+rovxDAahs2X2IJBNreAhQtCCLuO9qzEwhrWBjbRlWnWXYxS/hWfdIV u6Jyj1v1mllWg== Date: Sun, 22 Dec 2024 12:06:22 +0200 From: Mike Rapoport To: Guo Weikang Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v6] mm/memblock: Add memblock_alloc_or_panic interface Message-ID: References: <20241222054331.2705948-1-guoweikang.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222054331.2705948-1-guoweikang.kernel@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 197A118000D X-Rspam-User: X-Stat-Signature: cypasiq1k65hkkmhqwtb488z1jemndam X-HE-Tag: 1734861993-145351 X-HE-Meta: U2FsdGVkX18dzT1CyWHEaRomIJEOJvKWfl6bX7yj/qg1a4UeMESrZov3GDe3o+YA5Cs3Kv8HW2VGAM7puVkeb+DrLq6Ibh2az90LUQEYWEiqW62LleW/kR5QxFCi38cupUFT4TYhZiRBVSV0zwcZWSc8DoPgfum/vzGIPdHdEC6FSUQedI5+NmHhMfK600t1RoVtohJOGCKodyLo3kPB+ium7H4/wfW05kI70PhvGjrsqHQTj9qBSRuBRy8Z+Q/k3ai9t3zp4pQZqawe0yVf/2/dRfU89wK03YXVQZj2dbHSzsfFSCSRM1jD2bp8RZmG9XvCRlTzhlUsDGES1lMlUezT9D3pQ0jGNlU5EItj1e4fyyYb0CU7FC0HnbIFMf/+8X1M7Z2QHRa6K0hArHtlIEQht/dULrOwEUOGxq8XfZ3RcTvxitnX1kwS1SIyy1TIOglf/PAN01WZgyQzF8OeE1VoXz1RYccdLEavZWTIPiJZb7FsLphACeaODo/FgnEaU7MD+fpeQs4Bx7ljPB/3KuBkMY7d5McgWYlhiyCm9osocSwdDfHXinhfyi35RVrH8Yh+895aS765mEnHC+nQvGncHyt73LnRAr0loN9IOvOiDtHnoCT1ivC9JYjLUILDT0apwNTXhe23oAT++CUJQXlVHn9b24ttIldplj53DmQpZ7VBdPhiSap6Ph9q5v2O8IyB2DDc9jJ67Gax7Jsw0wne152ifs+DfHEWNgxcFjWgp7iHEkyplR/zY87trEtdIEEsSbsJx2hVeP3/+eEZcNpTb7SQ/VwxkTxgu1nSQDNTXD9sgASAr1ZfP952mvxW4s9N7r6fehyc3bvhKqWo1MMXZIS4eNLvM/7IHhQKLdbQuvodn4xO1oX6l1TszacgmqJBWr++5fASquEw2S5Q3M551YT0zIYdgyM1FEVNNqWESUI0l+9IWZVe7o0INZ441tGMX1HlDjWpo/VT0rM hw7LkGF6 tcnqM5r427HAyq9mp+5J1/Uviyp+TlXOjlPRfduPfveAZtSCFzSBseVB/0S42SpZCI1u0Z5Qn6uaZR1JY+/+QJTJPw+m89ceKJlIOa4f7poWO5YxCMAOt4GLnn52z+I5cVGliLsxuk+wSySh69SYX8fzog/yxdoVB7MtqYz+Lw3Ppim0u0Rmda0k61fjiwHxE9rwmpn+jeXvSLB+xsY/1BOV5g42vFglVfKXwSvnPVQ/cf2CWt7EWYiKZZxOsO+YobDd2kOHY1cxHbE6U8ik+aBmAfoTx34efaAtudcIj1CP2bmuuvqf02rXVpbBKAXlge7kZPN6P7BBZV/wpNR78VvG3NRXNpRWPGuwz35uY+8757I2Fou8eF8lG/ZYDWXnVmjEtUwgghtlK5ZIhM+2YUhYKDxhLYLGSkEAe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 22, 2024 at 01:43:31PM +0800, Guo Weikang wrote: > Before SLUB initialization, various subsystems used memblock_alloc to > allocate memory. In most cases, when memory allocation fails, an immediate > panic is required. To simplify this behavior and reduce repetitive checks, > introduce `memblock_alloc_or_panic`. This function ensures that memory > allocation failures result in a panic automatically, improving code > readability and consistency across subsystems that require this behavior. > > Signed-off-by: Guo Weikang > --- ... > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 673d5cae7c81..73af7ca3fa1c 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -417,6 +417,12 @@ static __always_inline void *memblock_alloc(phys_addr_t size, phys_addr_t align) > MEMBLOCK_ALLOC_ACCESSIBLE, NUMA_NO_NODE); > } > > +void *__memblock_alloc_or_panic(phys_addr_t size, phys_addr_t align, > + const char *func); Please align this line with the first parameter to the function. Other than that Acked-by: Mike Rapoport (Microsoft) > + > +#define memblock_alloc_or_panic(size, align) \ > + __memblock_alloc_or_panic(size, align, __func__) > + > static inline void *memblock_alloc_raw(phys_addr_t size, > phys_addr_t align) > { -- Sincerely yours, Mike.