From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F0BE77188 for ; Sun, 22 Dec 2024 05:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 024D16B007B; Sun, 22 Dec 2024 00:04:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F16C66B0082; Sun, 22 Dec 2024 00:04:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDDF46B0083; Sun, 22 Dec 2024 00:04:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BFADD6B007B for ; Sun, 22 Dec 2024 00:04:03 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3117CA02F2 for ; Sun, 22 Dec 2024 05:04:03 +0000 (UTC) X-FDA: 82921401738.07.8A9BC53 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf18.hostedemail.com (Postfix) with ESMTP id A7E611C0004 for ; Sun, 22 Dec 2024 05:03:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=gsZCaz78; spf=pass (imf18.hostedemail.com: domain of gourry@gourry.net designates 209.85.215.171 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734843800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aRqCUQOlRgtZiRc2AC0vsaNCGW6lWCvjfZ2K0ekwaBA=; b=1T8c/bqRfdPN4ZIExhyDCu/uKMUPt3xBovlTVzsTdfjEr5AA2ouIFxoDJKJjjWMDeBKHE2 W8ZUNqzAROOT2+n88rAA7KrPJrFr7aEGkGtKuhb7UXdbIaiE8PTkbpe1ZVBkglsM5DPXQL odSMb+31u5UoJm4iwGOF81OOi+d775w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734843800; a=rsa-sha256; cv=none; b=vu0ZnPw+PUxl+oe267b9z4bihjAm/j8L7NA2Xxsd410fX221KGIxr1hUkX61xR3Q4QhPXr /bV3lFjp/m1klh9s5fLjHUpTeXvjtKVa+oWis55DiAbUf6/6G3vDri2BdC1mOH+k+sCTgT NBCTkpro6tq6cawFjdKXtcdBDbJ/gGM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=gsZCaz78; spf=pass (imf18.hostedemail.com: domain of gourry@gourry.net designates 209.85.215.171 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7fcfb7db9bfso2290723a12.1 for ; Sat, 21 Dec 2024 21:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1734843840; x=1735448640; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=aRqCUQOlRgtZiRc2AC0vsaNCGW6lWCvjfZ2K0ekwaBA=; b=gsZCaz78+/ERt3pFs1R9ix1b2fS1s3ydOcjbISLutO4qeU8Cv4t4UolcnkLoqWWV1r HmvX1oEi7U6pmxSEfokBFeVFC83tvudSHydCa8bVE/EWQzyXncs+CMdw2bSNmxcm2Cbk LubT6MEg8uKg/mQjmP+nBmK62ylZAk/gRIMhpuskEo9VdoM6HtF+flq2MMZC7SyuBX6d redMiYSfPFKo+r8grxxVOumR1w202eEbQt6PYl6gxUAaS9szjo2jzJLBsTEpIkV0H7h4 t2ySrsQQQAk1QrcA/pV79PmpH5G0OJEa0HdnUUWnF2Ec+kkprL0jQxWUU/0ROCjT0Imd BZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734843840; x=1735448640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aRqCUQOlRgtZiRc2AC0vsaNCGW6lWCvjfZ2K0ekwaBA=; b=ruRkoqjAnmr4qACrJ3jTfLdd6GH74ytQUV+ETHzCYVny8Pr85YNUUz08RSAKkLczvk aBzE2mGXrsC/g0f6WHDw3UCe8QcdagHNBumhmoq5RNFYksQW9dH2oPvZBV28jPlHcuTb aPkaGBewwcu4tlnZLWNxhRHUc5BaF/7rS1GihzztRpbmC1aVQ3ZtymZ/eRnO8R0JXOcU F9aGDjOYt9bMz+f6J/L6LBcD6q1C5OmDu8ec9kWu9AuGnlwXJXs4SnIc6s9lbBLgtZYS shxJT5WUKe3Xp/vLVG/JR6+CTnF+Ld3RMMWJeMD0hgNIGpvNNGa91mZMYevRFQeWQ0pQ FLPg== X-Forwarded-Encrypted: i=1; AJvYcCUsoHaVEcbJM36AMw6jg67eqz3gmZgZboq1iuHw8/OISCjMBJlUyFYCbeWNgJqZJJZZI2p3qAzVFg==@kvack.org X-Gm-Message-State: AOJu0YyzVNLPLhQx+iOW3V/vbHbVtiIed4O73wmhgyd01XkVn4hGtS/V qgT0pV/URdb2F6ryIBih8nOfN6zN8+m+dOegwCz5CsZwHwbo+HLDSBvNl1pCjKI= X-Gm-Gg: ASbGncsy2AhE92QnYDLeIXEB564Lc40b5DknYHaiTKPa/LoKOJWRTkMIDxew9QZD0N+ W4l80ApWNK8riNqe71uWc4O8BzkF4puY8cubnkiJ0LYrWpv5FpmiMhcbMThiDzlMPhmBF9afUAz 0P16zk1wtTetJ/Jjvc3D2FsGLluJiNQnWD9P3v/cjfrooE28LzIxA9V30pnXwJ6ZcQkXPQQGcIs iPWM0rmJQgPrcQCEp98OsN7Z7/GQsLMWDkEaXzP1h4/4xkqzKjbc2PhkYKA30Hyvcjxh2U/AEr9 6BLu23k= X-Google-Smtp-Source: AGHT+IEz6nqPahLXccgfO9cSrt88CcjDjg2Jbhh4D2ThWhv0YE8dqXggljaBjhQgpLKbihe32IQpgQ== X-Received: by 2002:a17:90b:2e06:b0:2ee:ba0c:1718 with SMTP id 98e67ed59e1d1-2f452ee8cd4mr13567612a91.37.1734843839761; Sat, 21 Dec 2024 21:03:59 -0800 (PST) Received: from gourry-fedora-PF4VCD3F ([75.167.163.61]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ed52dfffsm7819678a91.5.2024.12.21.21.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 21:03:59 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Sun, 22 Dec 2024 00:03:56 -0500 To: David Hildenbrand Cc: Gregory Price , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, kernel-team@meta.com, corbet@lwn.net, osalvador@suse.de, akpm@linux-foundation.org, chenhuacai@kernel.org, kernel@xen0n.name, gregkh@linuxfoundation.org, rafael@kernel.org Subject: Re: [PATCH v3] mm: add build-time option for hotplug memory default online type Message-ID: References: <20241220210709.300066-1-gourry@gourry.net> <5e958aaa-b1ac-4512-a592-0e1612032861@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e958aaa-b1ac-4512-a592-0e1612032861@redhat.com> X-Rspamd-Queue-Id: A7E611C0004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: dqfhtffbweij9tf3rwuj879qr31989r7 X-HE-Tag: 1734843824-587993 X-HE-Meta: U2FsdGVkX1/cAepNyT8VJ3oJ19kWKOAs4dCEcQqwjnTQpevvsGI9Mq9ahVZWM5P6vimT/dOjGv8fALz9kjkLoJiUgkeutsxSuif9kHE8QOwYDBsDLYz12W70s7cmZ0MstRR30Sr6JPNqdtzEWKm4g4jQf7OAm3vgHnOxTgQRZhdCes0WTpRHmrL0kVZf+d7wU6EkfqymOuCLwj5b6cVAJ506EtGNybLquZSPbN777EPEnahFtZqz3goM/wv6IebqxBue3xHpfTZ+Rl4zIBPogzHw1m3awgQVWB2nBNKdi39scnI9auHaV3XZRYrQ1Dyc1hnP7zr9yjy1pLhAvpsqOOxMnI2EjzPPx/CgirAdVCAquR1bhV+N9Lq3uqQb27kmB6mw6TqpFi7/mnyHLmuT3nl/FT11n3eR/h/WLfUMeVNI8JArKYgSaI5DVFsKnXzFKFCeu9UcgFbSPSzBiya9BpyB6fuzcqSF/nE1OiVAezE6P5nXr92rMNV/ofJa3xv4khWT50WikSIH7SxaD5lNRRyE1Ab3CDVwhFARCzvLiOQomsP5/MbgyNRpHSknzDYYcKi2LU9E0ZUt4QyJ6WVOaVHm3gQG9+YGDTZaNUHdE2iAfQRH3o9IozfHX3dCRtqRXVc+6c40Fi3m3Sh+cgEbj/5YLapIo32UbH5tLDPQvihXgKzLVR105rKgVqGcOWGuZ/sgIA7kco+9IvSQsPCN4asy0v0Gci+Wq/521hcDY/VnMwcAaJEAATCS6flC+sFPa7iEJJwz/o3d2DvS/Llvs9d7n4sYxb0us1WsyynXBxZrLF58hq/8GHGQ8H5uJwuHRE6q7unB8WK7D8BPhsT7YmmgJjpLEzNeUc4GX4VK80LUO1WNiLkHfxl55Tzr/SVpVImAkd3bPVMimxoPjL2xMoJU1fnRVUgMu5ByekJfzVuvxy85+i6GVeojWbXfOBRgZV9mibrO+ZH8xFdBSGs Gyq5Eipn pgWDbmolp1tAl4mkaGhmZWu289SUUfx+5kSe1nlNhqUwHGsWbfuRshZ7eHJby3B7SUKTJ8Wx66HWN4vWsWK2vPLMtXu3IkV+UgGjcJkCJSaRW9WSjnW7LvdH/s/4PPbqrxZmHiPi+2UPGFaitWGgC3w2qteRIgA0DLyXWsMk6pYP+Nad8CdvijiaMKgU52ht0ueWdXLOfCCGA0t+uc/QlmtzI6Q6TIcnjF6sm1upcuGqCeDHxrsf+dMu+sE8eR3/RDYxdQqzPJrbgOegx7MCmR7bWf/2gILj+PESmMDXABnHHjB026l2nnjib+fO/BOxubjyzliI3SN0qI7s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.400409, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 21, 2024 at 04:30:21PM +0100, David Hildenbrand wrote: > > > -config MEMORY_HOTPLUG_DEFAULT_ONLINE > > - bool "Online the newly added memory blocks by default" > > - depends on MEMORY_HOTPLUG > > +choice > > + prompt "Memory Hotplug Default Online Type" > > + default MHP_DEFAULT_ONLINE_TYPE_OFFLINE > > help > > + Default memory type for driver managed hotplug memory. > > We should call it "hotplugged memory" consistently, which it is from a pure > core-mm perspective ("add memory"). > > "Driver managed" reminds too much about add_memory_driver_managed(), which > is only one case. Maybe just drop the "e.g., page tables" from the examples > below. > I suppose it's accurate that this also affects VM-hotplugged memory, which may not necessarily be "driver managed" in that regard. So it's more accurate to just say "hotplugged memory" - although even that's not quite completely accurate according to the definition in the docs. Either way, will change it to "hotplugged memory". Probably at the point where you have multiple sources affected by this change, you need a udev/systemd setup anyway. We may have to revisit this later, but I doubt it. ~Gregory