From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26862E77188 for ; Sat, 28 Dec 2024 11:46:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C5046B007B; Sat, 28 Dec 2024 06:46:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 575106B0082; Sat, 28 Dec 2024 06:46:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43BC66B0083; Sat, 28 Dec 2024 06:46:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 267506B007B for ; Sat, 28 Dec 2024 06:46:20 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4A4211C842C for ; Sat, 28 Dec 2024 11:46:19 +0000 (UTC) X-FDA: 82944188586.15.4C20A60 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf19.hostedemail.com (Postfix) with ESMTP id D86091A000E for ; Sat, 28 Dec 2024 11:45:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=DeMVPGVN; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735386347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gQSGh7ChLZ6SIkGPLQOi8mUoiexMog40UKhBm2WpLzg=; b=Z0TfIRNydaSvuEslMJOKyeMtKx1ZPecE51qW0u8YbwuB9zkEdGD+I2yZyJ7OQb3AzcSMyb be8PXO9Q0VqpJM6+y7x1gtBlnzSOMZcAwNcrdgPer/yvhaC2w1+7Ee55sBXRtlNBnsvM/A orwXkE+fqGCSpacyEOuN5CJoUjKoRlg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=DeMVPGVN; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735386347; a=rsa-sha256; cv=none; b=2C59f7qgqBI0opQA/JLj7GtWS9RRSoyQyBheuSlMR5WS6X/tpm5IMdETMHvmC3bNSl1wf4 aS8l0nw0X+VR2e6j8tI5kB1Iv4vv4e3TRSMWt4gbNx9lRjLBnJMiCbXX+gnCT5OfgY37aa vXNzTqZ2lnugyHlBfIFuSyCDdzjpcU4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gQSGh7ChLZ6SIkGPLQOi8mUoiexMog40UKhBm2WpLzg=; b=DeMVPGVNRne4phsiqPRv7tmO+k N7GfT9S5FxDC4egVTsCh4yIrMFZCO2odczcyNUhXgLYtwS+uDWzMoVRIXvR0ZRTN84aUDTnjSnV50 58ZcpbhHf7ySCIJynbMg18L/YIfBCuoenSCaUmLzGrj+vtmJZzYPIVw6RZ2o0wJTCfm6To/o5Q8eP pR9WNU7lC9XXI0YUtsSTFC/DfTuoDANhOWxncV+T0zyFMvJoa/iHxdlAGhC94gTMjh1q7JDQyvR+/ j+3hYj5EE8M2Ss+WsnaZzGeMXRkGZimpkD4/vNysfQRiYcjaC0o2yiGDYc8WWVBfvrzQFotjxgvfO Mi8N9fLw==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tRV3n-003ZCO-1H; Sat, 28 Dec 2024 19:46:09 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 28 Dec 2024 19:46:08 +0800 Date: Sat, 28 Dec 2024 19:46:08 +0800 From: Herbert Xu To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: <20241221063119.29140-1-kanchana.p.sridhar@intel.com> <20241221063119.29140-3-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241221063119.29140-3-kanchana.p.sridhar@intel.com> X-Rspamd-Server: rspam05 X-Stat-Signature: tr9m9ush3of7sgczim5tdrd597zgef96 X-Rspamd-Queue-Id: D86091A000E X-Rspam-User: X-HE-Tag: 1735386330-429864 X-HE-Meta: U2FsdGVkX19T0NVN84zQDnHVrGO4Ch6aUpuEJTGdo9V02vJnqdPLMsagmingwwNJUNiM5PUunLfVLHGJ4WrXEtVji+uzI4hkm+PkydxRwj1qBgSX3OLcXCazvgQNwN1Z4vDmGOLfjcLeGV2S9r0dniExedbAswX1V31DupkXm7QwkC3OdzekNZgEMXchqV+ITR/nch3s73VcFqRb3ATs75h2fYoocPRlZOisnC1Y8ogtB4tWdXU5ojQthDe/FF/sTOHR75QGVDiqdnpeoyjxFc2gTiYBBoB7iJljVWE6fImFXAZ8vzI9wz0TG1BKirXj/X34MROtJnaMiU9Diy2pg8dN1OjpPVG/s1smhlMy3tqWm63gNX2pTJVK+qNbKITB7UWRaCUvzht+E9PaEcEDJrzmJGle5sV7n/lrG8FiJWugXeaYzkCKgsCaXPXLApFYoYvDBMTyXwoYogJdr9QML51QERP9cDwwOF9yM8AySCtK5xujEL5Xt6hw9Osz/VL7jk87XLcXCOcZU1V94SXF/3iwOavf7FTcQRB4OLsVIVJTQu1KwBWRCbIrjT5nDBfwYD9i0NxhR9MZBVQLbpnR3IMiRSsEm2dPn9kIxGIDXZu69W0GKOrBndebCUnVC2jq6L2K+JCEP1w6xs6MkeSn+1BoObixdfQleKNhFeJoAOBExuhBLJlGJb+bVFc/PpqlKoLEzBOZ2Z1HKqdbjTve8MVAwIh9P40LiDF/A7sy5HKIyuNUoxJRGg6WmuWNTNs2eUAxnNjZ2SL3HMSGriihjux26Id5Ay+zA9GTxsn5Zy1lVLh/zmz9lpN5RnA+qxWQT9Hslx9k2bgnyIulT0Hd+ofY1qbzK/Yj0l0fZT4LTYhDorTeMHM5Uls+R2jyIlKUassgVu0Xg6hW2VAiaDNdW6Q3mEVjd9+G7RWu/JrNvM8HZdtvLNTPNtq+us72ur+d+z8MT1yhcrE6gXLp7nX Ds3UVljT NFmmViwzffemShL8HSByqzixYEOleSPtASzz8knC+UkR/3fZe8YX4X7qNqFrUZwsE1Ty6WeYlx4myu7CZTozhPgnchM4Qi7ExFbc0XrTEGEGMOZ3NTWSBSAM1C2NzY81cSly89Hi0trtDRxKaNkM0blpIIq5hIObDwSjjazlZo/UolubJvu7+9R1eYRMDZHAyBCC57wX7RqoEmJ0UDmXu5ics8S1C9mpDBASuAalcbC2l62IAhvwJ8Pqydf/HSckNUSaAzckZ8OOTTa0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 20, 2024 at 10:31:09PM -0800, Kanchana P Sridhar wrote: > This commit adds get_batch_size(), batch_compress() and batch_decompress() > interfaces to: First of all we don't need a batch compress/decompress interface because the whole point of request chaining is to supply the data in batches. I'm also against having a get_batch_size because the user should be supplying as much data as they're comfortable with. In other words if the user is happy to give us 8 requests for iaa then it should be happy to give us 8 requests for every implementation. The request chaining interface should be such that processing 8 requests is always better than doing 1 request at a time as the cost is amortised. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt