From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A97E77188 for ; Fri, 20 Dec 2024 14:38:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A6F06B0083; Fri, 20 Dec 2024 09:38:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8560D6B0088; Fri, 20 Dec 2024 09:38:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7445A6B0089; Fri, 20 Dec 2024 09:38:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 585BF6B0083 for ; Fri, 20 Dec 2024 09:38:16 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC89E4493B for ; Fri, 20 Dec 2024 14:38:15 +0000 (UTC) X-FDA: 82915592172.02.8E1581C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id E915C1A0009 for ; Fri, 20 Dec 2024 14:37:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GHlHJ01A; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734705470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gnUDRwXu5Oc0MjSPV/TNquo8RX99rNYEuhTQmuOlvNQ=; b=r5aS8Jzud7xga+FacCBFtQ/cJw4ttC+3flY7DCOEyKVLws9tgGhf1G+Ohj9QD3/gwH+TJm OkRSHtzpUvloMOp07AKwKnXXn5jIN/x9e3uY9zBywVZkt1waE6n3m30SYlaIKaswz/Mcry yprb/W1R4MaKVLi18ZWHnXeoZ8uNrD4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GHlHJ01A; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734705470; a=rsa-sha256; cv=none; b=j0VB8OEmkixJfe7kbp+zoFW1rkzP//JbdZscxQXsAd7L065PgEmfk2Q0TXtTMUi4WAdOXc QXN/SHAokOGqu4r/HNOR3f9xf/DIRAACq7fPW+MxlBg9anulzX3assXs40fpcxhw/vOhnZ TvoYfCZ84/bqmxLg4vxsPESeocp9+64= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gnUDRwXu5Oc0MjSPV/TNquo8RX99rNYEuhTQmuOlvNQ=; b=GHlHJ01AHRmRKTBcEp3F+m0Cwc OaZFXHbkQ8Sb0qYr0vG6mKmPQ0yho3lMkGfPHdqKQO4/PrwAsQga2iTHfnK1sFxXFjKqcmuDp3Lgh 5zyCMbVXbWsDVuZ29vWe5XW45C6e3oXsxEQ9VdlwTfjzWPbsUKwF4ahu9nRjRnwRU14nzXGmESkE6 Kc4aN+1LbwQ6jPtM1Mf67bV4aE6nQp97y23JRWdvHFZzVNoFv9jFyGCgD95tfqdSwIwzfAtnX/+VY poQ2Re5U3u6sC8c5k8UhhXkdiTNB5EysxZ23xXpSUHrMBk0A2wFY5UdnVtadkC99dDSH8Q+BHvzKt sRYQkeaA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tOe8n-000000013C3-29L3; Fri, 20 Dec 2024 14:38:09 +0000 Date: Fri, 20 Dec 2024 14:38:09 +0000 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Jens Axboe , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, bfoster@redhat.com, David Hildenbrand , Vlastimil Babka Subject: Re: [PATCH 04/11] mm: add PG_dropbehind folio flag Message-ID: References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-5-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Stat-Signature: 3k51r6angtgogyc5qihbb3wcop6zbxsi X-Rspamd-Queue-Id: E915C1A0009 X-Rspam-User: X-HE-Tag: 1734705456-97428 X-HE-Meta: U2FsdGVkX1+oocP+8xieDkQyIEBh4RnXTnfU1DyJ2B5RCkbnPmfC3T2gfE0TUK8UdckypBgMwDcVmFku1DFcyWDS912aOqvijm8edIcbhkIMfxGH1BaTry6dF3NefL7pcWD5fCemRRoTkjt/WBhSD9okidkpEMR0DalLvZXvCZ3h9woDcGMnwH9+KslPRwpdAhD28MoTUWSZsGX5wJ3gib0XABS4Y9e9A1ALvVcmp7mz8ATzuUGkPmT3l1W22v+Gao6WDBrCztmWdOKpOtFz8WII6N1if0cHWTcVQO0ybS8/3WRuwubYVEk4Z6EkLx5TFIjPaaDNoBsdi6x842eHHUCnTTnbseJitko+tZNKVU76AHSyPQoBuPtXB4QMq677F1hNlBAbbfyvpRxEtQTCAsDGInV3DI+XH9kXUiqpvFNZ4hrh5hLJxeK2qj5hoOAXbrQbW/RKWUpZPIfzktcHtOGLKqEDuKvvUS1vYPf86+PnC8Me3/+fGq4UvNE6Q0lYY+QXhv4OVUWE33lII0dWSbsNsLZb0OeXs60OIL2/CMfMwfyAXVctbMLTqpXKANCS0xRJ7gGbwlQQxjAdaULglXeDIbuANHLTkv+54V3xM43V0irjVpRxtYuIinRxI+mOztPE+lG8ckDvR/1Wr8K2q993k9fbPlKia/ro9AtRd4KZ5jIHG+QzZ5V0KEk8wkpmrPAuOobuywBlImz7Gaw0QsxOnyhVr5Ulwty5DQ2ZdDPfCJAD17dPeI17fnan7hQWgfWGBQmHxPZk6WWYb1o/ogeHFlgTnvGylT0Ki+Q1b3WQA80Xbv+hdzqpIgFiTZQGJS/SnPb5UdaWcRrChRXEQM2Gj+T0mhsPVErHkOq2OYsXb8PbU7n7bYajH6ApTQyf5/gWeLUiQ+lb+FEKh7ljNNotI5W8CoGmCD8mZzfPA5W9falRorSr4bkz+DrIJ1KngGarnl040d5I1T5xxpW fgXSmVx6 jHHWz1mG4Q/BjWF3oDd9VUJOqRJ03JzTd84KaXp2u/DSRhcy8cwZ107Pbiyfv8/aADQhNAIxFkL3ChdUoVK7Wmi/U6AEWLitdlRwiZ3BLU+6zS4yc11A35iNc2gtjZlqJCQjHD1HPRMqLca4wepvMCRwHcfDyM1uIQjibLPMxMCIbnpqi4cb3gyTXw+JrLnCNTm/tLe3SgsrJUkEOuZfFxECL+adfYygMNXQBdVfAXO+sZ06Hjy4MMa9ye11tuDZWvLmHUk0TO9AxExcKC3R3iuzS0+HzNmmprqNyClPGgE7TyDk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 20, 2024 at 01:08:39PM +0200, Kirill A. Shutemov wrote: > On Fri, Dec 13, 2024 at 08:55:18AM -0700, Jens Axboe wrote: > > Add a folio flag that file IO can use to indicate that the cached IO > > being done should be dropped from the page cache upon completion. > > > > Signed-off-by: Jens Axboe > > Reviewed-by: Kirill A. Shutemov > > + David, Vlastimil. > > I think we should consider converting existing folio_set_reclaim() / > SetPageReclaim() users to the new flag. From a quick scan, all of them > would benefit from dropping the page after writeback is complete instead > of leaving the folio on the LRU. Ooh, that would be nice. Removes the overloading of PG_reclaim with PG_readahead, right?