From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F30E77188 for ; Fri, 20 Dec 2024 18:36:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FB416B0088; Fri, 20 Dec 2024 13:36:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 084AA6B0089; Fri, 20 Dec 2024 13:36:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67446B008A; Fri, 20 Dec 2024 13:36:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C50256B0088 for ; Fri, 20 Dec 2024 13:36:50 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 585B4B01B4 for ; Fri, 20 Dec 2024 18:36:50 +0000 (UTC) X-FDA: 82916191344.17.1323BB6 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf15.hostedemail.com (Postfix) with ESMTP id 0A029A0003 for ; Fri, 20 Dec 2024 18:35:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=NvM3bA4X; spf=pass (imf15.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.176 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734719769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+8l87UkO1FsVBdmut5rv9MW930uB7khYn6pwlB72Hhw=; b=YVhGBwUkCcXxQhkyXpKZqhR54qTXaxRe55JF3fz7Qn3gBNgjrja0WfjMnd3lFb9I3UygcD CQFtl4OQgIonlRV171JYz0N7izLYrk3qvXJcvdXLxE6gDc0suDOWV0NJbW9cKhgoJo/CEd BOBHjdV3YSIz+YfURYxINQlsdiz5Dy4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734719769; a=rsa-sha256; cv=none; b=g0ZV+Bx7Kda2akcGmEwifSbqTBRC+d6isJ9l4r0kp1fnUJY/25WfqRxORP+7Ozs4fddpgY f7Mld/c1F7NW9hdgjMWx1haf+unZjVTRnVqL6nDFAEiJebcL1ETxDSHKmzRuPcMps5vuqj rKPlWhln5YYcA2RkuiA8m0RqZiRTkQM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=NvM3bA4X; spf=pass (imf15.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.176 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7b6eb531e13so101712885a.0 for ; Fri, 20 Dec 2024 10:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1734719807; x=1735324607; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=+8l87UkO1FsVBdmut5rv9MW930uB7khYn6pwlB72Hhw=; b=NvM3bA4XKu+bax0hjKDE6my2tG1Sn3fGtEDk88SEoEQl4HUzc+szIG2hNBO3yM9yAK a5q8F6UyVRJUG5NxJw+7wSQ9T6LMJ/y7FDXr/O70EmqVZbAhlvugp44IK8ymkJ56xprQ whRwZUd9jUPhMqG9cS6LKb3z2WEQ66+eMxldL43jH+1GGG/5HfvIoMrFc9KNUuHAQcNa JuMZzBfCOMenMla0Vw0CGE/vvQ/HH6D0BUhWCBDMMDfhSj5i2fUfKfUnXOYkPchOrm2v 2O6R2DiPxuWDiWBKiVSiJBgCVzo4W/dXjBT6BGWHKJj0vFvFnziGCvSaTQDcFoKtrSch Rlng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734719807; x=1735324607; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+8l87UkO1FsVBdmut5rv9MW930uB7khYn6pwlB72Hhw=; b=XhAlR+D43eOb54Qvi7Ezr+H+2gnFSSz8drbaVrKVcBJy8SBafx0akAcf/IZD4gzP4v IsoJba0g10134Lf9BZ38+6mxTTC6LFmZYXg+LZXCZvG3MB0cWJc7xYi4A2HZu3H8YdcN Mg+SkAdmVHAgg8P0apTK4jRxlaKNn2PHJFTL02RVjCBVYygRn/h1FDh2iORH0p6fHmOy B1B96TVpTBQuCQKXsmQWMqFhXwxLWyfUFIZ63qz8QwdOGlcQBJXf19x+QubccnVQapoo eSsrZo30eM2fC0nz612YOpGxhtbwvY0db8sG8dt1ZQpPwezN6jRzUGa37ta3IwRqdj6k fkTQ== X-Forwarded-Encrypted: i=1; AJvYcCVwZdVNq/WJzJfR6J/muZNyEq7fAbSdKTIkjZoEW7L7pBGoN1glyc1tdXG06Bca3k+gwieD3uTDsA==@kvack.org X-Gm-Message-State: AOJu0Ywz/5ZPRA5Jp5KVsMNWH4AFT7hwrV+RInrw4z2RgaJgmgxz1yxC iV/wdPjdSMdJwFiUM8DH36ut/1fRRFjC705eWhBtUZUz7y5h7roogxiSdCZnPT4= X-Gm-Gg: ASbGnctNZk0AEyiOqZDCX/9146c2WrgyFa+tyK1LvFi4KeLc5jX9+/MERGoAvFD7Y+v 5bzESjSym1yQAEvjp2S4O/LY6SfulxuNHeUJFkIhFxX8T0ggN4b09NoTVw22WpqcmXO5uFdejmR ngOumWz/H81TU3+f7dv2JIcEDITiR33XO9ob6IcFr0PtonKiBibqKVogzwFNfuwqxerH+S6uh75 qZq1Nsv2sRbjDtHMIg7Ph3yca4vkyi3Mw/3iKbEhjxwgZ5/PEwDgBPuGahjzyAbCYad5D9m8rRu 0zNGW1bsJZiR8yrm7AiVTQ//5NC8eqdIvbaUgCaxasxFHNjV3E8kUsA= X-Google-Smtp-Source: AGHT+IGPURTnMr02miProdqy6sJQjCwglzS51IyPoS1yC3iwi8sQwJ8SiFrixyM/TpmlQrI6TJMlQg== X-Received: by 2002:a05:620a:3193:b0:7b8:629a:69b8 with SMTP id af79cd13be357-7b9ba725121mr631052185a.17.1734719807519; Fri, 20 Dec 2024 10:36:47 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac480908sm158435485a.80.2024.12.20.10.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 10:36:47 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 20 Dec 2024 13:36:45 -0500 To: David Hildenbrand Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm: add build-time option to set hotplug default type Message-ID: References: <20241220144518.206208-1-gourry@gourry.net> <3775fe9c-460e-4b31-9d5c-068a1f685513@redhat.com> <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com> X-Rspamd-Queue-Id: 0A029A0003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 44cjswmq43athz17rn1e737n91j8pe7o X-HE-Tag: 1734719754-52866 X-HE-Meta: U2FsdGVkX19otc/W1WgGIo1eVLT/gd1TuylX+xBv6v7I4ky20M+GqS3JarA2MBN3Rl+2WzbJ20zjKMvYR6rJjt1+bdtcvWX8ybpXf3h7/sf3/myC9czNUbL7J+881APCpIOs4//eCJtNyLyglXDHgfXfQfvCmkCLN5yrLxfqwmgSS+C1D4CXcejUU/yl0J7rbntuEzp8cuLMIolS8OayGTdUBoSM7Ic5N+av796HaPtBIoVhq5G0v8XPj9nHy03YPcok7STNSar+iAxa1JiHkqNENzs+y7zX2MUP/C0iFCYMZKutKGZZTqPx921GiNf7yohBHoOKkVS51rQQCzBVSZYCjXkE6DCimRxkfU4UlpH5JrOJXTzAwJbcgSo/0roxhH7GTuA62I/S5bGKig4LMaNLlmzR6vs1dYKIO8wE0I0V9QCRQkwggQh5Qrq5xPE8LZnXfdq1bsJzf8HSy5fgsjvoAElfNE25nApJTvFsQ3NHlwOfRUBfBjvvkyuZTTgCFcrpKrUCkOQt4+ozSXqFlfg22ZMRzd2rmG2v0FCZCbWtjGdW+G2Ma0hGuGf1Axj/fVaPXsVyKfgaQd6zmMtfE9rVFKHPd6R++iJBxrTah+iYHDbmTzVs6LB/p6BkbD+QtvealIEllwo1L446/ZqH0JaWyqPYjdHYS2BoYLMPr5IGQTNX5BVrlezkKlbifQRLarOzEORibN5czCdma6S3g6foD+ffsGv8dykABrgmkuIrvGNYZZ6rkS7GL4BZLQyDGdCfX8EB16A9vLonlsV+fmKDlSWyYAcanhHsOfV/CIdNS4tKaJQVIEZ5/Gk1wHu7lR3etL4/oCKAcpssFTjL1oG2504raTcXP16JcQTY7EwYfwWrVzzu/bBlDApeGfx+mAzlikm+mA0CPxCl6TDszjbI7/NvunlG8Mp4GyWkLy9nufW0uI2cXJyFNgLa1n6A1FrTmBUssWheMV8hmIm KI9lbkwy 8WtCCtp/O5LOwPP7tziD3VVS2QL44oJOL10Rx5dsgDYDDXxIa2vp7Fl/DtQFXOblOB1+yh8DfPJaAtuALg8+0uFye3mSerej0AtVM7aOlAoH9rNO9ONedJgVUgRfbdAYh2WlD4tZRAlXYfcOKZE1gZZTYfb4VCEHW5JlAqpMjn6MUGOtF6f8vKJ6PW7frwmgrSSmn1+dAvfKgZDyCOo1zCeRtOn/gU2IMUtW2TcT5iru3601orvCCm+A8r2wVt7UdvkdvGf+9eRhP82GsSG2z6iKX010AzHf2IaWa6t6TQ2LmgABn+ONGWQm9cP8WwMKcaDJibgbPDEFLTdo= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.482798, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 20, 2024 at 07:25:57PM +0100, David Hildenbrand wrote: > > If you have another suggestion, I'm open > > I'd just do it like CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS, and simply do > > if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE)) > ... > else if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE_MOVABLE)) > ... > > No need for parsing strings and dealing with unexpected values. > onward to V3 :P ~Gregory