From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA19BE7718B for ; Fri, 20 Dec 2024 18:35:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 409596B0088; Fri, 20 Dec 2024 13:35:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 391186B0089; Fri, 20 Dec 2024 13:35:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 232336B008A; Fri, 20 Dec 2024 13:35:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 016BE6B0088 for ; Fri, 20 Dec 2024 13:35:57 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A528A1A0CFA for ; Fri, 20 Dec 2024 18:35:57 +0000 (UTC) X-FDA: 82916189118.20.32DD1D3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id 6649C4000C for ; Fri, 20 Dec 2024 18:35:24 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734719719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7KXR54CGSrSbqb/7H2c1OQn6Inadnotq2aA0wVA9618=; b=kQuaVRpff/and8BJfaiNOtt9uNhbHP8tB3RU2Aup/VA0r3qJlhs2EPNFqJ9hCcEqYvzWBe X+Wno/4UCcY0oTN0Gk3D6gwqeotRZyS20tZ2OzyYqBB11Y/IukoMNe6bbHm5RmxWZ/7dUP bm6cWe8ZahV4TNNMrPwyTfhG13CRCb0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734719719; a=rsa-sha256; cv=none; b=nSjohTX5z9ihhtCcCCECVdQyooxmWD4wFyX/eoaRqp+nRKfhwYtq0TGBK3I46Nb2azTXfn BI6LV2s4pFaWxKBsSVkn2vYeVBV+NhgZ4z1xydhN5/hNgM6xBfQdoH11EUyFll8IqZDWKD GMJd0ldTbCAJhMfk04mNL/thUdKrHQg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D5041A420B8; Fri, 20 Dec 2024 18:34:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD88BC4CECD; Fri, 20 Dec 2024 18:35:52 +0000 (UTC) Date: Fri, 20 Dec 2024 18:35:50 +0000 From: Catalin Marinas To: Zhenhua Huang Cc: will@kernel.org, ardb@kernel.org, ryan.roberts@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, dave.hansen@linux.intel.com, akpm@linux-foundation.org, chenfeiyang@loongson.cn, chenhuacai@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] arm64: mm: implement vmemmap_check_pmd for arm64 Message-ID: References: <20241209094227.1529977-1-quic_zhenhuah@quicinc.com> <20241209094227.1529977-3-quic_zhenhuah@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241209094227.1529977-3-quic_zhenhuah@quicinc.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6649C4000C X-Rspam-User: X-Stat-Signature: yo6gqkq8ertdxybqr8xpsocc65ir873p X-HE-Tag: 1734719724-214496 X-HE-Meta: U2FsdGVkX1/CcliMCGLnrSTrU6v7Fo7dFELdeXNb7zZv0+fgJn+VwxuXZUFcvbb4Y6Fm+E1KQZNfjMO0WyuLc6cqX5nmHPupASJC2JdzJYseskCJ70RvGTVs//zZ/dSOAYCGph+w1+uXnvF0z3ARPhyKP94FilUALzkdMMUKIHPzHkrBiupPP5hbatF1HKlW5adWezidxPgeIqDFVhixPKtMA4Y8xWcpPspkle+PZrfLnZtH2dPm1Yco+tPLc1GRLJAA22Y4scJqJ0DqhCv+05C52gk48+o4Btj9tZocO6rIEj98PETivbPEhuQkTBz6RokDC6sgtfAqWndiqLA0t8k2uHFTlUUzg6RBtJXIdWhJnf2uKiOm48uSV20LLoEIQVgZZ6Q14PKwK0j16d9uzvBRg7aVI/ne+GdAMWqJN0M2CEhpxaz4ABvPgm/a69XV6yx0Vp3MiwwqUFWdq50aZZGFCoSQ8NN1Vcqh3mOi3QYHgOlDngihz+amI/ZMz4Zpv2O8/QKueTYE/EF7Q1Tn0W5X7QExHJiXzf9gcz0ocDPk8AjLfyETLIwbr0hbbAtV6x+ej5FA50hv/3b34Q5BS16U+zIeLjqC4QHP/pSCQtRD5dvCElbeP5aMrkdIuC3z+ucfdDwqVYOmm2TAlY6eG+FIGnAk/MI2Yuo45q+hsXzCguhivNWicbDHqHIC+2deXmnh9XQefmoyq+6HDmzdCYVoR/z8y2/7IAR06WhpMRY1Ixclg6MKmGZseXUQUTRRclI8Se6i0AEeXyOkP1vMesKozkitP0engfipNBDDVjqtL57iv0mZoYauqrfImzkT7GBngJc69f99ajfZlb+3eTVcr4cKluOLezhiclKEdsuy76nJdmdLgYVDHdyHGfMfsvco6qORJpmrkOM9MhDrS57gnRd91vnHkgcryqZKfnImzGWVwDHOt9X4e8myoKbbxp12v/rR1l83ERsOcjI HQ3RA3D4 CXCGH8I/nz9q2Qw/aKE7l0eU5Ge3B0NTk6LOZpZDVcTHSA4MTLiwcvq1mP/Q5weT5A6ZtuK+FoyAO1Ep9X2yQPCue8kxAUlGnRA+gpwoZ8I8Cch6IL6674GUXnRSr2bme89QaR/L8uk43hbnLpioun6dCJvdLBvpG/2bgcf2ACh/R3qU4TShwUQKVFq/Is7aivQKXI2vqZAI6CD4N/souDNu9IuWtZ1ubyWvydO9BZb5jYBY81+bZw+Dhwu6KajTC4a+CTnZ/98yv6t3q/UGM3Fp3cu6RRSzMutwhKTf2LHx+UAs18hXfoXwFwu5mgzJTq5S6tb/QQQVLN+DCT/VVP9RqOztR7s6S5vnqhLmQLNAVE/yVSYoFWIzvFrk1wmz9K1rqjWIT9yBRbYX8o1yu76YLyXmWP5wA+727ptEdUpN2j9BzC6W0m3HK/F9UHTW25vk8UPBhguw4Lrc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 09, 2024 at 05:42:27PM +0800, Zhenhua Huang wrote: > vmemmap_check_pmd() is used to determine if needs to populate to base > pages. Implement it for arm64 arch. > > Fixes: 2045a3b8911b ("mm/sparse-vmemmap: generalise vmemmap_populate_hugepages()") > Signed-off-by: Zhenhua Huang > --- > arch/arm64/mm/mmu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index fd59ee44960e..41c7978a92be 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1169,7 +1169,8 @@ int __meminit vmemmap_check_pmd(pmd_t *pmdp, int node, > unsigned long addr, unsigned long next) > { > vmemmap_verify((pte_t *)pmdp, node, addr, next); > - return 1; > + > + return pmd_sect(*pmdp); > } > > int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, Don't we need this patch only if we implement the first one? Please fold it into the other patch. -- Catalin