From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1BC4E77188 for ; Fri, 20 Dec 2024 18:24:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 628896B007B; Fri, 20 Dec 2024 13:24:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D8E46B0082; Fri, 20 Dec 2024 13:24:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A21C6B0083; Fri, 20 Dec 2024 13:24:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A5B26B007B for ; Fri, 20 Dec 2024 13:24:44 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 991A8140C7B for ; Fri, 20 Dec 2024 18:24:43 +0000 (UTC) X-FDA: 82916161650.08.E36CF1E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id F32184000C for ; Fri, 20 Dec 2024 18:24:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WEzQhONM; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734719066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZSUgJWf89GuUNaxwrUPCTvHi/aEJ6DazxVR7uNCZBWA=; b=Ujd5odJP+pHWMHpzuQ6Cnj72U9omL0fbf51U7atztEp7CKj8IGFacG5+Wdyek8lNxW4OCh 2r9hRa3lOcPFf9WuHtflvNL8UUwlHF8fyl3wypylvnxaznGD6L+Rc1h7dNBDEKcg/rmGFX pilKIMy4enM9Ik8vqlT1lWA4rzswq94= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734719066; a=rsa-sha256; cv=none; b=f2WiSdpeO/r/jYk6oG5ZuhQSsZrrYFSSVCuTGO0yXPDWOBL6aKhgMLOOsdtp0xrZ9M4IkI i/pnDZ6LKZ+rZGcegYkEBJpTth2ZOMwc2dnTjOZVfI/N7auZFaLxddCSsHzrkDgtI53+Kw YipDU3r9l21+pHl7+K+Kb8/C9N6Q40A= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WEzQhONM; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZSUgJWf89GuUNaxwrUPCTvHi/aEJ6DazxVR7uNCZBWA=; b=WEzQhONMURtrdmfJVniGyphw8M +Sr3IfTsoY9lZ1J+Ug9ZfyNQ6Hj0xbWOQoP3dpSW3N3KpZ1ujRcBnWnERvsnCpIPGgbiw9tTNg6kp M8MWfH+JKrz2GL6KJ5A0/05x2uALDhObDHm7ixVDlgzSjmb/2gTCq/9jFRzftwKeJW50ydTVA5i54 hOjcyGrgBBgVhh9NvEIVQBJ2K+A/Nayw+dWCXxg8d/8/rdgUh9WR3VUAEVnvw2YHb32eyCHFnUWw8 0b4/QG+56K0KP+N9GOK/DM5RpKPfUMsb12q8n21wQFKkigAg+7HG39qqh4g82B2mu7OmnSrkkW4qP w/AOomIw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tOhfz-000000024gY-1Bsb; Fri, 20 Dec 2024 18:24:39 +0000 Date: Fri, 20 Dec 2024 18:24:39 +0000 From: Matthew Wilcox To: Phillip Lougher Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 5/5] squashfs: Convert squashfs_fill_page() to take a folio Message-ID: References: <20241216162701.57549-1-willy@infradead.org> <20241216162701.57549-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: h8hmhnr8c5ajas411w3opu11jknoxhdm X-Rspamd-Queue-Id: F32184000C X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734719054-543793 X-HE-Meta: U2FsdGVkX1/OD6kOPSFQMeGpzgEfafVfFsX0BZkBNsBYTFbHTZDwZD+qD5vM8lFwLUVzPdkcecg+SU3zqBbydEWQqAe6UxQDZndYRzH9pGAgKfU3IkFcJdHEZca/XtkKo2qy1eP8fjEG8H7D/zHva+PhcXuPnqiSu1Komv1TjKVXmXEtrOwNgfPg6PCKL+Xxrse13R37XzVuGDDFUJXUSeEOeXf1WFsnczgVtG8ela1BH7MjYBKW43fFKyS6NKBrDPREUS4hn6QoxoF/EtEYsJBaqWbTUGDLc5BI/4N2Xgw1VDYUmEviDyCsyq3AauQzUasI/mlZiD0IDzpViUD2k1l0xD1GJyw9W3x+1GxUxsWgAiGMVMrQQrv9JQVdpCj7f/Tb+XSB4yPRFX9iUmUfL2ZeEgzM9CUT19uQAR6NBipiXPhitSBG+JRdpsuKb8ryONYxGuKe1bgGW/+bJf/sJgii21EiY94KfwkrTLURCvpbvV6tg+c22ZTLR1Ynu7PkxTqVEgE838MgISKuOULrwnv5MVdln9sabwoBSUnaWjspnQ1tXayKEsoivauw5NKGpLA1dDiSkHxNeVXIScPjA2TLuveHPkM2VpKxtD8bbLeEIIsFfzOPsrYZZ+vZbmi1Dau8EHsyMHkb1uwyNCwjMufevacY1IrPuYjMEu+sevTYp1/uWTyEf3SebhcW5GdAGhwdGAG8m66vwRWhS6aahRGO8T15uT+SD14aT2+Jfm71z6ZM84DCPwNYf6hfPnCY8qA3SY0ck5sgGPwZHg4Y7AoLNSdkq26ZRV6Pq92LjXE2bGm0VwmfpYNAR8ThJEz8fzw0x0OuccoeWZVd7JnR+P3034a9pGq3qwYLMo9BIgoWH9adM5NJoKET8Bn044Tyqzs77eBugkXKKtHcaRyN28i7+kYTZBTd7mwevKXF0MLdqBIQdYUM3FL/UJyUX12tKPrzkeXAnurU264X8Xq 82FoUGUM JR4kj84NIE5TmD+9ryZA5OrtW28Tg64/cPIKUU3X0bo3jfa72xS+pmfP9JtHR0UhvBRprylGJfErDK5zaab1QC1s26QPJ/BdAxNkfit0C/X44HbFB4wplRm1+npJ3xlM/FKPdFUUM0/yzm4uOHumKzEZKQIh5IMwnxn6Zw1WdOXDlDdmU+jp2jDFeVSCoKF/Cn5SdXtwO8pMkUK3iKko+sCdgISAntoDYgYUM1vHcCnGw9EIOzUbFkPPXcK8O00q2pGKwAqRz84KAUpSjAK37cV+2yg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 20, 2024 at 06:19:35PM +0000, Phillip Lougher wrote: > > @@ -398,6 +400,7 @@ void squashfs_copy_cache(struct folio *folio, > > bytes -= PAGE_SIZE, offset += PAGE_SIZE) { > > struct folio *push_folio; > > size_t avail = buffer ? min(bytes, PAGE_SIZE) : 0; > > + bool filled = false; ahh, this should have been filled = true (if the folio is already uptodate, then it has been filled). Or maybe it'd be less confusing if we named the bool 'uptodate'. Would you like me to submit a fresh set of patches, or will you fix these two bugs up? Thanks for testing!