From: Matthew Wilcox <willy@infradead.org>
To: Phillip Lougher <phillip@squashfs.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/5] squashfs: Convert squashfs_fill_page() to take a folio
Date: Fri, 20 Dec 2024 18:24:39 +0000 [thread overview]
Message-ID: <Z2W2Z2Tq4WMNluWU@casper.infradead.org> (raw)
In-Reply-To: <ac706104-4d78-4534-8542-706f88caa4b7@squashfs.org.uk>
On Fri, Dec 20, 2024 at 06:19:35PM +0000, Phillip Lougher wrote:
> > @@ -398,6 +400,7 @@ void squashfs_copy_cache(struct folio *folio,
> > bytes -= PAGE_SIZE, offset += PAGE_SIZE) {
> > struct folio *push_folio;
> > size_t avail = buffer ? min(bytes, PAGE_SIZE) : 0;
> > + bool filled = false;
ahh, this should have been filled = true (if the folio is already
uptodate, then it has been filled). Or maybe it'd be less confusing if
we named the bool 'uptodate'.
Would you like me to submit a fresh set of patches, or will you fix
these two bugs up?
Thanks for testing!
next prev parent reply other threads:[~2024-12-20 18:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 16:26 [PATCH 1/5] squashfs: Use a folio throughout squashfs_read_folio() Matthew Wilcox (Oracle)
2024-12-16 16:26 ` [PATCH 2/5] squashfs: Pass a folio to squashfs_readpage_fragment() Matthew Wilcox (Oracle)
2025-01-14 21:08 ` Phillip Lougher
2024-12-16 16:26 ` [PATCH 3/5] squashfs: Convert squashfs_readpage_block() to take a folio Matthew Wilcox (Oracle)
2025-01-14 21:08 ` Phillip Lougher
2024-12-16 16:26 ` [PATCH 4/5] squashfs; Convert squashfs_copy_cache() " Matthew Wilcox (Oracle)
2025-01-14 21:08 ` Phillip Lougher
2024-12-16 16:26 ` [PATCH 5/5] squashfs: Convert squashfs_fill_page() " Matthew Wilcox (Oracle)
2024-12-20 18:19 ` Phillip Lougher
2024-12-20 18:19 ` Phillip Lougher
2024-12-20 18:24 ` Matthew Wilcox [this message]
2024-12-20 18:42 ` Phillip Lougher
2024-12-20 22:19 ` Andrew Morton
2025-01-14 21:08 ` Phillip Lougher
2025-01-14 21:07 ` [PATCH 1/5] squashfs: Use a folio throughout squashfs_read_folio() Phillip Lougher
2025-01-14 21:10 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2W2Z2Tq4WMNluWU@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=phillip@squashfs.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox