From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56BAE77188 for ; Fri, 20 Dec 2024 11:18:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 575916B0085; Fri, 20 Dec 2024 06:18:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5251C6B0088; Fri, 20 Dec 2024 06:18:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EC6C6B0089; Fri, 20 Dec 2024 06:18:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 22C2D6B0085 for ; Fri, 20 Dec 2024 06:18:45 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C75501A0954 for ; Fri, 20 Dec 2024 11:18:44 +0000 (UTC) X-FDA: 82915089096.11.21C5072 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf15.hostedemail.com (Postfix) with ESMTP id EEC59A0003 for ; Fri, 20 Dec 2024 11:17:49 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=i+eYY57H; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf15.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734693490; a=rsa-sha256; cv=none; b=Rufmdvve4Wwp257heePIpTY5R/jHgjtIdUpsQm3NyMeEHNiQ6i4CUFLZ9WF5EprlSfv++K xwwH3bKeRniKA7XLshyRXR5SiJ+wXkd1/zwr6Ck96BJkKm8dFnIkF1OyuNNP6tF7h4wxkD L7JKj+cUr+HmFlw1WFrBhi3/qZgn4Yk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=i+eYY57H; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf15.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734693490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VTDoWcoQ1Do43bcRpkcFPTXrbalVP/zSadlkqOn9knA=; b=wNe8smtaRXEcg/DfXxdBrZ1Q+u1fyrx6gUqist/OmfUrNXJpNb1qODRqYECM6bPfjH5gBf x3gd206NmT6sqvps/9Iqqlm8SJpWMKSqOEFTJx/sGVePTt+sJvlcm7G6luClB+ZM5BdLqS HuFotuRqsjdkjwbcdItQzTH/ui+rc18= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BKBHBW0001729; Fri, 20 Dec 2024 11:18:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=VTDoWcoQ1Do43bcRpkcFPTXrbalVP/ zSadlkqOn9knA=; b=i+eYY57H80CgDLd+GtmG83AtQ8gUebNW5gwk7bYNKSxCFh H96pOw3wB20vEkivfAnhdA9NeJNZtgNMQibneXcaV1CJlPm0dWXljf36nYGF81CB h1CXnNyelhWYJMWjhx2nOoDTN7RUoV3kTd98BP5AwdWARKXZlw3lcMcGxgCsFlUj beulLhkRa7+ZUNG66bA+UnwuLbhdfYALeqgniU+iBhwDidVhGuvH1NUrIiE7cepp uCuivmm66VtkSdsCAaZuH4qSTzY9+t4PsLLotE+/vMfu6+vu2qX/69kMa3Wqb8Wh 48Qq432Bg96elH1tPwU3QULjj6cd29PygbFBQLVw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mwmhjf0b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Dec 2024 11:18:27 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BKBF90t021621; Fri, 20 Dec 2024 11:18:27 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mwmhjf0a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Dec 2024 11:18:27 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BK6recE014383; Fri, 20 Dec 2024 11:18:26 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43hq221fy9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Dec 2024 11:18:26 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BKBIOfM52953592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Dec 2024 11:18:24 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6EFBC2004F; Fri, 20 Dec 2024 11:18:24 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3721C2004D; Fri, 20 Dec 2024 11:18:24 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 20 Dec 2024 11:18:24 +0000 (GMT) Date: Fri, 20 Dec 2024 12:18:20 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/15] mm: pgtable: introduce generic __tlb_remove_table() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: DHEMKeKCdeKwBgc4veY0RuU36n0nJgmE X-Proofpoint-GUID: rKiFh2Wu-Nx3Rfnfo2M_cEQgn4CjyLpE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 adultscore=0 mlxlogscore=529 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412200091 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EEC59A0003 X-Stat-Signature: e9k8cho67fcnhknhgehrfaaw9mt7ah81 X-Rspam-User: X-HE-Tag: 1734693469-746124 X-HE-Meta: U2FsdGVkX1+qSyR5nzvV3Dka+ZW8PXkjBreM3FwjYjesrYcuB7Cpr/oQmtvlyfK3vgp49y4SM8/ouYnXGr5Pby5pUuAiYxkiakBYxENfYT1+c55dpuYeFYoJeus9eMPw58uEka4I8SJXlVm5ce8dcGFAib8s+7z8Cr7lKesBB6pFlFfpCpeVXOhgIQ4ZfSx4BOE8TykENFCirn7o3dz1VGyKtMd2Hyh3ni1eH3m/+J72KM/MkVVTjB2Vq8Z07WXskHwOlPFFmyVnar4/247BveoseqSdelieC1kg034KhL6Bkn5A+VyLN+61BWmyXTAqCwP9fDsR97ahrEQrlUnPorh9zevgR7D2EJng5BtNgEj/phn+TBFVoj0MTviacfs4apBPlgVT1IvwZtAif6J5ma/ypCjKHjD7PhQr4wp1bx3X729/dOZG3TdnVPndB90jaIeE7SgNVCH2XptrlFo90f18RP/YPXOWYrRLpcfMuSxV1Vcb7VmuYMepk++OnZgx/tX3zHcXUsMgezf1ozuwkbvhdeGMwBiYkcf+Uo8ukJyXWhJrXD2SNB5Sa2Oqwq3OH0Jx1AioFRpV1Z6TR24G5qU+h3Xnqm0BcFZ3ER/mNWXlAasnobcK4+gKGmAamJWAPzObZTei+2y9tyWnSPCKO6Vab5iwiX/8DDjsoSoe0Iz0fYHfeOiP3v8e89TuVE+I2eUwmIH9lRxB7JQsr4xhGlmFLCws+c6TFdcgRWXYvBTDUEzjSMQltJ9RgcnbF4j8uc76deqcIEXEz2QO1iOxp4LcT3Dfx9zTLxbSLCgGZnCTo3BDXMJSUREO7G99dStpL2uFkDB6wsknRuF7WFRwsMaGyzN5lU+Q8MuVztbz+D6vUVf50QGesDZY8/4RVEOStovWRGD8OBv8a4yB779prFkNkETMd/v9yx5HAo+2c2OmCK/eAzyDNq0Cr/YeZbH+5/WLUyLCXjIoGrcgKdv rd+7jIUF d07OgIbh8CKmP3RwttuVwv1OcSl+P0mNjqUDR95HyyVPoDjTQOdAjwFFAZbAij+Ng7hMieeWtpByUbt78LE4NF7ARLGzu0BGeJJ7zXoP4IbL1L3KZ23SAp5FSbjOrEyRYUQD7yfpP6QMAoJ7cADJbhIwClmQYlPnuYy7dJpYoVHd8e3yLH+htRiwQDguDLDaGG3/DBLLcQuzoX3sHwrDJ8AwaBaQHOiscnq60mrfpzmn1liNX6vWfMZkl8MNnZI37eOcMaYAkNUBfjHZJ3YtayAscLw1x8N6CpJg2B9/HrjKytB4vhhA7xd8nDWW2SHsn6hwIOV7Iqe7+D4mB6iXyckjcDSJpTtPkT+L4OdVfN39C2X84+cLTb+4UU+BMCa/H3IQBmSs+ybdKXqoxw2/tA3CMEGVttR3bRpyxsNMACzLZrN1HwNCCzoaeQjl90tXwnkCBUFuq0FfPkM8hXc6KIPzQsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 18, 2024 at 09:04:47PM +0800, Qi Zheng wrote: > Several architectures (arm, arm64, riscv, s390 and x86) define exactly the > same __tlb_remove_table(), just introduce generic __tlb_remove_table() to > eliminate these duplications. s390 is nearly the same, but not exactly (see below). > arch/s390/include/asm/tlb.h | 1 - > arch/s390/mm/pgalloc.c | 7 ------- ... > --- a/arch/s390/mm/pgalloc.c > +++ b/arch/s390/mm/pgalloc.c > @@ -193,13 +193,6 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) > pagetable_dtor_free(ptdesc); > } > > -void __tlb_remove_table(void *table) > -{ > - struct ptdesc *ptdesc = virt_to_ptdesc(table); > - > - pagetable_dtor_free(ptdesc); With this change you introduce these duplication in __tlb_remove_table() and in pagetable_dtor_free(): pagetable_dtor(ptdesc); pagetable_free(ptdesc); But I still would prefer to avoid __HAVE_ARCH_TLB_REMOVE_TABLE. Could it be possible to move pagetable_dtor_free() to asm-generic and make s390 __tlb_remove_table() version generic? > -} > - > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > static void pte_free_now(struct rcu_head *head) > { Thanks!