From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C782FE77188 for ; Fri, 20 Dec 2024 08:42:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 476EA6B007B; Fri, 20 Dec 2024 03:42:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 425916B0083; Fri, 20 Dec 2024 03:42:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ECDA6B0085; Fri, 20 Dec 2024 03:42:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 12A976B007B for ; Fri, 20 Dec 2024 03:42:28 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 809691A085E for ; Fri, 20 Dec 2024 08:42:27 +0000 (UTC) X-FDA: 82914694926.26.3B22495 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf07.hostedemail.com (Postfix) with ESMTP id 6DE6B40017 for ; Fri, 20 Dec 2024 08:41:32 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CQlJXGLV; spf=pass (imf07.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734684118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZRSRO1+IMydt5X2E+6U7iNTI+6Ud7oAoHs5HZLZHBvE=; b=MlIsA1HpZ01ymdKOvhfQ8uz29WMCanLP2t1ZL1+cqd8NwEJJ1PZdKj7FomGDNehCeD6zL0 BwfOCV3xZTAYuxw1i25AkP3q8ZZAzUogdMjvUANJNpdJor9HTQ4ahh7W5Nqa+A4K/yGWf/ wfvlvSPkf1uLoJhQ9uVOOiu46l7OapY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CQlJXGLV; spf=pass (imf07.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734684118; a=rsa-sha256; cv=none; b=W6sCqDEPVwnoIe2hrO11+6vQcIQb3RWXTQtdD4iJi0j67LB25O2KwV2YM24He78mxAfU4e yoirCNb3+0iiIpPfBVX1C6gr3VvGxzHD+cEv5oCuyiUxHi5hWw3OWCPZSwcU0L4pQo5A55 iCloOtZSEO9Di+96D6toT9thBw+vAEE= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BJNbFUa010362; Fri, 20 Dec 2024 08:42:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=ZRSRO1+IMydt5X2E+6U7iNTI+6Ud7o AoHs5HZLZHBvE=; b=CQlJXGLV7nWk6F848mJVjZbx8m8Bx/ilYDO4o+It6YihXI NdKgpjE/b6TIAwSdICZchWxpBvWfROgOp3if4gcFO1x/E1adZSpXqUTJDI59d1KS UcZ5tmme/On0DfN8nccMpRH6KpKfSLMDG/jN1xTugbQdnygtHgKZDfIFtWbxInlN V1qw9+30CsgeEwPnVsarULOjqDHCg/FNDfqIpIEoOXMOalkjDl/2uuJ0xFFaAWy9 10Yn3NLIr8jzZavgCFKd90LofyIewmQ8jXJUu/4KJREDvOSLUoStgTG6oIeWf5f8 X7ASOe867RrrQ43MjggNx/5fMH35Jrk7hUwtLm6g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mwaahsbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Dec 2024 08:42:10 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BK8axYW007991; Fri, 20 Dec 2024 08:42:09 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mwaahsbq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Dec 2024 08:42:09 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BK5PiS2005488; Fri, 20 Dec 2024 08:42:09 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43hnbnhc4f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Dec 2024 08:42:09 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BK8g7HM57278888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Dec 2024 08:42:07 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F01BF2004B; Fri, 20 Dec 2024 08:42:06 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 68AE32004E; Fri, 20 Dec 2024 08:42:05 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.45.163]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 20 Dec 2024 08:42:05 +0000 (GMT) Date: Fri, 20 Dec 2024 09:42:03 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v2 10/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Message-ID: References: <0a6caf8305409173b5d41dccb6ecd46460cf9c1c.1734526570.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a6caf8305409173b5d41dccb6ecd46460cf9c1c.1734526570.git.zhengqi.arch@bytedance.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: kmj9hT5gcmZ27lZo4Hu4ANqUpOmExIrn X-Proofpoint-GUID: jWWgn2vamVxqyPJwznO3SnWKD7Jvt1ul X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 mlxlogscore=486 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412200070 X-Rspamd-Queue-Id: 6DE6B40017 X-Rspamd-Server: rspam12 X-Stat-Signature: 6eyzutjbkbhtyi1j5p38jbpgex88tciy X-Rspam-User: X-HE-Tag: 1734684092-407030 X-HE-Meta: U2FsdGVkX19EhssUQFNZ2JVl6p0nLcgS4lrdQm0vMlzU/6PJC1s2k4CX0c9/1LU9cYa8HA2TCIlj14GkYW89nx4pdEKM17xTRkzaCaxkNz67df+Vjv5KnCxeBSE962AdImHRkNLB8Qfg8p+5ZgDhofVxGi58OVrVKLM9GOQ+0/pLV5dTTPFFKtr5jFBN5Rh+cZlspE17ErlNi/qQdXPTspY5Ob5jUOxD9Qk4aeJ+LScB34qXE7hDcrOEEayCFIy8wJCH0EiYBRye49XCviQ2jD+C01Ha/XlRbjz/XUvK1v49nRvpZz/C5rqV2GLu3k0Va2cqkfkwQRBXedH5IWJg9ckY0mcdbGXQ0RCLdW/mJU8ZVhVOotggobbLj/A7YyFS7XKzstgfhLyMYpKgXMtdmm+1T5U59Wachll2JEehtyFOtvL+spKpf096FpTMlryZt+nZVXd1eOkMFCc/s6CEZAfYTaatw6k2jPUAZlvExpebEBz3ySFEF/yTBC910ZE6Ng5KAlE8vnrX+MZxEv3fmzPvSk4a6At/FGsbZlGkXFogqdigozUmuheEkXRhGhGaBxpDzd6/X/mzfLQCZSJ7lLGXgCIMIo14QMF0iQW9rYTch9XcfaZkHxKR/LMNWDifR3XwBF7O/+rsfOolP0b8IBZwTffr+dDMWOSJeNAFwK0/LRAH/FzqWkX4d2Vo8/EAgDFJkI63CpggX4qWvGYd+U5PK8GWplC1QXQJVQF3+dRjLezGZt/FD6dtcTRHDr+ln0gRavOrsgM7RPsjurJaTG0YDAfDyZOMUk4cSPQa2AfGKOh9x8BxZPFYHPDpYTkhAQGTRopmGuqHvd0sturVjdy/WBYKF1Jg5J9mLqTxmWJz1TFNIm7Ru1giPsYPxonEJEPdN7dfRzjb0N+dBz5AG0tMtgO1Y7xYQz7UFokQtfIbpQ+ZSdQeoPdqGKDNmwe8WOCJ7wWQdJyAtLK16Wc pF6kJ7y0 gFL/skEdcQwHoPgnWAspFYAzgYfKmN4DajXYVJKzitDETJ6jo10LOHZtzzu1VcYw+ZePcSZf2yzhwGvkz2XweysXxPlERx6IrP0SmuARlbX8O/zcpSdnN6ed11YSYn/XD7smWFfmqCGk3wSPm7WzEqJ/J1HopNsNIIVUcukHMbbN2l8g9cMaYGYG0Qjs7U2E7/7gY/MgCW755tv4pDiy+5XSUPe1hovfPwGV1bR5bdBMhrAVsFFosImMTPiLC+/2ypsRbfq3PuRRs94DYlM3zo9ic0duY5wjloNQ19BZx8R2Vrq1LcH56kuueW7qy0C+VVKdxq4jqX+1mTqS+LMIzZraMZPleqJp7UcCTsSTD91NE9g67n5bGg5cR0AvMzCJTWGH7st99PBfYWQy9056j9wtDG6fW7sIaW7XMdjKwCQHMFNUls1LRR5gbO7ES8Vtyg0XTrUEmbP6/pOk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 18, 2024 at 09:04:46PM +0800, Qi Zheng wrote: > In s390, the pagetable_dtor() of PTE has long been moved to > __tlb_remove_table(). Well, not pagetable_dtor(), but rather pagetable_pte_dtor() and not to __tlb_remove_table(), but to pagetable_pte_dtor_free() ;) > So similarly, also move the pagetable_dtor() of > PMD|PUD|P4D to __tlb_remove_table(). This prevents the use-after-free > problem where the ptlock is freed immediately but the page table pages > is freed later via RCU. > > By the way, rename pagetable_pte_dtor_free() to pagetable_dtor_free(). This is not just a random rename, but rather a result of unifying PxD and PTE TLB free paths. Could you please come up with a better wording concerning the above? > Signed-off-by: Qi Zheng > Suggested-by: Peter Zijlstra (Intel) > Cc: linux-s390@vger.kernel.org > --- > arch/s390/include/asm/tlb.h | 3 --- > arch/s390/mm/pgalloc.c | 14 ++++---------- > 2 files changed, 4 insertions(+), 13 deletions(-) You also did not CC linux-s390@vger.kernel.org for other patches that affect s390 sources. Just CC the whole series, please. Thanks!