From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B416BE77184 for ; Thu, 19 Dec 2024 16:33:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19F396B0083; Thu, 19 Dec 2024 11:33:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1288A6B0085; Thu, 19 Dec 2024 11:33:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE3A16B0088; Thu, 19 Dec 2024 11:33:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C5ED46B0083 for ; Thu, 19 Dec 2024 11:33:09 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6C0208177F for ; Thu, 19 Dec 2024 16:33:09 +0000 (UTC) X-FDA: 82912252332.22.253D790 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf28.hostedemail.com (Postfix) with ESMTP id 7283DC0004 for ; Thu, 19 Dec 2024 16:32:30 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XCL2gX5N; spf=pass (imf28.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734625972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TcPTvfwqM7u7CKWKVuI4kHjT7dxBSrdnkpU9Qv1a7fw=; b=MnU9DU5MIvrVvSM+sGT1gjpuBfIGXCJLzeT0RWybZEHtIQdzpFVFOWSdcpIx19kAP/CwkB aAdRT9Hr/4Ps4s7zz0Jo1YzeJD6jvCqfYpqyI0E+ZPCm1W93RryIb1Wr1qA59X5RNSSE/6 XkZmksbGknSDgjfz6/XQCNz9W476OPM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XCL2gX5N; spf=pass (imf28.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734625972; a=rsa-sha256; cv=none; b=JG2ZvqAgst1B4C1+7t7OIkLLRyrXPT+4hW+VnR4MHPG6BLsr4X1fMMVyMEYBgoakpbvr5O fQSTiOB/YWe4LyRbuSESUgyeblSVD0LhT/rEWFrqeN8vwwNoLwfWct6xlcK0kZ3D7Ag/g9 6v0N2G3OYRZwGbj+896ho8Nu4vNj71g= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BJDIYGd025275; Thu, 19 Dec 2024 16:32:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=TcPTvfwqM7u7CKWKVuI4kHjT7dxBSr dnkpU9Qv1a7fw=; b=XCL2gX5NX0oqJuA3wOOs5oS8h3LJTkdu/f/AfEJPJsKnVR nrtDUbFx6HtU8zEH6kdG94Z06/5Wz9nReLaCU5SyXuSpesc3TGraEWQTZnB2Hyuj XMH1JEKVrtCb+2aXjollXPOu2CRHZdOPCZvXzYOX5Fzki4xO4ldgj5M4hbhl8k7v 0BNEQj9r52ZlR8i2MdlBt9nVTTogpHAONIubv6FzEYpf8ZKm7cF48w56L5ZsHgM/ RRO4b71pv9rRyz3OAJtlRxoOp1g39vUo0ifeULVmtWscCfdlKwYOyCg7ulFf91c9 Xcx9919pyKLtWi9Q6PPz3CUx4AGNQEZNTEyqQwug== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mbyhuarn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Dec 2024 16:32:46 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BJGW1qF008150; Thu, 19 Dec 2024 16:32:46 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43mbyhuarj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Dec 2024 16:32:46 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BJDKN12024022; Thu, 19 Dec 2024 16:32:44 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43hnuknwxk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Dec 2024 16:32:44 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BJGWgLQ55116142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Dec 2024 16:32:42 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ABC8420043; Thu, 19 Dec 2024 16:32:42 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 68FB320040; Thu, 19 Dec 2024 16:32:42 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 19 Dec 2024 16:32:42 +0000 (GMT) Date: Thu, 19 Dec 2024 17:32:37 +0100 From: Alexander Gordeev To: Qi Zheng Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/15] mm: pgtable: introduce generic p4d_alloc_one() and p4d_free() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: g2Lk5szcAk0nRKvYG5-DaIC9sPIAONs9 X-Proofpoint-GUID: l8R-xB1U3F3wOz25pRmxmKnppbEc3euC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0 clxscore=1011 phishscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=369 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412190132 X-Rspamd-Queue-Id: 7283DC0004 X-Stat-Signature: k9tkq1cf739huid9ym3e1jwuunhpeo8k X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734625950-150443 X-HE-Meta: U2FsdGVkX1/P5yzVv+hUTK7SGgaN6C1oeg5IcIFOsPZyV+yMLe0lEwNTB3Wxo0Q28Ro6eISwa2QR+HTXZ9FWxoaOhEVblS3OHQe8zhavtidBQi0BcsLZ497uHo2msaKuk++pBancheV5hzmhil80Q/3ejuWFMnpX2h3n3Tnf09wrmBGL8T6pwt5xu2Q44iE5mTrclISukp+AmmKunehyxZ4Ceer1MdztKyGLi6pA34+/6mTKAeadEY/NqhxJPIdIWWTOTI+ZponzL8K/DB56ssZehijzaqVpgo15N2JFu93GgmCAq0Fhqkxe9Yz9g4h545xziC1UoA1tS2PnnYM2TaQsAdDFDQF55gOQ2w8yPiZ8BYH6fQoAqmT30V3xRXVTymXSkP/5kjap9TclAK7+3MPfUE/NL9QQz+Np9y3YDPAlECZDbb3WQTq6P8Ev475pVlQmVqeGK3oh3FgUDVsA7m0IiipeKCsD1hS2snkd+PX5iud/Dg4NRWCmZS84LKOMiZ+1ObxR6nfVOR91ZfX5c1DFBQDUMHkSD1EY3eflFAJ7cRNcmw8mcoF+mH9OV6I5JESWeuh0YcGMXc+mnGWC3ZVMv32TDRpOcSZ2MUn1ahcLkKdER57wgtQgJ2q0CHgTYhblMMHDIavX7QHvr69yEpcGvNvlU1IZk+RwlZ+GbV3Ox365iBCbWZ0S0Hsm+X4iXqwupkGCFiGLJC5MhbOYcmvCvIFjk+gAB0d2cR9myjdeYqhdQ3x7lVl883qnQ0eIuevEce6AzDBIEaAnbzzxCkc0Qsf0aQ0yJYI4Sf6waN0Pn0CLJcWpWb0KJ3Ctcg8jKU1cW5eo/lmA7fmszUxluoE7XLgtoQFY/EOfeLHq+FXD1FppcvU95wb2VGO+EXh8eSyEO7onpdd4Ypl4WdN1M+8JUnwCwQTt/3IkJHNojjnrEn1cdTkV8mKGJELdoJ11D/31i7EktNtIfGNRzK1 i1p5n169 i13IY72QEwgab6QcXmKTkSmjtira2NieKA3GvL4LKin7/hyP++OtMCDLc4QtO7uLD2eg8Q4chwLP7pid/ltwf74hOfGR0iqlA6svvgQN8xfkHzkf8xYsoXzPcukRM8TNIJlxEXzEXl+Ythu1gril1xo7+DnLHvcGHusMc8um0M7O+V6jwTRsbPoxq4x4/oMP2Ehof0UKfiI3Y+D1AiboAUiNiRsDJoK7tFAvbxFYwzX6FRojFEkLjP1XEW63X97cUMrFqhVJOJs/dmojrsqV/PvOFEnS2+DpgLFy1QWQG2fl6YcHvg3Bb1yjlb5dYBT9M09GnjdPomIiW7+Baj98Q9MsL6oc/vzTSFTzI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 18, 2024 at 09:04:38PM +0800, Qi Zheng wrote: > For these architectures, provide a generic implementation in > asm-generic/pgalloc.h and convert them to use it. And like other levels > of page tables, add statistics for P4D level page table. FWIW, introducing the generic implementation and adding ctor|dtors look as separate changes to me. ... > static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) > { > - if (!pgtable_l5_enabled()) > - return; > - BUG_ON((unsigned long)p4d & (PAGE_SIZE-1)); Or maybe? BUG_ON(!IS_ALIGNED((unsigned long)p4d, PAGE_SIZE)); > - free_page((unsigned long)p4d); > + if (pgtable_l5_enabled()) > + __p4d_free(mm, p4d); > }