From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C77E77184 for ; Thu, 19 Dec 2024 07:52:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00EE26B0095; Thu, 19 Dec 2024 02:52:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F01C76B0098; Thu, 19 Dec 2024 02:52:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC90A6B009A; Thu, 19 Dec 2024 02:52:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD6FD6B0095 for ; Thu, 19 Dec 2024 02:52:36 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4757D16135B for ; Thu, 19 Dec 2024 07:52:36 +0000 (UTC) X-FDA: 82910939160.20.A1194C3 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf13.hostedemail.com (Postfix) with ESMTP id 5E24120003 for ; Thu, 19 Dec 2024 07:52:02 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZPzuvmd9; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734594720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PSh5zdBRE0Lx5DSukPiPhNlF87R8ZTZj0121Qz9y/bE=; b=wOGfOt5xAWwz84B5hBIFqhxxp3ZD0FJQ4t2mb+IK/bu7MVRrzB6LmpFHh32IHm9oZO1nF4 Q39/+4mQQV9s43CXYBZe+MZxAGwYCnRBLrDGWPjzP1uVF0hW9mtqH+caazshVDMrE90Zqd L4djkR0ebg1+DBeAQuAoeetEkDD/EQo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZPzuvmd9; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734594720; a=rsa-sha256; cv=none; b=MzX4lhicutStNIbM3cFFH7BVIwZsf6UFpRCPODOKUFWT5R6MZ7fqN8hAErt0OuOpS3grzc IaoZaOHVSqPv19c/PvFlbsBDKDQ/8OGS/xDjmnD+GfmBY3i08MdjW0LVaIkXe4tWUhREjM iXPx3sHH3d0vwdh3LFiLxHE4kKVYo6w= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aa6b4cc7270so74534666b.0 for ; Wed, 18 Dec 2024 23:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734594752; x=1735199552; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PSh5zdBRE0Lx5DSukPiPhNlF87R8ZTZj0121Qz9y/bE=; b=ZPzuvmd9HbDvCqJsLQYJBOtx0STowqWA2u/1zCeWF0DkDQ2rHBKLfEBis91pVjivq5 E93/JIVaDog7GNJe0pf72JFysA5CPreBwBkN1kYnarUJ+vEjjOMQcez+pJEfTCfBxj8K VGo74yZiuDU0ViolEDcYujvPYe+fzJtJOTR3wqX+DZkDXyGv8KYKZu8NOYsK2dMIjsYW 9V8vekYBkfBJk3fAzOeWe2DDCBVw70LTgYyAv/TOWNXy2/CkW1GylSFDUboVEwEbOil3 hCo6/2lsQY+xbHV6VlH9BQfsQOw8xUVgTjoBO2TMdn3pHkknVWtbBzxw0+ATAoSSGYM3 fkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734594752; x=1735199552; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PSh5zdBRE0Lx5DSukPiPhNlF87R8ZTZj0121Qz9y/bE=; b=Fw5I2EXzmdn5scj2cR5xJgOO+izi1GJm0frhCzG6HvwJEDi5sK/5SWe9pTkLWbxBWr vzACPHTLeEy6aiMTT7EsYnpabt5pYb+crCTEP3P0UPeR3ZiNwRljFER9Q7bnSrJJFXi9 PF1Ujf00djqSl/gOlRJp1d7AFCbowEuTeQopH8kuBU+i49NQoMaARWGMrgmIibm7zQ9Z Sc4GfihQ0ToCPsuahyDtg2PJvSJXYwQkkdVo8oHmn8ZBdbdjZWmzOszpW0zjedS32oax dLYH65+t138+xj2ICmbt6lHSX05uZqFLQEDrv9J3gQxW9MVO5eo/UEnj/JC+9rTzHiA0 yO1g== X-Forwarded-Encrypted: i=1; AJvYcCXzJdFyK+D9+Z7Q7ppI+Cjrp5W839ZOn6gp2xmHj9Fo/uHsCSKaDvOxe4hNK1uf9YJMPqAIE9/SGA==@kvack.org X-Gm-Message-State: AOJu0Yxn/pD+H6602o45XxFaib8V4pQBKuTxEUqKV4fIJ5uPUZ3jsU5S SEwC3sogBExFu93yPoT0ZFAtvtaU/+Bkl0dKhqZOdmP6ctL+yEFOVXATF5TQNsk= X-Gm-Gg: ASbGncvS6xLDT/lxucUPF1X7mz9C7b1ugG3tWZoh5D0hRvlQcxhgTKkdqv9Txbzqt7Y MvrvDqbcggXLpkGBeety6lbcgW5nwTE/EW9dgH9vz7YaBgI/gD4NMlDZR9jvYACex4WhDFBgvJl GKH5S/CUMuX4e4zLU3Tjf9iAqe5Uaf1zxwiGSllJ9QKjcVJIhfrcxT+xoF50CM/DO3RqJaSmCX0 vj53ICguItJdq36gbtPQI8tu/dlCDiEn+7Hm1OKnuQmYzElxP7Ks1yUN8yZ4/p/ X-Google-Smtp-Source: AGHT+IGmdcFGiE+dyHXWcxYMeYetvrccLjZHhMlUrN4PpMv4Z/QfsdlsYoYYFwlCHTc2Lt7pBsfY4A== X-Received: by 2002:a05:6402:4492:b0:5d3:ff93:f5f9 with SMTP id 4fb4d7f45d1cf-5d8025caf0bmr4517867a12.20.1734594752623; Wed, 18 Dec 2024 23:52:32 -0800 (PST) Received: from localhost (109-81-88-1.rct.o2.cz. [109.81.88.1]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe415dsm36745066b.123.2024.12.18.23.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 23:52:32 -0800 (PST) Date: Thu, 19 Dec 2024 08:52:31 +0100 From: Michal Hocko To: Alexei Starovoitov Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Vlastimil Babka , Sebastian Sewior , Steven Rostedt , Hou Tao , Johannes Weiner , Shakeel Butt , Matthew Wilcox , Thomas Gleixner , Jann Horn , Tejun Heo , linux-mm , Kernel Team Subject: Re: [PATCH bpf-next v3 4/6] memcg: Use trylock to access memcg stock_lock. Message-ID: References: <20241218030720.1602449-1-alexei.starovoitov@gmail.com> <20241218030720.1602449-5-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5E24120003 X-Rspam-User: X-Stat-Signature: dpt9tarhtr3xc98tzagbirkzfmffir4q X-HE-Tag: 1734594722-868090 X-HE-Meta: U2FsdGVkX1/eC20GDoUVCZMGEHwxkAQPIzONfFB/CXd4LNWuJlj27nQ2sBp72rP+ihrcF9rotW7KwneNWexKt3kidFJsryLqfkp/WMDUrYY9y6vcSPQvzN9k40O33sQNTviUndVbB4ZjxXzgjy+7moF6JfK/u9uVn9QCQAPinJ91664HpH8zIpm133p7s/bHEmtaHEWqD4xTrwzPv6i9QMuV8+IDprcSVg3v15FdaiaLFgpHcGokRkAvlV1x0+PlrxQaa6ZH8whB5sUhRgl3S3d3kFNCc0ylXI4CkYiScRNP8QpOxnguvfkdv7QN73tp2fUDnZAJ+dY0W5/BlIrNuEM1+Bk0+xyJkQJAXvv7HBtF/ZoTVRAhrxejC42djlyw42UsfXmsqYgN9xzIsTWUy/G8RrBMvaoHyZOyVbQX6kIlNiwMU/kWIq7vAakZt7LALu7Svf8KxGP+7ajStFSD09uTM4DlbJT98cgrNbIQ+i81aJTCLx4iuEvBQ8tDiF4BnBszBXJcy+IFIh/4d4cXHu7ZU1YcF/i5MDksZh0BHKRhN2Jq1omD3ZWit3Bh6l4UHcGO6ck8V5+P/IQZl218CT9Fb+5OknhFWPWKxvdZwfb6Pg33+o9OmBvrcwUZ0HKJQKZJ0AFYgv+te7HNAz4g4dYZaiubergg+fZ3tFYTVfsUHScO11Ysv7nrdMe8/y8ibUxZGd3cRvQXYrqjK8Rngf96YGo8/OsskHZR74zIqk3MvGJOiQhuYWmCCbHxxw0CccJDkQ1pK8IKTfp/zMR42DO1q+Vo+8iFuB1dnFmkF1o9yf3etrcf+54+YBzksFyeUx1c+H3kSCvayBY5RcfUIGtNsy8kh7hk1kayifSHljNHXfdsDlOL7jYavNlkG5tr9p6J5GviC1JOW3WI0K6sYzQSQNtGYRR5CfKDpbgcY9AhiiJA4oZkwqS6XQS3YK56AOtZsQAZwU5sKoboLiD LpZpNdLp gZM0saDupQlORtFqmNTU/2N5whVtzrdSvrFppEzh7OX+lnNbLZIjNWIGyk6luHh/oyIhFqKFFgantPZkACSUMbKMWWZh7yRFITgUsyt6S0RbadYaXw4CruOenRD8y7vO7FuRNKjfw84QbBgSOhxZ/xWt2L1Rlvizs1OFxPqFHj3lWnd20NJu9fHdEj8mPQc2+AzGYVVuQSY+tN5zQsh+89ZnPiTYrfrThkVfsUAjePhCfnHbSpjpQ32ILZNCbPBtFuiC/HKR5tTnEyIXED1YUWJtSNtKbga/ZIFltyjKmk+yHQfTOInzVwvI3NGZt+uZFut15tQ/LjA+uwdxgnF/Lnlf0VX0rjCfm8EoXY+9z335LsB/cnd87EzXG6pXF2Pbuv61XFhIOTsI5ZcrGVFuJ7E2Bsx8dcHV9N+3CLyXHknB0tkM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000210, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 19-12-24 08:27:06, Michal Hocko wrote: > On Thu 19-12-24 08:08:44, Michal Hocko wrote: > > All that being said, the message I wanted to get through is that atomic > > (NOWAIT) charges could be trully reentrant if the stock local lock uses > > trylock. We do not need a dedicated gfp flag for that now. > > And I want to add. Not only we can achieve that, I also think this is > desirable because for !RT this will be no functional change and for RT > it makes more sense to simply do deterministic (albeit more costly > page_counter update) than spin over a lock to use the batch (or learn > the batch cannot be used). So effectively this on top of yours diff --git a/mm/memcontrol.c b/mm/memcontrol.c index f168d223375f..29a831f6109c 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1768,7 +1768,7 @@ static bool consume_stock(struct mem_cgroup *memcg, unsigned int nr_pages, return ret; if (!local_trylock_irqsave(&memcg_stock.stock_lock, flags)) { - if (gfp_mask & __GFP_TRYLOCK) + if (!gfpflags_allow_blockingk(gfp_mask)) return ret; local_lock_irqsave(&memcg_stock.stock_lock, flags); } @@ -2211,6 +2211,9 @@ int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, if (consume_stock(memcg, nr_pages, gfp_mask)) return 0; + if (!gfpflags_allow_blockingk(gfp_mask)) + batch = nr_pages; + if (!do_memsw_account() || page_counter_try_charge(&memcg->memsw, batch, &counter)) { if (page_counter_try_charge(&memcg->memory, batch, &counter)) -- Michal Hocko SUSE Labs